govuk_publishing_components 21.47.0 → 21.48.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a88b34716fb241b208992a85a5554ad8b041729523c3a10c7274818b00d0c936
-  data.tar.gz: 7a0d928fdd91e5bec26a068e81086a9e5667076dfd554b458cae25cb3266b97d
+  metadata.gz: 41bce645d4da9c9c6fd2b1ab5e91fb4ecea8d1b76060fde43f56141fa3101570
+  data.tar.gz: 3ae1030faab5c0cd05487dda793de110743831147d5fe145c9cc69b8d92231b5
 SHA512:
-  metadata.gz: 8b66ecac6dc60e0f92c6518c49beb6e52ea3fc242ee59122c746a392547aab37fd26ff0cc83b2fbeea78fb4f0ef540f413d04a92f91493117c7b6f48326dd150
-  data.tar.gz: 935b0628237148bab2337d69336a48617014dd9e164e2678cf70003005b29899c7c535b15b2171704c7f3b3375018b97ccfc487c56dba9f582157407d718a8a5
+  metadata.gz: 2402cf261528736c5326f7687e70af627469ce970dd74800825a2a0cd7f3fdb97a0a4b56178a331579733ca98a3ee03987fafd192159f1ece14c29a4a9848076
+  data.tar.gz: a84744cc1ae7d7805aab08a6144b277f3e304ef23ad40b05396f47ed68fe04ebf103b9f51234cb223e9e3ecbf5215d7aa58d9ef86748a701f13cd44b8e1d9cc9

data/app/assets/stylesheets/govuk_publishing_components/components/_action-link.scss

@@ -71,10 +71,10 @@
     &:before {
       content: "";
       position: absolute;
-      top: 0;
+      top: 10%;
       left: govuk-spacing(2);
       width: govuk-spacing(2);
-      height: 100%;
+      height: 80%;
       border-left: solid 1px $govuk-text-colour;
     }
   }

data/app/views/govuk_publishing_components/components/_action_link.html.erb

@@ -10,17 +10,22 @@
   simple ||= false
   dark_icon ||= false
   data ||= nil
+  classes ||= nil
+
   css_classes = %w(gem-c-action-link)
   css_classes << "gem-c-action-link--light-text" if light_text
   css_classes << "gem-c-action-link--dark-icon" if dark_icon
   css_classes << "gem-c-action-link--simple" if simple
   css_classes << "gem-c-action-link--with-subtext" if subtext
   css_classes << (shared_helper.get_margin_bottom)
+
+  link_classes = %w(govuk-link gem-c-action-link__link)
+  link_classes << shared_helper.classes if classes
 %>
 <% if href.present? && text.present? %>
   <div class="<%= css_classes.join(' ') %>">
     <span class="gem-c-action-link__link-wrapper">
-      <%= link_to  href, :class => "govuk-link gem-c-action-link__link", :data => data do %>
+      <%= link_to  href, :class => link_classes, :data => data do %>
         <%= text %>
         <%= content_tag(:span, nowrap_text, class: "gem-c-action-link__nowrap-text") if nowrap_text %>
       <% end %>

data/app/views/govuk_publishing_components/components/_button.html.erb

@@ -1,4 +1,8 @@
-<% button = GovukPublishingComponents::Presenters::ButtonHelper.new(local_assigns) %>
+<%
+  shared_helper = GovukPublishingComponents::Presenters::SharedHelper.new(local_assigns)
+  local_assigns[:classes] = shared_helper.classes
+  button = GovukPublishingComponents::Presenters::ButtonHelper.new(local_assigns)
+%>
 
 <% start_button_text = capture do %>
   <%= button.text %>

data/app/views/govuk_publishing_components/components/docs/action_link.yml

@@ -18,6 +18,12 @@ examples:
       href: '/my-test-page'
       data:
         attr_test: "hasDataAttribute"
+  with_js_classes:
+    description: Use `js-` prefixed classes only as interaction hooks – to query and operate on elements via JavaScript. Classes are added to the link itself.
+    data:
+      text: "Coronavirus (COVID-19)"
+      href: '/my-test-page'
+      classes: 'js-hook'
   with_no_wrapping_text:
     data:
       text: "Coronavirus (COVID-19):"

data/lib/govuk_publishing_components/presenters/button_helper.rb

@@ -44,12 +44,7 @@ module GovukPublishingComponents
         @destructive = local_assigns[:destructive]
         @name = local_assigns[:name]
         @value = local_assigns[:value]
-        if local_assigns.include?(:classes)
-          @classes = local_assigns[:classes].split(" ")
-          unless @classes.all? { |c| c.start_with?("js-") }
-            raise(ArgumentError, "The button component expects classes to be prefixed with `js-`")
-          end
-        end
+        @classes = local_assigns[:classes]
         @aria_label = local_assigns[:aria_label]
       end
 

data/lib/govuk_publishing_components/presenters/shared_helper.rb

@@ -1,13 +1,20 @@
 module GovukPublishingComponents
   module Presenters
     class SharedHelper
-      attr_reader :options, :margin_top, :margin_bottom, :heading_level
+      attr_reader :options, :margin_top, :margin_bottom, :heading_level, :classes
 
       def initialize(local_assigns)
         @options = local_assigns
         @margin_top = @options[:margin_top] || nil
         @margin_bottom = @options[:margin_bottom] || 3
         @heading_level = @options[:heading_level] || 2
+
+        if local_assigns.include?(:classes)
+          @classes = local_assigns[:classes].split(" ")
+          unless @classes.all? { |c| c.start_with?("js-") }
+            raise(ArgumentError, "Passed classes must be prefixed with `js-`")
+          end
+        end
       end
 
       def get_margin_top

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "21.47.0".freeze
+  VERSION = "21.48.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 21.47.0
+  version: 21.48.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-19 00:00:00.000000000 Z
+date: 2020-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gds-api-adapters