govuk_publishing_components 21.27.1 → 21.28.0

data/lib/govuk_publishing_components/presenters/organisation_logo_helper.rb

@@ -21,7 +21,7 @@ module GovukPublishingComponents
         if image
           image_tag(logo_image_src, alt: logo_image_alt, class: "gem-c-organisation-logo__image")
         else
-          content_tag('span', name, class: "gem-c-organisation-logo__name")
+          content_tag("span", name, class: "gem-c-organisation-logo__name")
         end
       end
 

data/lib/govuk_publishing_components/presenters/page_with_step_by_step_navigation.rb

@@ -85,7 +85,7 @@ module GovukPublishingComponents
           {
             title: current_step_nav.title,
             path: current_step_nav.base_path,
-            tracking_id: current_step_nav.content_id
+            tracking_id: current_step_nav.content_id,
           }
         else
           {}
@@ -137,7 +137,7 @@ module GovukPublishingComponents
       end
 
       def active_step_nav_content_id
-        @active_step_nav_content_id ||= @query_parameters['step-by-step-nav'].present? ? @query_parameters['step-by-step-nav'] : nil
+        @active_step_nav_content_id ||= @query_parameters["step-by-step-nav"].present? ? @query_parameters["step-by-step-nav"] : nil
       end
 
       def steps
@@ -185,7 +185,7 @@ module GovukPublishingComponents
           {
             href: step_nav.base_path,
             text: step_nav.title,
-            tracking_id: step_nav.content_id
+            tracking_id: step_nav.content_id,
           }
         end
       end

data/lib/govuk_publishing_components/presenters/related_navigation_helper.rb

@@ -13,11 +13,11 @@ module GovukPublishingComponents
         statistical_data_sets
       ).freeze
       WORLD_LOCATION_SPECIAL_CASES = {
-        'UK Mission to the European Union' => 'uk-mission-to-the-eu',
+        "UK Mission to the European Union" => "uk-mission-to-the-eu",
       }.freeze
 
       def initialize(options = {})
-        @content_item = options.fetch(:content_item) { raise ArgumentError, 'missing argument: content_item' }
+        @content_item = options.fetch(:content_item) { raise ArgumentError, "missing argument: content_item" }
         @context = options.fetch(:context, nil)
       end
 
@@ -57,8 +57,8 @@ module GovukPublishingComponents
         unless section_title === "related_items"
           I18n.t("components.related_#{@context}_navigation." + section_title,
                  default: [
-                   I18n.t('components.related_navigation.' + section_title),
-                   section_title.tr('_', ' '),
+                   I18n.t("components.related_navigation." + section_title),
+                   section_title.tr("_", " "),
                  ])
         end
       end
@@ -72,15 +72,15 @@ module GovukPublishingComponents
           css_classes << " #{css_class}--other"
         end
 
-        css_classes.join(' ')
+        css_classes.join(" ")
       end
 
       def section_data_track_count(section_title)
-        String(@context || 'sidebar') + String(section_title).camelcase
+        String(@context || "sidebar") + String(section_title).camelcase
       end
 
       def section_heading_level
-        @context == :footer ? 'h2' : 'h3'
+        @context == :footer ? "h2" : "h3"
       end
 
       def calculate_section_link_limit(links)
@@ -129,26 +129,26 @@ module GovukPublishingComponents
     private
 
       def translation_present?(content)
-        default_string = 'This is a string to act as a default for the `I18n.translate` method. Comparing the result reveals if there is a translation in the i18n files.'
+        default_string = "This is a string to act as a default for the `I18n.translate` method. Comparing the result reveals if there is a translation in the i18n files."
         I18n.translate(
           content,
           default: default_string,
-          fallback: false
+          fallback: false,
         ) != default_string
       end
 
       def related_items
-        related_quick_links = content_item_details_for('quick_links')
+        related_quick_links = content_item_details_for("quick_links")
 
         if related_quick_links.any?
           related_quick_links + related_mainstream_content
         else
-          content_item_links_for('ordered_related_items') + related_mainstream_content
+          content_item_links_for("ordered_related_items") + related_mainstream_content
         end
       end
 
       def related_world_locations
-        content_item_links_for('world_locations')
+        content_item_links_for("world_locations")
           .map do |link|
             slug = WORLD_LOCATION_SPECIAL_CASES[link[:text]] || link[:text].parameterize
             link.merge(path: "/world/#{slug}/news")
@@ -156,11 +156,11 @@ module GovukPublishingComponents
       end
 
       def related_statistical_data_sets
-        content_item_links_for('related_statistical_data_sets', only: 'statistical_data_set')
+        content_item_links_for("related_statistical_data_sets", only: "statistical_data_set")
       end
 
       def related_taxons
-        content_item_links_for('taxons', only: 'taxon')
+        content_item_links_for("taxons", only: "taxon")
       end
 
       def related_topics
@@ -174,8 +174,8 @@ module GovukPublishingComponents
       end
 
       def related_legacy_topics
-        mainstream_browse_page_links = content_item_links_for('mainstream_browse_pages', only: 'mainstream_browse_page')
-        topic_links = content_item_links_for('topics', only: 'topic')
+        mainstream_browse_page_links = content_item_links_for("mainstream_browse_pages", only: "mainstream_browse_page")
+        topic_links = content_item_links_for("topics", only: "topic")
 
         mainstream_browse_page_links + topic_links.find_all do |topic_link|
           mainstream_browse_page_links.none? do |mainstream_browse_page_link|
@@ -185,58 +185,58 @@ module GovukPublishingComponents
       end
 
       def related_topical_events
-        content_item_links_for('topical_events', only: 'topical_event')
+        content_item_links_for("topical_events", only: "topical_event")
       end
 
       def related_contacts
-        content_item_links_for('related', only: 'contact')
+        content_item_links_for("related", only: "contact")
       end
 
       def related_external_links
-        content_item_details_for('external_related_links')
+        content_item_details_for("external_related_links")
       end
 
       def related_mainstream_content
         return [] unless detailed_guide?
 
-        content_item_links_for('related_mainstream_content')
+        content_item_links_for("related_mainstream_content")
       end
 
       def related_guides
         return [] unless detailed_guide?
 
-        content_item_links_for('related_guides')
+        content_item_links_for("related_guides")
       end
 
       def related_document_collections
-        content_item_links_for('document_collections', only: 'document_collection')
+        content_item_links_for("document_collections", only: "document_collection")
       end
 
       def detailed_guide?
-        @content_item['document_type'] == 'detailed_guide'
+        @content_item["document_type"] == "detailed_guide"
       end
 
       def content_item_details_for(key)
-        Array(@content_item.dig('details', key))
-          .map { |link| { path: link['url'], text: link['title'], rel: 'external' } }
+        Array(@content_item.dig("details", key))
+          .map { |link| { path: link["url"], text: link["title"], rel: "external" } }
       end
 
       def content_item_links_for(key, only: nil)
-        links = Array(@content_item.dig('links', key))
+        links = Array(@content_item.dig("links", key))
 
-        if key == 'taxons'
-          links = links.find_all { |link| link['phase'] == 'live' }
+        if key == "taxons"
+          links = links.find_all { |link| link["phase"] == "live" }
         end
 
         if only.present?
-          links = links.find_all { |link| link['document_type'] == only }
+          links = links.find_all { |link| link["document_type"] == only }
         end
 
         links.map { |link|
           {
-            path: link['base_path'],
-            text: link['title'],
-            locale: link['locale'],
+            path: link["base_path"],
+            text: link["title"],
+            locale: link["locale"],
           }
         }
       end

data/lib/govuk_publishing_components/presenters/schema_org.rb

@@ -1,16 +1,16 @@
-require 'govuk_publishing_components/presenters/machine_readable/page'
-require 'govuk_publishing_components/presenters/machine_readable/article_schema'
-require 'govuk_publishing_components/presenters/machine_readable/creative_work_schema'
-require 'govuk_publishing_components/presenters/machine_readable/faq_page_schema'
-require 'govuk_publishing_components/presenters/machine_readable/government_service_schema'
-require 'govuk_publishing_components/presenters/machine_readable/has_part_schema'
-require 'govuk_publishing_components/presenters/machine_readable/is_part_of_schema'
-require 'govuk_publishing_components/presenters/machine_readable/news_article_schema'
-require 'govuk_publishing_components/presenters/machine_readable/organisation_schema'
-require 'govuk_publishing_components/presenters/machine_readable/person_schema'
-require 'govuk_publishing_components/presenters/machine_readable/potential_search_action_schema'
-require 'govuk_publishing_components/presenters/machine_readable/search_results_page_schema'
-require 'govuk_publishing_components/presenters/machine_readable/dataset_schema'
+require "govuk_publishing_components/presenters/machine_readable/page"
+require "govuk_publishing_components/presenters/machine_readable/article_schema"
+require "govuk_publishing_components/presenters/machine_readable/creative_work_schema"
+require "govuk_publishing_components/presenters/machine_readable/faq_page_schema"
+require "govuk_publishing_components/presenters/machine_readable/government_service_schema"
+require "govuk_publishing_components/presenters/machine_readable/has_part_schema"
+require "govuk_publishing_components/presenters/machine_readable/is_part_of_schema"
+require "govuk_publishing_components/presenters/machine_readable/news_article_schema"
+require "govuk_publishing_components/presenters/machine_readable/organisation_schema"
+require "govuk_publishing_components/presenters/machine_readable/person_schema"
+require "govuk_publishing_components/presenters/machine_readable/potential_search_action_schema"
+require "govuk_publishing_components/presenters/machine_readable/search_results_page_schema"
+require "govuk_publishing_components/presenters/machine_readable/dataset_schema"
 
 module GovukPublishingComponents
   module Presenters

data/lib/govuk_publishing_components/presenters/select.rb

@@ -22,7 +22,7 @@ module GovukPublishingComponents
           [
             option[:text],
             option[:value],
-            options_data_attribute(option[:data_attributes])
+            options_data_attribute(option[:data_attributes]),
           ]
         }
       end

data/lib/govuk_publishing_components/presenters/step_by_step_nav_helper.rb

@@ -28,7 +28,7 @@ module GovukPublishingComponents
         content_tag(
           :p,
           text,
-          class: "gem-c-step-nav__paragraph"
+          class: "gem-c-step-nav__paragraph",
         )
       end
 
@@ -37,17 +37,17 @@ module GovukPublishingComponents
           get_list_element(element[:style]),
           class: "gem-c-step-nav__list #{get_list_style(element[:style])}",
           data: {
-            length: element[:contents].length
-          }
+            length: element[:contents].length,
+          },
         ) do
           element[:contents].collect { |contents|
             concat(
               content_tag(
                 :li,
-                class: "gem-c-step-nav__list-item js-list-item #{link_active(contents[:active])}"
+                class: "gem-c-step-nav__list-item js-list-item #{link_active(contents[:active])}",
               ) do
                 create_list_item_content(contents)
-              end
+              end,
             )
           }
         end
@@ -66,11 +66,11 @@ module GovukPublishingComponents
 
           link_to(
             href,
-            rel: ("external" if href.start_with?('http')),
+            rel: ("external" if href.start_with?("http")),
             data: {
-              position: "#{@options[:step_index] + 1}.#{@link_index}"
+              position: "#{@options[:step_index] + 1}.#{@link_index}",
             },
-            class: "gem-c-step-nav__link js-link"
+            class: "gem-c-step-nav__link js-link",
           ) do
             text
           end
@@ -99,7 +99,7 @@ module GovukPublishingComponents
       end
 
       def external_url?(href)
-        href.start_with?('http')
+        href.start_with?("http")
       end
 
       def link_with_step_nav_query_parameter(href)

data/lib/govuk_publishing_components/presenters/taxonomy_list_helper.rb

@@ -14,7 +14,7 @@ module GovukPublishingComponents
             image_src: image_card[:image][:url],
             image_alt: image_card[:image][:alt],
             heading_level: image_card[:link][:heading_level],
-            href_data_attributes: image_card[:link][:data_attributes]
+            href_data_attributes: image_card[:link][:data_attributes],
           }
         end
       end

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = '21.27.1'.freeze
+  VERSION = "21.28.0".freeze
 end

data/lib/tasks/govuk_publishing_components_tasks.rake

@@ -1,12 +1,12 @@
 namespace :component do
-  desc 'warns if component view files exist without corresponding documentation'
+  desc "warns if component view files exist without corresponding documentation"
   task :validate_documentation_exists do
     print "Validating that each component has documentation... "
     components_missing_docs = []
     component_views = Dir["app/views/#{GovukPublishingComponents::Config.component_directory_name}/**/*.html.erb"]
     component_views.each do |partial|
-      expected_component_docs_file = partial.split('/')[-1].gsub('html.erb', 'yml')
-      expected_component_docs_file.sub!(/^_/, '')
+      expected_component_docs_file = partial.split("/")[-1].gsub("html.erb", "yml")
+      expected_component_docs_file.sub!(/^_/, "")
 
       expected_component_docs_path = "app/views/#{GovukPublishingComponents::Config.component_directory_name}/docs/#{expected_component_docs_file}"
       components_missing_docs << partial unless File.exist?(expected_component_docs_path)
@@ -21,7 +21,7 @@ namespace :component do
     puts "✔︎"
   end
 
-  desc 'warns if component is missing accessibility criteria'
+  desc "warns if component is missing accessibility criteria"
   task :validate_accessibility_criteria_exist do
     print "Validating that each component has accessibility criteria... "
     errors = []
@@ -30,8 +30,8 @@ namespace :component do
     component_docs.each do |doc_file|
       file = YAML.load_file(doc_file)
 
-      if file['accessibility_criteria'].nil? && file['shared_accessibility_criteria'].nil?
-        errors << file['name']
+      if file["accessibility_criteria"].nil? && file["shared_accessibility_criteria"].nil?
+        errors << file["name"]
       end
     end
     if errors.any?
@@ -41,7 +41,7 @@ namespace :component do
     puts "✔︎"
   end
 
-  desc 'warns if component view files exist without corresponding documentation or accessibility critera'
+  desc "warns if component view files exist without corresponding documentation or accessibility critera"
   task :validate_documentation do
     Rake::Task["component:validate_documentation_exists"].invoke
     Rake::Task["component:validate_accessibility_criteria_exist"].invoke

data/node_modules/axe-core/CHANGELOG.md

@@ -2,6 +2,24 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [3.5.2](https://github.com/dequelabs/axe-core/compare/v3.5.1...v3.5.2) (2020-03-06)
+
+### Bug Fixes
+
+- **aria-allowed-role:** allow role=spinbutton on input[type=tel](<[635445b](https://github.com/dequelabs/axe-core/commit/635445ba6da7bc197bcdee6fb1a9d9dc81e43941)>)
+- **color-contrast:** ignore form elements that move text outside of node using text-indent ([#2044](https://github.com/dequelabs/axe-core/issues/2044)) ([85cc6ab](https://github.com/dequelabs/axe-core/commit/85cc6abd7f919a7311c6da01a41853cbfd539508))
+- **commons:** handle node(s) contained by SVG document when de… ([#2054](https://github.com/dequelabs/axe-core/issues/2054)) ([bf4c9bf](https://github.com/dequelabs/axe-core/commit/bf4c9bff2953b1ac7f40dbb1d0bd1986c1caa673))
+- **getCheckMessage:** add API to return check message ([#2066](https://github.com/dequelabs/axe-core/issues/2066)) ([e216322](https://github.com/dequelabs/axe-core/commit/e216322183c8b064ebfd748fea785b8c2fe78b16))
+- **has-lang:** fail check when `xml:lang` is used in HTML docum… ([#2053](https://github.com/dequelabs/axe-core/issues/2053)) ([e07aaea](https://github.com/dequelabs/axe-core/commit/e07aaea86bc9460a2d9f568637b4a77d33094ed6))
+- **label-content-name-mismatch:** ignore non `widget` aria role(s) & do not use deprecated `lookupTable.rolesOfType` ([#2022](https://github.com/dequelabs/axe-core/issues/2022)) ([89bd84c](https://github.com/dequelabs/axe-core/commit/89bd84c4a9846dc31a660eda6b274329e7ac70b5))
+- **package-lock:** change @deque/doT from agora to npm ([#2058](https://github.com/dequelabs/axe-core/issues/2058)) ([c03c0e5](https://github.com/dequelabs/axe-core/commit/c03c0e5ffc3ea1b49607355fa9d6f2e2faf0ebd1))
+- **page-has-heading-one:** find screen-reader only headings ([#2065](https://github.com/dequelabs/axe-core/issues/2065)) ([f808a12](https://github.com/dequelabs/axe-core/commit/f808a12261269719534ae52c878d1700fb70053e))
+- **region:** ignore direct child text nodes of body ([#2050](https://github.com/dequelabs/axe-core/issues/2050)) ([fde31d0](https://github.com/dequelabs/axe-core/commit/fde31d03d24820f681b257c4c42b98f25b2877ec))
+- **skip-link:** identify as skip-link only if the link is offscreen ([#2079](https://github.com/dequelabs/axe-core/issues/2079)) ([241e1d0](https://github.com/dequelabs/axe-core/commit/241e1d0715398a39c2e502ddb781f5fc29987dde))
+- check `invaildrole` fails only when all roles are invalid ([#2075](https://github.com/dequelabs/axe-core/issues/2075)) ([989b317](https://github.com/dequelabs/axe-core/commit/989b31788b08b6514dd4b606162193d4dd168be9))
+- ignore empty, whitespace or undefined `role` for rule `ari… ([#2077](https://github.com/dequelabs/axe-core/issues/2077)) ([dbd3c02](https://github.com/dequelabs/axe-core/commit/dbd3c0211b05641f366dfe2fe9c2124cad9e5e3a))
+- update tags for rule `area-alt` ([#2051](https://github.com/dequelabs/axe-core/issues/2051)) ([7db231f](https://github.com/dequelabs/axe-core/commit/7db231f2ff2b70a4e8e6f7aababe0871764ece96))
+
 ### [3.5.1](https://github.com/dequelabs/axe-core/compare/v3.5.0...v3.5.1) (2020-02-12)
 
 ### Bug Fixes

data/node_modules/axe-core/README.md

@@ -50,12 +50,15 @@ Now include the javascript file in each of your iframes in your fixtures or test
 Now insert calls at each point in your tests where a new piece of UI becomes visible or exposed:
 
 ```js
-axe.run(function (err, results) {
-  if (err) throw err;
-    ok(results.violations.length === 0, 'Should be no accessibility issues');
-    // complete the async call
-    ...
-});
+axe.run()
+  .then(results => {
+    if (results.violations.length) {
+      throw new Error('Accessibility issues found')
+    }
+  })
+  .catch(err => {
+    console.error('Something bad happened:', err.message)
+  })
 ```
 
 ## Supported Browsers

data/node_modules/axe-core/axe.js

@@ -1,4 +1,4 @@
-/*! axe v3.5.1
+/*! axe v3.5.2
  * Copyright (c) 2020 Deque Systems, Inc.
  *
  * Your use of this Source Code Form is subject to the terms of the Mozilla Public
@@ -27,7 +27,7 @@
     return _typeof(obj);
   }
   var axe = axe || {};
-  axe.version = '3.5.1';
+  axe.version = '3.5.2';
   if (typeof define === 'function' && define.amd) {
     define('axe-core', [], function() {
       'use strict';
@@ -11283,6 +11283,17 @@
     return lang.trim().split('-')[0].toLowerCase();
   };
   'use strict';
+  axe.utils.getCheckMessage = function getCheckMessage(checkId, type, data) {
+    var check = axe._audit.data.checks[checkId];
+    if (!check) {
+      throw new Error('Cannot get message for unknown check: '.concat(checkId, '.'));
+    }
+    if (!check.messages[type]) {
+      throw new Error('Check "'.concat(checkId, '"" does not have a "').concat(type, '" message.'));
+    }
+    return axe.utils.processMessage(check.messages[type], data);
+  };
+  'use strict';
   axe.utils.getCheckOption = function(check, ruleID, options) {
     var ruleCheckOption = ((options.rules && options.rules[ruleID] || {}).checks || {})[check.id];
     var checkOption = (options.checks || {})[check.id];
@@ -14880,7 +14891,7 @@
       id: 'area-alt',
       selector: 'map area[href]',
       excludeHidden: false,
-      tags: [ 'cat.text-alternatives', 'wcag2a', 'wcag111', 'section508', 'section508.22.a' ],
+      tags: [ 'cat.text-alternatives', 'wcag2a', 'wcag111', 'wcag244', 'wcag412', 'section508', 'section508.22.a' ],
       all: [],
       any: [ 'non-empty-alt', 'non-empty-title', 'aria-label', 'aria-labelledby' ],
       none: []
@@ -15035,6 +15046,15 @@
     }, {
       id: 'aria-roles',
       selector: '[role]',
+      matches: function matches(node, virtualNode, context) {
+        if (!virtualNode.hasAttr('role')) {
+          return false;
+        }
+        if (!virtualNode.attr('role').trim()) {
+          return false;
+        }
+        return true;
+      },
       tags: [ 'cat.aria', 'wcag2a', 'wcag412' ],
       all: [],
       any: [],
@@ -15206,6 +15226,23 @@
         if (node.getAttribute('aria-disabled') === 'true' || axe.commons.dom.findUpVirtual(virtualNode, '[aria-disabled="true"]')) {
           return false;
         }
+        var formElements = [ 'INPUT', 'SELECT', 'TEXTAREA' ];
+        if (formElements.includes(nodeName)) {
+          var style = window.getComputedStyle(node);
+          var textIndent = parseInt(style.getPropertyValue('text-indent'), 10);
+          if (textIndent) {
+            var rect = node.getBoundingClientRect();
+            rect = {
+              top: rect.top,
+              bottom: rect.bottom,
+              left: rect.left + textIndent,
+              right: rect.right + textIndent
+            };
+            if (!axe.commons.dom.visuallyOverlaps(rect, node)) {
+              return false;
+            }
+          }
+        }
         if (nodeName === 'INPUT') {
           return [ 'hidden', 'range', 'color', 'checkbox', 'radio', 'image' ].indexOf(nodeType) === -1 && !node.disabled;
         }
@@ -15567,7 +15604,10 @@
         if (!role) {
           return false;
         }
-        var isWidgetType = aria.lookupTable.rolesOfType.widget.includes(role);
+        var widgetRoles = Object.keys(aria.lookupTable.role).filter(function(key) {
+          return aria.lookupTable.role[key].type === 'widget';
+        });
+        var isWidgetType = widgetRoles.includes(role);
         if (!isWidgetType) {
           return false;
         }
@@ -15983,7 +16023,7 @@
       id: 'skip-link',
       selector: 'a[href^="#"], a[href^="/#"]',
       matches: function matches(node, virtualNode, context) {
-        return axe.commons.dom.isSkipLink(node);
+        return axe.commons.dom.isSkipLink(node) && axe.commons.dom.isOffscreen(node);
       },
       tags: [ 'cat.keyboard', 'best-practice' ],
       all: [],
@@ -16224,13 +16264,16 @@
     }, {
       id: 'invalidrole',
       evaluate: function evaluate(node, options, virtualNode, context) {
-        var invalidRoles = axe.utils.tokenList(virtualNode.attr('role')).filter(function(role) {
-          return !axe.commons.aria.isValidRole(role, {
+        var tokenList = axe.utils.tokenList;
+        var aria = axe.commons.aria;
+        var allRoles = tokenList(virtualNode.attr('role'));
+        var allInvalid = allRoles.every(function(role) {
+          return !aria.isValidRole(role, {
             allowAbstract: true
           });
         });
-        if (invalidRoles.length > 0) {
-          this.data(invalidRoles);
+        if (allInvalid) {
+          this.data(allRoles);
           return true;
         }
         return false;
@@ -17108,7 +17151,7 @@
           throw new TypeError('visible-in-page requires options.selector to be a string');
         }
         var matchingElms = axe.utils.querySelectorAllFilter(virtualNode, options.selector, function(vNode) {
-          return axe.commons.dom.isVisible(vNode.actualNode);
+          return axe.commons.dom.isVisible(vNode.actualNode, true);
         });
         this.relatedNodes(matchingElms.map(function(vNode) {
           return vNode.actualNode;
@@ -17136,7 +17179,7 @@
           throw new TypeError('visible-in-page requires options.selector to be a string');
         }
         var matchingElms = axe.utils.querySelectorAllFilter(virtualNode, options.selector, function(vNode) {
-          return axe.commons.dom.isVisible(vNode.actualNode);
+          return axe.commons.dom.isVisible(vNode.actualNode, true);
         });
         this.relatedNodes(matchingElms.map(function(vNode) {
           return vNode.actualNode;
@@ -17470,7 +17513,13 @@
     }, {
       id: 'has-lang',
       evaluate: function evaluate(node, options, virtualNode, context) {
-        return !!(node.getAttribute('lang') || node.getAttribute('xml:lang') || '').trim();
+        var isXHTML = axe.utils.isXHTML;
+        var langValue = (node.getAttribute('lang') || '').trim();
+        var xmlLangValue = (node.getAttribute('xml:lang') || '').trim();
+        if (!langValue && !isXHTML(document)) {
+          return false;
+        }
+        return !!(langValue || xmlLangValue);
       }
     }, {
       id: 'valid-lang',
@@ -18253,7 +18302,7 @@
               vNode = vNode.parent;
             }
             return [];
-          } else if (dom.hasContent(node, true)) {
+          } else if (node !== document.body && dom.hasContent(node, true)) {
             return [ virtualNode ];
           } else {
             return virtualNode.children.filter(function(_ref20) {
@@ -20186,7 +20235,7 @@
           allowedElements: {
             nodeName: 'input',
             properties: {
-              type: 'text'
+              type: [ 'text', 'tel' ]
             }
           }
         },
@@ -20333,7 +20382,7 @@
           allowedElements: [ 'ol', 'ul' ]
         },
         tooltip: {
-          type: 'widget',
+          type: 'structure',
           attributes: {
             allowed: [ 'aria-expanded', 'aria-errormessage' ]
           },
@@ -20502,6 +20551,8 @@
             return role === 'combobox' || role === 'searchbox' || role === 'spinbutton';
 
            case 'tel':
+            return role === 'combobox' || role === 'spinbutton';
+
            case 'url':
            case 'search':
            case 'email':
@@ -22141,18 +22192,18 @@
         }, []);
       };
       dom.urlPropsFromAttribute = function urlPropsFromAttribute(node, attribute) {
-        var value = node[attribute];
-        if (!value) {
+        if (!node.hasAttribute(attribute)) {
           return undefined;
         }
         var nodeName = node.nodeName.toUpperCase();
         var parser = node;
-        if (![ 'A', 'AREA' ].includes(nodeName)) {
+        if (![ 'A', 'AREA' ].includes(nodeName) || node.ownerSVGElement) {
           parser = document.createElement('a');
-          parser.href = value;
+          parser.href = node.getAttribute(attribute);
         }
         var protocol = [ 'https:', 'ftps:' ].includes(parser.protocol) ? parser.protocol.replace(/s:$/, ':') : parser.protocol;
-        var _getPathnameOrFilenam = getPathnameOrFilename(parser.pathname), pathname = _getPathnameOrFilenam.pathname, filename = _getPathnameOrFilenam.filename;
+        var parserPathname = /^\//.test(parser.pathname) ? parser.pathname : '/'.concat(parser.pathname);
+        var _getPathnameOrFilenam = getPathnameOrFilename(parserPathname), pathname = _getPathnameOrFilenam.pathname, filename = _getPathnameOrFilenam.filename;
         return {
           protocol: protocol,
           hostname: parser.hostname,