govuk_publishing_components 18.2.0 → 18.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ac6e954b1c78501866e17af77d1a1ccbe4bdc265a8775a6e9546ab9791f00ab
-  data.tar.gz: 6069d12624e6ad77aa88b817ea746ee21058b315057f65a184ec94621def5215
+  metadata.gz: 41819966f3acdcd91980fc9e8f51633caf134bc96333f053c0618e0f1306cd59
+  data.tar.gz: ad4486815abaab2fab8bfb56c8bcce37fb5384a8eab21997678dadf8cbd64d15
 SHA512:
-  metadata.gz: f57d71f018e862dc34d6a3c2a25fb36901443d6463238de63632bd8bca9c02916372a18e4f45338338177de1fe181f10ce73f6fff073b1939ccbea72191863e3
-  data.tar.gz: fed6631e756f445a51f5af976375b250c435067646bb479d6c4224874930fa03d9485422977ec54e7357311f37c16ab2f47cb00a17228c482ee92992058281c3
+  metadata.gz: d311fd3a434bcbcda4a498279635be91c1942aefa6bbc68c7882a74e866856b173b320e809a265e936e724219e92bd32e315e8e8ff5b2608f1bac6707bc56dd3
+  data.tar.gz: 479d44fb2d1c2a0ce945b29e74bf80feaeb49feb048821a1b73af391f6c9eacaf849b74bc07a95707dd414be9fd8201fdaac8fb4755204c468717d43a2410bf1

data/app/views/govuk_publishing_components/components/docs/button.yml

@@ -98,4 +98,13 @@ examples:
     data:
       text: "Second button"
       inline_layout: true
+  with_name_and_value_set:
+    description: |
+      By default, the button has no value or name set so it will not pass information when the form is submitted. This allows a name and value to be added so a button can add information to the form submission.
+
+      Please note that Internet Explorer 6 and 7 have **breaking bugs** when submitting a form with multiple buttons - this can [change what value is submitted by the button](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#Notes). Make sure to check your user needs and browser usage.
+    data:
+      text: "This is the button text"
+      value: "this_is_the_value"
+      name: "this_is_the_name"
 

data/app/views/govuk_publishing_components/components/docs/input.yml

@@ -37,22 +37,18 @@ examples:
         text: "Has an id"
       name: "hasid"
       id: "hasid"
-  aria_described_by:
+  with_aria_attributes:
     description: |
-      Allows the addition of an aria-describedby attribute. Note that this will be overridden in the event of an error, where the error will be used for the describedby attribute value.
+      The component accepts two possible aria attributes: aria-describedby and aria-controls.
 
-      The example below uses the ID of the main container for demonstration purposes as there aren't any useful elements with IDs in the component guide. In real use this would be passed the ID of an element that correctly described the input.
+      [aria-describedby](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-describedby_attribute) is used to indicate the ID of the element that describes the input. This will be overridden in the event of an error, where the error will be used for the describedby attribute value. This example uses the ID of the main container for demonstration purposes as there aren't any useful elements with IDs in the component guide. In real use this would be passed the ID of an element that correctly described the input.
+
+      aria-controls allows the addition of an aria-controls attribute, for use in places like the finders where the page is updated dynamically after value changes to the input.
     data:
       label:
         text: "This is an example only and may not work with a screen reader"
       name: "labelledby"
       describedby: "wrapper"
-  aria_controls:
-    description: Allows the addition of an aria-controls attribute, for use in places like the finders where the page is updated dynamically after value changes to the input.
-    data:
-      label:
-        text: "This is an example only and will not work with a screen reader as intended"
-      name: "controls"
       controls: "wrapper"
   with_hint:
     data:

data/lib/govuk_publishing_components/presenters/button_helper.rb

@@ -5,7 +5,7 @@ module GovukPublishingComponents
     class ButtonHelper
       attr_reader :href, :text, :title, :info_text, :rel, :data_attributes,
                   :margin_bottom, :inline_layout, :target, :type, :start,
-                  :secondary, :secondary_quiet, :destructive
+                  :secondary, :secondary_quiet, :destructive, :name, :value
 
       def initialize(local_assigns)
         @href = local_assigns[:href]
@@ -22,6 +22,8 @@ module GovukPublishingComponents
         @secondary = local_assigns[:secondary]
         @secondary_quiet = local_assigns[:secondary_quiet]
         @destructive = local_assigns[:destructive]
+        @name = local_assigns[:name]
+        @value = local_assigns[:value]
       end
 
       def link?
@@ -36,6 +38,8 @@ module GovukPublishingComponents
         options[:data] = data_attributes if data_attributes
         options[:title] = title if title
         options[:target] = target if target
+        options[:name] = name if name.present? && value.present?
+        options[:value] = value if name.present? && value.present?
         options
       end
 

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = '18.2.0'.freeze
+  VERSION = '18.3.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 18.2.0
+  version: 18.3.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-22 00:00:00.000000000 Z
+date: 2019-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gds-api-adapters