govuk_notify_rails 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f18695b6e10853e1315086f370905884654a58a1
-  data.tar.gz: 7b966ffaec4bb686445c5e4a04805ab56a42baea
+  metadata.gz: 8c8cfae3d9c9ea680d58a9d24aafe725365a8542
+  data.tar.gz: c9b21033bbbd27f9ce00b22aaee945cab02d3ea6
 SHA512:
-  metadata.gz: bdf44697db9f0e8d68a27829fe9f049b9f0a6b6d286fd73382945677a03355c6bfcb036d8d91ecbfc98d586847706c49c289a39019f9c2596e6c887dcee9db51
-  data.tar.gz: 354f76b28d13dc315f7a6c50c82805fa314779e9b42b5586ec9c885991e2289e48e26899fd1754147c7e748fcce90ca2ef666d964bb1b53b6ea3934f5bb7c182
+  metadata.gz: efb994f4e8a918b16a8ec04f2015330d704bbf8a98f946a86158cb768fc462d577a925cd84a60644520a72601a912399a259d1167f5cb35d24a3f3cdca4e978b
+  data.tar.gz: befa2a1f409c790dc98ee3c18a3befec69d60b05d901e7bdad0ead4f51d790075ceb1f406e7971e14f90cbfcfec772540fbff639a59e1a0135329e190acbea02

data/lib/govuk_notify_rails/delivery.rb

@@ -7,7 +7,10 @@ module GovukNotifyRails
     end
 
     def deliver!(message)
-      notify_client.send_email(payload_for(message))
+      response = notify_client.send_email(
+        payload_for(message)
+      )
+      message.govuk_notify_response = response
     end
 
     private

data/lib/govuk_notify_rails/mail_ext.rb

@@ -3,5 +3,6 @@ module Mail
     attr_accessor :govuk_notify_template
     attr_accessor :govuk_notify_reference
     attr_accessor :govuk_notify_personalisation
+    attr_accessor :govuk_notify_response
   end
 end

data/lib/govuk_notify_rails/version.rb

@@ -1,3 +1,3 @@
 module GovukNotifyRails
-  VERSION = '2.0.0'.freeze
+  VERSION = '2.1.0'.freeze
 end

data/spec/dummy/config/environments/development.rb

@@ -29,8 +29,6 @@ Rails.application.configure do
   # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 
-  config.action_mailer.perform_caching = false
-
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
@@ -47,8 +45,4 @@ Rails.application.configure do
 
   # Raises error for missing translations
   # config.action_view.raise_on_missing_translations = true
-
-  # Use an evented file watcher to asynchronously detect changes in source code,
-  # routes, locales, etc. This feature depends on the listen gem.
-  config.file_watcher = ActiveSupport::EventedFileUpdateChecker
 end

data/spec/dummy/config/environments/production.rb

@@ -55,7 +55,6 @@ Rails.application.configure do
   # Use a real queuing backend for Active Job (and separate queues per environment)
   # config.active_job.queue_adapter     = :resque
   # config.active_job.queue_name_prefix = "dummy_#{Rails.env}"
-  config.action_mailer.perform_caching = false
 
   # Ignore bad email addresses and do not raise email delivery errors.
   # Set this to true and configure the email server for immediate delivery to raise delivery errors.

data/spec/dummy/config/environments/test.rb

@@ -27,7 +27,6 @@ Rails.application.configure do
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false
-  config.action_mailer.perform_caching = false
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the

data/spec/dummy/config/initializers/new_framework_defaults.rb

@@ -10,15 +10,8 @@ Rails.application.config.action_controller.per_form_csrf_tokens = true
 # Enable origin-checking CSRF mitigation. Previous versions had false.
 Rails.application.config.action_controller.forgery_protection_origin_check = true
 
-# Make Ruby 2.4 preserve the timezone of the receiver when calling `to_time`.
-# Previous versions had false.
-ActiveSupport.to_time_preserves_timezone = true
-
 # Require `belongs_to` associations by default. Previous versions had false.
 Rails.application.config.active_record.belongs_to_required_by_default = true
 
-# Do not halt callback chains when a callback returns false. Previous versions had true.
-ActiveSupport.halt_callback_chains_on_return_false = false
-
 # Configure SSL options to enable HSTS with subdomains. Previous versions had false.
 Rails.application.config.ssl_options = { hsts: { subdomains: true } }

data/spec/dummy/log/development.log

@@ -37,3 +37,123 @@ NotifyMailer#test_email: processed outbound mail in 0.5ms
 NotifyMailer#test_email: processed outbound mail in 0.5ms
 NotifyMailer#test_email: processed outbound mail in 0.4ms
 NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 116.8ms
+NotifyMailer#test_email: processed outbound mail in 0.6ms
+NotifyMailer#test_email: processed outbound mail in 0.6ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.6ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 205.7ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+
+NotifyMailer#test_email: processed outbound mail in 149.8ms
+
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+
+NotifyMailer#test_email: processed outbound mail in 5.9ms
+
+NotifyMailer#test_email: processed outbound mail in 1.7ms
+
+NotifyMailer#test_email: processed outbound mail in 1.6ms
+
+NotifyMailer#test_email: processed outbound mail in 1.6ms
+
+NotifyMailer#test_email: processed outbound mail in 1.7ms
+
+NotifyMailer#test_email: processed outbound mail in 1.6ms
+NotifyMailer#test_email: processed outbound mail in 174.3ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 188.2ms
+NotifyMailer#test_email: processed outbound mail in 0.6ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 176.9ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 173.6ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 3.7ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 181.2ms
+NotifyMailer#test_email: processed outbound mail in 0.7ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 191.2ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 179.9ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 176.7ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 180.3ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 186.9ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 180.3ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms
+NotifyMailer#test_email: processed outbound mail in 193.3ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.6ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 178.5ms
+NotifyMailer#test_email: processed outbound mail in 0.5ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.4ms
+NotifyMailer#test_email: processed outbound mail in 0.3ms

data/spec/govuk_notify_delivery/delivery_spec.rb

@@ -24,6 +24,7 @@ describe GovukNotifyRails::Delivery do
     before(:each) do
       allow(notify_client).to receive(:new).with(api_key).and_return(notify_client)
       allow(subject).to receive(:notify_client).and_return(notify_client)
+      allow(message).to receive(:govuk_notify_response=)
     end
 
     it 'should deliver the message payload' do
@@ -33,6 +34,21 @@ describe GovukNotifyRails::Delivery do
       subject.deliver!(message)
     end
 
+    context 'client response' do
+      before do
+        allow(notify_client).to receive(:send_email).and_return('response')
+      end
+
+      it 'returns the client response' do
+        expect(subject.deliver!(message)).to eq('response')
+      end
+
+      it 'assigns the client response for later inspection' do
+        subject.deliver!(message)
+        expect(message).to have_received(:govuk_notify_response=).with('response')
+      end
+    end
+
     context 'no personalisation set' do
       let(:personalisation) { nil }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_notify_rails
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Jesus Laiz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-24 00:00:00.000000000 Z
+date: 2018-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.9.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement