govuk_navigation_helpers 7.4.0 → 7.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49e678f07da28f63da92adbb92744d4757ad5983
-  data.tar.gz: 1e5382fdd61d56918098e099b62d2eb906c615bc
+  metadata.gz: 6342b8057599155775feea0d29e377fafae68f9d
+  data.tar.gz: 5f95e172f522d070d14bb76a6555326202c5d0bf
 SHA512:
-  metadata.gz: a75d29c2c4b03dc72440a6e6c60f87bc654d779627a960652d7ff4deaf5b3e7e4b5dce7641655ab7b2560884bd43e721ef98702bf2f07b95efe1ab0ff82f9813
-  data.tar.gz: eb02d0ca3c6fa79e7559785a575f47624c9308496586a9d00ef100c0ce73c901402eea3184dcf9dbeb67e0221ee641ed072f2f6bbc4337c7e4a7041828237853
+  metadata.gz: 79180366cbb2fc58cbbc16032823e329fbb151e732ef6ed3932f273550307552f4fb1418816e9eafa0428fe2a64ba728e7dcf4e23033d94935317ebbaebfa24b
+  data.tar.gz: 1004a1758e916b0b1e7818067ff9e0002c69718afe27bd99435b3a6531ee9caf4656584074eeed715658b797ca79f38b8ac0a0d9a08a7be7cc93c2410550570e

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 7.5.0
+* Adds ability to detect if the current page is under test
+
 ## 7.4.0
 
 * Adds functionality to render the tasklist content into frontend applications under AB Testing.

data/lib/govuk_navigation_helpers/current_tasklist_ab_test.rb

@@ -39,16 +39,20 @@ module GovukNavigationHelpers
     end
 
     def show_tasklist_sidebar?
-      sidebar_variant.variant?('B')
+      sidebar_variant.variant?('B') && is_tested_page?
     end
 
     def show_tasklist_header?
-      header_variant.variant?('B')
+      header_variant.variant?('B') && is_tested_page?
+    end
+
+    def is_tested_page?
+      return current_tasklist.is_page_included_in_ab_test? if current_tasklist
     end
 
     def set_response_header(response)
-      sidebar_variant.configure_response(response) if show_tasklist_sidebar?
-      header_variant.configure_response(response) if show_tasklist_header?
+      sidebar_variant.configure_response(response) if is_tested_page?
+      header_variant.configure_response(response) if is_tested_page?
     end
 
     def publication_with_sidebar?

data/lib/govuk_navigation_helpers/version.rb

@@ -1,3 +1,3 @@
 module GovukNavigationHelpers
-  VERSION = "7.4.0".freeze
+  VERSION = "7.5.0".freeze
 end

data/spec/current_tasklist_ab_test_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+module GovukNavigationHelpers
+  RSpec.describe CurrentTasklistAbTest do
+    let(:tasklist) { TasklistContent.current_tasklist('/vehicles-can-drive') }
+
+    it "indicates when to show the task list components" do
+      request = double('request', headers: {
+        'HTTP_GOVUK_ABTEST_TASKLISTSIDEBAR' => 'B',
+        'HTTP_GOVUK_ABTEST_TASKLISTHEADER' => 'B'
+        })
+      ab_test = described_class.new(current_tasklist: tasklist, request: request)
+      expect(ab_test.show_tasklist_sidebar?).to be true
+      expect(ab_test.show_tasklist_header?).to be true
+    end
+
+    it "indicates when to not show the task list components" do
+      request = double('request', headers: {
+        'HTTP_GOVUK_ABTEST_TASKLISTSIDEBAR' => 'A',
+        'HTTP_GOVUK_ABTEST_TASKLISTHEADER' => 'A'
+        })
+      ab_test = described_class.new(current_tasklist: tasklist, request: request)
+      expect(ab_test.show_tasklist_sidebar?).to be false
+      expect(ab_test.show_tasklist_header?).to be false
+    end
+
+    it "copes with a mixture when to not show the task list components" do
+      request = double('request', headers: {
+        'HTTP_GOVUK_ABTEST_TASKLISTSIDEBAR' => 'B',
+        'HTTP_GOVUK_ABTEST_TASKLISTHEADER' => 'A'
+        })
+      ab_test = described_class.new(current_tasklist: tasklist, request: request)
+      expect(ab_test.show_tasklist_sidebar?).to be true
+      expect(ab_test.show_tasklist_header?).to be false
+    end
+
+    it "configures the response vary header correctly " do
+      request = double('request', headers: {
+        'HTTP_GOVUK_ABTEST_TASKLISTSIDEBAR' => 'A',
+        'HTTP_GOVUK_ABTEST_TASKLISTHEADER' => 'B'
+        })
+      response = double('response', headers: {})
+      ab_test = described_class.new(current_tasklist: tasklist, request: request)
+
+      ab_test.set_response_header(response)
+
+      expect(response.headers["Vary"]).to eq("GOVUK-ABTest-TaskListSidebar, GOVUK-ABTest-TaskListHeader")
+    end
+
+    it "configures the response vary header correctly when the page is not under test" do
+      request = double('request', headers: {
+        'HTTP_GOVUK_ABTEST_TASKLISTSIDEBAR' => 'A',
+        'HTTP_GOVUK_ABTEST_TASKLISTHEADER' => 'B'
+        })
+      response = double('response', headers: {})
+      tasklist = TasklistContent.current_tasklist("/not_under_test")
+      ab_test = described_class.new(current_tasklist: tasklist, request: request)
+
+      ab_test.set_response_header(response)
+
+      expect(response.headers["Vary"]).to be nil
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_navigation_helpers
 version: !ruby/object:Gem::Version
-  version: 7.4.0
+  version: 7.5.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-15 00:00:00.000000000 Z
+date: 2017-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gds-api-adapters
@@ -217,6 +217,7 @@ files:
 - lib/govuk_navigation_helpers/version.rb
 - spec/breadcrumbs_spec.rb
 - spec/content_item_spec.rb
+- spec/current_tasklist_ab_test_spec.rb
 - spec/related_items_spec.rb
 - spec/related_navigation_sidebar_spec.rb
 - spec/spec_helper.rb
@@ -250,6 +251,7 @@ summary: Gem to transform items from the content-store into payloads for GOV.UK
 test_files:
 - spec/breadcrumbs_spec.rb
 - spec/content_item_spec.rb
+- spec/current_tasklist_ab_test_spec.rb
 - spec/related_items_spec.rb
 - spec/related_navigation_sidebar_spec.rb
 - spec/spec_helper.rb