govuk_frontend_toolkit 3.4.1 → 3.4.2

data/app/assets/CHANGELOG.md

@@ -1,3 +1,10 @@
+#3.4.2
+
+- Fix: Before this fix, when a user fell into variant 0 of a multivariate test,
+the data wouldn't be reported to Google correctly because of a broken
+null check in the code block that opts the user into the Google Content
+Experiment.
+
 # 3.4.1
 
 - Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA
@@ -11,7 +18,7 @@ backend for multivariate tests
 
 # 3.3.1
 
-- Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA 
+- Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA
 
 # 3.3.0
 

data/app/assets/VERSION.txt

@@ -1 +1 @@
-3.4.1
+3.4.2

data/app/assets/javascripts/govuk/multivariate-test.js

@@ -87,7 +87,9 @@
   MultivariateTest.prototype.setUpContentExperiment = function(cohort) {
     var contentExperimentId = this.contentExperimentId;
     var cohortVariantId = this.cohorts[cohort]['variantId'];
-    if(contentExperimentId && cohortVariantId && typeof window.ga === "function"){
+    if(typeof contentExperimentId !== 'undefined' &&
+      typeof cohortVariantId !== 'undefined' &&
+      typeof window.ga === "function"){
       window.ga('set', 'expId', contentExperimentId);
       window.ga('set', 'expVar', cohortVariantId);
     };

data/app/assets/spec/unit/MultivariateTestSpec.js

@@ -187,10 +187,10 @@ describe("MultivariateTest", function() {
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
         contentExperimentId: "asdfsadasdfa",
-        cohorts: {foo: {variantId: 0, weight: 0},  bar: {variantId: 1, weight: 1}}
+        cohorts: {foo: {variantId: 0, weight: 1},  bar: {variantId: 1, weight: 0}}
       });
       expect(window.ga.calls.first().args).toEqual(['set', 'expId', 'asdfsadasdfa']);
-      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'expVar', 1]);
+      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'expVar', 0]);
       expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
         'multivariatetest_cohort_stuff',
         'run',

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_frontend_toolkit
 version: !ruby/object:Gem::Version
-  version: 3.4.1
+  version: 3.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-15 00:00:00.000000000 Z
+date: 2015-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -288,7 +288,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 722518431187392326
+      hash: -4030544481151529176
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -297,7 +297,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 722518431187392326
+      hash: -4030544481151529176
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23