govuk_frontend_toolkit 3.4.1 → 3.4.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
data/app/assets/CHANGELOG.md
CHANGED
|
@@ -1,3 +1,10 @@
|
|
|
1
|
+
#3.4.2
|
|
2
|
+
|
|
3
|
+
- Fix: Before this fix, when a user fell into variant 0 of a multivariate test,
|
|
4
|
+
the data wouldn't be reported to Google correctly because of a broken
|
|
5
|
+
null check in the code block that opts the user into the Google Content
|
|
6
|
+
Experiment.
|
|
7
|
+
|
|
1
8
|
# 3.4.1
|
|
2
9
|
|
|
3
10
|
- Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA
|
|
@@ -11,7 +18,7 @@ backend for multivariate tests
|
|
|
11
18
|
|
|
12
19
|
# 3.3.1
|
|
13
20
|
|
|
14
|
-
- Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA
|
|
21
|
+
- Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA
|
|
15
22
|
|
|
16
23
|
# 3.3.0
|
|
17
24
|
|
data/app/assets/VERSION.txt
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
3.4.
|
|
1
|
+
3.4.2
|
|
@@ -87,7 +87,9 @@
|
|
|
87
87
|
MultivariateTest.prototype.setUpContentExperiment = function(cohort) {
|
|
88
88
|
var contentExperimentId = this.contentExperimentId;
|
|
89
89
|
var cohortVariantId = this.cohorts[cohort]['variantId'];
|
|
90
|
-
if(contentExperimentId
|
|
90
|
+
if(typeof contentExperimentId !== 'undefined' &&
|
|
91
|
+
typeof cohortVariantId !== 'undefined' &&
|
|
92
|
+
typeof window.ga === "function"){
|
|
91
93
|
window.ga('set', 'expId', contentExperimentId);
|
|
92
94
|
window.ga('set', 'expVar', cohortVariantId);
|
|
93
95
|
};
|
|
@@ -187,10 +187,10 @@ describe("MultivariateTest", function() {
|
|
|
187
187
|
var test = new GOVUK.MultivariateTest({
|
|
188
188
|
name: 'stuff',
|
|
189
189
|
contentExperimentId: "asdfsadasdfa",
|
|
190
|
-
cohorts: {foo: {variantId: 0, weight:
|
|
190
|
+
cohorts: {foo: {variantId: 0, weight: 1}, bar: {variantId: 1, weight: 0}}
|
|
191
191
|
});
|
|
192
192
|
expect(window.ga.calls.first().args).toEqual(['set', 'expId', 'asdfsadasdfa']);
|
|
193
|
-
expect(window.ga.calls.mostRecent().args).toEqual(['set', 'expVar',
|
|
193
|
+
expect(window.ga.calls.mostRecent().args).toEqual(['set', 'expVar', 0]);
|
|
194
194
|
expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
|
|
195
195
|
'multivariatetest_cohort_stuff',
|
|
196
196
|
'run',
|
metadata
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: govuk_frontend_toolkit
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 3.4.
|
|
4
|
+
version: 3.4.2
|
|
5
5
|
prerelease:
|
|
6
6
|
platform: ruby
|
|
7
7
|
authors:
|
|
@@ -9,7 +9,7 @@ authors:
|
|
|
9
9
|
autorequire:
|
|
10
10
|
bindir: bin
|
|
11
11
|
cert_chain: []
|
|
12
|
-
date: 2015-04-
|
|
12
|
+
date: 2015-04-16 00:00:00.000000000 Z
|
|
13
13
|
dependencies:
|
|
14
14
|
- !ruby/object:Gem::Dependency
|
|
15
15
|
name: rails
|
|
@@ -288,7 +288,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
|
|
|
288
288
|
version: '0'
|
|
289
289
|
segments:
|
|
290
290
|
- 0
|
|
291
|
-
hash:
|
|
291
|
+
hash: -4030544481151529176
|
|
292
292
|
required_rubygems_version: !ruby/object:Gem::Requirement
|
|
293
293
|
none: false
|
|
294
294
|
requirements:
|
|
@@ -297,7 +297,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
|
|
|
297
297
|
version: '0'
|
|
298
298
|
segments:
|
|
299
299
|
- 0
|
|
300
|
-
hash:
|
|
300
|
+
hash: -4030544481151529176
|
|
301
301
|
requirements: []
|
|
302
302
|
rubyforge_project:
|
|
303
303
|
rubygems_version: 1.8.23
|