govuk_content_models 42.0.0 → 42.0.1

data/test/test_helper.rb

@@ -1,61 +0,0 @@
-ENV["RACK_ENV"] = "test"
-
-require "bundler/setup"
-
-require "active_support/test_case"
-
-# NOTE: this test_helper does not introduce enough of rails to make
-# require_dependency to be available, requiring "active_support/dependencies"
-# causes the tests to fail, so we introduce our own require_dependency
-# that simply passes through to require
-def require_dependency(*args)
-  require(*args)
-end
-
-require "shoulda/context"
-require "minitest/autorun"
-require "mocha/mini_test"
-require "mongoid"
-require "govuk_content_models/require_all"
-require "database_cleaner"
-require "gds_api/test_helpers/panopticon"
-require "webmock/minitest"
-require "govuk_content_models/test_helpers/factories"
-require 'govuk_content_models/test_helpers/action_processor_helpers'
-require "timecop"
-require "byebug"
-
-# The models depend on a zone being set, so tests will fail if we don't
-Time.zone = "London"
-
-Mongoid.load! File.expand_path("../../config/mongoid.yml", __FILE__)
-Mongoid::Tasks::Database.create_indexes
-WebMock.disable_net_connect!
-
-DatabaseCleaner.strategy = :truncation
-# initial clean
-DatabaseCleaner.clean
-
-class ActiveSupport::TestCase
-  PROJECT_ROOT = File.expand_path("../..", __FILE__)
-
-  include GdsApi::TestHelpers::Panopticon
-  include GovukContentModels::TestHelpers::ActionProcessorHelpers
-
-  def without_metadata_denormalisation(*klasses, &block)
-    klasses.each {|klass| klass.any_instance.stubs(:denormalise_metadata).returns(true) }
-    result = yield
-    klasses.each {|klass| klass.any_instance.unstub(:denormalise_metadata) }
-    result
-  end
-
-  def clean_db
-    DatabaseCleaner.clean
-  end
-  set_callback :teardown, :before, :clean_db
-
-  def timecop_return
-    Timecop.return
-  end
-  set_callback :teardown, :before, :timecop_return
-end

data/test/traits/attachable_test.rb

@@ -1,244 +0,0 @@
-require 'test_helper'
-
-class ModelWithAttachments
-  include Attachable
-  include Mongoid::Document
-
-  field :title, type: String
-  attaches :image
-end
-
-class ModelWithAttachmentsAndUrl
-  include Attachable
-  include Mongoid::Document
-
-  field :title, type: String
-  attaches :image, with_url_field: true
-end
-
-class ModelWithUpdatableAttachments
-  include Attachable
-  include Mongoid::Document
-
-  field :title, type: String
-  attaches :image, update_existing: true, with_url_field: true
-end
-
-class AttachableTest < ActiveSupport::TestCase
-
-  setup do
-    @edition = ModelWithAttachments.new
-    @edition_with_url_field = ModelWithAttachmentsAndUrl.new
-    @edition_with_update_option = ModelWithUpdatableAttachments.new
-    @previous_api_client = Attachable.asset_api_client
-    @mock_asset_api = mock("mock_asset_api")
-    Attachable.asset_api_client = @mock_asset_api
-  end
-
-  teardown do
-    Attachable.asset_api_client = @previous_api_client
-  end
-
-  context "retreiving assets from the api" do
-    should "raise an exception if there is no api client present" do
-      Attachable.asset_api_client = nil
-
-      @edition.image_id = "an_image_id"
-      assert_raise Attachable::ApiClientNotPresent do
-        @edition.image.file_url
-      end
-    end
-
-    should "make the request to the asset api" do
-      @edition.image_id = "an_image_id"
-
-      asset = OpenStruct.new(:file_url => "/path/to/image")
-      @mock_asset_api.expects(:asset).with("an_image_id").returns(asset)
-
-      assert_equal "/path/to/image", @edition.image.file_url
-    end
-
-    should "cache the asset from the api" do
-      @edition.image_id = "an_image_id"
-
-      asset = OpenStruct.new(:something => "one", :something_else => "two")
-      @mock_asset_api.expects(:asset).once.with("an_image_id").returns(asset)
-
-      assert_equal "one", @edition.image.something
-      assert_equal "two", @edition.image.something_else
-    end
-
-    should "assign a file and detect it has changed" do
-      file = File.open(File.expand_path("../../fixtures/uploads/image.jpg", __FILE__))
-      @edition.image = file
-      assert @edition.image_has_changed?
-    end
-  end
-
-  context "saving an edition without update_existing set" do
-    setup do
-      @file = File.open(File.expand_path("../../fixtures/uploads/image.jpg", __FILE__))
-      @asset = OpenStruct.new(
-        id: 'http://asset-manager.dev.gov.uk/assets/an_image_id',
-        file_url: 'http://asset-manager.dev.gov.uk/media/an_image_id/image.jpg'
-      )
-    end
-
-    should "create another asset even if an asset already exists" do
-      @edition.image_id = "foo"
-      @mock_asset_api.expects(:create_asset).returns(@asset)
-
-      @edition.image = @file
-      @edition.save!
-    end
-
-    should "create an asset when one does not exist" do
-      @mock_asset_api.expects(:create_asset).with({ :file => @file }).returns(@asset)
-
-      @edition.image = @file
-      @edition.save!
-    end
-
-    should "not upload an asset if it has not changed" do
-      @edition.save!
-    end
-
-    should "assign the asset id to the attachment id attribute" do
-      @mock_asset_api.expects(:create_asset).with({ :file => @file }).returns(@asset)
-
-      @edition.image = @file
-      @edition.save!
-
-      assert_equal "an_image_id", @edition.image_id
-    end
-
-    should "assign the asset url to the attachment url attribute if requested" do
-      @mock_asset_api.expects(:create_asset).with({ :file => @file }).returns(@asset)
-
-      @edition_with_url_field.image = @file
-      @edition_with_url_field.save!
-
-      assert_equal 'http://asset-manager.dev.gov.uk/media/an_image_id/image.jpg', @edition_with_url_field.image_url
-    end
-
-    should "not create the attachment url attribute if not requested" do
-      @mock_asset_api.expects(:create_asset).with({ :file => @file }).returns(@asset)
-
-      @edition.image = @file
-      @edition.save!
-
-      refute @edition.respond_to?(:image_url)
-    end
-
-    should "raise an exception if there is no api client present" do
-      Attachable.asset_api_client = nil
-
-      @edition.image = @file
-      assert_raise Attachable::ApiClientNotPresent do
-        @edition.save!
-      end
-    end
-
-    should "catch any errors raised by the api client" do
-      @mock_asset_api.expects(:create_asset).raises(StandardError)
-
-      assert_nothing_raised do
-        @edition.image = @file
-        @edition.save!
-      end
-
-      assert_equal ["could not be uploaded"], @edition.errors[:image_id]
-    end
-
-    should "not stop the edition from being saved when an uploading error is raised" do
-      @mock_asset_api.expects(:create_asset).raises(StandardError)
-
-      @edition.image = @file
-      @edition.title = "foo"
-      @edition.save!
-
-      @edition.reload
-      assert_equal "foo", @edition.title
-    end
-  end
-
-  context "removing an asset" do
-    should "remove an asset when remove_* set to true" do
-      @edition.image_id = 'an_image_id'
-      @edition.remove_image = true
-      @edition.save!
-
-      assert_nil @edition.image_id
-    end
-
-    should "not remove an asset when remove_* set to false or empty" do
-      @edition.image_id = 'an_image_id'
-      @edition.remove_image = false
-      @edition.remove_image = ""
-      @edition.remove_image = nil
-      @edition.save!
-
-      assert_equal "an_image_id", @edition.image_id
-    end
-  end
-
-  context "with update_existing option set" do
-    setup do
-      @file = File.open(File.expand_path("../../fixtures/uploads/image.jpg", __FILE__))
-
-      @asset_id = 'an_image_id'
-
-      @asset_response = OpenStruct.new(
-        id: "http://asset-manager.dev.gov.uk/assets/#{@asset_id}",
-        file_url: 'http://asset-manager.dev.gov.uk/media/an_image_id/image.jpg'
-      )
-    end
-
-    context "saving an edition without an existing asset" do
-      should "create a new asset" do
-        @mock_asset_api.expects(:create_asset).with(:file => @file).returns(@asset_response)
-
-        @edition_with_update_option.image = @file
-        @edition_with_update_option.save!
-      end
-
-      should "assign the asset id and file url" do
-        @mock_asset_api.stubs(:create_asset).returns(@asset_response)
-
-        @edition_with_update_option.image = @file
-        @edition_with_update_option.save!
-
-        assert_equal @asset_id, @edition_with_update_option.image_id
-        assert_equal @asset_response.file_url, @edition_with_update_option.image_url
-      end
-    end
-
-    context "saving an edition with and existing asset" do
-      setup do
-        @existing_asset = OpenStruct.new(
-          id: "http://asset-manager.dev.gov.uk/assets/#{@asset_id}",
-          file_url: 'http://asset-manager.dev.gov.uk/media/an_image_id/old_image.jpg'
-        )
-
-        @edition_with_update_option.image_id = @asset_id
-        @edition_with_update_option.image_url = @existing_asset.file_url
-      end
-
-      should "update the asset on save" do
-        @mock_asset_api.expects(:update_asset).with(@asset_id, :file => @file).returns(@asset_response)
-
-        @edition_with_update_option.image = @file
-        @edition_with_update_option.save!
-      end
-
-      should "update the file url for the asset" do
-        @mock_asset_api.stubs(:update_asset).returns(@asset_response)
-
-        @edition_with_update_option.image = @file
-        @edition_with_update_option.save!
-
-        assert_equal @asset_response.file_url, @edition_with_update_option.image_url
-      end
-    end
-  end
-end

data/test/validators/link_validator_test.rb

@@ -1,86 +0,0 @@
-# encoding: UTF-8
-
-require 'test_helper'
-
-class LinkValidatorTest < ActiveSupport::TestCase
-  class Dummy
-    include Mongoid::Document
-
-    field "body", type: String
-    field "assignee", type: String
-    GOVSPEAK_FIELDS = [:body]
-
-    validates_with LinkValidator
-  end
-
-  context "links" do
-    should "not be verified for blank govspeak fields" do
-      doc = Dummy.new(body: nil)
-
-      assert_nothing_raised do
-        doc.valid?
-      end
-      assert_empty doc.errors
-    end
-
-    should "not contain empty array for errors on fields" do
-      doc = Dummy.new(body: "Nothing is invalid")
-
-      assert doc.valid?
-      assert_empty doc.errors[:body]
-    end
-
-    should "start with http[s]://, mailto: or /" do
-      doc = Dummy.new(body: "abc [external](external.com)")
-      assert doc.invalid?
-      assert_includes doc.errors.keys, :body
-
-      doc = Dummy.new(body: "abc [external](http://external.com)")
-      assert doc.valid?
-
-      doc = Dummy.new(body: "abc [internal](/internal)")
-      assert doc.valid?
-    end
-
-    should "not contain hover text" do
-      doc = Dummy.new(body: 'abc [foobar](http://foobar.com "hover")')
-      assert doc.invalid?
-      assert_includes doc.errors.keys, :body
-    end
-
-    should "validate smart quotes as normal quotes" do
-      doc = Dummy.new(body: %q<abc [foobar](http://foobar.com “hover”)>)
-      assert doc.invalid?
-      assert_includes doc.errors.keys, :body
-    end
-
-    should "not set rel=external" do
-      doc = Dummy.new(body: 'abc [foobar](http://foobar.com){:rel="external"}')
-      assert doc.invalid?
-      assert_includes doc.errors.keys, :body
-    end
-
-    should "show multiple errors" do
-      doc = Dummy.new(body: 'abc [foobar](foobar.com "bar"){:rel="external"}')
-      assert doc.invalid?
-      assert_equal 3, doc.errors[:body].first.length
-    end
-
-    should "only show each error once" do
-      doc = Dummy.new(body: 'abc [link1](foobar.com), ghi [link2](bazquux.com)')
-      assert doc.invalid?
-      assert_equal 1, doc.errors[:body].first.length
-    end
-
-    should "be validated when any attribute of the document changes" do
-      # already published document having link validation errors
-      doc = Dummy.new(body: 'abc [link1](foobar.com), ghi [link2](bazquux.com)')
-      doc.save(validate: false)
-
-      doc.assignee = "4fdef0000000000000000001"
-      assert doc.invalid?
-
-      assert_equal 1, doc.errors[:body].first.length
-    end
-  end
-end

data/test/validators/safe_html_validator_test.rb

@@ -1,83 +0,0 @@
-require 'test_helper'
-
-class SafeHtmlTest < ActiveSupport::TestCase
-  class Dummy
-    include Mongoid::Document
-
-    field :i_am_govspeak, type: String
-
-    GOVSPEAK_FIELDS = [:i_am_govspeak]
-
-    validates_with SafeHtml
-
-    embeds_one :dummy_embedded_single, class_name: 'SafeHtmlTest::DummyEmbeddedSingle'
-  end
-
-  class DummyEmbeddedSingle
-    include Mongoid::Document
-
-    embedded_in :dummy, class_name: 'SafeHtmlTest::Dummy'
-
-    field :i_am_govspeak, type: String
-
-    GOVSPEAK_FIELDS = [:i_am_govspeak]
-
-    validates_with SafeHtml
-  end
-
-  context "we don't quite trust mongoid (2)" do
-    should "validate embedded documents automatically" do
-      embedded = DummyEmbeddedSingle.new(i_am_govspeak: "<script>")
-      dummy = Dummy.new(i_am_govspeak: embedded)
-      # Can't invoke embedded.valid? because that would run the validations
-      assert dummy.invalid?
-      assert_includes dummy.errors.keys, :i_am_govspeak
-    end
-  end
-
-  context "what to validate" do
-    should "allow clean content in nested fields" do
-      dummy = Dummy.new(i_am_govspeak: { "clean" => ["plain text"] })
-      assert dummy.valid?
-    end
-
-    should "disallow images not hosted by us" do
-      dummy = Dummy.new(i_am_govspeak: '<img src="http://evil.com/trollface"/>')
-      assert dummy.invalid?
-      assert_includes dummy.errors.keys, :i_am_govspeak
-    end
-
-    should "allow images hosted by us" do
-      dummy = Dummy.new(i_am_govspeak: '<img src="http://www.dev.gov.uk/trollface"/>')
-      assert dummy.valid?
-    end
-
-    should "allow plain text" do
-      dummy = Dummy.new(i_am_govspeak: "foo bar")
-      assert dummy.valid?
-    end
-
-    should "check only specified fields as Govspeak" do
-      nasty_govspeak = %q{[Numberwang](script:nasty(); "Wangernum")}
-      assert ! Govspeak::Document.new(nasty_govspeak).valid?, "expected this to be identified as bad"
-
-      dummy = Dummy.new(i_am_govspeak: nasty_govspeak)
-      assert dummy.invalid?
-    end
-
-    should "all models that have govspeak fields should use this validator" do
-      models_dir = File.expand_path("../../app/models/*", File.dirname(__FILE__))
-
-      classes = Dir[models_dir]
-        .map { |file|
-          File.basename(file, ".rb").camelize.constantize
-        }
-        .select { |klass|
-          klass.included_modules.include?(Mongoid::Document) && klass.const_defined?(:GOVSPEAK_FIELDS)
-        }
-        .each { |klass|
-          assert_includes klass.validators.map(&:class), SafeHtml, "#{klass} must be validated with SafeHtml"
-        }
-    end
-  end
-end