govuk_content_models 41.1.1 → 42.0.0

data/test/models/tag_test.rb

@@ -1,188 +0,0 @@
-require "test_helper"
-
-class TagTest < ActiveSupport::TestCase
-  test "should return a hash of the fields" do
-    tag = FactoryGirl.build(:live_tag,
-      tag_id: "crime",
-      tag_type: "section",
-      title: "Crime",
-    )
-    expected_hash = {
-      id: "crime",
-      title: "Crime",
-      type: "section",
-      description: nil,
-      short_description: nil
-    }
-    assert_equal expected_hash, tag.as_json
-  end
-
-  setup do
-    %w(crime business housing).each do |section|
-      FactoryGirl.create(:live_tag, :tag_id => section, :title => section.capitalize)
-    end
-
-    %w(pie mash chips).each do |keyword|
-      FactoryGirl.create(
-        :live_tag,
-        :tag_id => keyword,
-        :title => keyword.capitalize,
-        :tag_type => "keyword"
-      )
-    end
-  end
-
-  test "should load by tag ID" do
-    assert_equal "Crime", Tag.by_tag_id("crime").title
-  end
-
-  test "should load by tag ID and type" do
-    # This form is deprecated in favour of providing the type as an option
-    assert_equal "Crime", Tag.by_tag_id("crime", "section").title
-  end
-
-  test "accepts the tag type as an option" do
-    assert_equal "Crime", Tag.by_tag_id("crime", type: "section").title
-  end
-
-  test "should not load an incorrectly-typed tag" do
-    assert_nil Tag.by_tag_id("crime", "keyword")
-  end
-
-  test "should return nil if tag does not exist" do
-    assert_nil Tag.by_tag_id("batman")
-  end
-
-  test "should return multiple tags" do
-    assert_equal(
-      %w(Crime Business),
-      Tag.by_tag_ids(%w(crime business)).map(&:title)
-    )
-  end
-
-  test "should not return missing tags" do
-    tag_ids = %w(crime business not_a_real_tag housing)
-    tags = Tag.by_tag_ids(tag_ids)
-
-    assert_equal %w(crime business housing), tags.map(&:tag_id)
-  end
-
-  test "should not return draft tags unless requested" do
-    draft_tag = FactoryGirl.create(:draft_tag,
-      tag_id: "draft-tag",
-      tag_type: "section",
-      title: "A draft tag",
-    )
-
-    tag_ids = %w(crime business draft-tag housing)
-
-    assert_equal %w(crime business housing).to_set, Tag.by_tag_ids(tag_ids).map(&:tag_id).to_set
-    assert_equal %w(crime business draft-tag housing).to_set, Tag.by_tag_ids(tag_ids, draft: true).map(&:tag_id).to_set
-
-    assert_nil Tag.by_tag_id('draft-tag')
-    assert_equal draft_tag, Tag.by_tag_id('draft-tag', draft: true)
-  end
-
-  test "should return nil for tags of the wrong type" do
-    tag_ids = %w(crime business pie batman)
-    tags = Tag.by_tag_ids(tag_ids, "section")
-    [2, 3].each do |i| assert_nil tags[i] end
-    [0, 1].each do |i| assert_equal tag_ids[i], tags[i].tag_id end
-  end
-
-  test "should raise an exception if any tags are missing" do
-    assert_raises Tag::MissingTags do
-      Tag.validate_tag_ids(%w(crime business batman))
-    end
-  end
-
-  test "should raise an exception with the wrong tag type" do
-    assert_raises Tag::MissingTags do
-      Tag.validate_tag_ids(%w(crime business pie chips), "section")
-    end
-  end
-
-  test "should return tags given a list of tag ids and tag types" do
-    tag_types_and_ids = [
-      { tag_type: "section", tag_id: "crime" },
-      { tag_type: "section", tag_id: "business" },
-      { tag_type: "keyword", tag_id: "pie" },
-      { tag_type: "keyword", tag_id: "chips" }
-    ]
-    tags = Tag.by_tag_types_and_ids(tag_types_and_ids)
-
-    assert_equal %w{Business Chips Crime Pie}, tags.map(&:title).sort
-  end
-
-  test "should be invalid when tag id already exists for the tag type" do
-    Tag.create!(tag_id: "cars", tag_type: "vehicles", title: "Cars")
-    Tag.create!(tag_id: "cars", tag_type: "gary-numan-songs", title: "Cars")
-
-    tag = Tag.new(tag_id: "cars", tag_type: "vehicles")
-
-    refute tag.valid?
-    assert tag.errors.has_key?(:tag_id)
-  end
-
-  test "should validate with TagIdValidator" do
-    assert_includes Tag.validators.map(&:class), TagIdValidator
-  end
-
-  test "#parent returns the parent even if the parent is draft" do
-    parent = FactoryGirl.create(:tag, state: 'draft')
-    child = FactoryGirl.create(:tag, state: 'draft', parent_id: parent.tag_id)
-
-    assert_equal parent, child.parent
-  end
-
-  context "state" do
-    setup do
-      @atts = { tag_type: 'section', tag_id: 'test', title: 'Test' }
-    end
-
-    should "be created in draft state by default" do
-      tag = Tag.create(@atts)
-
-      assert tag.persisted?
-      assert_equal 'draft', tag.state
-    end
-
-    should "be able to be set to live" do
-      tag = Tag.new(@atts)
-      tag.state = 'live'
-      tag.save
-
-      tag.reload
-      assert_equal 'live', tag.state
-    end
-
-    should "not be created in another state" do
-      tag = Tag.new(@atts)
-      tag.state = 'foo'
-
-      assert !tag.valid?
-      assert tag.errors.has_key?(:state)
-    end
-
-    should "be set to live when published" do
-      tag = Tag.create(@atts)
-
-      assert_equal 'draft', tag.state
-      tag.publish!
-
-      tag.reload
-      assert_equal 'live', tag.state
-    end
-
-    should "not be published more than once" do
-      tag = Tag.create(@atts)
-
-      tag.publish!
-      tag.reload
-
-      assert_raises StateMachines::InvalidTransition do
-        tag.publish!
-      end
-    end
-  end
-end

data/test/traits/taggable_test.rb

@@ -1,132 +0,0 @@
-require 'test_helper'
-
-# This test relies on the fact that artefact uses the taggable module
-class TaggableTest < ActiveSupport::TestCase
-
-  TEST_KEYWORDS = [['cheese', 'Cheese'], ['bacon', 'Bacon']]
-
-  setup do
-    @parent_section = FactoryGirl.create(:live_tag, :tag_id => 'crime', :tag_type => 'section', :title => 'Crime')
-    FactoryGirl.create(:live_tag, :tag_id => 'crime/the-police', :tag_type => 'section', :title => 'The Police', :parent_id => @parent_section.id)
-    FactoryGirl.create(:live_tag, :tag_id => 'crime/batman', :tag_type => 'section', :title => 'Batman', :parent_id => @parent_section.id)
-    @draft_section = FactoryGirl.create(:draft_tag, parent_id: @parent_section.id)
-
-    TEST_KEYWORDS.each do |tag_id, title|
-      FactoryGirl.create(:live_tag, :tag_id => tag_id, :tag_type => 'keyword', :title => title)
-    end
-
-    @item = FactoryGirl.create(:artefact)
-  end
-
-  test "can set sections" do
-    @item.sections = ['crime', 'crime/the-police']
-
-    assert_equal ['crime', 'crime/the-police'], @item.tag_ids, 'Mismatched tags'
-    assert_equal ['crime', 'crime/the-police'], @item.sections.collect(&:tag_id), 'Mismatched sections'
-
-    assert_equal 'Crime', @item.primary_section.title
-  end
-
-  test "can set sections and primary section separately" do
-    @item.sections = ['crime', 'crime/the-police']
-    @item.primary_section = 'crime'
-
-    assert_equal ['crime', 'crime/the-police'], @item.tag_ids, 'Mismatched tags'
-    assert_equal ['crime', 'crime/the-police'], @item.sections.collect(&:tag_id), 'Mismatched sections'
-
-    assert_equal 'Crime', @item.primary_section.title
-  end
-
-  test "can set subsection as primary section" do
-    @item.sections = ['crime/the-police', 'crime']
-    @item.primary_section = 'crime/the-police'
-    assert_equal 'The Police', @item.primary_section.title
-  end
-
-  test "cannot set non-existent sections" do
-    assert_raise Tag::MissingTags do
-      @item.sections = ['weevils']
-    end
-  end
-
-  test "cannot set non-section tags" do
-    assert_raise Tag::MissingTags do
-      @item.sections = ['crime', 'bacon']
-    end
-  end
-
-  test "can set no sections" do
-    @item.sections = ['crime', 'crime/the-police']
-    @item.sections = []
-    assert_equal [], @item.sections
-
-    refute @item.primary_section
-  end
-
-  test "setting sections doesn't break other tags" do
-    @item.keywords = ['cheese', 'bacon']
-    @item.sections = ['crime']
-    @item.primary_section = 'crime'
-
-    assert_equal ['bacon', 'cheese', 'crime'], @item.tag_ids.sort
-    assert_equal 'Crime', @item.primary_section.title
-  end
-
-  test "setting primary section adds section to tags" do
-    @item.sections = ['crime', 'crime/the-police']
-    @item.primary_section = 'crime/batman'
-
-    assert_includes @item.sections.collect(&:tag_id), 'crime/batman'
-  end
-
-  test "setting primary section to existing section works" do
-    @item.sections = ['crime', 'crime/the-police']
-    @item.primary_section = 'crime/the-police'
-    # Note: not testing the order of the sections in this test, just testing
-    # that the section is still present and not duplicated
-    assert_equal ['crime', 'crime/the-police'], @item.sections.collect(&:tag_id).sort
-  end
-
-  test "setting primary section to existing section reorders correctly" do
-    @item.sections = ['crime', 'crime/the-police']
-    @item.save!
-
-    @item.primary_section = 'crime/batman'
-    @item.save!
-
-    assert_equal 'crime/batman', @item.primary_section.tag_id
-    assert_equal ['crime/batman', 'crime', 'crime/the-police'], @item.sections.collect(&:tag_id)
-  end
-
-  test "can set tags using foo_ids= type method" do
-    @item.keyword_ids = ['bacon']
-    @item.save!
-
-    @item.reload
-
-    assert_equal ['bacon'], @item.keyword_ids
-  end
-
-  test "can set tags of type to be nil" do
-    @item.section_ids = nil
-    @item.save!
-
-    assert_equal [], @item.section_ids
-
-    @item.sections = nil
-    @item.save!
-
-    assert_equal [], @item.section_ids
-  end
-
-  test "returns draft tags only if requested" do
-    @item.section_ids = [@parent_section.tag_id, @draft_section.tag_id]
-    @item.save!
-
-    assert_equal [@parent_section.tag_id], @item.section_ids
-    assert_equal [@parent_section.tag_id, @draft_section.tag_id], @item.section_ids(draft: true)
-
-    assert_equal [@parent_section], @item.sections
-    assert_equal [@parent_section, @draft_section], @item.sections(draft: true)
-  end
-end

data/test/validators/browse_page_validator_test.rb

@@ -1,34 +0,0 @@
-require 'test_helper'
-require 'browse_page_validator'
-
-class BrowsePageValidatorTest < ActiveSupport::TestCase
-  class Record
-    include Mongoid::Document
-
-    field :browse_pages, type: Array
-
-    validates_with BrowsePageValidator
-  end
-
-  should "allow tagging to a variety of unique browse pages" do
-    record = Record.new(
-      browse_pages: [
-        'business/tax',
-        'housing/safety-environment'
-      ]
-    )
-
-    assert record.valid?
-  end
-
-  should "be invalid if there's duplicates in the browse page list" do
-    record = Record.new(
-      browse_pages: [
-        'housing/safety-environment',
-        'housing/safety-environment'
-      ]
-    )
-
-    refute record.valid?
-  end
-end

data/test/validators/tag_id_validator_test.rb

@@ -1,66 +0,0 @@
-require 'test_helper'
-require 'tag_id_validator'
-
-class TagIdValidatorTest < ActiveSupport::TestCase
-  class Dummy
-    include Mongoid::Document
-
-    field :tag_id, type: String
-    field :parent_id, type: String
-
-    validates_with TagIdValidator
-  end
-
-  should "permit a lower-case alphanumeric tag id" do
-    dummy = Dummy.new(tag_id: "a-good-tag-id")
-    assert dummy.valid?
-  end
-
-  should "not permit a tag id with spaces" do
-    dummy = Dummy.new(tag_id: "this tag has spaces")
-    refute dummy.valid?
-    assert dummy.errors.has_key?(:tag_id)
-  end
-
-  should "not permit a tag id with uppercase characters" do
-    dummy = Dummy.new(tag_id: "CLEAN-ALL-THE-THINGS")
-    refute dummy.valid?
-    assert dummy.errors.has_key?(:tag_id)
-  end
-
-  should "not permit a tag id with non-alphanumeric characters" do
-    dummy = Dummy.new(tag_id: "a-t@g-!d")
-    refute dummy.valid?
-    assert dummy.errors.has_key?(:tag_id)
-  end
-
-  should "not permit a tag id with underscores" do
-    dummy = Dummy.new(tag_id: "tag_id_with_underscores")
-    refute dummy.valid?
-    assert dummy.errors.has_key?(:tag_id)
-  end
-
-  should "permit a child tag id containing a slash" do
-    dummy = Dummy.new(tag_id: "parent-tag-id/child-tag-id", parent_id: 1)
-    assert dummy.valid?
-  end
-
-  should "not permit a parent tag id containing a slash" do
-    dummy = Dummy.new(tag_id: "an-invalid/parent-tag-id", parent_id: nil)
-    refute dummy.valid?
-    assert dummy.errors.has_key?(:tag_id)
-  end
-
-  should "not permit a child tag id with more than one slash" do
-    dummy = Dummy.new(tag_id: "parent-tag-id/two/slashes", parent_id: 1)
-    refute dummy.valid?
-    assert dummy.errors.has_key?(:tag_id)
-  end
-
-  should "not permit a slash at the end of a tag id" do
-    dummy = Dummy.new(tag_id: "parent-tag-id/")
-    refute dummy.valid?
-    assert dummy.errors.has_key?(:tag_id)
-  end
-
-end

data/test/validators/topic_validator_test.rb

@@ -1,48 +0,0 @@
-require 'test_helper'
-require 'topic_validator'
-
-class TopicValidatorTest < ActiveSupport::TestCase
-  class Record
-    include Mongoid::Document
-
-    field :primary_topic, type: String
-    field :additional_topics, type: Array
-
-    validates_with TopicValidator
-  end
-
-  should "allow tagging to a variety of unique topics" do
-    record = Record.new(
-      primary_topic: 'oil-and-gas/exploration',
-      additional_topics: [
-        'oil-and-gas/fields-and-wells',
-        'oil-and-gas/licensing'
-      ]
-    )
-
-    assert record.valid?
-  end
-
-  should "be invalid if there's duplicates in the additional topic list" do
-    record = Record.new(
-      additional_topics: [
-        'oil-and-gas/fields-and-wells',
-        'oil-and-gas/fields-and-wells'
-      ]
-    )
-
-    refute record.valid?
-  end
-
-  should "be invalid if the primary topic is in the additional topic list" do
-    record = Record.new(
-      primary_topic: 'oil-and-gas/fields-and-wells',
-      additional_topics: [
-        'oil-and-gas/fields-and-wells',
-        'oil-and-gas/licensing'
-      ]
-    )
-
-    refute record.valid?
-  end
-end