govuk_content_models 41.0.0 → 41.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a665f9f898baa89d155ed724cf36c4a489aedb0
-  data.tar.gz: e13f1d9f21a351ce972c7e881120cbbcd0501755
+  metadata.gz: dbcfb829a13e415c1340980483a7fdc28a46b852
+  data.tar.gz: d8a1ae1a225355001e6455992ca58d41d728dad8
 SHA512:
-  metadata.gz: 644d193130ee66d93516633f457308cc9236498cf1ffe836d431fb24b7c253a735c4b8ff388be7086be27a3747cfb1c7720457240b3b02970eff27f1598ae653
-  data.tar.gz: 5b814b44410cc7ac2554ad8a85ba1d80beec9d83406a9f70980c9442a98bc2d7cb11e7e59bc0ad358634ae3a49df1464a4def76483568bd373e262b4fff0cda9
+  metadata.gz: 84a2db1e3826a777476146dc6900127b9b8554c675024de35aeef93af1a9c1fa5ec193b3f584f5d76b01062f0f2838c2664af23d4cf0f5a764223d5aee6f6a57
+  data.tar.gz: 3676a0785f93ebcd0164a294d6a5a8dce86d803ec05530f2018ba090389683c6c2bf02fd93f1695aa5e012d86f236b915109238304bdcb37686a72fb6cb59ee8

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 41.1.0
+
+- Adds 'skip review' Edition workflow processor
+
 ## 41.0.0
 
 - Add start button text attribute for SimpleSmartAnswerEdition

data/app/models/workflow.rb

@@ -28,7 +28,7 @@ module Workflow
         edition.publish_at = nil
       end
 
-      before_transition on: [:approve_review, :request_amendments] do |edition, transition|
+      before_transition on: [:approve_review, :skip_review, :request_amendments] do |edition, _transition|
         edition.reviewer = nil
       end
 
@@ -56,6 +56,10 @@ module Workflow
         transition [:fact_check_received, :in_review, :ready, :fact_check] => :amends_needed
       end
 
+      event :skip_review do
+        transition in_review: :ready
+      end
+
       # Editions can optionally be sent out for fact check
       event :send_fact_check do
         transition [:ready, :fact_check_received] => :fact_check
@@ -86,10 +90,6 @@ module Workflow
         transition [:ready, :scheduled_for_publishing] => :published
       end
 
-      event :emergency_publish do
-        transition draft: :published
-      end
-
       event :archive do
         transition all => :archived, :unless => :archived?
       end

data/lib/govuk_content_models/action_processors/skip_review_processor.rb

@@ -0,0 +1,9 @@
+module GovukContentModels
+  module ActionProcessors
+    class SkipReviewProcessor < BaseProcessor
+      def process?
+        actor.permissions.include?("skip_review")
+      end
+    end
+  end
+end

data/lib/govuk_content_models/action_processors.rb

@@ -18,6 +18,7 @@ module GovukContentModels
       publish: 'PublishProcessor',
       archive: 'ArchiveProcessor',
       new_version: 'NewVersionProcessor',
+      skip_review: 'SkipReviewProcessor',
     }
   end
 end

data/lib/govuk_content_models/test_helpers/action_processor_helpers.rb

@@ -34,6 +34,10 @@ module GovukContentModels
           publish_at: action_attributes[:publish_at] || Time.zone.now.utc,
           comment: action_attributes[:comment] || 'Schedule!' })
       end
+
+      def skip_review(user, edition)
+        user.progress(edition, request_type: :skip_review, comment: "Skipping review as this is an out of hours urgent update.")
+      end
     end
   end
 end

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "41.0.0"
+  VERSION = "41.1.0"
 end

data/test/models/edition_test.rb

@@ -890,12 +890,6 @@ class EditionTest < ActiveSupport::TestCase
     refute edition.can_publish?
   end
 
-  test "a draft edition can be emergency published" do
-    edition = FactoryGirl.create(:guide_edition, panopticon_id: @artefact.id, state: "draft")
-    assert edition.can_emergency_publish?
-  end
-
-
   # test denormalisation
 
   test "should denormalise an edition with an assigned user and action requesters" do

data/test/models/workflow_test.rb

@@ -149,6 +149,21 @@ class WorkflowTest < ActiveSupport::TestCase
     assert edition.can_publish?
   end
 
+  test "skip review workflow" do
+    user = FactoryGirl.create(:user, name: "Ben", permissions: ["skip_review"])
+    other = FactoryGirl.create(:user, name: "Ben", permissions: ["signin"])
+
+    edition = user.create_edition(:guide, title: "My Title", slug: "my-title", panopticon_id: @artefact.id)
+
+    assert edition.can_request_review?
+    request_review(user, edition)
+    assert edition.can_skip_review?
+    refute skip_review(other, edition)
+    assert skip_review(user, edition)
+    assert edition.ready?
+    assert edition.can_publish?
+  end
+
   test "when fact check has been initiated it can be skipped" do
     user = FactoryGirl.create(:user, name: "Ben")
     other_user = FactoryGirl.create(:user, name: "James")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 41.0.0
+  version: 41.1.0
 platform: ruby
 authors:
 - Paul Battley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-01 00:00:00.000000000 Z
+date: 2016-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bson_ext
@@ -391,6 +391,7 @@ files:
 - lib/govuk_content_models/action_processors/schedule_for_publishing_processor.rb
 - lib/govuk_content_models/action_processors/send_fact_check_processor.rb
 - lib/govuk_content_models/action_processors/skip_fact_check_processor.rb
+- lib/govuk_content_models/action_processors/skip_review_processor.rb
 - lib/govuk_content_models/presentation_toggles.rb
 - lib/govuk_content_models/require_all.rb
 - lib/govuk_content_models/test_helpers/action_processor_helpers.rb