govuk_content_models 23.0.0 → 24.0.0

data/app/models/workflow_actor.rb

@@ -1,157 +0,0 @@
-require "answer_edition"
-require "guide_edition"
-require "local_transaction_edition"
-require "place_edition"
-require "programme_edition"
-require "transaction_edition"
-
-module WorkflowActor
-  SIMPLE_WORKFLOW_ACTIONS = %w(
-    request_review
-    request_amendments
-    approve_review
-    approve_fact_check
-    archive
-    cancel_scheduled_publishing
-  )
-
-  def record_action(edition, type, options={})
-    type = Action.const_get(type.to_s.upcase)
-    action = edition.new_action(self, type, options)
-    edition.denormalise_users!
-    action
-  end
-
-  def record_action_without_validation(edition, type, options={})
-    type = Action.const_get(type.to_s.upcase)
-    action = edition.new_action_without_validation(self, type, options)
-    edition.denormalise_users!
-    action
-  end
-
-  def can_take_action(action, edition)
-    respond_to?(:"can_#{action}?") ? __send__(:"can_#{action}?", edition) : true
-  end
-
-  def take_action(edition, action, details = {}, action_parameters = [])
-    if can_take_action(action, edition) && edition.send(action, *action_parameters)
-      record_action(edition, action, details)
-      edition
-    else
-      false
-    end
-  end
-
-  def take_action!(edition, action, details = {}, action_parameters = [])
-    edition = take_action(edition, action, details, action_parameters)
-    edition.save if edition
-  end
-
-  def progress(edition, activity_details)
-    activity = activity_details.delete(:request_type)
-
-    edition = send(activity, edition, activity_details)
-    edition.save if edition
-  end
-
-  def record_note(edition, comment, type = Action::NOTE)
-    edition.new_action(self, type, comment: comment)
-  end
-
-  def resolve_important_note(edition)
-    record_note(edition, nil, Action::IMPORTANT_NOTE_RESOLVED)
-  end
-
-  def create_edition(format, attributes = {})
-    format = "#{format}_edition" unless format.to_s.match(/edition$/)
-    publication_class = format.to_s.camelize.constantize
-
-    item = publication_class.create(attributes)
-    record_action(item, Action::CREATE) if item.persisted?
-    item
-  end
-
-  def new_version(edition, convert_to = nil)
-    return false unless edition.published?
-
-    if not convert_to.nil?
-      convert_to = convert_to.to_s.camelize.constantize
-      new_edition = edition.build_clone(convert_to)
-    else
-      new_edition = edition.build_clone
-    end
-
-    if new_edition
-      record_action new_edition, Action::NEW_VERSION
-      new_edition
-    else
-      false
-    end
-  end
-
-  def send_fact_check(edition, details)
-    return false if details[:email_addresses].blank?
-
-    details[:comment] ||= "Fact check requested"
-
-    take_action(edition, __method__, details)
-  end
-
-  # Always records the action.
-  def receive_fact_check(edition, details)
-    edition.perform_event_without_validations(:receive_fact_check)
-    # Fact checks are processed async, so the user doesn't get an opportunity
-    # to retry without the content that (inadvertantly) fails validation, which happens frequently.
-    record_action_without_validation(edition, :receive_fact_check, details)
-  end
-
-  def skip_fact_check(edition, details)
-    edition.skip_fact_check
-    record_action(edition, :skip_fact_check, details)
-  end
-
-  SIMPLE_WORKFLOW_ACTIONS.each do |method|
-    define_method(method) do |edition, details = {}|
-      take_action(edition, __method__, details)
-    end
-  end
-
-  def schedule_for_publishing(edition, details)
-    publish_at = details.delete(:publish_at)
-    take_action(edition, __method__, details, [publish_at])
-  end
-
-  def publish(edition, details)
-    take_action(edition, __method__, details)
-  end
-
-  def can_approve_review?(edition)
-    requester_different?(edition)
-  end
-
-  def can_request_amendments?(edition)
-    if edition.in_review?
-      requester_different?(edition)
-    else
-      true
-    end
-  end
-
-  def assign(edition, recipient)
-    edition.set(:assigned_to_id, recipient.id)
-    record_action edition.reload, __method__, recipient: recipient
-  end
-
-  private
-
-  def requester_different?(edition)
-    # To accommodate latest_status_action being nil, we'll always return true in
-    # those cases
-    # This is intended as a v.temporary fix until we can remedy the root cause
-    if edition.latest_status_action
-      edition.latest_status_action.requester_id != self.id
-    else
-      true
-    end
-  end
-end

data/test/models/workflow_actor_test.rb

@@ -1,112 +0,0 @@
-require_relative "../test_helper"
-
-class WorkflowActorTest < ActiveSupport::TestCase
-
-  context "creating a new version of an edition" do
-    setup do
-      @user = User.new
-      @user.stubs(:record_action)
-      @edition = stub("AnswerEdition", :published? => true, :build_clone => :new_version)
-    end
-
-    should "return false if the edition is not published" do
-      @edition.stubs(:published?).returns(false)
-      @edition.expects(:build_clone).never
-      @user.expects(:record_action).never
-      assert_equal false, @user.new_version(@edition)
-    end
-
-    should "build a clone" do
-      @edition.expects(:build_clone).with(nil).returns(:new_verison)
-      @user.new_version(@edition)
-    end
-
-    should "record the action" do
-      @user.expects(:record_action).with(:new_version, Action::NEW_VERSION)
-      @user.new_version(@edition)
-    end
-
-    should "return the new edition" do
-      assert_equal :new_version, @user.new_version(@edition)
-    end
-
-    context "creating an edition of a different type" do
-      should "build a clone of a new type" do
-        @edition.expects(:build_clone).with(GuideEdition).returns(:new_verison)
-        @user.new_version(@edition, "GuideEdition")
-      end
-
-      should "record the action" do
-        @user.expects(:record_action).with(:new_version, Action::NEW_VERSION)
-        @user.new_version(@edition)
-      end
-    end
-
-    context "when building the edition fails" do
-      setup do
-        @edition.stubs(:build_clone).returns(nil)
-      end
-
-      should "not record the action" do
-        @user.expects(:record_action).never
-        @user.new_version(@edition)
-      end
-
-      should "return false" do
-        assert_equal false, @user.new_version(@edition)
-      end
-    end
-  end
-
-  context "#receive_fact_check" do
-    setup do
-      @edition = FactoryGirl.create(:guide_edition_with_two_parts, state: :fact_check)
-      # Internal links must start with a forward slash eg [link text](/link-destination)
-      @edition.parts.first.update_attribute(:body,
-        "[register and tax your vehicle](registering-an-imported-vehicle)")
-    end
-
-    should "transition an edition with link validation errors to fact_check_received state" do
-      assert @edition.invalid?
-      assert User.new.receive_fact_check(@edition, {})
-      assert_equal "fact_check_received", @edition.reload.state
-    end
-
-    should "record the action" do
-      user = User.new
-      user.receive_fact_check(@edition, {})
-
-      assert_equal 1, @edition.actions.count
-      assert_equal "receive_fact_check", @edition.actions.last.request_type
-    end
-  end
-
-  context "#schedule_for_publishing" do
-    setup do
-      @user = FactoryGirl.build(:user)
-      @publish_at = 1.day.from_now
-      @activity_details = { publish_at: @publish_at, comment: "Go schedule !" }
-    end
-
-    should "return false when scheduling an already published edition" do
-      edition = FactoryGirl.create(:edition, state: 'published')
-      refute @user.schedule_for_publishing(edition, @activity_details)
-    end
-
-    should "schedule an edition for publishing if it is ready" do
-      edition = FactoryGirl.create(:edition, state: 'ready')
-
-      edition = @user.schedule_for_publishing(edition, @activity_details)
-
-      assert edition.scheduled_for_publishing?
-      assert_equal @publish_at.to_i, edition.publish_at.to_i
-    end
-
-    should "record the action" do
-      edition = FactoryGirl.create(:edition, state: 'ready')
-      @user.expects(:record_action).with(edition, :schedule_for_publishing, { comment: "Go schedule !" })
-
-      @user.schedule_for_publishing(edition, @activity_details)
-    end
-  end
-end