govuk_content_models 14.1.0 → 14.1.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 14.1.1
+* Use another way to transition Editions without
+  validation
+
 ## 14.1.0
 * Edition errors should not block receiving of
   fact check response, and related state transition.

data/app/models/workflow_actor.rb

@@ -98,7 +98,7 @@ module WorkflowActor
     # advance state if possible (i.e. if in "fact_check" state),
     # save separately without validation
     # http://rubydoc.info/github/pluginaweek/state_machine/StateMachine/Machine:event
-    edition.state_event = :receive_fact_check
+    edition.receive_fact_check(false)
     edition.save(validate: false)
     # Fact checks are processed async, so the user doesn't get an opportunity
     # to retry without the content that (inadvertantly) fails validation, which happens frequently.

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "14.1.0"
+  VERSION = "14.1.1"
 end

data/test/models/workflow_actor_test.rb

@@ -59,14 +59,25 @@ class WorkflowActorTest < ActiveSupport::TestCase
   end
 
   context "#receive_fact_check" do
-    should "transition an edition with link validation errors to fact_check_received state" do
-      edition = FactoryGirl.create(:guide_edition_with_two_parts, state: :fact_check)
+    setup do
+      @edition = FactoryGirl.create(:guide_edition_with_two_parts, state: :fact_check)
       # Internal links must start with a forward slash eg [link text](/link-destination)
-      edition.parts.first.update_attribute(:body, "[register and tax your vehicle](registering-an-imported-vehicle)")
+      @edition.parts.first.update_attribute(:body,
+        "[register and tax your vehicle](registering-an-imported-vehicle)")
+    end
+
+    should "transition an edition with link validation errors to fact_check_received state" do
+      assert @edition.invalid?
+      assert User.new.receive_fact_check(@edition, {})
+      assert_equal "fact_check_received", @edition.reload.state
+    end
+
+    should "record the action" do
+      user = User.new
+      user.receive_fact_check(@edition, {})
 
-      assert edition.invalid?
-      assert User.new.receive_fact_check(edition, {})
-      assert_equal "fact_check_received", edition.reload.state
+      assert_equal 1, @edition.actions.count
+      assert_equal "receive_fact_check", @edition.actions.last.request_type
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 14.1.0
+  version: 14.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -466,7 +466,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -941845765885480404
+      hash: 2394194236032864468
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -475,7 +475,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -941845765885480404
+      hash: 2394194236032864468
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23