govuk_content_models 14.0.1 → 14.1.0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 14.1.0
+* Edition errors should not block receiving of
+  fact check response, and related state transition.
+
 ## 14.0.1
 * Valdations for Business support scheme dates.
 

data/app/models/workflow_actor.rb

@@ -93,10 +93,13 @@ module WorkflowActor
     take_action(edition, __method__, details)
   end
 
-  # Advances state if possible (i.e. if in "fact_check" state)
   # Always records the action.
   def receive_fact_check(edition, details)
-    edition.receive_fact_check
+    # advance state if possible (i.e. if in "fact_check" state),
+    # save separately without validation
+    # http://rubydoc.info/github/pluginaweek/state_machine/StateMachine/Machine:event
+    edition.state_event = :receive_fact_check
+    edition.save(validate: false)
     # Fact checks are processed async, so the user doesn't get an opportunity
     # to retry without the content that (inadvertantly) fails validation, which happens frequently.
     record_action_without_validation(edition, :receive_fact_check, details)

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "14.0.1"
+  VERSION = "14.1.0"
 end

data/test/models/workflow_actor_test.rb

@@ -58,6 +58,18 @@ class WorkflowActorTest < ActiveSupport::TestCase
     end
   end
 
+  context "#receive_fact_check" do
+    should "transition an edition with link validation errors to fact_check_received state" do
+      edition = FactoryGirl.create(:guide_edition_with_two_parts, state: :fact_check)
+      # Internal links must start with a forward slash eg [link text](/link-destination)
+      edition.parts.first.update_attribute(:body, "[register and tax your vehicle](registering-an-imported-vehicle)")
+
+      assert edition.invalid?
+      assert User.new.receive_fact_check(edition, {})
+      assert_equal "fact_check_received", edition.reload.state
+    end
+  end
+
   context "#schedule_for_publishing" do
     setup do
       @user = FactoryGirl.build(:user)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 14.0.1
+  version: 14.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-07 00:00:00.000000000 Z
+date: 2014-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bson_ext
@@ -466,7 +466,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2796015811550823768
+      hash: -941845765885480404
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -475,7 +475,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2796015811550823768
+      hash: -941845765885480404
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23