govuk_content_models 13.1.0 → 13.2.0

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 13.2.0
+
+* Denormalising users doesn't require the entire edition
+  to be validated and saved. Hence replacing it with a
+  set operation.
+
 ## 13.1.0
 
 * Perform link validation everytime an edition is saved,

data/app/models/workflow.rb

@@ -11,7 +11,7 @@ module Workflow
     before_destroy :check_can_delete_and_notify
     after_destroy :notify_siblings_of_published_edition
 
-    before_save :denormalise_users
+    before_save :denormalise_users!
     after_create :notify_siblings_of_new_edition
 
     field :state, type: String, default: "draft"
@@ -113,13 +113,13 @@ module Workflow
       # collections, but share a model and relationships with eg actions.
       # Therefore, Panopticon might not find a user for an action.
       if action.requester
-        self[property] = action.requester.name
+        set(property, action.requester.name)
       end
     end
   end
 
-  def denormalise_users
-    self.assignee = assigned_to.name if assigned_to
+  def denormalise_users!
+    set(:assignee, assigned_to.name) if assigned_to
     update_user_action("creator",   [Action::CREATE, Action::NEW_VERSION])
     update_user_action("publisher", [Action::PUBLISH])
     update_user_action("archiver",  [Action::ARCHIVE])

data/app/models/workflow_actor.rb

@@ -18,14 +18,14 @@ module WorkflowActor
   def record_action(edition, type, options={})
     type = Action.const_get(type.to_s.upcase)
     action = edition.new_action(self, type, options)
-    edition.save! # force callbacks for denormalisation
+    edition.denormalise_users!
     action
   end
 
   def record_action_without_validation(edition, type, options={})
     type = Action.const_get(type.to_s.upcase)
     action = edition.new_action_without_validation(self, type, options)
-    edition.save! # force callbacks for denormalisation
+    edition.denormalise_users!
     action
   end
 

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "13.1.0"
+  VERSION = "13.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 13.1.0
+  version: 13.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-30 00:00:00.000000000 Z
+date: 2014-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bson_ext
@@ -468,7 +468,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3968322493535116070
+      hash: -3600422238156997598
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -477,7 +477,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3968322493535116070
+      hash: -3600422238156997598
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23