govuk_content_models 11.0.0 → 11.0.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 11.0.1
+
+*  Destroyng an edition lets siblings know
+
 ## 11.0.0
 
 *  Remove fact check logic from the `Edition` model, since it only belongs in

data/app/models/workflow.rb

@@ -9,6 +9,7 @@ module Workflow
   included do
     validate :not_editing_published_item
     before_destroy :check_can_delete_and_notify
+    after_destroy :notify_siblings_of_published_edition
 
     before_save :denormalise_users
     after_create :notify_siblings_of_new_edition

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "11.0.0"
+  VERSION = "11.0.1"
 end

data/test/models/edition_test.rb

@@ -473,6 +473,34 @@ class EditionTest < ActiveSupport::TestCase
     assert_nil loaded_answer
   end
 
+  test "deleting a newer draft of a published edition removes sibling information" do
+    user1 = FactoryGirl.create(:user)
+    edition = AnswerEdition.find_or_create_from_panopticon_data(@artefact.id, user1, {})
+    edition.update_attribute(:state, "published")
+    second_edition = edition.build_clone
+    second_edition.save!
+    edition.reload
+
+    assert edition.sibling_in_progress
+
+    second_edition.destroy
+    edition.reload
+
+    assert_nil edition.sibling_in_progress
+  end
+
+  test "the latest edition should remove sibling_in_progress details if it is present" do
+    user1 = FactoryGirl.create(:user)
+    edition = AnswerEdition.find_or_create_from_panopticon_data(@artefact.id, user1, {})
+    edition.update_attribute(:state, "published")
+
+    # simulate a document having a newer edition destroyed (previous behaviour).
+    edition.sibling_in_progress = 2
+    edition.save(validate: false)
+
+    assert edition.can_create_new_edition?
+  end
+
   test "should also delete associated artefact" do
     
     FactoryGirl.create(:tag, tag_id: "test-section", title: "Test section", tag_type: "section")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 11.0.0
+  version: 11.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-19 00:00:00.000000000 Z
+date: 2014-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bson_ext
@@ -463,7 +463,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2782953638830349202
+      hash: -1368179395246728508
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -472,7 +472,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2782953638830349202
+      hash: -1368179395246728508
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23