govuk_content_item_loader 1.2.2 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 704a8afd75af58674109ebefcb22e9855c481d7b5280330e6f1d25eac2fcbec2
-  data.tar.gz: 7415244c1e4abd90dfd25e1499bb083839e1dc0bc37d6ae6c9937c9c256a9c26
+  metadata.gz: a00bbc8f14d56f67f1ef763163819d0ca8aa5cadc19657e99ba4138e30d5613c
+  data.tar.gz: 7ad600627ef7be66f62cf980d8e9417b044ee39367792d89dac743382c9724cd
 SHA512:
-  metadata.gz: 20823b0e5c2a93ede2bb195995393aa692dbb07e4b5d0cafe02b6d241ecac06c072bb8f009419dd66424b44a91237e813d6e226a282c300a46eb12fc7c52a13a
-  data.tar.gz: b9a349fb86b3232ae009d77c60672c0c8cdea9c5850f2d639e17ca09ea3d6724999314cfdbc540d933353aa4d333abc18716eb17607b1272b2f1a73a29430037
+  metadata.gz: 46c9ebf6a037ca8087c093f2f69f5399dc22e1273468ec0b70a833d58e7762e69332f42ad75e1da12082461eb0c94ced34b311da7166ddbf5dd85502ab971e07
+  data.tar.gz: fbbe5c0102e6e13d14a3a5685cee82973afc6c2e5cf31d565b9f96992a03819be1647571259e953c4e88d410dc832df8e05e79da5c32463696d82ea40df79182

data/CHANGELOG.md

@@ -1,12 +1,17 @@
 # Changelog
 
+## 2.0.0
+
+* BREAKING: replaces `stub_conditional_loader_returns_content_item` test helper with `stub_conditional_loader_returns_content_item_for_path` to match requests to a specific request path, for testing in frontend applications.
+* BREAKING: replaces `stub_conditional_loader_does_not_return_content_item` test helper with `stub_conditional_loader_does_not_return_content_item_for_path` to match requests to a specific request path, for testing in frontend applications.
+
 ## 1.2.2
 
 * Update dependencies
 
 ## 1.2.1
 
-* Stub the requests in test helpers and add Plek as dependency 
+* Stub the requests in test helpers and add Plek as dependency
 
 ## 1.2.0
 

data/govuk_content_item_loader.gemspec

@@ -30,4 +30,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rubocop-govuk", "~> 5.2"
   spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "webmock"
 end

data/lib/govuk_content_item_loader/test_helpers.rb

@@ -1,58 +1,26 @@
-require "json"
+require "gds_api/test_helpers/content_item_helpers"
+require "gds_api/test_helpers/content_store"
+require "gds_api/test_helpers/publishing_api"
 
 module GovukConditionalContentItemLoaderTestHelpers
-  CONTENT_STORE_ENDPOINT = Plek.find("content-store")
-  PUBLISHING_API_ENDPOINT = Plek.find("publishing-api")
+  include GdsApi::TestHelpers::ContentStore
+  include GdsApi::TestHelpers::PublishingApi
 
-  # Stubs the loader returns a content item
-  # The following options can be passed in:
-  #
-  #   :max_age  will set the max-age of the Cache-Control header in the response. Defaults to 900
-  #   :private  if true, the Cache-Control header will include the "private" directive. By default it
-  #             will include "public"
-  def stub_conditional_loader_returns_content_item(body, options = {})
-    body = body.is_a?(String) ? body : body.to_json
-    max_age = options.fetch(:max_age, 900)
-    visibility = options[:private] ? "private" : "public"
-
-    [CONTENT_STORE_ENDPOINT, PUBLISHING_API_ENDPOINT].each do |endpoint|
-      stub_request(:get, %r{#{Regexp.escape(endpoint)}}).to_return(
-        status: 200,
-        body: body,
-        headers: {
-          "Cache-Control" => "#{visibility}, max-age=#{max_age}",
-          "Date" => Time.now.httpdate,
-        },
-      )
-    end
-
-    loader = instance_double(GovukConditionalContentItemLoader, load: JSON.parse(body))
-
-    allow(GovukConditionalContentItemLoader).to receive(:new).with(request: anything)
-      .and_return(loader)
+  def stub_conditional_loader_returns_content_item_for_path(base_path, body = content_item_for_base_path(base_path), options = {})
+    stub_content_store_has_item(base_path, body, options)
+    stub_publishing_api_graphql_has_item(base_path, body, options)
   end
 
-  # Stubs the loader returns a error response
-  # The following options can be passed in:
-  #
-  #   :status         the HTTP status code for the error. Defaults to 404
-  #   :message        the error message. Defaults to "Not Found"
-  #   :error_details  optional additional error details to attach to the exception
-  #   :http_body      optional raw response body to attach to the exception
-  def stub_conditional_loader_does_not_return_content_item(options = {})
-    status = options.fetch(:status, 404)
-    message = options.fetch(:message, "Not Found")
-    error_details = options[:error_details]
-    http_body = options[:http_body]
-
-    error = GdsApi::HTTPErrorResponse.new(status, message, error_details, http_body)
+  def stub_conditional_loader_does_not_return_content_item_for_path(base_path, options = {})
+    stub_content_store_does_not_have_item(base_path, options)
+    stub_publishing_api_graphql_does_not_have_item(base_path)
+  end
 
-    loader = instance_double(GovukConditionalContentItemLoader)
+private
 
-    allow(GovukConditionalContentItemLoader).to receive(:new).with(request: anything)
-      .and_return(loader)
-    allow(loader).to receive(:load).and_raise(error)
+  def content_item_for_base_path(base_path)
+    include GdsApi::TestHelpers::ContentItemHelpers
 
-    error
+    super.merge("base_path" => base_path)
   end
 end

data/lib/govuk_content_item_loader/version.rb

@@ -1,3 +1,3 @@
 module GovukContentItemLoader
-  VERSION = "1.2.2".freeze
+  VERSION = "2.0.0".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_item_loader
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 2.0.0
 platform: ruby
 authors:
 - GOV.UK Dev
@@ -149,6 +149,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 email:
 - govuk-dev@digital.cabinet-office.gov.uk
 executables: []