govuk_ab_testing 1.0.1 → 1.0.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: cf8724e8049a225793408d0becd62e990dbb1ba6
4
- data.tar.gz: ac6096751d5d9ca190bea8a4afcf960f02629623
3
+ metadata.gz: 2b77eb483d96fe7cf122323876be63428b7acd7e
4
+ data.tar.gz: 3dc5d675e80993664b6b17f70b59f6758150face
5
5
  SHA512:
6
- metadata.gz: 62365454673a1f953879cd31a13d519effa971de501dc9be18de358f3cd5e372d62ebb90bf8d58d78eaa19b395f7e69d996ecc626a33272dd0e736b4442e83f5
7
- data.tar.gz: a09800cd1ee970ca90fa77ed7f4f93f53fa1b8cfa428b9492c0eb3bb2f0efdddb3ab76a4843db6cb5b0009e4d44db2a9c8e2c322e466a265fce2f70be67cbe2e
6
+ metadata.gz: d8bb081b41576da8edcfab5f9883e037b3b48046e3c78a33df4f8cbca945a3a95b270f77f75281b973c5716574bf7b9ec488c70a051d0b12cdf6349079b5c3e5
7
+ data.tar.gz: 161c6619457164b03af84126fdd8c6df48f700a82b9bbac26cfc3315f84284389f4689245f1ec20ef00392d35172c6d0b5d9264f4dfad5dd39508312e0e532df
data/CHANGELOG.md CHANGED
@@ -1,3 +1,8 @@
1
+ ## 1.0.2
2
+
3
+ * Ensure `assert_response_not_modified_for_ab_test` test helper works with all
4
+ test frameworks
5
+
1
6
  ## 1.0.1
2
7
 
3
8
  * Stop memoising meta tags so `with_variant` can be used multiple times in the
@@ -7,7 +12,7 @@
7
12
 
8
13
  * Pass in request headers instead of the actual request to RequestedVariant.
9
14
  This is a breaking change.
10
- * Slit testing framework helpers from acceptance test frameworks. This means we
15
+ * Split testing framework helpers from acceptance test frameworks. This means we
11
16
  can now use a combination of RSpec/Minitest and Capybara/ActiveSupport test
12
17
  cases.
13
18
 
@@ -56,10 +56,12 @@ module GovukAbTesting
56
56
  end
57
57
 
58
58
  def assert_response_not_modified_for_ab_test
59
- assert_nil response.headers['Vary'],
60
- "`Vary` header is being added to a page which is outside of the A/B test"
59
+ assert_nil acceptance_test_framework.vary_header(response),
60
+ "`Vary` header is being added to a page which should not be modified by the A/B test"
61
61
 
62
- assert_select "meta[name='govuk:ab-test']", false
62
+ meta_tags = acceptance_test_framework.analytics_meta_tags
63
+ assert_equal(0, meta_tags.count,
64
+ "A/B meta tag is being added to a page which should not be modified by the A/B test")
63
65
  end
64
66
  end
65
67
  end
@@ -1,3 +1,3 @@
1
1
  module GovukAbTesting
2
- VERSION = "1.0.1".freeze
2
+ VERSION = "1.0.2".freeze
3
3
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: govuk_ab_testing
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.1
4
+ version: 1.0.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - GOV.UK Dev
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2017-03-01 00:00:00.000000000 Z
11
+ date: 2017-03-03 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rake