govuk_ab_testing 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cf8724e8049a225793408d0becd62e990dbb1ba6
-  data.tar.gz: ac6096751d5d9ca190bea8a4afcf960f02629623
+  metadata.gz: 2b77eb483d96fe7cf122323876be63428b7acd7e
+  data.tar.gz: 3dc5d675e80993664b6b17f70b59f6758150face
 SHA512:
-  metadata.gz: 62365454673a1f953879cd31a13d519effa971de501dc9be18de358f3cd5e372d62ebb90bf8d58d78eaa19b395f7e69d996ecc626a33272dd0e736b4442e83f5
-  data.tar.gz: a09800cd1ee970ca90fa77ed7f4f93f53fa1b8cfa428b9492c0eb3bb2f0efdddb3ab76a4843db6cb5b0009e4d44db2a9c8e2c322e466a265fce2f70be67cbe2e
+  metadata.gz: d8bb081b41576da8edcfab5f9883e037b3b48046e3c78a33df4f8cbca945a3a95b270f77f75281b973c5716574bf7b9ec488c70a051d0b12cdf6349079b5c3e5
+  data.tar.gz: 161c6619457164b03af84126fdd8c6df48f700a82b9bbac26cfc3315f84284389f4689245f1ec20ef00392d35172c6d0b5d9264f4dfad5dd39508312e0e532df

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.0.2
+
+* Ensure `assert_response_not_modified_for_ab_test` test helper works with all
+  test frameworks
+
 ## 1.0.1
 
 * Stop memoising meta tags so `with_variant` can be used multiple times in the
@@ -7,7 +12,7 @@
 
 * Pass in request headers instead of the actual request to RequestedVariant.
   This is a breaking change.
-* Slit testing framework helpers from acceptance test frameworks. This means we
+* Split testing framework helpers from acceptance test frameworks. This means we
   can now use a combination of RSpec/Minitest and Capybara/ActiveSupport test
   cases.
 

data/lib/govuk_ab_testing/minitest_helpers.rb

@@ -56,10 +56,12 @@ module GovukAbTesting
     end
 
     def assert_response_not_modified_for_ab_test
-      assert_nil response.headers['Vary'],
-        "`Vary` header is being added to a page which is outside of the A/B test"
+      assert_nil acceptance_test_framework.vary_header(response),
+        "`Vary` header is being added to a page which should not be modified by the A/B test"
 
-      assert_select "meta[name='govuk:ab-test']", false
+      meta_tags = acceptance_test_framework.analytics_meta_tags
+      assert_equal(0, meta_tags.count,
+        "A/B meta tag is being added to a page which should not be modified by the A/B test")
     end
   end
 end

data/lib/govuk_ab_testing/version.rb

@@ -1,3 +1,3 @@
 module GovukAbTesting
-  VERSION = "1.0.1".freeze
+  VERSION = "1.0.2".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_ab_testing
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-01 00:00:00.000000000 Z
+date: 2017-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake