govuk_ab_testing 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 932ff8b3b3372bd294d76a70863720b2d83c24f7
-  data.tar.gz: bcb3ed31428a44de078d465292e15370870f0c5f
+  metadata.gz: 18474bfbb55c70f00605b094d91984ed583dc453
+  data.tar.gz: 5720d82232f259549103a9bcc764d56ed11fab79
 SHA512:
-  metadata.gz: 8b0fd195675173cc90c1ec42021749f47f0c1f7096e8c8c821939db377f634b4d6768beb6c0a0748ac8428907b045ce3cb2d6b9b47e7077e0956cf3aae84dce2
-  data.tar.gz: b4816a5cc4017ce3a5411b2433f15adee7ee952b045587f9d3b06677174d03be9e28c445d8cf2ec2af6413b3affd34994c552a5c253267e9022c24778c7bdf3b
+  metadata.gz: 4195586a3e90136a9029e4df8670f785208f049be7d80f78b815eb3158d6142db21598e8c357ac05663893305932fbe57bef22e5c8e68e0ecac8707ad985b5b0
+  data.tar.gz: b9875cb1350159153b96085a07f81c0317e132290918a4e7f32caa4736106c8a95ff9fca0b0db2bba66971c2709e25f5adc08c125b27a409f2c8144170bef071

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## 2.3.0
+
+* Fix for Rails 5.0.2 - the Active Support acceptance tests used to memoize
+  the `@request` and `@response` objects. This worked fine in Rails 4, but
+  it looks like Rails 5 now points to a different object at some point during
+  the request/response lifecycle, breaking the memoization. The fix removes
+  this memoization and directly queries the scope for each `@request` or
+  `@response`.
+
 ## 2.2.0
 
 * Remove string interpolated parameter in error message of

data/lib/govuk_ab_testing/acceptance_tests/active_support.rb

@@ -1,16 +1,23 @@
 module GovukAbTesting
   module AcceptanceTests
     class ActiveSupport
-      attr_reader :request, :request_headers, :scope
+      attr_reader :request_headers, :scope
 
       def initialize(scope)
-        @request = scope.instance_variable_get(:@request)
-        if @request.nil?
-          raise "Couldn't find '@request' defined, are you using ActiveSupport test cases?"
-        end
         @scope = scope
         @request_headers = {}
-        @response = scope.instance_variable_get(:@response)
+
+        if request.nil?
+          raise "Couldn't find '@request' defined, are you using ActiveSupport test cases?"
+        end
+      end
+
+      def request
+        @scope.instance_variable_get(:@request)
+      end
+
+      def response
+        @scope.instance_variable_get(:@response)
       end
 
       def set_header(name, value)
@@ -19,7 +26,7 @@ module GovukAbTesting
       end
 
       def vary_header
-        @response.headers['Vary']
+        response.headers['Vary']
       end
 
       def analytics_meta_tags_for_test(ab_test_name)

data/lib/govuk_ab_testing/version.rb

@@ -1,3 +1,3 @@
 module GovukAbTesting
-  VERSION = "2.2.0".freeze
+  VERSION = "2.3.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_ab_testing
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-05-10 00:00:00.000000000 Z
+date: 2017-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake