govuk_ab_testing 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d3b5ab50b3ac4b2eba97a72773a26010efd36d3
-  data.tar.gz: f9fcb6b2cd4b83fd38c7de312a79319976353eda
+  metadata.gz: 9ff58dec73e2ed3af500ce0c9f9883ce44366a08
+  data.tar.gz: b8ea71471e420af109704ff84476cc00ddcb13f3
 SHA512:
-  metadata.gz: b24413b67052c7acd6db7b656c1bec81ef03e865381f5826c490d1d2343be1fc9191c80adcaf240125ba23d61c982f827381f8f88e1086f6ee01ac91c0f29853
-  data.tar.gz: 908b7618c8ae6adaffaecb80cd9fade61b741ab9be43e2ee82f398840271a868d6383d93ee0a96ca82f9b783a201928cebd221fe5884d6c4c6c4712f41cb7be4
+  metadata.gz: 4acc9deda25396e9fe7e5d36af8b38e0aec3c35b7931d937e4b8fd75da39bfda6a110d1ebaf06de78a67c1b2225db2e06d3c49919791dac09a09b432e1cbff97
+  data.tar.gz: 72339f5bec3f32c374f0a95f0e73ea8b006e404d8c689719f203958eddd973a1a7b22ce0f27494a53a4b8e2f013991cd69118c9cfd3d2df4420c32c65c4b8fe4

data/README.md

@@ -112,8 +112,7 @@ class PartyControllerTest < ActionController::TestCase
   include GovukAbTesting::MinitestHelpers
 
   should "show the original " do
-    analytics_dimension = 123
-    setup_ab_variant("your_ab_test_name", "B", analytics_dimension)
+    setup_ab_variant("your_ab_test_name", "B") # optionally pass in a analytics dimension as the third argument
 
     get :show
 

data/lib/govuk_ab_testing/minitest_helpers.rb

@@ -13,16 +13,13 @@ module GovukAbTesting
       assert_equal ab_test.response_header, response.headers['Vary'], "You probably forgot to use `configure_response`"
 
       unless args[:assert_meta_tag] == false
-        raise "Cannot test the A/B meta tag because no expected :dimension parameter was specified by test" unless args[:dimension]
-
-        assert_meta_tag "govuk:ab-test",
-          ab_test.meta_tag_name + ':' + requested_variant.variant_name,
-          args[:dimension],
-          "You probably forgot to add the `analytics_meta_tag`"
+        content = ab_test.meta_tag_name + ':' + requested_variant.variant_name
+        message = "You probably forgot to add the `analytics_meta_tag` to the views"
+        assert_select "meta[name='govuk:ab-test'][content='#{content}']", 1, message
       end
     end
 
-    def setup_ab_variant(ab_test_name, variant, dimension)
+    def setup_ab_variant(ab_test_name, variant, dimension = 300)
       ab_test = GovukAbTesting::AbTest.new(ab_test_name, dimension: dimension)
 
       @request.headers[ab_test.request_header] = variant
@@ -34,11 +31,5 @@ module GovukAbTesting
 
       assert_select "meta[name='govuk:ab-test']", false
     end
-
-  private
-
-    def assert_meta_tag(name, content, dimension, message)
-      assert_select "meta[name='#{name}'][content='#{content}'][data-analytics-dimension='#{dimension}']", 1, message
-    end
   end
 end

data/lib/govuk_ab_testing/version.rb

@@ -1,3 +1,3 @@
 module GovukAbTesting
-  VERSION = "0.1.2".freeze
+  VERSION = "0.1.3".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_ab_testing
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - GOV.UK Dev