gouda 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a5b6d65b9cbfbe699e5bbfe1dd2854eeebc74d711d22243ec9c1c647d6986f7
-  data.tar.gz: d2642c37fe82af94a577d6b0806e9178842b8b0a53b64fe2eefeb1362f748a06
+  metadata.gz: 225a9cde8e106f517e71827c18bb5d189b6570b3b8717f91c59ecd263235773a
+  data.tar.gz: 165421a35c9f0a9b969e105b3c83867c2ca184b3d9fdc428e2c1d21121c92795
 SHA512:
-  metadata.gz: 8d276d47fd5dced75511522900f1328ee1cb7cb076f833e6dc0d8eb597cafdc1933986ebb17a2ec37390d0d3e74b2c183fdabba204cc0e41c2010ccb2adefcdb
-  data.tar.gz: 644d5eba7e6fca4fbf2f21d805d98985be8e72fcfa5e06dc8402a26fefb292c2a204134071e0e31ca345ab74863ea6191aa934479e6eb1b865a31e4bea2ff817
+  metadata.gz: dcf1832c6f23778920eccb160878aba29e6d00c141722a7398cd05b81e44a2f0668520ca5eef964217d62d1e06b87f892cb745813ae5cdbfc6a252f3e70cf3a8
+  data.tar.gz: 26732655634330f34ac7d8c4f1b32b8a6e27a450d32b824d65a9d960cf888362e460d4f4e9cf2ae57fbaf4ec3a755ad1ad02d0ce73fbaf6d7f490349e780e99c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.2.1]
+
+- Fix a potential memory leak in `in_bulk`. Thanks to Julik.
+
 ## [0.2.0]
 
 - Introduce fiber execution for workers

data/gemfiles/rails_7.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    gouda (0.2.0)
+    gouda (0.2.1)
       activejob (>= 7.2.0)
       activerecord (>= 7.2.0)
       activesupport (>= 7.2.0)

data/gemfiles/rails_8.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    gouda (0.2.0)
+    gouda (0.2.1)
       activejob (>= 7.2.0)
       activerecord (>= 7.2.0)
       activesupport (>= 7.2.0)

data/lib/gouda/bulk.rb

@@ -18,7 +18,8 @@ module Gouda
   #    end
   # @return [Object] the return value of the block
   def self.in_bulk(&blk)
-    if Thread.current[:gouda_bulk_buffer].nil?
+    outermost = Thread.current[:gouda_bulk_buffer].nil?
+    if outermost
       Thread.current[:gouda_bulk_buffer] = []
       retval = yield
       buf, Thread.current[:gouda_bulk_buffer] = Thread.current[:gouda_bulk_buffer], nil
@@ -27,6 +28,8 @@ module Gouda
     else # There already is an open bulk
       yield
     end
+  ensure
+    Thread.current[:gouda_bulk_buffer] = nil if outermost
   end
 
   # This method exists in edge Rails so probably can be replaced later:

data/lib/gouda/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gouda
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/test/gouda/concurrency_extension_test.rb

@@ -4,6 +4,7 @@ require "gouda/test_helper"
 
 class GoudaConcurrencyExtensionTest < ActiveSupport::TestCase
   include AssertHelper
+
   class TestJobWithoutConcurrency < ActiveJob::Base
     self.queue_adapter = Gouda::Adapter.new
   end
@@ -11,6 +12,7 @@ class GoudaConcurrencyExtensionTest < ActiveSupport::TestCase
   class TestJobWithPerformConcurrency < ActiveJob::Base
     self.queue_adapter = Gouda::Adapter.new
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with(perform_limit: 1)
 
     def perform(*args)
@@ -42,6 +44,7 @@ class GoudaConcurrencyExtensionTest < ActiveSupport::TestCase
   class TestJobWithCommonConcurrency < ActiveJob::Base
     self.queue_adapter = Gouda::Adapter.new
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with(total_limit: 1)
 
     def perform(*args)
@@ -79,6 +82,7 @@ class GoudaConcurrencyExtensionTest < ActiveSupport::TestCase
   class TestJobWithEnqueueConcurrency < ActiveJob::Base
     self.queue_adapter = Gouda::Adapter.new
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with(enqueue_limit: 1)
 
     def perform(*args)
@@ -105,6 +109,7 @@ class GoudaConcurrencyExtensionTest < ActiveSupport::TestCase
   class TestJobWithCustomKey < ActiveJob::Base
     self.queue_adapter = Gouda::Adapter.new
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with total_limit: 1, key: "42"
   end
 
@@ -117,6 +122,7 @@ class GoudaConcurrencyExtensionTest < ActiveSupport::TestCase
   class TestJobWithCustomKeyProc < ActiveJob::Base
     self.queue_adapter = Gouda::Adapter.new
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with total_limit: 1, key: -> { @ivar }
 
     def initialize(...)

data/test/gouda/gouda_test.rb

@@ -58,6 +58,7 @@ class GoudaTest < ActiveSupport::TestCase
 
   class JobWithEnqueueConcurrencyViaGoudaAndEnqueueLimit < GoudaTestJob
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with(enqueue_limit: 1, key: -> { self.class.to_s })
     def perform
       "perform result of #{self.class}"
@@ -66,6 +67,7 @@ class GoudaTest < ActiveSupport::TestCase
 
   class JobWithEnqueueConcurrencyViaGoudaAndTotalLimit < GoudaTestJob
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with(total_limit: 1, key: -> { self.class.to_s })
     def perform
       "perform result of #{self.class}"
@@ -84,6 +86,7 @@ class GoudaTest < ActiveSupport::TestCase
 
   class JobWithExecutionConcurrencyViaGoudaAndTotalLimit < GoudaTestJob
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with(total_limit: 1, key: -> { self.class.to_s })
     def perform
       "perform result of #{self.class}"
@@ -92,6 +95,7 @@ class GoudaTest < ActiveSupport::TestCase
 
   class JobWithExecutionConcurrencyViaGoudaAndPerformLimit < GoudaTestJob
     include Gouda::ActiveJobExtensions::Concurrency
+
     gouda_control_concurrency_with(perform_limit: 1, key: -> { self.class.to_s })
     def perform
       "perform result of #{self.class}"
@@ -384,6 +388,29 @@ class GoudaTest < ActiveSupport::TestCase
     end
   end
 
+  test "resets the bulk buffer thread local when the block raises" do
+    assert_raises(RuntimeError) do
+      Gouda.in_bulk do
+        raise "boom"
+      end
+    end
+    assert_nil Thread.current[:gouda_bulk_buffer], "The bulk buffer thread local must be reset after an exception"
+  end
+
+  test "enqueues jobs normally after a failed in_bulk block" do
+    assert_raises(RuntimeError) do
+      Gouda.in_bulk do
+        StandardJob.perform_later
+        raise "boom"
+      end
+    end
+
+    # Jobs enqueued after the failed bulk block should still be enqueued normally
+    assert_changes_by(-> { Gouda::Workload.count }, exactly: 1) do
+      StandardJob.perform_later
+    end
+  end
+
   test "sets the correct queue with perform_later" do
     assert_changes_by(-> { Gouda::Workload.count }, exactly: 1) do
       HeavyJob.perform_later

data/test/gouda/scheduler_test.rb

@@ -19,6 +19,7 @@ class GoudaSchedulerTest < ActiveSupport::TestCase
 
   class FailingJob < ActiveJob::Base
     include Gouda::ActiveJobExtensions::Concurrency
+
     self.queue_adapter = Gouda::Adapter.new
 
     class MegaError < StandardError

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gouda
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Sebastian van Hesteren
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-04 00:00:00.000000000 Z
+date: 2026-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord