gorgon 0.7.0.rc4 → 0.7.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MjNhMGExNjljNThiZWI4MjE2NzEyZDYxZWM1YTc5NjVhZTNhMjIwYw==
+    Njg4ZmM0YTg5NWRkZTk0ZWU4ZWY4OTRiNjEwYTcxMmYwNGI1MzdjZQ==
   data.tar.gz: !binary |-
-    NGE1Y2UxMmM3NzEwYjk5MWI3NmFhMDdjYmU3YmYwYjY4M2E4ZTBjNA==
+    ODAxYjJlMDgyNjFhMDM1YjI2ZTU4ZTJiNzE3OTI4MzViNThmZTM2Mw==
 SHA512:
   metadata.gz: !binary |-
-    YzczOGFhYzMzYTBkZDM1ZGY3OTg5Zjg3N2JhMmIyNzk4MjZkNDAxOTk5NTQ1
-    ZjBiNjNkYzlkNzc4OWNlNmYwZmRhMmZiNjRkYThmN2MyOGM2MTc0YTk3ODM0
-    MDNkZjU1M2Y2NGQyMTc4ZmI1ZmMzNmMwMzkyM2EyMjU3ZTdmZTY=
+    MWYxYzg1NzAwNThjOTEzZDhjODZmMWU5Y2VmNTI4ODI3NWUyZWM5M2JhNWI0
+    YzI3NzE4N2RiODY0NDM1NmIzOGRlNzY5NjY2MTFiN2ZiNGM1NWIwNDEyOGJh
+    NzZmOTE0YzQyYTY2NGJlOTk1NGZkODFjODgyNDQ5MzQ4NGQ4MzA=
   data.tar.gz: !binary |-
-    MjZkNmU3OWU0OGY3MmQwOGI5NTE0ODA1YzFlOGUyNmYzMTA2MTYxOGIxMDM4
-    ZTNlYWVmNzBhMGYwMzhmYjE0Mzk4NDVhOWNlMjJiOWMzZjE2MWI5NTczZDJj
-    OWI4NjJiOWU1ZDI5NWI2OTBkMTYwMTYyOWEzODNjNzg5MDI0MDY=
+    ZjE2ZjQyMzI5NmExYzBkYTJlZjVkMzczNGNiMzIzMTcyZjUwZWFkYzJiODAz
+    MjkyYTZkZTAwMmI4Nzc3NTJkZGQ2NjU3MGNiM2E3NzI3NDUyZmI5OWU3YTVk
+    MDdkNTA4ZDgwYTA0MDE2ZWY1OTcwMWJiY2IzNzExMGE2MmIzN2Y=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gorgon (0.7.0.rc4)
+    gorgon (0.7.0)
       amqp (~> 1.1.0)
       awesome_print
       colorize (~> 0.5.8)
@@ -21,7 +21,7 @@ GEM
     colorize (0.5.8)
     diff-lcs (1.1.3)
     eventmachine (1.0.3)
-    open4 (1.3.3)
+    open4 (1.3.0)
     rake (0.9.2.2)
     rspec (2.11.0)
       rspec-core (~> 2.11.0)

data/lib/gorgon/version.rb

@@ -1,3 +1,3 @@
 module Gorgon
-  VERSION = "0.7.0.rc4"
+  VERSION = "0.7.0"
 end

data/spec/crash_reporter_spec.rb

@@ -1,7 +1,7 @@
 require 'gorgon/crash_reporter'
 
 describe "CrashReporter" do
-  let(:exchange) { stub("GorgonBunny Exchange", :publish => nil) }
+  let(:exchange) { double("GorgonBunny Exchange", :publish => nil) }
   let(:info) { {
       :out_file => "stdout_file", :err_file => "stderr_file", :footer_text => "Text"
     } }
@@ -22,14 +22,14 @@ describe "CrashReporter" do
     end
 
     it "calls send_crash_message" do
-      container_class.stub!(:'`').and_return "stdout text", "stderr text "
+      container_class.stub(:'`').and_return "stdout text", "stderr text "
       container_class.should_receive(:send_crash_message).with(exchange, "stdout text", "stderr text Text")
       container_class.report_crash exchange, info
     end
 
     it "returns last lines of output from stderr message and footer text" do
-      container_class.stub!(:'`').and_return "stdout text", "stderr text "
-      container_class.stub!(:send_crash_message)
+      container_class.stub(:'`').and_return "stdout text", "stderr text "
+      container_class.stub(:send_crash_message)
       result = container_class.report_crash exchange, info
       result.should == "stdout text\nstderr text Text"
     end

data/spec/failures_printer_spec.rb

@@ -1,11 +1,11 @@
 require 'gorgon/failures_printer'
 
 describe FailuresPrinter do
-  let(:job_state) { stub("Job State", :add_observer => nil,
+  let(:job_state) { double("Job State", :add_observer => nil,
                          :is_job_complete? => true, :is_job_cancelled? => false,
                          :each_failed_test => nil,
                          :each_running_file => nil)}
-  let(:fd) {stub("File descriptor", :write => nil)}
+  let(:fd) {double("File descriptor", :write => nil)}
 
   subject do
     FailuresPrinter.new(job_state)
@@ -27,7 +27,7 @@ describe FailuresPrinter do
 
     context "job is not completed nor cancelled" do
       it "doesn't output anything" do
-        job_state.stub!(:is_job_complete? => false)
+        job_state.stub(:is_job_complete? => false)
         File.should_not_receive(:open)
         @printer.update({})
       end
@@ -35,7 +35,7 @@ describe FailuresPrinter do
 
     context "job is completed" do
       it "outputs failed tests return by job_state#each_failed_test" do
-        job_state.stub!(:each_failed_test).and_yield({:filename => "file1.rb"}).and_yield({:filename => "file2.rb"})
+        job_state.stub(:each_failed_test).and_yield({:filename => "file1.rb"}).and_yield({:filename => "file2.rb"})
         File.should_receive(:open).with(FailuresPrinter::OUTPUT_FILE, 'w+').and_yield fd
         fd.should_receive(:write).with(Yajl::Encoder.encode(["file1.rb", "file2.rb"]))
         @printer.update({})
@@ -44,20 +44,20 @@ describe FailuresPrinter do
 
     context "job is cancelled" do
       before do
-        job_state.stub!(:is_job_complete?).and_return(false)
-        job_state.stub!(:is_job_cancelled?).and_return(true)
+        job_state.stub(:is_job_complete?).and_return(false)
+        job_state.stub(:is_job_cancelled?).and_return(true)
       end
 
       it "outputs failed tests return by job_state#each_failed_test" do
-        job_state.stub!(:each_failed_test).and_yield({:filename => "file1.rb"}).and_yield({:filename => "file2.rb"})
+        job_state.stub(:each_failed_test).and_yield({:filename => "file1.rb"}).and_yield({:filename => "file2.rb"})
         File.should_receive(:open).with(FailuresPrinter::OUTPUT_FILE, 'w+').and_yield fd
         fd.should_receive(:write).once.with(Yajl::Encoder.encode(["file1.rb", "file2.rb"]))
         @printer.update({})
       end
 
       it "outputs still-running files returns by job_state#each_running_file" do
-        job_state.stub!(:each_running_file).and_yield("host1", "file1.rb").and_yield("host2", "file2.rb")
-        File.stub!(:open).and_yield fd
+        job_state.stub(:each_running_file).and_yield("host1", "file1.rb").and_yield("host2", "file2.rb")
+        File.stub(:open).and_yield fd
         fd.should_receive(:write).once.with(Yajl::Encoder.encode(["file1.rb", "file2.rb"]))
         @printer.update({})
       end

data/spec/gem_command_handler_spec.rb

@@ -1,17 +1,17 @@
 require 'gorgon/gem_command_handler'
 
 describe GemCommandHandler do
-  let(:exchange) { stub("GorgonBunny Exchange", :publish => nil) }
-  let(:bunny) { stub("GorgonBunny", :exchange => exchange, :stop => nil) }
+  let(:exchange) { double("GorgonBunny Exchange", :publish => nil) }
+  let(:bunny) { double("GorgonBunny", :exchange => exchange, :stop => nil) }
 
   let(:payload) {
       {:type => :update, :reply_exchange_name => "name",
                                          :body => {:gem_command => "cmd"}}
   }
-  let(:stdin) { stub("IO object", :close => nil)}
-  let(:stdout) { stub("IO object", :read => "output", :close => nil)}
-  let(:stderr) { stub("IO object", :read => "errors", :close => nil)}
-  let(:status) { stub("Process Status", :exitstatus => 0)}
+  let(:stdin) { double("IO object", :close => nil)}
+  let(:stdout) { double("IO object", :read => "output", :close => nil)}
+  let(:stderr) { double("IO object", :read => "errors", :close => nil)}
+  let(:status) { double("Process Status", :exitstatus => 0)}
 
   describe "#handle" do
     before do
@@ -76,9 +76,9 @@ describe GemCommandHandler do
   end
 
   def stub_methods
-    Open4.stub!(:popen4).and_return([1, stdin, stdout, stderr])
-    Process.stub!(:waitpid2).and_return([nil, status])
-    Yajl::Encoder.stub!(:encode).and_return :json_msg
-    @handler.stub!(:exit)
+    Open4.stub(:popen4).and_return([1, stdin, stdout, stderr])
+    Process.stub(:waitpid2).and_return([nil, status])
+    Yajl::Encoder.stub(:encode).and_return :json_msg
+    @handler.stub(:exit)
   end
 end

data/spec/gem_service_spec.rb

@@ -2,18 +2,18 @@ require 'gorgon/gem_service'
 
 describe GemService do
   let(:configuration){ {:connection => {:host => "host"}, :originator_log_file => "file.log"}}
-  let(:protocol) { stub("OriginatorProtocol", :connect => nil,
+  let(:protocol) { double("OriginatorProtocol", :connect => nil,
                         :receive_payloads => nil, :disconnect => nil,
                         :send_message_to_listeners => nil)}
-  let(:logger){ stub("Originator Logger", :log => nil, :log_message => nil)}
+  let(:logger){ double("Originator Logger", :log => nil, :log_message => nil)}
 
   before do
-    $stdout.stub!(:write)
+    $stdout.stub(:write)
     GemService.any_instance.stub(:load_configuration_from_file).and_return configuration
-    EM.stub!(:run).and_yield
-    EM.stub!(:add_periodic_timer).and_yield
-    OriginatorLogger.stub!(:new).and_return logger
-    OriginatorProtocol.stub!(:new).and_return(protocol)
+    EM.stub(:run).and_yield
+    EM.stub(:add_periodic_timer).and_yield
+    OriginatorLogger.stub(:new).and_return logger
+    OriginatorProtocol.stub(:new).and_return(protocol)
     @service = GemService.new
     @command = "install"
   end
@@ -38,7 +38,7 @@ describe GemService do
     context "when it receives an running_command message" do
       before do
         payload = {:type => "running_command", :hostname => "host"}
-        protocol.stub!(:receive_payloads).and_yield Yajl::Encoder.encode(payload)
+        protocol.stub(:receive_payloads).and_yield Yajl::Encoder.encode(payload)
       end
 
       it "writes to console" do
@@ -56,7 +56,7 @@ describe GemService do
       before do
         running_command_payload = {:type => "running_command", :hostname => "host"}
         complete_payload = {:type => "command_completed", :hostname => "host"}
-        protocol.stub!(:receive_payloads).and_yield(Yajl::Encoder.encode(running_command_payload))
+        protocol.stub(:receive_payloads).and_yield(Yajl::Encoder.encode(running_command_payload))
           .and_yield(Yajl::Encoder.encode(complete_payload))
       end
 

data/spec/gorgon_rspec_formatter_spec.rb

@@ -3,26 +3,26 @@ require 'gorgon/gorgon_rspec_formatter'
 BaseFormatter = RSpec::Core::Formatters::GorgonRspecFormatter
 
 describe RSpec::Core::Formatters::GorgonRspecFormatter do
-  let(:example) {stub("Example", :description => "description",
+  let(:example) {double("Example", :description => "description",
                       :full_description => "Full_Description",
                       :metadata => {:file_path => "path/to/file", :line_number => 2},
                       :execution_result => {:status => "passed"}, :exception => nil)}
-  let(:fail_example) {stub("Example", :description => "description",
+  let(:fail_example) {double("Example", :description => "description",
                            :full_description => "Full_Description",
                            :metadata => {:file_path => "path/to/file", :line_number => 2},
                            :execution_result => {:status => "failed"}, :exception => nil)}
 
-  let(:exception) { stub("Exception", :class => Object, :message => "some msg",
+  let(:exception) { double("Exception", :class => Object, :message => "some msg",
                          :backtrace => "backtrace")}
 
-  let(:output) { stub("StringIO", :write => nil, :close => nil) }
+  let(:output) { double("StringIO", :write => nil, :close => nil) }
 
   before do
     @formatter = BaseFormatter.new(output)
   end
 
   it "returns an array of hashes when there are failures" do
-    @formatter.stub!(:examples).and_return([example, fail_example])
+    @formatter.stub(:examples).and_return([example, fail_example])
 
     expected_result = [{:test_name => "Full_Description: line 2", :description => "description",
                          :full_description => "Full_Description", :status => "failed",
@@ -33,7 +33,7 @@ describe RSpec::Core::Formatters::GorgonRspecFormatter do
   end
 
   it "returns an empty array when all examples pass" do
-    @formatter.stub!(:examples).and_return([example, example])
+    @formatter.stub(:examples).and_return([example, example])
 
     output.should_receive(:write).with("[]")
     @formatter.stop
@@ -41,8 +41,8 @@ describe RSpec::Core::Formatters::GorgonRspecFormatter do
   end
 
   it "returns an empty array when all examples are pending" do
-    example.stub!(:execution_result).and_return(:status => "pending")
-    @formatter.stub!(:examples).and_return([example, example])
+    example.stub(:execution_result).and_return(:status => "pending")
+    @formatter.stub(:examples).and_return([example, example])
 
     output.should_receive(:write).with("[]")
     @formatter.stop
@@ -50,8 +50,8 @@ describe RSpec::Core::Formatters::GorgonRspecFormatter do
   end
 
   it "returns exception details if there is an exception" do
-    fail_example.stub!(:exception).and_return(exception)
-    @formatter.stub!(:examples).and_return([fail_example])
+    fail_example.stub(:exception).and_return(exception)
+    @formatter.stub(:examples).and_return([fail_example])
     expected_result = [{:test_name => "Full_Description: line 2", :description => "description",
                          :full_description => "Full_Description", :status => "failed",
                          :file_path => "path/to/file", :line_number => 2, :class => Object.name,

data/spec/job_state_spec.rb

@@ -6,7 +6,7 @@ describe JobState do
       :type => "pass", :failures => []}
   }
 
-  let (:host_state){ stub("Host State", :file_started => nil, :file_finished => nil)}
+  let (:host_state){ double("Host State", :file_started => nil, :file_finished => nil)}
 
   subject { JobState.new 5 }
   it { should respond_to :failed_files_count }
@@ -62,14 +62,14 @@ describe JobState do
     end
 
     it "doesn't create a new HostState object if this is not the first file started by 'hostname'" do
-      HostState.stub!(:new).and_return host_state
+      HostState.stub(:new).and_return host_state
       @job_state.file_started(payload)
       HostState.should_not_receive(:new)
       @job_state.file_started(payload)
     end
 
     it "calls #file_started on HostState object representing 'hostname'" do
-      HostState.stub!(:new).and_return host_state
+      HostState.stub(:new).and_return host_state
       host_state.should_receive(:file_started).with("worker_id", "file_name")
       @job_state.file_started({:hostname => "hostname",
                                 :worker_id => "worker_id",
@@ -85,7 +85,7 @@ describe JobState do
 
   describe "#file_finished" do
     before do
-      HostState.stub!(:new).and_return host_state
+      HostState.stub(:new).and_return host_state
       @job_state.file_started payload
     end
 
@@ -124,7 +124,7 @@ describe JobState do
     end
 
     it "tells to the proper HostState object that a file finished in that host" do
-      HostState.stub!(:new).and_return host_state
+      HostState.stub(:new).and_return host_state
       @job_state.file_started({:hostname => "hostname",
                                 :worker_id => "worker_id",
                                 :filename => "file_name"})

data/spec/listener_spec.rb

@@ -2,10 +2,10 @@ require 'gorgon/listener'
 
 describe Listener do
   let(:connection_information) { double }
-  let(:queue) { stub("GorgonBunny Queue", :bind => nil) }
-  let(:exchange) { stub("GorgonBunny Exchange", :publish => nil) }
-  let(:bunny) { stub("GorgonBunny", :start => nil, :queue => queue, :exchange => exchange) }
-  let(:logger) { stub("Logger", :info => true, :datetime_format= => "")}
+  let(:queue) { double("GorgonBunny Queue", :bind => nil) }
+  let(:exchange) { double("GorgonBunny Exchange", :publish => nil) }
+  let(:bunny) { double("GorgonBunny", :start => nil, :queue => queue, :exchange => exchange) }
+  let(:logger) { double("Logger", :info => true, :datetime_format= => "")}
 
   before do
     Logger.stub(:new).and_return(logger)
@@ -138,7 +138,7 @@ describe Listener do
         let(:ping_payload) { [nil, nil, Yajl::Encoder.encode({:type => "ping", :reply_exchange_name => "name", :body => {}}) ] }
 
         before do
-          queue.stub!(:pop => ping_payload)
+          queue.stub(:pop => ping_payload)
           listener.stub(:configuration).and_return({:worker_slots => 3})
        end
 
@@ -160,10 +160,10 @@ describe Listener do
               :body => {:command => command}}
         }
 
-        let(:gem_command_handler) { stub("GemCommandHandler", :handle => nil)  }
+        let(:gem_command_handler) { double("GemCommandHandler", :handle => nil)  }
         let(:configuration) { {:worker_slots => 3} }
         before do
-          queue.stub!(:pop => [nil, nil, Yajl::Encoder.encode(payload)])
+          queue.stub(:pop => [nil, nil, Yajl::Encoder.encode(payload)])
           listener.stub(:configuration).and_return(configuration)
         end
 
@@ -181,14 +181,14 @@ describe Listener do
           :sync_exclude => ["log"], :callbacks => {:a_callback => "path/to/callback"}
         }}
 
-      let(:syncer) { stub("SourceTreeSyncer", :sync => nil, :exclude= => nil, :success? => true,
+      let(:syncer) { double("SourceTreeSyncer", :sync => nil, :exclude= => nil, :success? => true,
                           :output => "some output", :errors => "some errors",
                           :remove_temp_dir => nil, :sys_command => "rsync ...")}
-      let(:process_status) { stub("Process Status", :exitstatus => 0)}
-      let(:callback_handler) { stub("Callback Handler", :after_sync => nil) }
-      let(:stdin) { stub("IO object", :write => nil, :close => nil)}
-      let(:stdout) { stub("IO object", :read => nil, :close => nil)}
-      let(:stderr) { stub("IO object", :read => nil, :close => nil)}
+      let(:process_status) { double("Process Status", :exitstatus => 0)}
+      let(:callback_handler) { double("Callback Handler", :after_sync => nil) }
+      let(:stdin) { double("IO object", :write => nil, :close => nil)}
+      let(:stdout) { double("IO object", :read => nil, :close => nil)}
+      let(:stderr) { double("IO object", :read => nil, :close => nil)}
 
       before do
         stub_classes
@@ -205,9 +205,9 @@ describe Listener do
 
       context "syncer#sync fails" do
         before do
-          syncer.stub!(:success?).and_return false
-          syncer.stub!(:output).and_return "some output"
-          syncer.stub!(:errors).and_return "some errors"
+          syncer.stub(:success?).and_return false
+          syncer.stub(:output).and_return "some output"
+          syncer.stub(:errors).and_return "some errors"
         end
 
         it "aborts current job" do
@@ -254,11 +254,11 @@ describe Listener do
     private
 
     def stub_classes
-      SourceTreeSyncer.stub!(:new).and_return syncer
-      CallbackHandler.stub!(:new).and_return callback_handler
-      Open4.stub!(:popen4).and_return([1, stdin, stdout, stderr])
-      Process.stub!(:waitpid2).and_return([0, process_status])
-      Socket.stub!(:gethostname).and_return("hostname")
+      SourceTreeSyncer.stub(:new).and_return syncer
+      CallbackHandler.stub(:new).and_return callback_handler
+      Open4.stub(:popen4).and_return([1, stdin, stdout, stderr])
+      Process.stub(:waitpid2).and_return([0, process_status])
+      Socket.stub(:gethostname).and_return("hostname")
     end
   end
 end

data/spec/mini_test_runner_spec.rb

@@ -7,7 +7,7 @@ describe MiniTestRunner do
 
   describe "#run_file" do
 
-    let(:runner) {stub("MiniTestUnitRunner", :run => nil, :report => ["report"])}
+    let(:runner) {double("MiniTestUnitRunner", :run => nil, :report => ["report"])}
     before do
       Object.stub(:load)
       MiniTestUnitRunner.stub(:new).and_return(runner)

data/spec/originator_protocol_spec.rb

@@ -1,17 +1,17 @@
 require 'gorgon/originator_protocol'
 
 describe OriginatorProtocol do
-  let(:connection) { stub("Connection", :disconnect => nil, :on_closed => nil)}
-  let(:queue) { stub("Queue", :bind => nil, :subscribe => nil, :name => "queue", :purge => nil,
+  let(:connection) { double("Connection", :disconnect => nil, :on_closed => nil)}
+  let(:queue) { double("Queue", :bind => nil, :subscribe => nil, :name => "queue", :purge => nil,
                      :delete => nil) }
-  let(:exchange) { stub("Exchange", :publish => nil, :name => "exchange", :delete => nil) }
-  let(:channel) { stub("Channel", :queue => queue, :direct => exchange, :fanout => exchange,
+  let(:exchange) { double("Exchange", :publish => nil, :name => "exchange", :delete => nil) }
+  let(:channel) { double("Channel", :queue => queue, :direct => exchange, :fanout => exchange,
                        :default_exchange => exchange) }
-  let(:logger){ stub("Logger", :log => nil)}
+  let(:logger){ double("Logger", :log => nil)}
 
   before do
-    AMQP.stub!(:connect).and_return connection
-    AMQP::Channel.stub!(:new).and_return channel
+    AMQP.stub(:connect).and_return connection
+    AMQP::Channel.stub(:new).and_return channel
     @originator_p = OriginatorProtocol.new logger
     @conn_information = {:host => "host"}
   end
@@ -38,13 +38,13 @@ describe OriginatorProtocol do
     end
 
     it "opens a reply and exchange queue" do
-      UUIDTools::UUID.stub!(:timestamp_create).and_return 1
+      UUIDTools::UUID.stub(:timestamp_create).and_return 1
       channel.should_receive(:queue).once.with("reply_queue_1", :auto_delete => true)
       @originator_p.connect @conn_information
     end
 
     it "opens a reply exchange and binds reply queue to it" do
-      UUIDTools::UUID.stub!(:timestamp_create).and_return 1
+      UUIDTools::UUID.stub(:timestamp_create).and_return 1
       channel.should_receive(:direct).with("reply_exchange_1", :auto_delete => true)
       queue.should_receive(:bind).with(exchange)
       @originator_p.connect @conn_information

data/spec/originator_spec.rb

@@ -1,16 +1,16 @@
 require 'gorgon/originator'
 
 describe Originator do
-  let(:protocol){ stub("Originator Protocol", :connect => nil, :publish_files => nil,
+  let(:protocol){ double("Originator Protocol", :connect => nil, :publish_files => nil,
                        :publish_job => nil, :receive_payloads => nil, :cancel_job => nil,
                        :disconnect => nil)}
 
   let(:configuration){ {:job => {}, :files => ["some/file"], :file_server => {:host => 'host-name'}}}
-  let(:job_state){ stub("JobState", :is_job_complete? => false, :file_finished => nil,
+  let(:job_state){ double("JobState", :is_job_complete? => false, :file_finished => nil,
                         :add_observer => nil)}
-  let(:progress_bar_view){ stub("Progress Bar View", :show => nil)}
-  let(:originator_logger){ stub("Originator Logger", :log => nil, :log_message => nil)}
-  let(:source_tree_syncer) { stub("Source Tree Syncer", :push => nil, :exclude= => nil, :success? => true,
+  let(:progress_bar_view){ double("Progress Bar View", :show => nil)}
+  let(:originator_logger){ double("Originator Logger", :log => nil, :log_message => nil)}
+  let(:source_tree_syncer) { double("Source Tree Syncer", :push => nil, :exclude= => nil, :success? => true,
                                   :sys_command => 'command')}
 
   before do
@@ -26,14 +26,14 @@ describe Originator do
     end
 
     it "creates a JobState instance and passes total files" do
-      @originator.stub!(:files).and_return ["a file", "other file"]
+      @originator.stub(:files).and_return ["a file", "other file"]
       JobState.should_receive(:new).with(2).and_return job_state
 
       @originator.publish
     end
 
     it "creates a ProgressBarView and show" do
-      JobState.stub!(:new).and_return job_state
+      JobState.stub(:new).and_return job_state
       ProgressBarView.should_receive(:new).with(job_state).and_return progress_bar_view
       progress_bar_view.should_receive(:show)
       @originator.publish
@@ -64,7 +64,7 @@ describe Originator do
 
     it 'tells ShutdownManager to cancel_job' do
       shutdown_manager = double('ShutdownManager')
-      JobState.stub!(:new).and_return job_state
+      JobState.stub(:new).and_return job_state
 
       ShutdownManager.should_receive(:new).
           with(hash_including(protocol: protocol, job_state: job_state)).
@@ -79,7 +79,7 @@ describe Originator do
   describe "#cleanup_if_job_complete" do
     before do
       stub_methods
-      JobState.stub!(:new).and_return job_state
+      JobState.stub(:new).and_return job_state
       @originator.publish
     end
 
@@ -89,7 +89,7 @@ describe Originator do
     end
 
     it "disconnect if job is complete" do
-      job_state.stub!(:is_job_complete?).and_return true
+      job_state.stub(:is_job_complete?).and_return true
       protocol.should_receive(:disconnect)
       @originator.cleanup_if_job_complete
     end
@@ -98,7 +98,7 @@ describe Originator do
   describe "#handle_reply" do
     before do
       stub_methods
-      JobState.stub!(:new).and_return job_state
+      JobState.stub(:new).and_return job_state
       @originator.publish
     end
 
@@ -130,14 +130,14 @@ describe Originator do
 
   describe "#job_definition" do
     it "returns a JobDefinition object" do
-      @originator.stub!(:configuration).and_return configuration
+      @originator.stub(:configuration).and_return configuration
       job_definition = JobDefinition.new
       JobDefinition.should_receive(:new).and_return job_definition
       @originator.job_definition.should equal job_definition
     end
 
     it "builds source_tree_path if it was not specified in the configuration" do
-      @originator.stub!(:configuration).and_return(configuration.merge(:file_server => {:host => 'host-name'}))
+      @originator.stub(:configuration).and_return(configuration.merge(:file_server => {:host => 'host-name'}))
       Socket.stub(:gethostname => 'my-host')
       Dir.stub(:pwd => 'dir')
 
@@ -145,7 +145,7 @@ describe Originator do
     end
 
     it "returns source_tree_path specified in configuration if it is present" do
-      @originator.stub!(:configuration).and_return({:job => {:source_tree_path => "login@host:path/to/dir"}})
+      @originator.stub(:configuration).and_return({:job => {:source_tree_path => "login@host:path/to/dir"}})
       @originator.job_definition.source_tree_path.should == "login@host:path/to/dir"
     end
   end
@@ -153,12 +153,12 @@ describe Originator do
   private
 
   def stub_methods
-    EventMachine.stub!(:run).and_yield
-    ProgressBarView.stub!(:new).and_return progress_bar_view
-    OriginatorProtocol.stub!(:new).and_return protocol
-    @originator.stub!(:configuration).and_return configuration
-    @originator.stub!(:connection_information).and_return 'host'
-    @originator.stub!(:job_definition).and_return JobDefinition.new
+    EventMachine.stub(:run).and_yield
+    ProgressBarView.stub(:new).and_return progress_bar_view
+    OriginatorProtocol.stub(:new).and_return protocol
+    @originator.stub(:configuration).and_return configuration
+    @originator.stub(:connection_information).and_return 'host'
+    @originator.stub(:job_definition).and_return JobDefinition.new
   end
 
   def start_payload

data/spec/ping_service_spec.rb

@@ -3,17 +3,17 @@ require 'gorgon/ping_service'
 describe "PingService" do
   describe "#ping_listeners" do
     let(:configuration){ {:connection => {:host => "host"}, :originator_log_file => "file.log"}}
-    let(:protocol) { stub("OriginatorProtocol", :connect => nil, :ping => nil,
+    let(:protocol) { double("OriginatorProtocol", :connect => nil, :ping => nil,
                           :receive_payloads => nil, :disconnect => nil,
                           :send_message_to_listeners => nil)}
-    let(:logger){ stub("Originator Logger", :log => nil, :log_message => nil)}
+    let(:logger){ double("Originator Logger", :log => nil, :log_message => nil)}
 
     before do
-      $stdout.stub!(:write)
+      $stdout.stub(:write)
       PingService.any_instance.stub(:load_configuration_from_file).and_return configuration
-      EventMachine.stub!(:run).and_yield
-      EM.stub!(:add_timer).and_yield
-      OriginatorLogger.stub!(:new).and_return logger
+      EventMachine.stub(:run).and_yield
+      EM.stub(:add_timer).and_yield
+      OriginatorLogger.stub(:new).and_return logger
     end
 
     it "connnects and calls OriginatorProtocol#send_message_to_listeners" do
@@ -25,7 +25,7 @@ describe "PingService" do
 
     context "after sending ping messages" do
       before do
-        OriginatorProtocol.stub!(:new).and_return(protocol)
+        OriginatorProtocol.stub(:new).and_return(protocol)
         @service = PingService.new
       end
 

data/spec/pipe_forker_spec.rb

@@ -1,8 +1,8 @@
 require 'gorgon/pipe_forker'
 
 describe PipeForker do
-  let(:io_pipe) { stub("IO object", :close => nil)}
-  let(:pipe) {stub("Pipe", :write => io_pipe)}
+  let(:io_pipe) { double("IO object", :close => nil)}
+  let(:pipe) {double("Pipe", :write => io_pipe)}
 
   let(:container_class) do
     Class.new do
@@ -11,10 +11,10 @@ describe PipeForker do
   end
 
   before do
-    IO.stub!(:pipe).and_return([io_pipe, io_pipe])
-    STDIN.stub!(:reopen)
-    container_class.stub!(:fork).and_yield.and_return(1)
-    container_class.stub!(:exit)
+    IO.stub(:pipe).and_return([io_pipe, io_pipe])
+    STDIN.stub(:reopen)
+    container_class.stub(:fork).and_yield.and_return(1)
+    container_class.stub(:exit)
   end
 
   describe ".pipe_fork" do

data/spec/progress_bar_view_spec.rb

@@ -28,7 +28,7 @@ describe ProgressBarView do
   end
 
   describe "#update" do
-    let(:progress_bar) { stub("Progress Bar", :title= => nil, :progress= => nil, :format => nil,
+    let(:progress_bar) { double("Progress Bar", :title= => nil, :progress= => nil, :format => nil,
                               :finished? => false)}
     let(:payload) {
       { :filename => "path/file.rb",
@@ -37,11 +37,11 @@ describe ProgressBarView do
     }
 
     before do
-      ProgressBar.stub!(:create).and_return progress_bar
+      ProgressBar.stub(:create).and_return progress_bar
       @job_state = JobState.new 2
-      @job_state.stub!(:state).and_return :running
+      @job_state.stub(:state).and_return :running
       @progress_bar_view = ProgressBarView.new @job_state
-      $stdout.stub!(:write)
+      $stdout.stub(:write)
       @progress_bar_view.show
     end
 
@@ -74,8 +74,8 @@ describe ProgressBarView do
 
     it "prints failures and finish progress_bar when job is done" do
       @progress_bar_view.update
-      @job_state.stub!(:each_failed_test).and_yield(payload)
-      @job_state.stub!(:is_job_complete?).and_return :true
+      @job_state.stub(:each_failed_test).and_yield(payload)
+      @job_state.stub(:is_job_complete?).and_return :true
       $stdout.should_receive(:write).with(/Failure messages/)
       @progress_bar_view.update
     end
@@ -83,11 +83,11 @@ describe ProgressBarView do
     context "when job is cancelled" do
       before do
         @progress_bar_view.update
-        @job_state.stub!(:is_job_cancelled?).and_return :true
+        @job_state.stub(:is_job_cancelled?).and_return :true
       end
 
       it "prints failures and finish progress_bar when job is cancelled" do
-        @job_state.stub!(:each_failed_test).and_yield(payload)
+        @job_state.stub(:each_failed_test).and_yield(payload)
         $stdout.should_receive(:write).with(/Failure messages/)
         @progress_bar_view.update
       end
@@ -103,7 +103,7 @@ describe ProgressBarView do
       let(:crash_message) {{:type => "crash", :hostname => "host",
           :stdout => "some output", :stderr => "some errors"}}
       it "prints info about crash in standard error" do
-        $stderr.stub!(:write)
+        $stderr.stub(:write)
         $stderr.should_receive(:write).with(/crash.*host/i)
         $stderr.should_receive(:write).with(/some output/i)
         $stderr.should_receive(:write).with(/some errors/i)

data/spec/rspec_runner_spec.rb

@@ -11,8 +11,7 @@ describe RspecRunner do
 
     before do
       RSpec::Core::Runner.stub(:run)
-      RSpec.stub(configuration: configuration,
-                 instance_variable_set: nil)
+      RspecRunner.stub(:keep_config_modules).and_yield
     end
 
     it "uses Rspec runner to run filename and uses the correct options" do
@@ -30,19 +29,11 @@ describe RspecRunner do
     end
 
     it "parses the output of the Runner and returns it" do
-      str_io = stub("StringIO", :rewind => nil, :read => :content)
-      StringIO.stub!(:new).and_return(str_io)
+      str_io = double("StringIO", :rewind => nil, :read => :content)
+      StringIO.stub(:new).and_return(str_io)
       Yajl::Parser.any_instance.should_receive(:parse).with(:content).and_return :result
       RspecRunner.run_file("file").should == :result
     end
-
-    # since configuration is reset on each run
-    # https://github.com/rspec/rspec-core/issues/621
-    it 'restore initial rspec configuration' do
-      RSpec.should_receive(:instance_variable_set).
-          with(:@configuration, configuration)
-      RspecRunner.run_file "file"
-    end
   end
 
   describe "#runner" do

data/spec/shutdown_manager_spec.rb

@@ -1,9 +1,9 @@
 require 'gorgon/shutdown_manager'
 
 describe ShutdownManager do
-  let(:protocol){ stub("Originator Protocol", :cancel_job => nil, :disconnect => nil)}
+  let(:protocol){ double("Originator Protocol", :cancel_job => nil, :disconnect => nil)}
 
-  let(:job_state){ stub("JobState", cancel: nil)}
+  let(:job_state){ double("JobState", cancel: nil)}
 
   describe '#cancel_job' do
     it "call JobState#cancel" do

data/spec/source_tree_syncer_spec.rb

@@ -10,10 +10,10 @@ describe SourceTreeSyncer.new("") do
   it { should respond_to :output }
   it { should respond_to :errors }
 
-  let(:stdin) { stub("IO object", :close => nil)}
-  let(:stdout) { stub("IO object", :read => nil, :close => nil)}
-  let(:stderr) { stub("IO object", :read => nil, :close => nil)}
-  let(:status) { stub("Process Status", :exitstatus => 0)}
+  let(:stdin) { double("IO object", :close => nil)}
+  let(:stdout) { double("IO object", :read => nil, :close => nil)}
+  let(:stderr) { double("IO object", :read => nil, :close => nil)}
+  let(:status) { double("Process Status", :exitstatus => 0)}
 
   before do
     @syncer = SourceTreeSyncer.new "path/to/source"
@@ -112,11 +112,11 @@ describe SourceTreeSyncer.new("") do
   private
 
   def stub_utilities_methods
-    Dir.stub!(:mktmpdir).and_return("tmp/dir")
-    Dir.stub!(:chdir)
-    Open4.stub!(:popen4).and_return([1, stdin, stdout, stderr])
-    Process.stub!(:waitpid2).and_return([nil, status])
-    FileUtils.stub!(:remove_entry_secure)
-    @syncer.stub!(:system)
+    Dir.stub(:mktmpdir).and_return("tmp/dir")
+    Dir.stub(:chdir)
+    Open4.stub(:popen4).and_return([1, stdin, stdout, stderr])
+    Process.stub(:waitpid2).and_return([nil, status])
+    FileUtils.stub(:remove_entry_secure)
+    @syncer.stub(:system)
   end
 end

data/spec/worker_manager_spec.rb

@@ -1,20 +1,20 @@
 require 'gorgon/worker_manager'
 
 describe WorkerManager do
-  let(:exchange) { stub("GorgonBunny Exchange", :publish => nil) }
-  let(:queue) { stub("Queue", :bind => nil, :subscribe => nil, :delete => nil,
+  let(:exchange) { double("GorgonBunny Exchange", :publish => nil) }
+  let(:queue) { double("Queue", :bind => nil, :subscribe => nil, :delete => nil,
                      :pop => {:payload => :queue_empty}) }
-  let(:bunny) { stub("GorgonBunny", :start => nil, :exchange => exchange,
+  let(:bunny) { double("GorgonBunny", :start => nil, :exchange => exchange,
                      :queue => queue, :stop => nil) }
   before do
-    STDIN.stub!(:read).and_return "{}"
-    STDOUT.stub!(:reopen)
-    STDERR.stub!(:reopen)
-    STDOUT.stub!(:sync)
-    STDERR.stub!(:sync)
-    GorgonBunny.stub!(:new).and_return(bunny)
-    Configuration.stub!(:load_configuration_from_file).and_return({})
-    EventMachine.stub!(:run).and_yield
+    STDIN.stub(:read).and_return "{}"
+    STDOUT.stub(:reopen)
+    STDERR.stub(:reopen)
+    STDOUT.stub(:sync)
+    STDERR.stub(:sync)
+    GorgonBunny.stub(:new).and_return(bunny)
+    Configuration.stub(:load_configuration_from_file).and_return({})
+    EventMachine.stub(:run).and_yield
   end
 
   describe ".build" do

data/spec/worker_spec.rb

@@ -16,8 +16,8 @@ describe Worker do
   let(:file_queue) { double("Queue") }
   let(:reply_exchange) { double("Exchange", :publish => nil) }
   let(:fake_amqp) { fake_amqp = FakeAmqp.new file_queue, reply_exchange }
-  let(:callback_handler) { stub("Callback Handler", :before_start => nil, :after_complete => nil) }
-  let(:job_definition) {stub("JobDefinition", :callbacks => ["/path/to/callback"],
+  let(:callback_handler) { double("Callback Handler", :before_start => nil, :after_complete => nil) }
+  let(:job_definition) {double("JobDefinition", :callbacks => ["/path/to/callback"],
                              :file_queue_name => "queue",
                              :reply_exchange_name => "exchange")}
 
@@ -36,9 +36,9 @@ describe Worker do
     let(:config) { {:connection => "", :log_file => "path/to/log_file"} }
     before do
       stub_streams
-      AmqpService.stub!(:new).and_return fake_amqp
-      CallbackHandler.stub!(:new).and_return callback_handler
-      Worker.stub!(:new)
+      AmqpService.stub(:new).and_return fake_amqp
+      CallbackHandler.stub(:new).and_return callback_handler
+      Worker.stub(:new)
     end
 
     it "redirects output to a file since writing to a pipe may block when pipe is full" do
@@ -70,7 +70,7 @@ few lines of output and send it to originator. Order matters" do
     end
 
     it "creates a new worker" do
-      JobDefinition.stub!(:new).and_return job_definition
+      JobDefinition.stub(:new).and_return job_definition
       Worker.should_receive(:new).with(params)
       Worker.build 1, config
     end
@@ -82,7 +82,7 @@ few lines of output and send it to originator. Order matters" do
       stub_const("MiniTest", :test)
       Worker.any_instance.stub(:initialize_logger)
       @worker = Worker.new params
-      @worker.stub!(:require_relative)
+      @worker.stub(:require_relative)
     end
 
     it 'should do nothing if the file queue is empty' do
@@ -100,7 +100,7 @@ few lines of output and send it to originator. Order matters" do
       end
       reply_exchange.should_receive(:publish).with(any_args())
 
-      TestRunner.stub!(:run_file).and_return({:type => :pass, :time => 0})
+      TestRunner.stub(:run_file).and_return({:type => :pass, :time => 0})
 
       @worker.work
     end
@@ -115,13 +115,13 @@ few lines of output and send it to originator. Order matters" do
         msg[:filename].should == 'testfile1'
       end
 
-      TestRunner.stub!(:run_file).and_return({:type => :pass, :time => 0})
+      TestRunner.stub(:run_file).and_return({:type => :pass, :time => 0})
 
       @worker.work
     end
 
     it "should send finish message when test run has failures" do
-      failures = stub
+      failures = double
 
       file_queue.should_receive(:pop).and_return("testfile1", nil)
 
@@ -133,7 +133,7 @@ few lines of output and send it to originator. Order matters" do
         msg[:failures].should == failures
       end
 
-      TestRunner.stub!(:run_file).and_return({:type => :fail, :time => 0, :failures => failures})
+      TestRunner.stub(:run_file).and_return({:type => :fail, :time => 0, :failures => failures})
 
       @worker.work
     end
@@ -165,8 +165,8 @@ few lines of output and send it to originator. Order matters" do
 
         # ruby 1.9 defines MiniTest by default, so let's remove it for these test cases
         Object.send(:remove_const, :MiniTest)
-        file_queue.stub!(:pop).and_return("file_test.rb", nil)
-        File.stub!(:read).and_return("")
+        file_queue.stub(:pop).and_return("file_test.rb", nil)
+        File.stub(:read).and_return("")
       end
 
       it "runs file using TestUnitRunner when file doesn't end in _spec and Test is defined" do
@@ -179,7 +179,7 @@ few lines of output and send it to originator. Order matters" do
       end
 
       it "runs file using RspecRunner when file finishes in _spec.rb and Rspec is defined" do
-        file_queue.stub!(:pop).and_return("file_spec.rb", nil)
+        file_queue.stub(:pop).and_return("file_spec.rb", nil)
 
         @worker.should_receive(:require_relative).with "rspec_runner"
         TestRunner.should_receive(:run_file).with("file_spec.rb", RspecRunner).and_return({})
@@ -197,7 +197,7 @@ few lines of output and send it to originator. Order matters" do
 
       it "runs file using TestUnitRunner when file doesn't end in _spec.rb, MiniTest is defined but project is using test-unit gem" do
         MiniTest = Temp
-        File.stub!(:read).and_return("test-unit")
+        File.stub(:read).and_return("test-unit")
         stub_const("Test", :test_unit)
 
         @worker.should_receive(:require_relative).with "test_unit_runner"
@@ -208,7 +208,7 @@ few lines of output and send it to originator. Order matters" do
 
       it "uses UnknownRunner if the framework is unknown" do
         stub_const("UnknownRunner", :unknown_runner)
-        file_queue.stub!(:pop).and_return("file.rb", nil)
+        file_queue.stub(:pop).and_return("file.rb", nil)
 
         @worker.should_receive(:require_relative).with "unknown_runner"
         TestRunner.should_receive(:run_file).with("file.rb", UnknownRunner).and_return({})
@@ -226,10 +226,10 @@ few lines of output and send it to originator. Order matters" do
   private
 
   def stub_streams
-    STDIN.stub!(:read).and_return "{}"
-    STDOUT.stub!(:reopen)
-    STDERR.stub!(:reopen)
-    STDOUT.stub!(:sync)
-    STDERR.stub!(:sync)
+    STDIN.stub(:read).and_return "{}"
+    STDOUT.stub(:reopen)
+    STDERR.stub(:reopen)
+    STDOUT.stub(:sync)
+    STDERR.stub(:sync)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gorgon
 version: !ruby/object:Gem::Version
-  version: 0.7.0.rc4
+  version: 0.7.0
 platform: ruby
 authors:
 - Justin Fitzsimmons
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-03 00:00:00.000000000 Z
+date: 2014-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -360,9 +360,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>'
+  - - ! '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: gorgon
 rubygems_version: 2.1.11