googlebooks 0.0.6 → 0.0.7

data/README.md

@@ -13,7 +13,7 @@ Using GoogleBooks is simple. There's just one class, `GoogleBooks`, and one meth
     require 'googlebooks' # unless you're using Bundler
     
     books = GoogleBooks.search('The Great Gatsby')
-    first_book = book.first
+    first_book = books.first
     
     first_book.author #=> 'F. Scott Fitzgerald'
     first_book.isbn #=> '9781443411080'

data/lib/book/item.rb

@@ -1,14 +1,14 @@
 module GoogleBooks
 
   class Item
-    attr_reader :kind, :id, :title, :authors, :publisher, :published_date, :description, :isbn, :isbn_10, :isbn_13, :page_count, :print_type, :categories, :average_rating, :ratings_count, :language, :preview_link, :info_link, :sale_info
+    attr_reader :kind, :id, :title, :authors, :publisher, :published_date, :description, :isbn, :isbn_10, :isbn_13, :other_identifier, :page_count, :print_type, :categories, :average_rating, :ratings_count, :language, :preview_link, :info_link, :sale_info
 
     def initialize(item)
       @item = item
       @volume_info = @item['volumeInfo']
       retrieve_attribute
     end
-    
+
     # Enables image_link attribute to be customized via passing
     # optional zoom and edge arguments as a hash
     def image_link(opts = {})
@@ -18,7 +18,7 @@ module GoogleBooks
     end
 
   private
-  	
+
   	def retrieve_attribute
     	@kind = @item['kind']
     	@id = @item['id']
@@ -27,9 +27,9 @@ module GoogleBooks
     	@publisher = @volume_info['publisher']
     	@published_date = @volume_info['publishedDate']
     	@description = @volume_info['description']
-    	@isbn = @volume_info['industryIdentifiers'][1]['identifier'] rescue nil
-    	@isbn_10 = @volume_info['industryIdentifiers'][0]['identifier'] rescue nil
-    	@isbn_13 = @isbn
+
+      retrieve_industry_identifiers
+
     	@page_count = @volume_info['pageCount']
     	@print_type = @volume_info['printType']
     	@categories = [@volume_info['categories']].flatten.join(', ')
@@ -40,11 +40,30 @@ module GoogleBooks
 			@info_link = @volume_info['infoLink']
       @sale_info = @item['saleInfo']
    	end
-   	
+
    	def build_title
    		title = [@volume_info['title']].flatten.join(': ')
 			@volume_info['subtitle'].nil? ? title : title + ": " + @volume_info['subtitle']
 		end
+
+    def retrieve_industry_identifiers
+
+      return unless @volume_info['industryIdentifiers']
+
+      @volume_info['industryIdentifiers'].each do |identifier_hash|
+        identifier = identifier_hash["identifier"]
+
+        case identifier_hash['type']
+        when "ISBN_13"
+          @isbn = @isbn_13 = identifier
+        when "ISBN_10"
+          @isbn_10 = identifier
+        when "OTHER"
+          @other_identifier = identifier
+        end
+      end
+
+    end
   end
 
 end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module GoogleBooks
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/spec/googlebooks/book/item_spec.rb

@@ -3,32 +3,32 @@ require 'spec_helper'
 module GoogleBooks
   class Item
     describe Item do
-      
+
       example = GoogleBooks.search('isbn:9780062132345').first
-      
+
       it "should append a subtitle to the title if it exists" do
         example.title.should eq "Freakonomics: A Rogue Economist Explores the Hidden Side of Everything"
       end
-      
+
       it "should return a string authors delineated by a comma" do
         example.authors.should eq "Steven D. Levitt, Stephen J. Dubner"
       end
-      
+
       it "should have an isbn that is 13 digits" do
         example.isbn.should_not eq nil
         example.isbn.should eq '9780062132345'
         example.isbn.to_s.length.should eq 13
       end
-      
+
       it "should convert to a 10 digit isbn" do
         example.isbn_10.should eq '0062132342'
       end
-      
+
       it "should make a 13 digit isbn duplicated from the default isbn" do
         example.isbn_13.should eq '9780062132345'
         example.isbn_13.should eq example.isbn
       end
-      
+
       describe "image_link" do
         it "should have all zoom varieties and show 1 as a default" do
           example.image_link.should include "zoom=1"
@@ -39,13 +39,34 @@ module GoogleBooks
           example.image_link(:zoom => 6).should include "zoom=6"
           example.image_link(:zoom => 7).should include "zoom=7"
         end
-        
+
         it "should default to 'edge=none' and curl when dictated" do
           example.image_link.should include "edge=none"
           example.image_link(:curl => true).should include "edge=curl"
         end
+
+        context "when google_book_item has no isbn_10 but one OTHER industry identifiers" do
+
+          let(:google_book_item) {
+            {
+              "volumeInfo" => {
+                "industryIdentifiers" => [
+                  {
+                    "type" => "OTHER",
+                    "identifier" => "GENT:900000054512"
+                  }
+                ]
+              }
+            }
+          }
+          let(:item) { Item.new google_book_item }
+          subject { item }
+
+          its(:isbn_10) { should be_nil }
+          its(:other_identifier) { should == "GENT:900000054512" }
+        end
       end
-      
+
     end
   end
 end

metadata

@@ -1,59 +1,60 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: googlebooks
-version: !ruby/object:Gem::Version
-  version: 0.0.6
+version: !ruby/object:Gem::Version 
   prerelease: 
+  version: 0.0.7
 platform: ruby
-authors:
+authors: 
 - Zean Tsoi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-20 00:00:00.000000000Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2013-08-19 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: httparty
-  requirement: &83731200 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :runtime
-  prerelease: false
-  version_requirements: *83731200
-- !ruby/object:Gem::Dependency
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
   name: rspec
-  requirement: &83730990 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
-  prerelease: false
-  version_requirements: *83730990
-- !ruby/object:Gem::Dependency
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
   name: webmock
-  requirement: &83730780 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
-  prerelease: false
-  version_requirements: *83730780
-description: GoogleBooks is a lightweight Ruby wrapper that queries the Google API
-  to search for publications in the Google Books repository. It is inspired by the
-  google-book gem which relies on the deprecated Google GData Books API, but is updated
-  to hook into the current Google API.
-email:
+  version_requirements: *id003
+description: GoogleBooks is a lightweight Ruby wrapper that queries the Google API to search for publications in the Google Books repository. It is inspired by the google-book gem which relies on the deprecated Google GData Books API, but is updated to hook into the current Google API.
+email: 
 - zean.tsoi@gmail.com
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - Gemfile
 - LICENSE
@@ -70,27 +71,33 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/zeantsoi/googlebooks
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
 requirements: []
+
 rubyforge_project: googlebooks
-rubygems_version: 1.8.17
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
-summary: GoogleBooks is a lightweight Ruby wrapper that queries the Google API to
-  search for publications in the Google Books repository.
-test_files: []
+summary: GoogleBooks is a lightweight Ruby wrapper that queries the Google API to search for publications in the Google Books repository.
+test_files: 
+- spec/googlebooks/book/item_spec.rb
+- spec/googlebooks/book/response_spec.rb
+- spec/googlebooks/googlebooks_spec.rb
+- spec/spec_helper.rb