google_maps_geocoder 0.4.0.pre1 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 843c384bc9a07abcd15c8d310bced7b1fc80c979
-  data.tar.gz: 3336c894ba548664bcfb7f5b2ef91aed785fff21
+SHA256:
+  metadata.gz: f46234243841130a16f88cfaa7e5e1f3cfa0a3b077872340a8f962247631550b
+  data.tar.gz: '08cc73decc514ca46cb109b91c5a530a6add7d5baeae8fb0a982cccc619f4dff'
 SHA512:
-  metadata.gz: fe1386c06d1bfedea6c5be18de70bd95455cda8778615f918d21bc7991ec197c5aee9bd8525bea23b520b8c00cd734c9a42aad68d5331277623eedb25569928f
-  data.tar.gz: 105330f683835366620945bc14dd2b2118f9f3bc07a1d97f8445f5660152a919ec565c23196c1bf842b1c89ceb6f53e65f55af8f207780c7bcf7b8cdd1963fbd
+  metadata.gz: f1f39673ac4fb7cf61a6a3168a74cd5953040fdbd7334c65ba7891195e35f16134613d2caf20ccc6a9faee677f339648c3cec0c987f339b8f872f92e2668d5d1
+  data.tar.gz: df17491635d7a798f19ba4df1c338bc057506ed54c743f1e417936272dc313389e37d7a3297fa450716a81498bee1f943db7e67f659b245e42123961e36e504a

data/.github/CONTRIBUTING.md

@@ -0,0 +1,22 @@
+# How to contribute
+
+## **Did you find a bug?**
+
+1. **Ensure the bug was not already reported** by searching on GitHub under [Issues](https://github.com/ivanoblomov/google_maps_geocoder/issues).
+
+2. If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/ivanoblomov/google_maps_geocoder/issues/new). Be sure to include:
+    1. a **title and clear description**
+    2. as much **relevant information** as possible
+    3. a **code sample** or an **executable test case** demonstrating the expected behavior that is not occurring.
+
+## **Did you write a patch that fixes a bug or adds a new feature?**
+
+1. **Add specs** that either reproduces the bug or covers the new feature. In the former's case, *make sure it fails without the fix!*
+
+2. **Confirm your last build passes** on [Travis CI](https://travis-ci.org/ivanoblomov/google_maps_geocoder/branches).
+
+3. **Update the inline documentation.** Format it with [YARD](http://www.rubydoc.info/gems/yard/file/docs/GettingStarted.md). For example, see [`GoogleMapsGeocoder.new`](https://github.com/ivanoblomov/google_maps_geocoder/blob/github-templates/lib/google_maps_geocoder/google_maps_geocoder.rb#L43-L50).
+
+4. [Open a pull request](https://github.com/ivanoblomov/google_maps_geocoder/compare) with the patch or feature. Follow the template's directions.
+
+## Thanks for contributing!

data/.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,17 @@
+# Description
+
+Provide as much background as you need to get the implementer up to speed on the problem to be solved. This can also include screenshots and links to other issues or pull requests.
+
+# Steps to Reproduce
+
+Don't forget to point out the difference between what *should* happen and what *does* happen. Here's an example:
+
+1. Try geocoding "1600 Pennsylvania Ave":
+    ```ruby
+    white_house = GoogleMapsGeocoder.new('1600 Pennsylvania Ave')
+    ```
+2. The formatted address doesn't match the White House:
+   ```ruby
+   white_house.formatted_address
+   => "1600 Pennsylvania Ave, Charleston, WV 25302, USA"
+   ```

data/.github/ISSUE_TEMPLATE/bug-report.md

@@ -0,0 +1,23 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+# Description
+
+Provide as much background as you need to get the implementer up to speed on the problem to be solved. This can also include screenshots and links to other issues or pull requests.
+
+# Steps to Reproduce
+
+Don't forget to point out the difference between what *should* happen and what *does* happen. Here's an example:
+
+1. Try geocoding "1600 Pennsylvania Ave":
+    ```ruby
+    white_house = GoogleMapsGeocoder.new('1600 Pennsylvania Ave')
+    ```
+2. The formatted address doesn't match the White House:
+   ```ruby
+   white_house.formatted_address
+   => "1600 Pennsylvania Ave, Charleston, WV 25302, USA"
+   ```

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,16 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+---
+
+# Goal
+Explain this issue's purpose. Focus on the problem that needs to be solved and *not* a particular solution. For example: "Make it easier for users to reset their passwords."
+
+# Description
+1. Provide as much background as you need to familiarize the implementer with the problem to be solved.
+2. Include:
+    * screenshots
+    * links to other issues or pull requests
+
+# Success Criteria
+How would a stakeholder test whether the feature was completed successfully?

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,9 @@
+Closes: #
+
+# Goal
+What problem does this pull request solve? This should be close to the goal of the issue this pull request addresses.
+
+# Approach
+1. Describe the approach you chose to solve the above problem.
+2. This will help code reviewers get oriented quickly.
+3. It will also document for future maintainers exactly what changed (and why) when this PR was merged.

data/.travis.yml

@@ -1,6 +1,10 @@
-sudo: false
 rvm:
-  - 2.0.0
+  - 2.2.10
+  - 2.3.8
+  - 2.4.10
+  - 2.5.8
+  - 2.6.6
+  - 2.7.1
 script:
   - bundle exec rake
   - bundle exec rubocop

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2011 Roderick Monje
+Copyright (c) 2011-2017 Roderick Monje
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the
@@ -17,4 +17,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -1,31 +1,38 @@
 # GoogleMapsGeocoder
 
-[![Gem Version](https://badge.fury.io/rb/google_maps_geocoder.svg)](http://badge.fury.io/rb/google_maps_geocoder)
+[![Build Status](https://secure.travis-ci.org/ivanoblomov/google_maps_geocoder.svg)](http://travis-ci.org/ivanoblomov/google_maps_geocoder)
 [![Code Climate](https://codeclimate.com/github/ivanoblomov/google_maps_geocoder.png)](https://codeclimate.com/github/ivanoblomov/google_maps_geocoder)
-[![Coverage Status](https://coveralls.io/repos/ivanoblomov/google_maps_geocoder/badge.svg?branch=master&service=github)](https://coveralls.io/github/ivanoblomov/google_maps_geocoder?branch=master)
-[![Build Status](https://secure.travis-ci.org/ivanoblomov/google_maps_geocoder.png)](http://travis-ci.org/ivanoblomov/google_maps_geocoder)
-[![Dependency Status](https://gemnasium.com/ivanoblomov/google_maps_geocoder.png)](https://gemnasium.com/ivanoblomov/google_maps_geocoder)
+[![Coverage Status](https://coveralls.io/repos/github/ivanoblomov/google_maps_geocoder/badge.svg?branch=master)](https://coveralls.io/github/ivanoblomov/google_maps_geocoder?branch=master)
+[![Inline docs](http://inch-ci.org/github/Ivanoblomov/google_maps_geocoder.svg?branch=master)](http://inch-ci.org/github/Ivanoblomov/google_maps_geocoder)
+[![Gem Version](https://badge.fury.io/rb/google_maps_geocoder.svg)](http://badge.fury.io/rb/google_maps_geocoder)
+[![security](https://hakiri.io/github/ivanoblomov/google_maps_geocoder/master.svg)](https://hakiri.io/github/ivanoblomov/google_maps_geocoder/master)
 
-A simple PORO wrapper for geocoding with Google Maps.
+A simple Plain Old Ruby Object wrapper for geocoding with Google Maps.
 
 ## Installation
 
-Add GoogleMapsGeocoder to your Gemfile and run `bundle`:
+1. Set your Google Maps API key, which Google now requires, as an environment variable:
 
-```ruby
-  gem 'google_maps_geocoder'
-```
+    ```bash
+    export GOOGLE_MAPS_API_KEY=[your key]
+    ```
 
-Or try it out in `irb` with:
+2. Add `GoogleMapsGeocoder` to your Gemfile and run `bundle`:
 
-```ruby
-  require './lib/google_maps_geocoder/google_maps_geocoder'
-```
+    ```ruby
+    gem 'google_maps_geocoder'
+    ```
+
+    Or try it out in `irb` with:
+
+    ```ruby
+    require './lib/google_maps_geocoder/google_maps_geocoder'
+    ```
 
 ## Ready to Go in One Step
 
 ```ruby
-chez_barack = GoogleMapsGeocoder.new '1600 Pennsylvania Washington'
+chez_barack = GoogleMapsGeocoder.new '1600 Pennsylvania DC'
 ```
 
 ## Usage
@@ -62,38 +69,33 @@ chez_barack.state_short_name
 
 The complete, hopefully self-explanatory, API is:
 
-* city
-* country_long_name
-* country_short_name
-* county
-* exact_match?
-* formatted_address
-* formatted_street_address
-* lat
-* lng
-* partial_match?
-* postal_code
-* state_long_name
-* state_short_name
-
-## Google Maps API Key (Optional)
-
-To have GoogleMapsGeocoder use your Google Maps API key, set it as an environment variable:
-
-```bash
-export GOOGLE_MAPS_API_KEY=[your key]
-```
-
-## Contributing to google_maps_geocoder
-
-* Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet
-* Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it
-* Fork the project
-* Start a feature/bugfix branch
-* Commit and push until you are happy with your contribution
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+* `GoogleMapsGeocoder#city`
+* `GoogleMapsGeocoder#country_long_name`
+* `GoogleMapsGeocoder#country_short_name`
+* `GoogleMapsGeocoder#county`
+* `GoogleMapsGeocoder#exact_match?`
+* `GoogleMapsGeocoder#formatted_address`
+* `GoogleMapsGeocoder#formatted_street_address`
+* `GoogleMapsGeocoder#lat`
+* `GoogleMapsGeocoder#lng`
+* `GoogleMapsGeocoder#partial_match?`
+* `GoogleMapsGeocoder#postal_code`
+* `GoogleMapsGeocoder#state_long_name`
+* `GoogleMapsGeocoder#state_short_name`
+
+For compatibility with [Geocoder](https://github.com/alexreisner/geocoder), the following aliases are also available:
+
+* `GoogleMapsGeocoder#address`
+* `GoogleMapsGeocoder#coordinates`
+* `GoogleMapsGeocoder#country`
+* `GoogleMapsGeocoder#country_code`
+* `GoogleMapsGeocoder#latitude`
+* `GoogleMapsGeocoder#longitude`
+* `GoogleMapsGeocoder#state`
+* `GoogleMapsGeocoder#state_code`
+
+## [Contributing to GoogleMapsGeocoder](https://github.com/ivanoblomov/google_maps_geocoder/blob/master/.github/CONTRIBUTING.md)
 
 ## Copyright
 
-Copyright (c) 2011 Roderick Monje. See LICENSE.txt for further details.
+Copyright © 2011-2020 Roderick Monje. See [LICENSE.txt](https://github.com/ivanoblomov/google_maps_geocoder/blob/master/LICENSE.txt) for further details.

data/google_maps_geocoder.gemspec

@@ -1,25 +1,28 @@
-require File.expand_path '../lib/google_maps_geocoder/version', __FILE__
+require File.expand_path('lib/google_maps_geocoder/version', __dir__)
 Gem::Specification.new do |s|
   s.name = 'google_maps_geocoder'
   s.version = GoogleMapsGeocoder::VERSION.dup
+  s.licenses = ['MIT']
   s.summary = 'A simple PORO wrapper for geocoding with Google Maps.'
   s.description = 'Geocode a location without worrying about parsing Google '\
                   "Maps' response. GoogleMapsGeocoder wraps it in a plain-old "\
                   'Ruby object.'
-  s.homepage = 'http://github.com/ivanoblomov/google_maps_geocoder'
+  s.homepage = 'https://github.com/ivanoblomov/google_maps_geocoder'
   s.authors = ['Roderick Monje']
+  s.email = 'rod@foveacentral.com'
 
-  s.add_development_dependency 'coveralls', '>= 0'
-  s.add_development_dependency 'rake', '>= 0'
-  s.add_development_dependency 'rspec', '>= 0'
-  s.add_development_dependency 'rubocop', '>= 0'
+  s.add_development_dependency 'codeclimate-test-reporter', '~> 0'
+  s.add_development_dependency 'coveralls', '~> 0'
+  s.add_development_dependency 'rake', '~> 12.3', '>= 12.3.3'
+  s.add_development_dependency 'rspec', '~> 3'
+  s.add_development_dependency 'rubocop', '~> 0.49.0'
 
-  s.add_runtime_dependency 'activesupport', '>= 0'
-  s.add_runtime_dependency 'rack', '>= 0'
+  s.add_runtime_dependency 'activesupport', '~> 4.1', '>= 4.1.11'
+  s.add_runtime_dependency 'rack', '~> 2.1.3'
 
   s.files       = `git ls-files`.split "\n"
   s.test_files  = `git ls-files -- {test,spec,features}/*`.split "\n"
   s.executables = `git ls-files -- bin/*`.split("\n")
-    .map { |f| File.basename f }
+                                         .map { |f| File.basename f }
   s.require_paths = ['lib']
 end

data/lib/google_maps_geocoder/google_maps_geocoder.rb

@@ -4,79 +4,138 @@ require 'net/http'
 require 'rack'
 
 # A simple PORO wrapper for geocoding with Google Maps.
+#
+# @example
+#   chez_barack = GoogleMapsGeocoder.new '1600 Pennsylvania DC'
+#   chez_barack.formatted_address
+#     => "1600 Pennsylvania Avenue Northwest, President's Park,
+#         Washington, DC 20500, USA"
 class GoogleMapsGeocoder
-  GOOGLE_ADDRESS_SEGMENTS = %i(
+  GOOGLE_ADDRESS_SEGMENTS = %i[
     city country_long_name country_short_name county lat lng postal_code
     state_long_name state_short_name
-  ).freeze
-  GOOGLE_API_URI = 'https://maps.googleapis.com/maps/api/geocode/json'.freeze
+  ].freeze
+  GOOGLE_MAPS_API = 'https://maps.googleapis.com/maps/api/geocode/json'.freeze
 
   ALL_ADDRESS_SEGMENTS = (
-    GOOGLE_ADDRESS_SEGMENTS + %i(
-      formatted_address formatted_street_address
-    )
+    GOOGLE_ADDRESS_SEGMENTS + %i[formatted_address formatted_street_address]
   ).freeze
 
   # Returns the complete formatted address with standardized abbreviations.
+  #
+  # @return [String] the complete formatted address
+  # @example
+  #   chez_barack.formatted_address
+  #     => "1600 Pennsylvania Avenue Northwest, President's Park,
+  #         Washington, DC 20500, USA"
   attr_reader :formatted_address
+
   # Returns the formatted street address with standardized abbreviations.
+  #
+  # @return [String] the formatted street address
+  # @example
+  #   chez_barack.formatted_street_address
+  #     => "1600 Pennsylvania Avenue Northwest"
   attr_reader :formatted_street_address
   # Self-explanatory
   attr_reader(*GOOGLE_ADDRESS_SEGMENTS)
 
-  # Instance Methods: Overrides ================================================
-
-  # Geocodes the specified address and wraps the results in a geocoder object.
-  #
-  # ==== Attributes
+  # Returns the formatted address as a comma-delimited string.
+  alias address formatted_address
+  # Returns the address' country as a full string.
+  alias country country_long_name
+  # Returns the address' country as an abbreviated string.
+  alias country_code country_short_name
+  # Returns the address' latitude as a float.
+  alias latitude lat
+  # Returns the address' longitude as a float.
+  alias longitude lng
+  # Returns the address' state as a full string.
+  alias state state_long_name
+  # Returns the address' state as an abbreviated string.
+  alias state_code state_short_name
+
+  # Geocodes the specified address and wraps the results in a GoogleMapsGeocoder
+  # object.
   #
-  # * +data+ - a geocodable address
-  #
-  # ==== Examples
-  #
-  #    white_house = GoogleMapsGeocoder.new('1600 Pennsylvania Washington')
-  #    white_house.formatted_address
-  #     => "1600 Pennsylvania Avenue Northwest, President's Park,
-  #         Washington, DC 20500, USA"
-  def initialize(data)
-    @json = data.is_a?(String) ? json_from_url(data) : data
-    fail "Geocoding \"#{data}\" exceeded query limit! Google returned...\n"\
-         "#{@json.inspect}" if @json.blank? || @json['status'] != 'OK'
+  # @param address [String] a geocodable address
+  # @return [GoogleMapsGeocoder] the Google Maps result for the specified
+  #   address
+  # @example
+  #   chez_barack = GoogleMapsGeocoder.new '1600 Pennsylvania DC'
+  def initialize(address)
+    @json = address.is_a?(String) ? google_maps_response(address) : address
+    status = @json && @json['status']
+    raise RuntimeError if status == 'OVER_QUERY_LIMIT'
+    raise GeocodingError, @json if @json.blank? || status != 'OK'
+
     set_attributes_from_json
-    logger.info('GoogleMapsGeocoder') do
-      "Geocoded \"#{data}\" => \"#{formatted_address}\""
+    Logger.new(STDERR).info('GoogleMapsGeocoder') do
+      "Geocoded \"#{address}\" => \"#{formatted_address}\""
     end
   end
 
-  # Instance Methods ===========================================================
+  # Returns the address' coordinates as an array of floats.
+  def coordinates
+    [lat, lng]
+  end
 
   # Returns true if the address Google returns is an exact match.
   #
-  # ==== Examples
-  #
-  #    white_house = GoogleMapsGeocoder.new('1600 Pennsylvania Ave')
-  #    white_house.exact_match?
+  # @return [boolean] whether the Google Maps result is an exact match
+  # @example
+  #   chez_barack.exact_match?
   #     => true
   def exact_match?
-    !self.partial_match?
+    !partial_match?
   end
 
   # Returns true if the address Google returns isn't an exact match.
   #
-  # ==== Examples
-  #
-  #    white_house = GoogleMapsGeocoder.new('1600 Pennsylvania Washington')
-  #    white_house.exact_match?
-  #     => false
+  # @return [boolean] whether the Google Maps result is a partial match
+  # @example
+  #   GoogleMapsGeocoder.new('1600 Pennsylvania DC').partial_match?
+  #     => true
   def partial_match?
     @json['results'][0]['partial_match'] == true
   end
 
+  # A geocoding error returned by Google Maps.
+  class GeocodingError < StandardError
+    # Returns the complete JSON response from Google Maps as a Hash.
+    #
+    # @return [Hash] Google Maps' JSON response
+    # @example
+    #   {
+    #     "results" => [],
+    #     "status" => "ZERO_RESULTS"
+    #   }
+    attr_reader :json
+
+    # Initialize a GeocodingError wrapping the JSON returned by Google Maps.
+    #
+    # @param json [Hash] Google Maps' JSON response
+    # @return [GeocodingError] the geocoding error
+    def initialize(json = {})
+      @json = json
+      if (message = @json['error_message'])
+        Logger.new(STDERR).error(message)
+      end
+      super @json['status']
+    end
+  end
+
   private
 
-  def api_key
-    @api_key ||= "&key=#{ENV['GOOGLE_MAPS_API_KEY']}" if
-      ENV['GOOGLE_MAPS_API_KEY']
+  def google_maps_request(address)
+    "#{GOOGLE_MAPS_API}?address=#{Rack::Utils.escape address}"\
+    "&key=#{ENV['GOOGLE_MAPS_API_KEY']}"
+  end
+
+  def google_maps_response(address)
+    uri = URI.parse google_maps_request(address)
+    response = http(uri).request(Net::HTTP::Get.new(uri.request_uri))
+    ActiveSupport::JSON.decode response.body
   end
 
   def http(uri)
@@ -86,17 +145,6 @@ class GoogleMapsGeocoder
     http
   end
 
-  def json_from_url(url)
-    uri = URI.parse query_url(url)
-    logger.debug('GoogleMapsGeocoder') { uri }
-    response = http(uri).request(Net::HTTP::Get.new(uri.request_uri))
-    ActiveSupport::JSON.decode response.body
-  end
-
-  def logger
-    @logger ||= Logger.new STDERR
-  end
-
   def parse_address_component_type(type, name = 'long_name')
     address_component = @json['results'][0]['address_components'].detect do |ac|
       ac['types'] && ac['types'].include?(type)
@@ -150,11 +198,6 @@ class GoogleMapsGeocoder
     parse_address_component_type('administrative_area_level_1', 'short_name')
   end
 
-  def query_url(query)
-    "#{GOOGLE_API_URI}?address=#{Rack::Utils.escape query}&sensor=false"\
-    "#{api_key}"
-  end
-
   def set_attributes_from_json
     ALL_ADDRESS_SEGMENTS.each do |segment|
       instance_variable_set :"@#{segment}", send("parse_#{segment}")

data/lib/google_maps_geocoder/version.rb

@@ -1,4 +1,4 @@
 # A simple PORO wrapper for geocoding with Google Maps.
 class GoogleMapsGeocoder
-  VERSION = '0.4.0.pre1'.freeze unless defined?(GoogleMapsGeocoder::VERSION)
+  VERSION = '0.7.1'.freeze unless defined?(GoogleMapsGeocoder::VERSION)
 end

data/spec/lib/google_maps_geocoder_spec.rb

@@ -1,10 +1,9 @@
 require File.dirname(__FILE__) + '/../spec_helper'
-
+# rubocop:disable Metrics/BlockLength
 describe GoogleMapsGeocoder do
   before(:all) do
     begin
-      @exact_match   = GoogleMapsGeocoder.new('837 Union Street Brooklyn NY')
-      @partial_match = GoogleMapsGeocoder.new('1600 Pennsylvania Washington')
+      @exact_match = GoogleMapsGeocoder.new('White House')
     rescue SocketError
       @no_network  = true
     rescue RuntimeError
@@ -17,68 +16,58 @@ describe GoogleMapsGeocoder do
     pending 'waiting for query limit to pass' if @query_limit
   end
 
-  context 'with "837 Union Street Brooklyn NY"' do
-    subject { @exact_match }
-    it { expect(subject).to be_exact_match }
+  describe '#new' do
+    context 'with "White House"' do
+      subject { @exact_match }
 
-    context 'address' do
-      it { expect(subject.formatted_street_address).to eq '837 Union Street' }
-      it { expect(subject.city).to eq 'Brooklyn' }
-      it { expect(subject.county).to match(/Kings/) }
-      it { expect(subject.state_long_name).to eq 'New York' }
-      it { expect(subject.state_short_name).to eq 'NY' }
-      it { expect(subject.postal_code).to match(/112[0-9]{2}/) }
-      it { expect(subject.country_short_name).to eq 'US' }
-      it { expect(subject.country_long_name).to eq 'United States' }
-      it do
-        expect(subject.formatted_address)
-          .to match(/837 Union St, Brooklyn, NY 112[0-9]{2}, USA/)
-      end
-    end
+      it { should be_exact_match }
 
-    context 'coordinates' do
-      it { expect(subject.lat).to be_within(0.005).of(40.6748151) }
-      it { expect(subject.lng).to be_within(0.005).of(-73.9760302) }
-    end
-  end
-
-  context 'with "1600 Pennsylvania Washington"' do
-    subject { @partial_match }
-    it { should be_partial_match }
-
-    context 'address' do
-      it do
-        expect(subject.formatted_street_address)
-          .to eq '1600 Pennsylvania Avenue Southeast'
+      context 'address' do
+        it do
+          expect(subject.formatted_street_address)
+            .to eq '1600 Pennsylvania Avenue Northwest'
+        end
+        it { expect(subject.city).to eq 'Washington' }
+        it { expect(subject.state_long_name).to eq 'District of Columbia' }
+        it { expect(subject.state_short_name).to eq 'DC' }
+        it { expect(subject.postal_code).to eq '20500' }
+        it { expect(subject.country_short_name).to eq 'US' }
+        it { expect(subject.country_long_name).to eq 'United States' }
+        it do
+          expect(subject.formatted_address)
+            .to match(/1600 Pennsylvania Ave NW, Washington, DC 20500, USA/)
+        end
       end
-      it { expect(subject.city).to eq 'Washington' }
-      it { expect(subject.state_long_name).to eq 'District of Columbia' }
-      it { expect(subject.state_short_name).to eq 'DC' }
-      it { expect(subject.postal_code).to match(/2000[0-9]/) }
-      it { expect(subject.country_short_name).to eq 'US' }
-      it { expect(subject.country_long_name).to eq 'United States' }
-      it do
-        expect(subject.formatted_address)
-          .to match(/1600 Pennsylvania Ave SE, Washington, DC 20003, USA/)
+      context 'coordinates' do
+        it { expect(subject.lat).to be_within(0.005).of(38.8976633) }
+        it { expect(subject.lng).to be_within(0.005).of(-77.0365739) }
+      end
+      context 'Geocoder API' do
+        it { expect(subject.address).to eq subject.formatted_address }
+        it { expect(subject.coordinates).to eq [subject.lat, subject.lng] }
+        it { expect(subject.country).to eq subject.country_long_name }
+        it { expect(subject.country_code).to eq subject.country_short_name }
+        it { expect(subject.latitude).to eq subject.lat }
+        it { expect(subject.longitude).to eq subject.lng }
+        it { expect(subject.state).to eq subject.state_long_name }
+        it { expect(subject.state_code).to eq subject.state_short_name }
       end
     end
+    context 'when API key is invalid' do
+      before do
+        @key = ENV['GOOGLE_MAPS_API_KEY']
+        ENV['GOOGLE_MAPS_API_KEY'] = 'invalid_key'
+      end
 
-    context 'coordinates' do
-      it { expect(subject.lat).to be_within(0.005).of(38.8791981) }
-      it { expect(subject.lng).to be_within(0.005).of(-76.9818437) }
-    end
-  end
-
-  context "when ENV['GOOGLE_MAPS_API_KEY'] = 'INVALID_KEY'" do
-    before { ENV['GOOGLE_MAPS_API_KEY'] = 'INVALID_KEY' }
+      after { ENV['GOOGLE_MAPS_API_KEY'] = @key }
 
-    subject { @exact_match }
+      subject { GoogleMapsGeocoder.new('nowhere that comes to mind') }
 
-    it do
-      expect(subject.send :query_url, nil).to eq(
-        'https://maps.googleapis.com/maps/api/geocode/json?address='\
-        '&sensor=false&key=INVALID_KEY'
-      )
+      it do
+        expect { subject }.to raise_error GoogleMapsGeocoder::GeocodingError,
+                                          'REQUEST_DENIED'
+      end
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

data/spec/spec_helper.rb

@@ -1,12 +1,17 @@
+require 'simplecov'
+SimpleCov.start
 require 'coveralls'
 Coveralls.wear!
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
+  Coveralls::SimpleCov::Formatter
+)
 require 'rubygems'
 require 'bundler'
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts 'Run `bundle install` to install missing gems'
+  warn e.message
+  warn 'Run `bundle install` to install missing gems'
   exit e.status_code
 end
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))

metadata

@@ -1,109 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: google_maps_geocoder
 version: !ruby/object:Gem::Version
-  version: 0.4.0.pre1
+  version: 0.7.1
 platform: ruby
 authors:
 - Roderick Monje
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-28 00:00:00.000000000 Z
+date: 2020-05-31 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.49.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.1.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.1.11
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.1.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.1.3
 description: Geocode a location without worrying about parsing Google Maps' response.
   GoogleMapsGeocoder wraps it in a plain-old Ruby object.
-email: 
+email: rod@foveacentral.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".document"
+- ".github/CONTRIBUTING.md"
+- ".github/ISSUE_TEMPLATE.md"
+- ".github/ISSUE_TEMPLATE/bug-report.md"
+- ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/PULL_REQUEST_TEMPLATE.md"
 - ".gitignore"
-- ".ruby-version"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -114,8 +144,9 @@ files:
 - lib/google_maps_geocoder/version.rb
 - spec/lib/google_maps_geocoder_spec.rb
 - spec/spec_helper.rb
-homepage: http://github.com/ivanoblomov/google_maps_geocoder
-licenses: []
+homepage: https://github.com/ivanoblomov/google_maps_geocoder
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -128,12 +159,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A simple PORO wrapper for geocoding with Google Maps.

data/.ruby-version

@@ -1 +0,0 @@
-2.2.2