google_maps_geocoder 0.3.0 → 0.3.1

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    N2IzNjAyZDM5YWVlOWM3YjM0NTQ0Yjk4ZWU3NWNiYjk2NDBiOTliYw==
+  data.tar.gz: !binary |-
+    NDA3NGI5YmFkZmQ3ZmI1NjExOTU4N2UwOTMyZGU5M2Q0N2RhMTJmMw==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    ZGFiNmM3MDg0Y2FmZDMwMjBiOTFkOTA5MmQ5NTU1ZGQ1NWMxMjgxMDJmODVm
+    Y2ExNTIwZGY4M2ZiZDIwYmRhYmZlY2M4NGNmNDY4OWJjYmZkODA2Y2NlY2M5
+    ZDAzZmY2YThmYzhjZTM3MmZmOWEyY2M1ZWJlODQ4MGE0N2YyYjQ=
+  data.tar.gz: !binary |-
+    ZDNhMzgyOWQzODE5NDk1NDdlZGQ5MzZlZTRjNTYxNzMyMTIzNDcyMTg3Nzgw
+    NjMyNjI2ZTFhOGY2YmVlYjA2N2Y3Y2NjNDhjMmFhZDhiZTgzOTZhN2RjMzE0
+    NDhlMDdhYmRiNGNhMmE1YjJhMDU0NWU3ZDQyMWUxMWQzMjM2OTA=

data/.ruby-version

@@ -0,0 +1 @@
+ruby-1.9.3-p385

data/.travis.yml

@@ -1,6 +1,3 @@
 rvm:
-  - 1.8.7
-  - 1.9.2
-  - ree
   - 1.9.3
   - 2.0.0

data/LICENSE.txt

@@ -17,4 +17,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -1,37 +1,61 @@
-# GoogleMapsGeocoder [![Build Status](https://secure.travis-ci.org/ivanoblomov/google_maps_geocoder.png)](http://travis-ci.org/ivanoblomov/google_maps_geocoder)
+# GoogleMapsGeocoder [![Code Climate](https://codeclimate.com/github/ivanoblomov/google_maps_geocoder.png)](https://codeclimate.com/github/ivanoblomov/google_maps_geocoder) [![Build Status](https://secure.travis-ci.org/ivanoblomov/google_maps_geocoder.png)](http://travis-ci.org/ivanoblomov/google_maps_geocoder) [![Dependency Status](https://gemnasium.com/ivanoblomov/google_maps_geocoder.png)](https://gemnasium.com/ivanoblomov/google_maps_geocoder)
 
 A simple PORO wrapper for geocoding with Google Maps.
 
-## Initialize in One Step
+## Installation
+
+In <b>Rails 3</b>, add this to your Gemfile and run "bundle":
+
+```ruby
+  gem 'google_maps_geocoder'
+```
+
+In <b>Rails 2</b>, add this to your environment.rb file:
+
+```ruby
+  config.gem 'google_maps_geocoder'
+```
+
+Or try it out in <b>irb</b> with:
+
+```ruby
+  require './lib/google_maps_geocoder'
+```
+
+## Ready to Go in One Step
 
 ```ruby
 chez_barack = GoogleMapsGeocoder.new '1600 Pennsylvania Washington'
 ```
 
-## Examples
+## Usage
 
 Get the complete, formatted address:
 
 ```ruby
 chez_barack.formatted_address
+ => "1600 Pennsylvania Avenue Northwest, President's Park, Washington, DC 20500, USA"
 ```
 
 ...standardized name of the city:
 
 ```ruby
 chez_barack.city
+ => "Washington"
 ```
 
 ...full name of the state or region:
 
 ```ruby
 chez_barack.state_long_name
+ => "District of Columbia"
 ```
 
 ...standard abbreviation for the state/region:
 
 ```ruby
 chez_barack.state_short_name
+ => "DC"
 ```
 
 ## API
@@ -64,4 +88,4 @@ The complete, hopefully self-explanatory, API is:
 
 ## Copyright
 
-Copyright (c) 2011 Roderick Monje. See LICENSE.txt for further details.
+Copyright (c) 2011 Roderick Monje. See LICENSE.txt for further details.

data/Rakefile

@@ -1,10 +1,8 @@
 require 'bundler'
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
-
 RSpec::Core::RakeTask.new(:test) do |t|
   t.pattern = 'spec/*/*_spec.rb'
   t.verbose = false
 end
-
 task :default => :test

data/google_maps_geocoder.gemspec

@@ -1,5 +1,4 @@
-require File.expand_path('../lib/version', __FILE__)
-
+require File.expand_path '../lib/version', __FILE__
 Gem::Specification.new do |s|
   s.name = "google_maps_geocoder"
   s.version = GoogleMapsGeocoder::VERSION.dup
@@ -15,8 +14,8 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'activesupport', '>= 0'
   s.add_runtime_dependency 'rack', '>= 0'
 
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{|f| File.basename(f)}
+  s.files         = `git ls-files`.split "\n"
+  s.test_files    = `git ls-files -- {test,spec,features}/*`.split "\n"
+  s.executables   = `git ls-files -- bin/*`.split("\n").map{|f| File.basename f}
   s.require_paths = ["lib"]
 end

data/lib/google_maps_geocoder.rb

@@ -25,18 +25,10 @@ class GoogleMapsGeocoder
   #    white_house.formatted_address
   #     => "1600 Pennsylvania Avenue Northwest, President's Park, Washington, DC 20500, USA"
   def initialize data
-    if data.is_a? String
-      response = Net::HTTP.get_response(URI.parse("http://maps.googleapis.com/maps/api/geocode/json?address=#{Rack::Utils.escape(data)}&sensor=false"))
-      @json = ActiveSupport::JSON.decode(response.body)
-      raise "Geocoding \"#{data}\" exceeded query limit! Google returned...\n#{@json.inspect}" if @json.blank? || @json['status'] != 'OK'
-    else
-      @json = data
-      address = data['formatted_address']
-    end
-
-    @city, @country_short_name, @country_long_name, @county, @formatted_address, @formatted_street_address, @lat, @lng, @postal_code, @state_long_name, @state_short_name = parse_city, parse_country_short_name, parse_country_long_name, parse_county, parse_formatted_address, parse_formatted_street_address, parse_lat, parse_lng, parse_postal_code, parse_state_long_name, parse_state_short_name
-
-    logger = Logger.new(STDERR)
+    @json = data.is_a?(String) ? json_from_url(data) : data
+		raise "Geocoding \"#{data}\" exceeded query limit! Google returned...\n#{@json.inspect}" if @json.blank? || @json['status'] != 'OK'
+    set_attributes_from_json
+    logger = Logger.new STDERR
     logger.info('GoogleMapsGeocoder') { "Geocoded \"#{data}\" => \"#{self.formatted_address}\"" }
   end
 
@@ -66,6 +58,11 @@ class GoogleMapsGeocoder
 
   private
 
+  def json_from_url url
+    response = Net::HTTP.get_response(URI.parse "http://maps.googleapis.com/maps/api/geocode/json?address=#{Rack::Utils.escape(url)}&sensor=false")
+    ActiveSupport::JSON.decode response.body
+  end
+
   def parse_address_component_type(type, name='long_name')
     _address_component = @json['results'][0]['address_components'].detect{ |ac| ac['types'] && ac['types'].include?(type) }
     _address_component && _address_component[name]
@@ -114,4 +111,8 @@ class GoogleMapsGeocoder
   def parse_state_short_name
     parse_address_component_type('administrative_area_level_1', 'short_name')
   end
-end
+
+  def set_attributes_from_json
+    @city, @country_short_name, @country_long_name, @county, @formatted_address, @formatted_street_address, @lat, @lng, @postal_code, @state_long_name, @state_short_name = parse_city, parse_country_short_name, parse_country_long_name, parse_county, parse_formatted_address, parse_formatted_street_address, parse_lat, parse_lng, parse_postal_code, parse_state_long_name, parse_state_short_name
+  end
+end

data/lib/version.rb

@@ -1,3 +1,3 @@
 class GoogleMapsGeocoder
-  VERSION = '0.3.0'.freeze unless defined?(GoogleMapsGeocoder::VERSION)
+  VERSION = '0.3.1'.freeze unless defined?(GoogleMapsGeocoder::VERSION)
 end

data/spec/lib/google_maps_geocoder_spec.rb

@@ -19,44 +19,44 @@ describe GoogleMapsGeocoder do
 
   context 'with "837 Union Street Brooklyn NY"' do
     subject { @exact_match }
-    specify { should be_exact_match }
+    it { expect(subject).to be_exact_match }
 
     context 'address' do
-      specify { subject.formatted_street_address.should == '837 Union Street' }
-      specify { subject.city.should == 'Brooklyn' }
-      specify { subject.county.should == 'Kings' }
-      specify { subject.state_long_name.should == 'New York' }
-      specify { subject.state_short_name.should == 'NY' }
-      specify { subject.postal_code.should =~ /1121[0-9]/ }
-      specify { subject.country_short_name.should == 'US' }
-      specify { subject.country_long_name.should == 'United States' }
-      specify { subject.formatted_address.should =~ /837 Union Street, Brooklyn, NY 1121[0-9], USA/ }
+      it { expect(subject.formatted_street_address).to eq '837 Union Street' }
+      it { expect(subject.city).to eq 'Brooklyn' }
+      it { expect(subject.county).to match /Kings/ }
+      it { expect(subject.state_long_name).to eq 'New York' }
+      it { expect(subject.state_short_name).to eq 'NY' }
+      it { expect(subject.postal_code).to match /112[0-9]{2}/ }
+      it { expect(subject.country_short_name).to eq 'US' }
+      it { expect(subject.country_long_name).to eq 'United States' }
+      it { expect(subject.formatted_address).to match /837 Union Street, Brooklyn, NY 112[0-9]{2}, USA/ }
     end
 
     context 'coordinates' do
-      specify { subject.lat.should be_within(0.005).of(40.6748151) }
-      specify { subject.lng.should be_within(0.005).of(-73.9760302) }
+      it { expect(subject.lat).to be_within(0.005).of(40.6748151) }
+      it { expect(subject.lng).to be_within(0.005).of(-73.9760302) }
     end
   end
 
   context 'with "1600 Pennsylvania Washington"' do
     subject { @partial_match }
-    specify { should be_partial_match }
+    it { should be_partial_match }
 
     context 'address' do
-      specify { subject.formatted_street_address.should == '1600 Pennsylvania Avenue Northwest' }
-      specify { subject.city.should == 'Washington' }
-      specify { subject.state_long_name.should == 'District of Columbia' }
-      specify { subject.state_short_name.should == 'DC' }
-      specify { subject.postal_code.should =~ /2050[0-9]/ }
-      specify { subject.country_short_name.should == 'US' }
-      specify { subject.country_long_name.should == 'United States' }
-      specify { subject.formatted_address.should =~ /1600 Pennsylvania Avenue Northwest, President's Park, Washington, DC 2050[0-9], USA/ }
+      it { expect(subject.formatted_street_address).to eq '1600 Pennsylvania Avenue Northwest' }
+      it { expect(subject.city).to eq 'Washington' }
+      it { expect(subject.state_long_name).to eq 'District of Columbia' }
+      it { expect(subject.state_short_name).to eq 'DC' }
+      it { expect(subject.postal_code).to match /2050[0-9]/ }
+      it { expect(subject.country_short_name).to eq 'US' }
+      it { expect(subject.country_long_name).to eq 'United States' }
+      it { expect(subject.formatted_address).to match(/1600 Pennsylvania Avenue Northwest, President's Park, Washington, DC 2050[0-9], USA/) }
    end
 
    context 'coordinates' do
-      specify { subject.lat.should be_within(0.005).of(38.8976964) }
-      specify { subject.lng.should be_within(0.005).of(-77.0365191) }
+      it { expect(subject.lat).to be_within(0.005).of(38.8976964) }
+      it { expect(subject.lng).to be_within(0.005).of(-77.0365191) }
    end
   end
-end
+end

data/spec/spec_helper.rb

@@ -1,6 +1,5 @@
 require 'simplecov'
 SimpleCov.start
-
 require 'rubygems'
 require 'bundler'
 begin
@@ -10,7 +9,6 @@ rescue Bundler::BundlerError => e
   $stderr.puts "Run `bundle install` to install missing gems"
   exit e.status_code
 end
-
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'google_maps_geocoder'
+require 'google_maps_geocoder'

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: google_maps_geocoder
 version: !ruby/object:Gem::Version
-  version: 0.3.0
-  prerelease: 
+  version: 0.3.1
 platform: ruby
 authors:
 - Roderick Monje
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-26 00:00:00.000000000 Z
+date: 2014-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -100,6 +89,7 @@ extra_rdoc_files: []
 files:
 - .document
 - .gitignore
+- .ruby-version
 - .travis.yml
 - Gemfile
 - LICENSE.txt
@@ -112,29 +102,27 @@ files:
 - spec/spec_helper.rb
 homepage: http://github.com/ivanoblomov/google_maps_geocoder
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A simple PORO wrapper for geocoding with Google Maps.
 test_files:
 - spec/lib/google_maps_geocoder_spec.rb
 - spec/spec_helper.rb
-has_rdoc: