google_distance_matrix 0.4.0 → 0.5.0

data/spec/lib/google_distance_matrix/places_spec.rb

@@ -1,77 +1,78 @@
-require "spec_helper"
+# frozen_string_literal: true
+
+require 'spec_helper'
 
 describe GoogleDistanceMatrix::Places do
-  let(:values) { [{address: "one"}, {address: "two"}, {address: "three"}] }
+  let(:values) { [{ address: 'one' }, { address: 'two' }, { address: 'three' }] }
   let(:places) { values.map { |v| GoogleDistanceMatrix::Place.new v } }
 
-  let(:place_4) { GoogleDistanceMatrix::Place.new address: "four" }
-  let(:place_5) { GoogleDistanceMatrix::Place.new address: "five" }
-  let(:place_6) { GoogleDistanceMatrix::Place.new address: "six" }
+  let(:place_4) { GoogleDistanceMatrix::Place.new address: 'four' }
+  let(:place_5) { GoogleDistanceMatrix::Place.new address: 'five' }
+  let(:place_6) { GoogleDistanceMatrix::Place.new address: 'six' }
 
   subject { described_class.new places }
 
-  it { should include *places }
+  it { should include(*places) }
   it { should_not include 5 }
 
-
   %w[<< push unshift].each do |attr|
-    describe "#{attr}" do
-      it "adds value" do
-        expect {
+    describe attr.to_s do
+      it 'adds value' do
+        expect do
           subject.public_send attr, place_4
-        }.to change { subject.include? place_4 }.to true
+        end.to change { subject.include? place_4 }.to true
       end
 
-      it "keeps uniq values" do
+      it 'keeps uniq values' do
         subject.public_send attr, place_4
 
-        expect {
+        expect do
           subject.public_send attr, place_4
-        }.to_not change subject, :length
+        end.to_not change subject, :length
       end
 
-      it "is chanable" do
+      it 'is chanable' do
         subject.public_send(attr, place_5).public_send(attr, place_6)
 
         expect(subject).to include place_5, place_6
       end
 
-      it "wraps values in a Place" do
-        subject.public_send attr, {address: "four"}
+      it 'wraps values in a Place' do
+        subject.public_send attr, address: 'four'
 
         expect(subject.all? { |place| place.is_a? GoogleDistanceMatrix::Place }).to be true
-        expect(subject.any? { |place| place.address == "four" }).to be true
+        expect(subject.any? { |place| place.address == 'four' }).to be true
       end
     end
   end
 
   %w[push unshift].each do |attr|
-    describe "#{attr}" do
-      it "adds multiple values at once" do
+    describe attr.to_s do
+      it 'adds multiple values at once' do
         subject.public_send attr, place_4, place_5
         expect(subject).to include place_4, place_5
       end
     end
   end
 
-  describe "#concat" do
+  describe '#concat' do
     let(:places_2) { [place_4, place_5, place_6] }
 
-    it "adds the given array" do
+    it 'adds the given array' do
       subject.concat places_2
-      expect(subject).to include *places_2
+      expect(subject).to include(*places_2)
     end
 
-    it "keeps values uniq" do
+    it 'keeps values uniq' do
       subject.concat places_2
 
-      expect {
+      expect do
         subject.concat places_2
-      }.to_not change subject, :length
+      end.to_not change subject, :length
     end
 
-    it "returns self" do
-      expect(subject.concat places_2).to eq subject
+    it 'returns self' do
+      expect(subject.concat(places_2)).to eq subject
     end
   end
 end

data/spec/lib/google_distance_matrix/polyline_encoder/delta_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module GoogleDistanceMatrix
@@ -6,9 +8,9 @@ module GoogleDistanceMatrix
       deltas = subject.deltas_rounded [[38.5, -120.2], [40.7, -120.95], [43.252, -126.453]]
 
       expect(deltas).to eq [
-        3850000,  -12020000,
-        220000,   -75000,
-        255200,   -550300
+        3_850_000, -12_020_000,
+        220_000,   -75_000,
+        255_200,   -550_300
       ]
     end
   end

data/spec/lib/google_distance_matrix/polyline_encoder_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module GoogleDistanceMatrix
@@ -5,12 +7,15 @@ module GoogleDistanceMatrix
     tests = {
       [[-179.9832104, -179.9832104]] => '`~oia@`~oia@',
       [[38.5, -120.2], [40.7, -120.95], [43.252, -126.453]] => '_p~iF~ps|U_ulLnnqC_mqNvxq`@',
-      [[41.3522171071184, -86.0456299662023],[41.3522171071183, -86.0454368471533]] => 'krk{FdxdlO?e@'
+      [
+        [41.3522171071184, -86.0456299662023],
+        [41.3522171071183, -86.0454368471533]
+      ] => 'krk{FdxdlO?e@'
     }
 
     tests.each_pair do |lat_lng_values, expected|
       it "encodes #{lat_lng_values} to #{expected}" do
-        expect(described_class.encode lat_lng_values).to eq expected
+        expect(described_class.encode(lat_lng_values)).to eq expected
       end
     end
   end

data/spec/lib/google_distance_matrix/route_spec.rb

@@ -1,24 +1,26 @@
-require "spec_helper"
+# frozen_string_literal: true
+
+require 'spec_helper'
 
 describe GoogleDistanceMatrix::Route do
   let(:attributes) do
     {
-      "distance" => {"text" => "2.0 km", "value" => 2032},
-      "duration" => {"text" =>"6 mins",  "value" => 367},
-      "duration_in_traffic" => {"text" =>"5 mins",  "value" => 301},
-      "status" =>"OK"
+      'distance' => { 'text' => '2.0 km', 'value' => 2032 },
+      'duration' => { 'text' => '6 mins',  'value' => 367 },
+      'duration_in_traffic' => { 'text' => '5 mins',  'value' => 301 },
+      'status' => 'OK'
     }
   end
 
   subject { described_class.new attributes }
 
-  it { expect(subject.status).to eq "ok" }
+  it { expect(subject.status).to eq 'ok' }
   it { expect(subject.distance_in_meters).to eq 2032 }
-  it { expect(subject.distance_text).to eq "2.0 km" }
+  it { expect(subject.distance_text).to eq '2.0 km' }
   it { expect(subject.duration_in_seconds).to eq 367 }
-  it { expect(subject.duration_text).to eq "6 mins" }
+  it { expect(subject.duration_text).to eq '6 mins' }
   it { expect(subject.duration_in_traffic_in_seconds).to eq 301 }
-  it { expect(subject.duration_in_traffic_text).to eq "5 mins" }
+  it { expect(subject.duration_in_traffic_text).to eq '5 mins' }
 
   it { is_expected.to be_ok }
 end

data/spec/lib/google_distance_matrix/routes_finder_spec.rb

@@ -1,16 +1,18 @@
-require "spec_helper"
+# frozen_string_literal: true
+
+require 'spec_helper'
 
 describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
-  let(:origin_1) { GoogleDistanceMatrix::Place.new address: "Karl Johans gate, Oslo" }
-  let(:origin_2) { GoogleDistanceMatrix::Place.new address: "Askerveien 1, Asker" }
+  let(:origin_1) { GoogleDistanceMatrix::Place.new address: 'Karl Johans gate, Oslo' }
+  let(:origin_2) { GoogleDistanceMatrix::Place.new address: 'Askerveien 1, Asker' }
 
-  let(:destination_1) { GoogleDistanceMatrix::Place.new address: "Drammensveien 1, Oslo" }
+  let(:destination_1) { GoogleDistanceMatrix::Place.new address: 'Drammensveien 1, Oslo' }
 
-  let(:destination_2_built_from) { double address: "Skjellestadhagen, Heggedal" }
+  let(:destination_2_built_from) { double address: 'Skjellestadhagen, Heggedal' }
   let(:destination_2) { GoogleDistanceMatrix::Place.new destination_2_built_from }
 
   let(:url_builder) { GoogleDistanceMatrix::UrlBuilder.new matrix }
-  let(:url) { url_builder.url }
+  let(:url) { url_builder.sensitive_url }
 
   let(:matrix) do
     GoogleDistanceMatrix::Matrix.new(
@@ -21,55 +23,61 @@ describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
 
   subject { described_class.new matrix }
 
-  context "success, with traffic data" do
+  context 'success, with traffic data' do
     before do
       matrix.configure do |c|
         c.departure_time = 'now'
       end
     end
 
-    let!(:api_request_stub) { stub_request(:get, url).to_return body: recorded_request_for(:success_with_in_traffic) }
+    let!(:api_request_stub) do
+      stub_request(:get, url).to_return body: recorded_request_for(:success_with_in_traffic)
+    end
 
-    describe "#shortest_route_by_duration_in_traffic_to" do
-      it "returns route representing shortest duration to given origin" do
+    describe '#shortest_route_by_duration_in_traffic_to' do
+      it 'returns route representing shortest duration to given origin' do
         expect(subject.shortest_route_by_duration_in_traffic_to(origin_1)).to eq matrix.data[0][0]
       end
 
-      it "returns route representing shortest duration to given destination" do
-        expect(subject.shortest_route_by_duration_in_traffic_to(destination_2)).to eq matrix.data[1][1]
+      it 'returns route representing shortest duration to given destination' do
+        expect(subject.shortest_route_by_duration_in_traffic_to(destination_2))
+          .to eq matrix.data[1][1]
       end
     end
 
-    describe "#shortest_route_by_duration_in_traffic_to!" do
-      it "returns the same as shortest_route_by_duration_in_traffic_to" do
-        expect(subject.shortest_route_by_duration_in_traffic_to!(origin_1)).to eq subject.shortest_route_by_duration_in_traffic_to(origin_1)
+    describe '#shortest_route_by_duration_in_traffic_to!' do
+      it 'returns the same as shortest_route_by_duration_in_traffic_to' do
+        expect(subject.shortest_route_by_duration_in_traffic_to!(origin_1))
+          .to eq subject.shortest_route_by_duration_in_traffic_to(origin_1)
       end
     end
   end
 
-  context "success, without in traffic data" do
-    let!(:api_request_stub) { stub_request(:get, url).to_return body: recorded_request_for(:success) }
+  context 'success, without in traffic data' do
+    let!(:api_request_stub) do
+      stub_request(:get, url).to_return body: recorded_request_for(:success)
+    end
 
-    describe "#routes_for" do
-      it "fails if given place does not exist" do
-        expect { subject.routes_for "foo" }.to raise_error ArgumentError
+    describe '#routes_for' do
+      it 'fails if given place does not exist' do
+        expect { subject.routes_for 'foo' }.to raise_error ArgumentError
       end
 
-      it "returns routes for given origin" do
+      it 'returns routes for given origin' do
         routes = subject.routes_for origin_1
 
         expect(routes.length).to eq 2
         expect(routes.map(&:origin).all? { |o| o == origin_1 }).to be true
       end
 
-      it "returns routes for given destination" do
+      it 'returns routes for given destination' do
         routes = subject.routes_for destination_2
 
         expect(routes.length).to eq 2
         expect(routes.map(&:destination).all? { |d| d == destination_2 }).to be true
       end
 
-      it "returns routes for given object a place was built from" do
+      it 'returns routes for given object a place was built from' do
         routes = subject.routes_for destination_2_built_from
 
         expect(routes.length).to eq 2
@@ -77,40 +85,42 @@ describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
       end
     end
 
-    describe "#routes_for!" do
-      it "returns the same as routes_for" do
-        expect(subject.routes_for! origin_1).to eq subject.routes_for(origin_1)
+    describe '#routes_for!' do
+      it 'returns the same as routes_for' do
+        expect(subject.routes_for!(origin_1)).to eq subject.routes_for(origin_1)
       end
     end
 
-    describe "#route_for" do
-      it "returns route" do
+    describe '#route_for' do
+      it 'returns route' do
         route = subject.route_for(origin: origin_1, destination: destination_1)
         expect(route.origin).to eq origin_1
         expect(route.destination).to eq destination_1
       end
 
-      it "returns route when you give it the object a place was built from" do
+      it 'returns route when you give it the object a place was built from' do
         route = subject.route_for(origin: origin_1, destination: destination_2_built_from)
         expect(route.origin).to eq origin_1
         expect(route.destination).to eq destination_2
       end
 
-      it "fails with argument error if origin is missing" do
+      it 'fails with argument error if origin is missing' do
         expect { subject.route_for destination: destination_2 }.to raise_error ArgumentError
       end
 
-      it "fails with argument error if destination is missing" do
+      it 'fails with argument error if destination is missing' do
         expect { subject.route_for origin: origin_1 }.to raise_error ArgumentError
       end
 
-      it "fails with argument error if sent in object is neither place nor something it was built from" do
-        expect { subject.route_for origin: origin_1, destination: double }.to raise_error ArgumentError
+      it 'fails with argument error if object is neither place nor something it was built from' do
+        expect do
+          subject.route_for origin: origin_1, destination: double
+        end.to raise_error ArgumentError
       end
     end
 
-    describe "#route_for!" do
-      it "returns the same as route_for" do
+    describe '#route_for!' do
+      it 'returns the same as route_for' do
         route = subject.route_for(origin: origin_1, destination: destination_1)
         route_bang = subject.route_for!(origin: origin_1, destination: destination_1)
 
@@ -118,60 +128,64 @@ describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
       end
     end
 
-    describe "#shortest_route_by_distance_to" do
-      it "returns route representing shortest distance to given origin" do
+    describe '#shortest_route_by_distance_to' do
+      it 'returns route representing shortest distance to given origin' do
         expect(subject.shortest_route_by_distance_to(origin_1)).to eq matrix.data[0][0]
       end
 
-      it "returns route representing shortest distance to given destination" do
+      it 'returns route representing shortest distance to given destination' do
         expect(subject.shortest_route_by_distance_to(destination_2)).to eq matrix.data[1][1]
       end
     end
 
-    describe "#shortest_route_by_distance_to!" do
-      it "returns the same as shortest_route_by_distance_to" do
-        expect(subject.shortest_route_by_distance_to!(origin_1)).to eq subject.shortest_route_by_distance_to(origin_1)
+    describe '#shortest_route_by_distance_to!' do
+      it 'returns the same as shortest_route_by_distance_to' do
+        expect(subject.shortest_route_by_distance_to!(origin_1))
+          .to eq subject.shortest_route_by_distance_to(origin_1)
       end
     end
 
-    describe "#shortest_route_by_duration_to" do
-      it "returns route representing shortest duration to given origin" do
+    describe '#shortest_route_by_duration_to' do
+      it 'returns route representing shortest duration to given origin' do
         expect(subject.shortest_route_by_duration_to(origin_1)).to eq matrix.data[0][0]
       end
 
-      it "returns route representing shortest duration to given destination" do
+      it 'returns route representing shortest duration to given destination' do
         expect(subject.shortest_route_by_duration_to(destination_2)).to eq matrix.data[1][1]
       end
     end
 
-    describe "#shortest_route_by_duration_to!" do
-      it "returns the same as shortest_route_by_duration_to" do
-        expect(subject.shortest_route_by_duration_to!(origin_1)).to eq subject.shortest_route_by_duration_to(origin_1)
+    describe '#shortest_route_by_duration_to!' do
+      it 'returns the same as shortest_route_by_duration_to' do
+        expect(subject.shortest_route_by_duration_to!(origin_1))
+          .to eq subject.shortest_route_by_duration_to(origin_1)
       end
     end
 
-    describe "#shortest_route_by_duration_in_traffic_to" do
-      it "returns route representing shortest duration to given origin" do
-        expect {
+    describe '#shortest_route_by_duration_in_traffic_to' do
+      it 'returns route representing shortest duration to given origin' do
+        expect do
           subject.shortest_route_by_duration_in_traffic_to(origin_1)
-        }.to raise_error GoogleDistanceMatrix::InvalidQuery
+        end.to raise_error GoogleDistanceMatrix::InvalidQuery
       end
     end
 
-    describe "#shortest_route_by_duration_in_traffic_to!" do
-      it "returns the same as shortest_route_by_duration_in_traffic_to" do
-        expect {
+    describe '#shortest_route_by_duration_in_traffic_to!' do
+      it 'returns the same as shortest_route_by_duration_in_traffic_to' do
+        expect do
           subject.shortest_route_by_duration_in_traffic_to!(origin_1)
-        }.to raise_error GoogleDistanceMatrix::InvalidQuery
+        end.to raise_error GoogleDistanceMatrix::InvalidQuery
       end
     end
   end
 
-  context "routes mssing data" do
-    let!(:api_request_stub) { stub_request(:get, url).to_return body: recorded_request_for(:zero_results) }
+  context 'routes mssing data' do
+    let!(:api_request_stub) do
+      stub_request(:get, url).to_return body: recorded_request_for(:zero_results)
+    end
 
-    describe "#routes_for" do
-      it "returns routes for given origin" do
+    describe '#routes_for' do
+      it 'returns routes for given origin' do
         routes = subject.routes_for origin_1
 
         expect(routes.length).to eq 2
@@ -179,53 +193,53 @@ describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
       end
     end
 
-    describe "#routes_for!" do
-      it "fails upon any non-ok route" do
-        expect {
+    describe '#routes_for!' do
+      it 'fails upon any non-ok route' do
+        expect do
           subject.routes_for! origin_1
-        }.to raise_error GoogleDistanceMatrix::InvalidRoute
+        end.to raise_error GoogleDistanceMatrix::InvalidRoute
       end
     end
 
-
-    describe "#route_for" do
-      it "returns route" do
+    describe '#route_for' do
+      it 'returns route' do
         route = subject.route_for origin: origin_1, destination: destination_2
         expect(route.origin).to eq origin_1
         expect(route.destination).to eq destination_2
       end
     end
 
-    describe "#route_for!" do
-      it "fails upon non-ok route" do
-        expect {
+    describe '#route_for!' do
+      it 'fails upon non-ok route' do
+        expect do
           subject.route_for! origin: origin_1, destination: destination_2
-        }.to raise_error GoogleDistanceMatrix::InvalidRoute
+        end.to raise_error GoogleDistanceMatrix::InvalidRoute
       end
     end
 
-
-    describe "#shortest_route_by_distance_to" do
-      it "returns route representing shortest distance to given origin" do
+    describe '#shortest_route_by_distance_to' do
+      it 'returns route representing shortest distance to given origin' do
         expect(subject.shortest_route_by_distance_to(origin_1)).to eq matrix.data[0][0]
       end
     end
 
-    describe "#shortest_route_by_distance_to!" do
-      it "fails upon non-ok route" do
-        expect { subject.shortest_route_by_distance_to!(origin_1) }.to raise_error GoogleDistanceMatrix::InvalidRoute
+    describe '#shortest_route_by_distance_to!' do
+      it 'fails upon non-ok route' do
+        expect { subject.shortest_route_by_distance_to!(origin_1) }
+          .to raise_error GoogleDistanceMatrix::InvalidRoute
       end
     end
 
-    describe "#shortest_route_by_duration_to" do
-      it "returns route representing shortest distance to given origin" do
+    describe '#shortest_route_by_duration_to' do
+      it 'returns route representing shortest distance to given origin' do
         expect(subject.shortest_route_by_duration_to(origin_1)).to eq matrix.data[0][0]
       end
     end
 
-    describe "#shortest_route_by_duration_to!" do
-      it "fails upon non-ok route" do
-        expect { subject.shortest_route_by_duration_to!(origin_1) }.to raise_error GoogleDistanceMatrix::InvalidRoute
+    describe '#shortest_route_by_duration_to!' do
+      it 'fails upon non-ok route' do
+        expect { subject.shortest_route_by_duration_to!(origin_1) }
+          .to raise_error GoogleDistanceMatrix::InvalidRoute
       end
     end
   end