google_currency_convert 0.0.3 → 0.0.4

data/README.md

@@ -1,13 +1,13 @@
-# google currency convert
+# Google currency convert
 currency convert by google finance [API](https://www.google.com/finance/converter)
 
-###Install
+### Install
 
 ```
 gem install google_currency_convert
 ```
 
-###get currency code and country info
+### Get currency code and country info
 
 ```
 GoogleCurrencyConvert.currency_info
@@ -22,7 +22,7 @@ GoogleCurrencyConvert.currency_info.select { |i| i.include?("Jap")}
 
 => ["JPY Japanese Yen (¥)"]
 ```
-###only get currency codes
+### Only get currency codes
 
 ```
 GoogleCurrencyConvert.currency_codes
@@ -30,7 +30,7 @@ GoogleCurrencyConvert.currency_codes
 => ["AED", "AFN", "ALL", "AMD", "ANG", "AOA", "ARS", "AUD", "AWG", "AZN", "BAM", "BBD", "BDT", "BGN", "BHD", "BIF", "BMD", "BND", "BOB", "BRL", "BSD", "BTC", "BTN", "BWP", "BYR", "BZD", "CAD", "CDF", "CHF", "CLF", "CLP", "CNH", "CNY", "COP", "CRC", "CUP", "CVE", "CZK", "DEM", "DJF", "DKK", "DOP", "DZD", "EGP", "ERN", "ETB", "EUR", "FIM", "FJD", "FKP", "FRF", "GBP", "GEL", "GHS", "GIP", "GMD", "GNF", "GTQ", "GYD", "HKD", "HNL", "HRK", "HTG", "HUF", "IDR", "IEP", "ILS", "INR", "IQD", "IRR", "ISK", "ITL", "JMD", "JOD", "JPY", "KES", "KGS", "KHR", "KMF", "KPW", "KRW", "KWD", "KYD", "KZT", "LAK", "LBP", "LKR", "LRD", "LSL", "LTL", "LVL", "LYD", "MAD", "MDL", "MGA", "MKD", "MMK", "MNT", "MOP", "MRO", "MUR", "MVR", "MWK", "MXN", "MYR", "MZN", "NAD", "NGN", "NIO", "NOK", "NPR", "NZD", "OMR", "PAB", "PEN", "PGK", "PHP", "PKG", "PKR", "PLN", "PYG", "QAR", "RON", "RSD", "RUB", "RWF", "SAR", "SBD", "SCR", "SDG", "SEK", "SGD", "SHP", "SLL", "SOS", "SRD", "STD", "SVC", "SYP", "SZL", "THB", "TJS", "TMT", "TND", "TOP", "TRY", "TTD", "TWD", "TZS", "UAH", "UGX", "USD", "UYU", "UZS", "VEF", "VND", "VUV", "WST", "XAF", "XCD", "XDR", "XOF", "XPF", "YER", "ZAR", "ZMK", "ZMW", "ZWL"]
 ```
 
-###currency convert
+### Currency convert
 
 The amount parameter has the default value, so if don't pass the amount, you will get the
 currency rate.
@@ -44,4 +44,20 @@ Convert US Dollar to Chinese Yuan, for example:
 ```
 GoogleCurrencyConvert.currency_convert("USD", "CNY")
 => 6.2092
+```
+
+### Run Test
+
+```
+Rspec test --format d
+
+GoogleCurrencyConvert
+  currency info is a non-empty array
+  currency codes a non-empty array
+  return error if the currency code is invalid
+  return error if the currency amount is not a positive integer
+  get a float if the code and maount are right
+
+Finished in 3.1 seconds (files took 0.32152 seconds to load)
+5 examples, 0 failures
 ```

data/lib/google_currency_convert.rb

@@ -1,8 +1,12 @@
-require 'net/http'
 require 'nokogiri'
+require_relative './http_method.rb'
 
 class GoogleCurrencyConvert
 
+	extend HttpMethod
+
+	URL = "https://www.google.com/finance/converter"
+
 	def self.currency_info
 		unless @info
 			@info = []
@@ -13,21 +17,18 @@ class GoogleCurrencyConvert
 	end
 
 	def self.currency_codes
-		@info ||= currency_info
-		@info.map { |i| i.split(' ')[0] }
+		(@info ||= currency_info).map { |i| i.split(' ')[0] }
 	end
 
 	def self.currency_convert(from, to, amount = 1)
 		if not currency_codes.include?(from) or not currency_codes.include?(to)
 			return "Error: cannot support such currency code"
 		end
-
 		return "Error: amount must be a positive integer" if amount <= 0 or amount.class != Fixnum
 
-    host = "www.google.com"
-    http = Net::HTTP.new(host, 80)
-    url = "/finance/converter?a=#{amount}&from=#{from}&to=#{to}"
-    response = http.get(url)
+    params = {from: from, to: to, a: amount}
+    response = https_get(URL, params)
+    return "connect google finance failed" unless response.code == '200'
 
     doc = Nokogiri::HTML(response.body)
     result = doc.css('div#currency_converter_result').first.text

data/lib/http_method.rb

@@ -0,0 +1,14 @@
+require 'net/http'
+
+module HttpMethod
+
+	def https_get(url, params)
+		uri = URI(url)
+		uri.query = URI.encode_www_form(params)
+		http = Net::HTTP.new(uri.host, uri.port)
+    http.use_ssl = true
+    request = Net::HTTP::Get.new(uri.request_uri)
+    response = http.request(request)
+	end
+
+end

data/test/google_currency_convert_spec.rb

@@ -1,4 +1,5 @@
 require_relative '../lib/google_currency_convert.rb'
+require_relative '../lib/http_method.rb'
 
 RSpec.describe GoogleCurrencyConvert do
 	it "currency info is a non-empty array" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google_currency_convert
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-09 00:00:00.000000000 Z
+date: 2015-07-16 00:00:00.000000000 Z
 dependencies: []
 description: Google currency convert by google finance API (https://github.com/liuzxc/google_currency_convert)
 email: lxq_102172@163.com
@@ -17,8 +17,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/google_currency_convert.rb
 - lib/curr_code.csv
+- lib/google_currency_convert.rb
+- lib/http_method.rb
 - test/google_currency_convert_spec.rb
 - README.md
 homepage: http://rubygems.org/gems/google_currency_convert