google_contacts_api 0.5.0 → 0.5.1

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/google_contacts_api.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "google_contacts_api"
-  s.version = "0.5.0"
+  s.version = "0.5.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alvin Liang"]
-  s.date = "2014-09-27"
+  s.date = "2015-05-07"
   s.description = "Lets you read from the Google Contacts API. Posting to come later."
   s.email = "ayliang@gmail.com"
   s.extra_rdoc_files = [

data/lib/google_contacts_api/contact.rb

@@ -114,6 +114,8 @@ module GoogleContactsApi
     def relations
       self['gContact$relation'] ? self['gContact$relation'] : []
     end
+
+    # Returns the spouse of the contact. (Assumes there's only one.)
     def spouse
       spouse_rel = relations.find {|r| r.rel = 'spouse'}
       spouse_rel['$t'] if spouse_rel

data/lib/google_contacts_api/groups.rb

@@ -10,13 +10,7 @@ module GoogleContactsApi
       # orderby, showdeleted, requirealldeleted, sortorder
       params["max-results"] = 100000 unless params.key?("max-results")
 
-      # Set the version, for some reason the header is not effective on its own?
-      params["v"] = 2
-
       url = "groups/default/full"
-      # TODO: So weird thing, version 3 doesn't return system groups
-      # When it does, uncomment this line and use it to request instead
-      # response = @api.get(url, params)
       response = @api.get(url, params)
 
       case GoogleContactsApi::Api.parse_response_code(response)

data/lib/google_contacts_api/user.rb

@@ -18,7 +18,7 @@ module GoogleContactsApi
     def contacts!(params = {})
       # contacts in this group
       @contacts = nil
-      contacts
+      contacts(params)
     end
 
     # Return the groups for this user and cache them.
@@ -29,7 +29,7 @@ module GoogleContactsApi
     # Return the groups for this user, retrieving them again from the server.
     def groups!(params = {})
       @groups = nil
-      groups
+      groups(params)
     end
   end
-end
+end

data/spec/google_contacts_api_spec.rb

@@ -109,7 +109,7 @@ describe "GoogleContactsApi" do
     }
     describe ".get_groups" do
       it "should get the groups using the internal @api object" do
-        expect(api).to receive(:get).with("groups/default/full", hash_including(:v => 2)).and_return(Hashie::Mash.new({
+        expect(api).to receive(:get).with("groups/default/full", kind_of(Hash)).and_return(Hashie::Mash.new({
           "body" => "some response", # could use example response here
           "code" => 200
         }))
@@ -130,6 +130,22 @@ describe "GoogleContactsApi" do
         expect(user.groups).to eq("group set")
       end
     end
+    describe ".groups!" do
+      it "should be able to get groups" do
+        expect(user).to receive(:get_groups).and_return("group set")
+        expect(user.groups!).to eq("group set")
+      end
+      it "should pass query params along to get_groups" do
+        expect(user).to receive(:get_groups).with("something" => "important").and_return("group set")
+        expect(user.groups!("something" => "important")).to eq("group set")
+      end
+      it "should reload the groups" do
+        expect(user).to receive(:get_groups).and_return("group set").twice
+        user.groups
+        groups = user.groups!
+        expect(groups).to eq("group set")
+      end
+    end
     describe ".contacts" do
       it "should be able to get contacts" do
         expect(user).to receive(:get_contacts).and_return("contact set")
@@ -147,6 +163,10 @@ describe "GoogleContactsApi" do
         expect(user).to receive(:get_contacts).and_return("contact set")
         expect(user.contacts!).to eq("contact set")
       end
+      it "should pass query params along to get_contacts" do
+        expect(user).to receive(:get_contacts).with("something" => "important").and_return("contact set")
+        expect(user.contacts!("something" => "important")).to eq("contact set")
+      end
       it "should reload the contacts" do
         expect(user).to receive(:get_contacts).and_return("contact set").twice
         user.contacts

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google_contacts_api
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-27 00:00:00.000000000 Z
+date: 2015-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -236,7 +236,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1433605714673791610
+      hash: -2026181777139974429
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: