google_contacts_api 0.3.0 → 0.3.1

data/README.markdown

@@ -1,10 +1,10 @@
 # google_contacts_api
 
-An unofficial Google Contacts API for ruby. Might not be stable (but probably is). In active usage at [thirsst.com](http://thirsst.com/). (Shameless plug: We help you manage your RSS and group bookmarking!)
+An unofficial Google Contacts API for ruby. Might not be stable (but probably is).
 
 ## Usage
 
-You need to provide an OAuth client, with access token, from an OAuth access library to this library. I've tested it with OAuth::AccessToken from the [oauth-ruby](https://github.com/oauth/oauth-ruby) gem. I'm guessing there would be a few small changes in implementation details of the GoogleContactsApi::Api class if you use another library, mostly to change how the base get/post/put/delete methods work.
+You need to provide an OAuth client, with access token, from an OAuth access library to this library. I've tested it with OAuth::AccessToken from the [oauth-ruby](https://github.com/oauth/oauth-ruby) gem and an OAuth2::AccessToken from the [oauth2](https://github.com/intridea/oauth2) gem. I'm guessing there would be a few small changes in implementation details of the GoogleContactsApi::Api class if you use another library, mostly to change how the base get/post/put/delete methods work.
 
 Then you can instantiate a GoogleContactsApi::Api object for direct posting and parsing, or a
 GoogleContactsApi::User object for easier stuff.
@@ -37,10 +37,10 @@ I welcome patches and pull requests, see the guidelines below (handily auto-gene
 by jeweler).
 
 * Any missing tests! (using RSpec, please)
-* Read more contact information (structured name, address, phone, ...)
+* Read more contact information (structured name, address, ...)
 * Get single contacts and groups
 * Posting/putting/deleting groups, contacts and their photos. This might require XML?
-* Test other OAuth libraries ([oauth2](https://github.com/intridea/oauth2) is next on my list). Does Google support OAuth 2.0 for contacts?
+* Adapter layer for different OAuth libraries? I'm not sure there are any other widely used libraries though
 * Support ClientLogin (maybe not, since Google's old library covers it)
 
 ## Contributing to google_contacts_api
@@ -55,4 +55,6 @@ by jeweler).
 
 ## Copyright
 
-Copyright (c) 2011 Alvin Liang. See LICENSE.txt for further details.
+Copyright (c) 2011 Alvin Liang. See LICENSE.txt for further details.
+
+Some code based on a few bugfixes in lfittl and fraudpointer forks.

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.3.1

data/google_contacts_api.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "google_contacts_api"
-  s.version = "0.3.0"
+  s.version = "0.3.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alvin Liang"]

data/lib/google_contacts_api/user.rb

@@ -16,11 +16,15 @@ module GoogleContactsApi
       # alt, q, max-results, start-index, updated-min,
       # orderby, showdeleted, requirealldeleted, sortorder
       params["max-results"] = 100000 unless params.key?("max-results")
+
+      # Set the version, for some reason the header is not effective on its own?
+      params["v"] = 2
+
       url = "groups/default/full"
       # TODO: So weird thing, version 3 doesn't return system groups
       # When it does, uncomment this line and use it to request instead
       # response = @api.get(url, params)
-      response = @api.get(url, params, {"GData-Version" => "2"})
+      response = @api.get(url, params)
 
       case GoogleContactsApi::Api.parse_response_code(response)
       when 401; raise

data/spec/google_contacts_api_spec.rb

@@ -67,8 +67,8 @@ describe "GoogleContactsApi" do
       GoogleContactsApi::ContactSet.stub(:new).and_return("contact set")
     end
     # Should hit the right URLs and return the right stuff
-    it "should be able to get groups" do
-      @user.api.should_receive(:get).with("groups/default/full", anything, {"GData-Version" => "2"})
+    it "should be able to get groups including system groups" do
+      @user.api.should_receive(:get).with("groups/default/full", hash_including(v: 2))
       @user.groups.should == "group set"
     end
     it "should be able to get contacts" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google_contacts_api
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -217,7 +217,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4509345012049129477
+      hash: -3015739328210497821
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: