google_contacts_api 0.2.3 → 0.2.4

data/README.markdown

@@ -4,7 +4,8 @@ An unofficial Google Contacts API for ruby. Might not be stable (but probably is
 
 ## Usage
 
-You need to provide an OAuth access token from one of the major OAuth libraries to this library.
+You need to provide an OAuth client, with access token, from an OAuth access library to this library. I've tested it with OAuth::AccessToken from the [oauth-ruby](https://github.com/oauth/oauth-ruby) gem. I'm guessing there would be a few small changes in implementation details of the GoogleContactsApi::Api class if you use another library, mostly to change how the base get/post/put/delete methods work.
+
 Then you can instantiate a GoogleContactsApi::Api object for direct posting and parsing, or a
 GoogleContactsApi::User object for easier stuff.
 
@@ -28,6 +29,8 @@ contact.emails
 
 In addition, Contacts and Groups are subclasses of [Hashie::Mash](https://github.com/intridea/hashie), so you can access any of the underlying data directly. Note that data is retrieved using Google's JSON API so the equivalent content of an XML element from the XML API is stored under the key "$t".
 
+The easiest way to see the convenience methods I've provided is to look at the RSpec tests.
+
 ## TODO
 
 I welcome patches and pull requests, see the guidelines below (handily auto-generated
@@ -37,7 +40,8 @@ by jeweler).
 * Read more contact information (structured name, address, phone, ...)
 * Get single contacts and groups
 * Posting/putting/deleting groups, contacts and their photos. This might require XML?
-* Support ClientLogin
+* Test other OAuth libraries ([oauth2](https://github.com/intridea/oauth2) is next on my list). Does Google support OAuth 2.0 for contacts?
+* Support ClientLogin (maybe not, since Google's old library covers it)
 
 ## Contributing to google_contacts_api
  

data/VERSION

@@ -1 +1 @@
-0.2.3
+0.2.4

data/google_contacts_api.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{google_contacts_api}
-  s.version = "0.2.3"
+  s.version = "0.2.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alvin Liang"]
-  s.date = %q{2011-07-09}
+  s.date = %q{2011-07-12}
   s.description = %q{Lets you read from the Google Contacts API. Posting to come later. Tests to come later.}
   s.email = %q{ayliang@gmail.com}
   s.extra_rdoc_files = [

data/lib/google_contacts_api/contact.rb

@@ -60,13 +60,17 @@ module GoogleContactsApi
     
     # Returns all email addresses for the contact
     def emails
-      self["gd$email"].map { |e| e.address }
+      self["gd$email"] ? self["gd$email"].map { |e| e.address } : []
     end
     
     # Returns primary email for the contact
     def primary_email
-      _email = self["gd$email"].find { |e| e.primary == "true" }
-      _email ? _email.address : nil
+      if self["gd$email"]
+        _email = self["gd$email"].find { |e| e.primary == "true" }
+        _email ? _email.address : nil
+      else
+        nil # no emails at all
+      end
     end
   end
 end

data/spec/contact_set.json

@@ -147,11 +147,6 @@
                 "rel": "edit",
                 "type": "application/atom+xml",
                 "href": "https://www.google.com/m8/feeds/contacts/example%40gmail.com/full/1"
-            }],
-            "gd$email": [{
-                "rel": "http://schemas.google.com/g/2005#other",
-                "address": "contact2@example.com",
-                "primary": "true"
             }]
         },
         {
@@ -190,8 +185,7 @@
             }],
             "gd$email": [{
                 "rel": "http://schemas.google.com/g/2005#other",
-                "address": "contact3@example.com",
-                "primary": "true"
+                "address": "contact3@example.com"
             }]
         },
         {

data/spec/google_contacts_api_spec.rb

@@ -154,6 +154,16 @@ describe "GoogleContactsApi" do
     it "should return the right primary e-mail address" do
       @contact.primary_email.should == "contact1@example.com"
     end
+    it "should return an empty array if there are no e-mail addresses" do
+      @contact = contact_no_emails_json_hash
+      @contact.emails.should == []
+    end
+    it "should return nil if there is no primary e-mail address" do
+      @contact2 = contact_no_emails_json_hash
+      @contact2.primary_email.should be_nil
+      @contact3 = contact_no_primary_email_json_hash
+      @contact3.primary_email.should be_nil
+    end
   end
   
   describe "Group" do

data/spec/spec_helper.rb

@@ -31,6 +31,14 @@ def contact_json_hash
   Hashie::Mash.new(JSON.parse(contact_set_json)).feed.entry.first
 end
 
+def contact_no_emails_json_hash
+  Hashie::Mash.new(JSON.parse(contact_set_json)).feed.entry[1]
+end
+
+def contact_no_primary_email_json_hash
+  Hashie::Mash.new(JSON.parse(contact_set_json)).feed.entry[2]
+end
+
 def group_json_hash
   Hashie::Mash.new(JSON.parse(group_set_json)).feed.entry.first
 end

metadata

@@ -2,7 +2,7 @@
 name: google_contacts_api
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors: 
 - Alvin Liang
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-09 00:00:00 -04:00
+date: 2011-07-12 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -157,7 +157,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 2324905511123203107
+      hash: -2760858629422999937
       segments: 
       - 0
       version: "0"