google-style 1.25.0 → 1.25.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e954fc240902e4faacb8fcdb6e4d40cd2b910e36408e73cc25cdf9010c2a7b10
-  data.tar.gz: 58e410551ca3077977df5eed54c089e2a80e28482e6e9f07abf76e02594e67bc
+  metadata.gz: 1d63fa1f076e05ed7cde6660545ad129a071e4b5ab733f466a1095185e2445ec
+  data.tar.gz: 957c6b7a2ae2cbefdf53b609117a9d33c6e7fb1c2b9bf891918b3c3472ee541a
 SHA512:
-  metadata.gz: a04d43f1bffbe7cb7edfb7a26039a95121c5aced3557a5fc233a3cdd37f4d673c577e69d3e8299a72fcd51fbb89aaf65621b91430f5e0668253ddbcd8f7af81f
-  data.tar.gz: 46b22449cc84c46c005cc6b72e9a498a85e51e7b0f6aa54be308f2b186e8d659bfe04951cd3980a5a4e0b1b8f25a2e8786b891e1f05d21c6234b4f4d6e6858fe
+  metadata.gz: 3aa1169d288734527a11ce696d0a0e6ff5356975ebf94a651cb07bf9d417d54202a5c7deb844a476b252086aeba8ff9fab29f5b508ea87da400843c4408fce6d
+  data.tar.gz: 9c42c3e98454732f66674635d2ecf26efec565bbdf811be3869e4c4ecf0e9214eef9a512cdae3e4f40809eec63e0abf6372ef168dc6d8099d0b18ab350b13169

data/README.md

@@ -45,13 +45,13 @@ For all `1.x.x` gem versions:
 
 Contributions to this library are always welcome and highly encouraged.
 
-See the [Contributing
-Guide](CONTRIBUTING.md)
+See the {file:CONTRIBUTING.md Contributing
+Guide}
 for more information on how to get started.
 
 Please note that this project is released with a Contributor Code of Conduct. By
-participating in this project you agree to abide by its terms. See the [Code of
-Conduct](CODE_OF_CONDUCT.md)
+participating in this project you agree to abide by its terms. See the {file:CODE_OF_CONDUCT.md Code of
+Conduct}
 for more information.
 
 ## License

data/google-style.yml

@@ -1,11 +1,11 @@
 # Copyright 2019 Google LLC
-
+#
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-
+#
 #     https://www.apache.org/licenses/LICENSE-2.0
-
+#
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -13,93 +13,225 @@
 # limitations under the License.
 
 AllCops:
-  SuggestExtensions: true
+  NewCops: disable
+  SuggestExtensions: false
   TargetRubyVersion: 2.5
 
+# Enforcing a blank line often worsens vertical layout.
 Layout/EmptyLineAfterGuardClause:
   Enabled: false
-Layout/EmptyLines: # for the extra line between copyright and code
+
+# For the extra line between copyright and code.
+Layout/EmptyLines:
   Enabled: false
+
+# This tends to be problematic, especially for nested hashes. In many cases,
+# our code adheres to the "table" style, but we do not want to enforce it.
 Layout/HashAlignment:
-  EnforcedColonStyle: table
-  EnforcedHashRocketStyle: table
+  Enabled: false
+
+# Our current preferred line length.
 Layout/LineLength:
   Max: 120
+
+# Added in Rubocop 1.7
 Layout/SpaceBeforeBrackets:
   Enabled: true
+
+# Added in Rubocop 1.7
 Lint/AmbiguousAssignment:
   Enabled: true
+
+# Added in Rubocop 1.8
 Lint/DeprecatedConstants:
   Enabled: true
+
+# Added in Rubocop 1.3
 Lint/DuplicateBranch:
   Enabled: true
+
+# Added in Rubocop 1.1
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
+
+# Added in Rubocop 1.1
 Lint/EmptyBlock:
   Enabled: true
+
+# Added in Rubocop 1.3
 Lint/EmptyClass:
   Enabled: true
+
+# Added in Rubocop 1.8
 Lint/LambdaWithoutLiteralBlock:
   Enabled: true
+
+# Added in Rubocop 1.2
 Lint/NoReturnInBeginEndBlocks:
   Enabled: true
+
+# Added in Rubocop 1.9
+Lint/NumberedParameterAssignment:
+  Enabled: true
+
+# Added in Rubocop 1.9
+Lint/OrAssignmentToConstant:
+  Enabled: true
+
+# Added in Rubocop 1.8
 Lint/RedundantDirGlobSort:
   Enabled: true
+
+# Added in Rubocop 1.9
+Lint/SymbolConversion:
+  Enabled: true
+
+# Added in Rubocop 1.1
 Lint/ToEnumArguments:
   Enabled: true
+
+# Added in Rubocop 1.9
+Lint/TripleQuotes:
+  Enabled: true
+
+# Added in Rubocop 1.5
 Lint/UnexpectedBlockArity:
   Enabled: true
+
+# Added in Rubocop 1.1
 Lint/UnmodifiedReduceAccumulator:
   Enabled: true
+
 Metrics/AbcSize:
   Max: 30
+
 Metrics/CyclomaticComplexity:
   Max: 10
+
 Metrics/MethodLength:
   Max: 25
+
+# Sometimes problematic for API calls which might have a lot of parameters,
+# and for generated code.
 Metrics/ParameterLists:
   Enabled: false
+
 Metrics/PerceivedComplexity:
   Max: 10
+
+# Does not allow distinguishing verbs (e.g. is vs has). Also causes problems
+# for generated code that might have generated method names.
+Naming/PredicateName:
+  Enabled: false
+
+# Numbers are occasionally semantically useful in names, and also occasionally
+# appear in generated code.
 Naming/VariableNumber:
   Enabled: false
+
+# Better to separate accessors for yardoc and type declarations.
+Style/AccessorGrouping:
+  EnforcedStyle: separated
+
+# Added in Rubocop 1.1
 Style/ArgumentsForwarding:
   Enabled: true
+
+# Problematic for generated code which might include unicode in comments.
+Style/AsciiComments:
+  Enabled: false
+
+# There are cases where we use the === operator as a general interface, e.g.
+# when specifying type checker objects.
+Style/CaseEquality:
+  Enabled: false
+
+# Added in Rubocop 1.2
 Style/CollectionCompact:
   Enabled: true
+
+# Added in Rubocop 1.1
 Style/DocumentDynamicEvalDefinition:
   Enabled: true
+
+# We prefer consistent method indentation.
 Style/EmptyMethod:
   EnforcedStyle: expanded
+
+# Added in Rubocop 1.8
 Style/EndlessMethod:
   Enabled: true
+
+# Frozen string literals are no more as of Ruby 3.
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+# Added in Rubocop 1.7
 Style/HashExcept:
   Enabled: true
+
+# It is sometimes preferable to use the non-modifier form even for single-line
+# expressions, for readability.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Added in Rubocop 1.9
+Style/IfWithBooleanLiteralBranches:
+  Enabled: true
+
+# We adopt Seattle-style paren usage
 Style/MethodCallWithArgsParentheses:
   AllowParenthesesInCamelCaseMethod: true
   AllowParenthesesInChaining: true
   AllowParenthesesInMultilineCall: true
   Enabled: true
   EnforcedStyle: omit_parentheses
+
+# We adopt Seattle-style paren usage
 Style/MethodDefParentheses:
   EnforcedStyle: require_no_parentheses
+
+# Enable use of the different semantics of module_function and extend self.
+Style/ModuleFunction:
+  Enabled: false
+
+# Added in Rubocop 1.2
 Style/NegatedIfElseCondition:
   Enabled: true
+
+# Added in Rubocop 1.3
 Style/NilLambda:
   Enabled: true
+
+# Added in Rubocop 1.4
 Style/RedundantArgument:
   Enabled: true
+
+# Disabled because we prefer to keep begin-end blocks in memoization for
+# readability (see https://github.com/rubocop/rubocop/pull/9602).
+Style/RedundantBegin:
+  Enabled: false
+
+# The idiom is useful in a variety of cases. We prefer to allow it.
 Style/RescueModifier:
   Enabled: false
+
+# We prefer standardizing on double-quoted strings for readability.
 Style/StringLiterals:
   EnforcedStyle: double_quotes
+
+# Added in Rubocop 1.1
 Style/SwapValues:
   Enabled: true
+
+# We prefer traditional bracket style for all arrays.
 Style/SymbolArray:
   EnforcedStyle: brackets
+
+# There are some cases where a full method shows intent better than an attr.
 Style/TrivialAccessors:
   Enabled: false
+
+# We prefer traditional bracket style for all arrays.
 Style/WordArray:
   EnforcedStyle: brackets

data/lib/google/style/version.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+# Copyright 2021 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+module Google
+  module Style
+    VERSION = "1.25.3"
+  end
+end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: google-style
 version: !ruby/object:Gem::Version
-  version: 1.25.0
+  version: 1.25.3
 platform: ruby
 authors:
+- Daniel Azuma
 - Graham Paye
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-28 00:00:00.000000000 Z
+date: 2022-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 1.28.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 1.28.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -54,6 +55,7 @@ dependencies:
         version: '12.3'
 description: Shared style guide for Google's ruby projects
 email:
+- dazuma@google.com
 - paye@google.com
 executables: []
 extensions: []
@@ -64,7 +66,8 @@ files:
 - LICENSE
 - README.md
 - google-style.yml
-homepage: https://github.com/googleapis/ruby-style/tree/master/
+- lib/google/style/version.rb
+homepage: https://github.com/googleapis/ruby-style/
 licenses:
 - Apache-2.0
 metadata: {}
@@ -83,8 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.3.5
 signing_key: 
 specification_version: 4
 summary: Collection of rubocop rules