google-style 0.2.0 → 1.25.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e3ddb8aebd0e652f439e901bcb0c9634670edaff3500d3cf6272a955816902d
-  data.tar.gz: 12c7ebab7e6ae32c5941d6d769154ae29163d9c645d71a83ebfaf2a97110dba9
+  metadata.gz: c8b6fc152c4c0d78c5e933d64a1a9b5fd355aaa18f9e889efe073994b75a4379
+  data.tar.gz: e3e0dbcdfd7beb63b8201d1083c3bbad01a0c46069edbe23ed0e0247e356857b
 SHA512:
-  metadata.gz: bbf3c681e41933290d66d84ac17c3b1b915117a11a6a4558b6ecdf3456ea2d9409e5b7725e81b904956c4b52f84788588f3618acf9168f7cd5b1c1c1f3fc5113
-  data.tar.gz: 03e8bb2b061d4a6592754bcdbb229f009cb812bc052782b93274df0e3ce91bc5670e07a2152460e9950d83fc5d4fd899093caa13d9dfb290e4434bb49349e004
+  metadata.gz: 36145174df5f7281ac6d953b806a55d9ac3422ce2a5f66ea9b5e64e93dfa30dc0e61d8386d118231d055a49731fa7ae186b3ed0be3e106de97c0fdf8217fd4d7
+  data.tar.gz: 976ea6551cd0d27b8b6cc412fd5d7920667181f6569698206f78225fef423690ca65b8aa913e0a39405e06b4327aa149e208705d61c8e701f009ad3eeb503fe0

data/README.md

@@ -31,6 +31,16 @@ And run:
 bundle exec rubocop
 ```
 
+## Versioning
+
+For all `1.x.x` gem versions:
+
+- The target and required Ruby version will match the minor gem version. `1.24.0` targets Ruby 2.4. When `1.25.0` is released, it will target Ruby 2.5, and `1.30.0` will target Ruby 3.0.
+
+- During a minor version bump, the rubocop dependency will be updated to the latest version.
+
+- For these reasons, it is highly recommended that dependencies specify at least a specific minor version of this gem.
+
 ## Contributing
 
 Contributions to this library are always welcome and highly encouraged.
@@ -51,11 +61,12 @@ This library is licensed under Apache 2.0. Full license text is available in
 
 ## Supported Ruby Versions
 
-These libraries are currently supported on Ruby 2.3+.
+These libraries are currently supported on Ruby 2.4+.
 
 Google provides official support for Ruby versions that are actively supported
 by Ruby Core—that is, Ruby versions that are either in normal maintenance or
-in security maintenance, and not end of life. Currently, this means Ruby 2.3
-and later. Older versions of Ruby _may_ still work, but are unsupported and not
-recommended. See https://www.ruby-lang.org/en/downloads/branches/ for details
-about the Ruby support schedule.
+in security maintenance, and not end of life. Currently, this means Ruby 2.4
+and later. Starting with Ruby 2.4, minor releases of the google-style gem under
+`1.x.x` will correspond with the required Ruby version, with `1.24.x` requiring
+Ruby 2.4.
+See https://www.ruby-lang.org/en/downloads/branches/ for details about the Ruby support schedule.

data/google-style.yml

@@ -1,11 +1,11 @@
 # Copyright 2019 Google LLC
-
+#
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-
+#
 #     https://www.apache.org/licenses/LICENSE-2.0
-
+#
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -13,40 +13,220 @@
 # limitations under the License.
 
 AllCops:
-  TargetRubyVersion: 2.3
-Layout/AlignHash:
-  EnforcedHashRocketStyle: table
-  EnforcedColonStyle: table
+  NewCops: disable
+  SuggestExtensions: false
+  TargetRubyVersion: 2.5
+
+# Enforcing a blank line often worsens vertical layout.
 Layout/EmptyLineAfterGuardClause:
   Enabled: false
-Layout/EmptyLines: # for the extra line between copyright and code
+
+# For the extra line between copyright and code.
+Layout/EmptyLines:
+  Enabled: false
+
+# This tends to be problematic, especially for nested hashes. In many cases,
+# our code adheres to the "table" style, but we do not want to enforce it.
+Layout/HashAlignment:
   Enabled: false
+
+# Our current preferred line length.
+Layout/LineLength:
+  Max: 120
+
+# Added in Rubocop 1.7
+Layout/SpaceBeforeBrackets:
+  Enabled: true
+
+# Added in Rubocop 1.7
+Lint/AmbiguousAssignment:
+  Enabled: true
+
+# Added in Rubocop 1.8
+Lint/DeprecatedConstants:
+  Enabled: true
+
+# Added in Rubocop 1.3
+Lint/DuplicateBranch:
+  Enabled: true
+
+# Added in Rubocop 1.1
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
+# Added in Rubocop 1.1
+Lint/EmptyBlock:
+  Enabled: true
+
+# Added in Rubocop 1.3
+Lint/EmptyClass:
+  Enabled: true
+
+# Added in Rubocop 1.8
+Lint/LambdaWithoutLiteralBlock:
+  Enabled: true
+
+# Added in Rubocop 1.2
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
+
+# Added in Rubocop 1.9
+Lint/NumberedParameterAssignment:
+  Enabled: true
+
+# Added in Rubocop 1.9
+Lint/OrAssignmentToConstant:
+  Enabled: true
+
+# Added in Rubocop 1.8
+Lint/RedundantDirGlobSort:
+  Enabled: true
+
+# Added in Rubocop 1.9
+Lint/SymbolConversion:
+  Enabled: true
+
+# Added in Rubocop 1.1
+Lint/ToEnumArguments:
+  Enabled: true
+
+# Added in Rubocop 1.9
+Lint/TripleQuotes:
+  Enabled: true
+
+# Added in Rubocop 1.5
+Lint/UnexpectedBlockArity:
+  Enabled: true
+
+# Added in Rubocop 1.1
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+
 Metrics/AbcSize:
   Max: 30
+
 Metrics/CyclomaticComplexity:
   Max: 10
-Metrics/LineLength:
-  Max: 120
+
 Metrics/MethodLength:
   Max: 25
+
+# Sometimes problematic for API calls which might have a lot of parameters,
+# and for generated code.
 Metrics/ParameterLists:
   Enabled: false
+
 Metrics/PerceivedComplexity:
   Max: 10
+
+# Does not allow distinguishing verbs (e.g. is vs has). Also causes problems
+# for generated code that might have generated method names.
+Naming/PredicateName:
+  Enabled: false
+
+# Numbers are occasionally semantically useful in names, and also occasionally
+# appear in generated code.
 Naming/VariableNumber:
   Enabled: false
+
+# Better to separate accessors for yardoc and type declarations.
+Style/AccessorGrouping:
+  EnforcedStyle: separated
+
+# Added in Rubocop 1.1
+Style/ArgumentsForwarding:
+  Enabled: true
+
+# Problematic for generated code which might include unicode in comments.
+Style/AsciiComments:
+  Enabled: false
+
+# There are cases where we use the === operator as a general interface, e.g.
+# when specifying type checker objects.
+Style/CaseEquality:
+  Enabled: false
+
+# Added in Rubocop 1.2
+Style/CollectionCompact:
+  Enabled: true
+
+# Added in Rubocop 1.1
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
+
+# We prefer consistent method indentation.
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+# Added in Rubocop 1.8
+Style/EndlessMethod:
+  Enabled: true
+
+# Frozen string literals are no more as of Ruby 3.
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+# Added in Rubocop 1.7
+Style/HashExcept:
+  Enabled: true
+
+# It is sometimes preferable to use the non-modifier form even for single-line
+# expressions, for readability.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Added in Rubocop 1.9
+Style/IfWithBooleanLiteralBranches:
+  Enabled: true
+
+# We adopt Seattle-style paren usage
 Style/MethodCallWithArgsParentheses:
+  AllowParenthesesInCamelCaseMethod: true
+  AllowParenthesesInChaining: true
+  AllowParenthesesInMultilineCall: true
   Enabled: true
   EnforcedStyle: omit_parentheses
-  AllowParenthesesInMultilineCall: true
-  AllowParenthesesInCamelCaseMethod: true
+
+# We adopt Seattle-style paren usage
 Style/MethodDefParentheses:
   EnforcedStyle: require_no_parentheses
+
+# Enable use of the different semantics of module_function and extend self.
+Style/ModuleFunction:
+  Enabled: false
+
+# Added in Rubocop 1.2
+Style/NegatedIfElseCondition:
+  Enabled: true
+
+# Added in Rubocop 1.3
+Style/NilLambda:
+  Enabled: true
+
+# Added in Rubocop 1.4
+Style/RedundantArgument:
+  Enabled: true
+
+# The idiom is useful in a variety of cases. We prefer to allow it.
 Style/RescueModifier:
   Enabled: false
+
+# We prefer standardizing on double-quoted strings for readability.
 Style/StringLiterals:
   EnforcedStyle: double_quotes
+
+# Added in Rubocop 1.1
+Style/SwapValues:
+  Enabled: true
+
+# We prefer traditional bracket style for all arrays.
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# There are some cases where a full method shows intent better than an attr.
 Style/TrivialAccessors:
   Enabled: false
+
+# We prefer traditional bracket style for all arrays.
+Style/WordArray:
+  EnforcedStyle: brackets

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-style
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.25.1
 platform: ruby
 authors:
 - Graham Paye
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-14 00:00:00.000000000 Z
+date: 2021-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.64.0
+        version: '1.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.64.0
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -76,14 +76,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Collection of rubocop rules