google-protobuf 3.16.0 → 3.21.12

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of google-protobuf might be problematic. Click here for more details.

Files changed (34) hide show
  1. checksums.yaml +4 -4
  2. data/ext/google/protobuf_c/convert.c +128 -116
  3. data/ext/google/protobuf_c/convert.h +12 -9
  4. data/ext/google/protobuf_c/defs.c +217 -1521
  5. data/ext/google/protobuf_c/defs.h +19 -19
  6. data/ext/google/protobuf_c/extconf.rb +11 -3
  7. data/ext/google/protobuf_c/map.c +115 -102
  8. data/ext/google/protobuf_c/map.h +7 -7
  9. data/ext/google/protobuf_c/message.c +399 -308
  10. data/ext/google/protobuf_c/message.h +22 -19
  11. data/ext/google/protobuf_c/protobuf.c +89 -63
  12. data/ext/google/protobuf_c/protobuf.h +16 -9
  13. data/ext/google/protobuf_c/repeated_field.c +85 -85
  14. data/ext/google/protobuf_c/repeated_field.h +6 -5
  15. data/ext/google/protobuf_c/ruby-upb.c +10664 -7049
  16. data/ext/google/protobuf_c/ruby-upb.h +4378 -2489
  17. data/ext/google/protobuf_c/third_party/utf8_range/LICENSE +21 -0
  18. data/ext/google/protobuf_c/third_party/utf8_range/naive.c +92 -0
  19. data/ext/google/protobuf_c/third_party/utf8_range/range2-neon.c +157 -0
  20. data/ext/google/protobuf_c/third_party/utf8_range/range2-sse.c +170 -0
  21. data/ext/google/protobuf_c/third_party/utf8_range/utf8_range.h +9 -0
  22. data/ext/google/protobuf_c/wrap_memcpy.c +4 -3
  23. data/lib/google/protobuf/api_pb.rb +1 -0
  24. data/lib/google/protobuf/descriptor_dsl.rb +465 -0
  25. data/lib/google/protobuf/descriptor_pb.rb +269 -0
  26. data/lib/google/protobuf/message_exts.rb +2 -2
  27. data/lib/google/protobuf/repeated_field.rb +15 -2
  28. data/lib/google/protobuf/type_pb.rb +1 -0
  29. data/lib/google/protobuf/well_known_types.rb +12 -2
  30. data/lib/google/protobuf.rb +5 -73
  31. data/tests/basic.rb +144 -9
  32. data/tests/stress.rb +1 -1
  33. metadata +15 -29
  34. data/ext/google/protobuf_c/third_party/wyhash/wyhash.h +0 -145
@@ -35,13 +35,12 @@
35
35
  #include "map.h"
36
36
  #include "protobuf.h"
37
37
  #include "repeated_field.h"
38
- #include "third_party/wyhash/wyhash.h"
39
38
 
40
39
  static VALUE cParseError = Qnil;
41
40
  static ID descriptor_instancevar_interned;
42
41
 
43
42
  static VALUE initialize_rb_class_with_no_args(VALUE klass) {
44
- return rb_funcall(klass, rb_intern("new"), 0);
43
+ return rb_funcall(klass, rb_intern("new"), 0);
45
44
  }
46
45
 
47
46
  VALUE MessageOrEnum_GetDescriptor(VALUE klass) {
@@ -54,19 +53,20 @@ VALUE MessageOrEnum_GetDescriptor(VALUE klass) {
54
53
 
55
54
  typedef struct {
56
55
  VALUE arena;
57
- const upb_msg* msg; // Can get as mutable when non-frozen.
58
- const upb_msgdef* msgdef; // kept alive by self.class.descriptor reference.
56
+ const upb_Message* msg; // Can get as mutable when non-frozen.
57
+ const upb_MessageDef*
58
+ msgdef; // kept alive by self.class.descriptor reference.
59
59
  } Message;
60
60
 
61
61
  static void Message_mark(void* _self) {
62
- Message* self = (Message *)_self;
62
+ Message* self = (Message*)_self;
63
63
  rb_gc_mark(self->arena);
64
64
  }
65
65
 
66
66
  static rb_data_type_t Message_type = {
67
- "Message",
68
- { Message_mark, RUBY_DEFAULT_FREE, NULL },
69
- .flags = RUBY_TYPED_FREE_IMMEDIATELY,
67
+ "Message",
68
+ {Message_mark, RUBY_DEFAULT_FREE, NULL},
69
+ .flags = RUBY_TYPED_FREE_IMMEDIATELY,
70
70
  };
71
71
 
72
72
  static Message* ruby_to_Message(VALUE msg_rb) {
@@ -90,18 +90,18 @@ static VALUE Message_alloc(VALUE klass) {
90
90
  return ret;
91
91
  }
92
92
 
93
- const upb_msg *Message_Get(VALUE msg_rb, const upb_msgdef **m) {
93
+ const upb_Message* Message_Get(VALUE msg_rb, const upb_MessageDef** m) {
94
94
  Message* msg = ruby_to_Message(msg_rb);
95
95
  if (m) *m = msg->msgdef;
96
96
  return msg->msg;
97
97
  }
98
98
 
99
- upb_msg *Message_GetMutable(VALUE msg_rb, const upb_msgdef **m) {
99
+ upb_Message* Message_GetMutable(VALUE msg_rb, const upb_MessageDef** m) {
100
100
  rb_check_frozen(msg_rb);
101
- return (upb_msg*)Message_Get(msg_rb, m);
101
+ return (upb_Message*)Message_Get(msg_rb, m);
102
102
  }
103
103
 
104
- void Message_InitPtr(VALUE self_, upb_msg *msg, VALUE arena) {
104
+ void Message_InitPtr(VALUE self_, upb_Message* msg, VALUE arena) {
105
105
  Message* self = ruby_to_Message(self_);
106
106
  self->msg = msg;
107
107
  self->arena = arena;
@@ -120,7 +120,8 @@ void Message_CheckClass(VALUE klass) {
120
120
  }
121
121
  }
122
122
 
123
- VALUE Message_GetRubyWrapper(upb_msg* msg, const upb_msgdef* m, VALUE arena) {
123
+ VALUE Message_GetRubyWrapper(upb_Message* msg, const upb_MessageDef* m,
124
+ VALUE arena) {
124
125
  if (msg == NULL) return Qnil;
125
126
 
126
127
  VALUE val = ObjectCache_Get(msg);
@@ -134,17 +135,17 @@ VALUE Message_GetRubyWrapper(upb_msg* msg, const upb_msgdef* m, VALUE arena) {
134
135
  return val;
135
136
  }
136
137
 
137
- void Message_PrintMessage(StringBuilder* b, const upb_msg* msg,
138
- const upb_msgdef* m) {
138
+ void Message_PrintMessage(StringBuilder* b, const upb_Message* msg,
139
+ const upb_MessageDef* m) {
139
140
  bool first = true;
140
- int n = upb_msgdef_fieldcount(m);
141
+ int n = upb_MessageDef_FieldCount(m);
141
142
  VALUE klass = Descriptor_DefToClass(m);
142
143
  StringBuilder_Printf(b, "<%s: ", rb_class2name(klass));
143
144
 
144
145
  for (int i = 0; i < n; i++) {
145
- const upb_fielddef* field = upb_msgdef_field(m, i);
146
+ const upb_FieldDef* field = upb_MessageDef_Field(m, i);
146
147
 
147
- if (upb_fielddef_haspresence(field) && !upb_msg_has(msg, field)) {
148
+ if (upb_FieldDef_HasPresence(field) && !upb_Message_Has(msg, field)) {
148
149
  continue;
149
150
  }
150
151
 
@@ -154,17 +155,17 @@ void Message_PrintMessage(StringBuilder* b, const upb_msg* msg,
154
155
  first = false;
155
156
  }
156
157
 
157
- upb_msgval msgval = upb_msg_get(msg, field);
158
+ upb_MessageValue msgval = upb_Message_Get(msg, field);
158
159
 
159
- StringBuilder_Printf(b, "%s: ", upb_fielddef_name(field));
160
+ StringBuilder_Printf(b, "%s: ", upb_FieldDef_Name(field));
160
161
 
161
- if (upb_fielddef_ismap(field)) {
162
- const upb_msgdef* entry_m = upb_fielddef_msgsubdef(field);
163
- const upb_fielddef* key_f = upb_msgdef_itof(entry_m, 1);
164
- const upb_fielddef* val_f = upb_msgdef_itof(entry_m, 2);
162
+ if (upb_FieldDef_IsMap(field)) {
163
+ const upb_MessageDef* entry_m = upb_FieldDef_MessageSubDef(field);
164
+ const upb_FieldDef* key_f = upb_MessageDef_FindFieldByNumber(entry_m, 1);
165
+ const upb_FieldDef* val_f = upb_MessageDef_FindFieldByNumber(entry_m, 2);
165
166
  TypeInfo val_info = TypeInfo_get(val_f);
166
- Map_Inspect(b, msgval.map_val, upb_fielddef_type(key_f), val_info);
167
- } else if (upb_fielddef_isseq(field)) {
167
+ Map_Inspect(b, msgval.map_val, upb_FieldDef_CType(key_f), val_info);
168
+ } else if (upb_FieldDef_IsRepeated(field)) {
168
169
  RepeatedField_Inspect(b, msgval.array_val, TypeInfo_get(field));
169
170
  } else {
170
171
  StringBuilder_PrintMsgval(b, msgval, TypeInfo_get(field));
@@ -188,14 +189,31 @@ enum {
188
189
  };
189
190
 
190
191
  // Check if the field is a well known wrapper type
191
- static bool IsWrapper(const upb_fielddef* f) {
192
- return upb_fielddef_issubmsg(f) &&
193
- upb_msgdef_iswrapper(upb_fielddef_msgsubdef(f));
192
+ static bool IsWrapper(const upb_MessageDef* m) {
193
+ if (!m) return false;
194
+ switch (upb_MessageDef_WellKnownType(m)) {
195
+ case kUpb_WellKnown_DoubleValue:
196
+ case kUpb_WellKnown_FloatValue:
197
+ case kUpb_WellKnown_Int64Value:
198
+ case kUpb_WellKnown_UInt64Value:
199
+ case kUpb_WellKnown_Int32Value:
200
+ case kUpb_WellKnown_UInt32Value:
201
+ case kUpb_WellKnown_StringValue:
202
+ case kUpb_WellKnown_BytesValue:
203
+ case kUpb_WellKnown_BoolValue:
204
+ return true;
205
+ default:
206
+ return false;
207
+ }
208
+ }
209
+
210
+ static bool IsFieldWrapper(const upb_FieldDef* f) {
211
+ return IsWrapper(upb_FieldDef_MessageSubDef(f));
194
212
  }
195
213
 
196
- static bool Match(const upb_msgdef* m, const char* name, const upb_fielddef** f,
197
- const upb_oneofdef** o, const char* prefix,
198
- const char* suffix) {
214
+ static bool Match(const upb_MessageDef* m, const char* name,
215
+ const upb_FieldDef** f, const upb_OneofDef** o,
216
+ const char* prefix, const char* suffix) {
199
217
  size_t sp = strlen(prefix);
200
218
  size_t ss = strlen(suffix);
201
219
  size_t sn = strlen(name);
@@ -207,12 +225,12 @@ static bool Match(const upb_msgdef* m, const char* name, const upb_fielddef** f,
207
225
  return false;
208
226
  }
209
227
 
210
- return upb_msgdef_lookupname(m, name + sp, sn - sp - ss, f, o);
228
+ return upb_MessageDef_FindByNameWithSize(m, name + sp, sn - sp - ss, f, o);
211
229
  }
212
230
 
213
231
  static int extract_method_call(VALUE method_name, Message* self,
214
- const upb_fielddef** f, const upb_oneofdef** o) {
215
- const upb_msgdef* m = self->msgdef;
232
+ const upb_FieldDef** f, const upb_OneofDef** o) {
233
+ const upb_MessageDef* m = self->msgdef;
216
234
  const char* name;
217
235
 
218
236
  Check_Type(method_name, T_SYMBOL);
@@ -222,156 +240,159 @@ static int extract_method_call(VALUE method_name, Message* self,
222
240
  if (Match(m, name, f, o, "", "=")) return METHOD_SETTER;
223
241
  if (Match(m, name, f, o, "clear_", "")) return METHOD_CLEAR;
224
242
  if (Match(m, name, f, o, "has_", "?") &&
225
- (*o || (*f && upb_fielddef_haspresence(*f)))) {
243
+ (*o || (*f && upb_FieldDef_HasPresence(*f)))) {
226
244
  // Disallow oneof hazzers for proto3.
227
245
  // TODO(haberman): remove this test when we are enabling oneof hazzers for
228
246
  // proto3.
229
- if (*f && !upb_fielddef_issubmsg(*f) &&
230
- upb_fielddef_realcontainingoneof(*f) &&
231
- upb_msgdef_syntax(upb_fielddef_containingtype(*f)) !=
232
- UPB_SYNTAX_PROTO2) {
247
+ if (*f && !upb_FieldDef_IsSubMessage(*f) &&
248
+ upb_FieldDef_RealContainingOneof(*f) &&
249
+ upb_MessageDef_Syntax(upb_FieldDef_ContainingType(*f)) !=
250
+ kUpb_Syntax_Proto2) {
233
251
  return METHOD_UNKNOWN;
234
252
  }
235
253
  return METHOD_PRESENCE;
236
254
  }
237
- if (Match(m, name, f, o, "", "_as_value") && *f && !upb_fielddef_isseq(*f) &&
238
- IsWrapper(*f)) {
255
+ if (Match(m, name, f, o, "", "_as_value") && *f &&
256
+ !upb_FieldDef_IsRepeated(*f) && IsFieldWrapper(*f)) {
239
257
  return METHOD_WRAPPER_GETTER;
240
258
  }
241
- if (Match(m, name, f, o, "", "_as_value=") && *f && !upb_fielddef_isseq(*f) &&
242
- IsWrapper(*f)) {
259
+ if (Match(m, name, f, o, "", "_as_value=") && *f &&
260
+ !upb_FieldDef_IsRepeated(*f) && IsFieldWrapper(*f)) {
243
261
  return METHOD_WRAPPER_SETTER;
244
262
  }
245
263
  if (Match(m, name, f, o, "", "_const") && *f &&
246
- upb_fielddef_type(*f) == UPB_TYPE_ENUM) {
264
+ upb_FieldDef_CType(*f) == kUpb_CType_Enum) {
247
265
  return METHOD_ENUM_GETTER;
248
266
  }
249
267
 
250
268
  return METHOD_UNKNOWN;
251
269
  }
252
270
 
253
- static VALUE Message_oneof_accessor(VALUE _self, const upb_oneofdef* o,
271
+ static VALUE Message_oneof_accessor(VALUE _self, const upb_OneofDef* o,
254
272
  int accessor_type) {
255
273
  Message* self = ruby_to_Message(_self);
256
- const upb_fielddef* oneof_field = upb_msg_whichoneof(self->msg, o);
274
+ const upb_FieldDef* oneof_field = upb_Message_WhichOneof(self->msg, o);
257
275
 
258
276
  switch (accessor_type) {
259
277
  case METHOD_PRESENCE:
260
278
  return oneof_field == NULL ? Qfalse : Qtrue;
261
279
  case METHOD_CLEAR:
262
280
  if (oneof_field != NULL) {
263
- upb_msg_clearfield(Message_GetMutable(_self, NULL), oneof_field);
281
+ upb_Message_ClearField(Message_GetMutable(_self, NULL), oneof_field);
264
282
  }
265
283
  return Qnil;
266
284
  case METHOD_GETTER:
267
285
  return oneof_field == NULL
268
286
  ? Qnil
269
- : ID2SYM(rb_intern(upb_fielddef_name(oneof_field)));
287
+ : ID2SYM(rb_intern(upb_FieldDef_Name(oneof_field)));
270
288
  case METHOD_SETTER:
271
289
  rb_raise(rb_eRuntimeError, "Oneof accessors are read-only.");
272
290
  }
273
291
  rb_raise(rb_eRuntimeError, "Invalid access of oneof field.");
274
292
  }
275
293
 
276
- static void Message_setfield(upb_msg* msg, const upb_fielddef* f, VALUE val,
277
- upb_arena* arena) {
278
- upb_msgval msgval;
279
- if (upb_fielddef_ismap(f)) {
280
- msgval.map_val = Map_GetUpbMap(val, f);
281
- } else if (upb_fielddef_isseq(f)) {
282
- msgval.array_val = RepeatedField_GetUpbArray(val, f);
294
+ static void Message_setfield(upb_Message* msg, const upb_FieldDef* f, VALUE val,
295
+ upb_Arena* arena) {
296
+ upb_MessageValue msgval;
297
+ if (upb_FieldDef_IsMap(f)) {
298
+ msgval.map_val = Map_GetUpbMap(val, f, arena);
299
+ } else if (upb_FieldDef_IsRepeated(f)) {
300
+ msgval.array_val = RepeatedField_GetUpbArray(val, f, arena);
283
301
  } else {
284
302
  if (val == Qnil &&
285
- (upb_fielddef_issubmsg(f) || upb_fielddef_realcontainingoneof(f))) {
286
- upb_msg_clearfield(msg, f);
303
+ (upb_FieldDef_IsSubMessage(f) || upb_FieldDef_RealContainingOneof(f))) {
304
+ upb_Message_ClearField(msg, f);
287
305
  return;
288
306
  }
289
307
  msgval =
290
- Convert_RubyToUpb(val, upb_fielddef_name(f), TypeInfo_get(f), arena);
308
+ Convert_RubyToUpb(val, upb_FieldDef_Name(f), TypeInfo_get(f), arena);
291
309
  }
292
- upb_msg_set(msg, f, msgval, arena);
310
+ upb_Message_Set(msg, f, msgval, arena);
293
311
  }
294
312
 
295
- VALUE Message_getfield(VALUE _self, const upb_fielddef* f) {
313
+ VALUE Message_getfield(VALUE _self, const upb_FieldDef* f) {
296
314
  Message* self = ruby_to_Message(_self);
297
- // This is a special-case: upb_msg_mutable() for map & array are logically
315
+ // This is a special-case: upb_Message_Mutable() for map & array are logically
298
316
  // const (they will not change what is serialized) but physically
299
317
  // non-const, as they do allocate a repeated field or map. The logical
300
318
  // constness means it's ok to do even if the message is frozen.
301
- upb_msg *msg = (upb_msg*)self->msg;
302
- upb_arena *arena = Arena_get(self->arena);
303
- if (upb_fielddef_ismap(f)) {
304
- upb_map *map = upb_msg_mutable(msg, f, arena).map;
305
- const upb_fielddef *key_f = map_field_key(f);
306
- const upb_fielddef *val_f = map_field_value(f);
307
- upb_fieldtype_t key_type = upb_fielddef_type(key_f);
319
+ upb_Message* msg = (upb_Message*)self->msg;
320
+ upb_Arena* arena = Arena_get(self->arena);
321
+ if (upb_FieldDef_IsMap(f)) {
322
+ upb_Map* map = upb_Message_Mutable(msg, f, arena).map;
323
+ const upb_FieldDef* key_f = map_field_key(f);
324
+ const upb_FieldDef* val_f = map_field_value(f);
325
+ upb_CType key_type = upb_FieldDef_CType(key_f);
308
326
  TypeInfo value_type_info = TypeInfo_get(val_f);
309
327
  return Map_GetRubyWrapper(map, key_type, value_type_info, self->arena);
310
- } else if (upb_fielddef_isseq(f)) {
311
- upb_array *arr = upb_msg_mutable(msg, f, arena).array;
328
+ } else if (upb_FieldDef_IsRepeated(f)) {
329
+ upb_Array* arr = upb_Message_Mutable(msg, f, arena).array;
312
330
  return RepeatedField_GetRubyWrapper(arr, TypeInfo_get(f), self->arena);
313
- } else if (upb_fielddef_issubmsg(f)) {
314
- if (!upb_msg_has(self->msg, f)) return Qnil;
315
- upb_msg *submsg = upb_msg_mutable(msg, f, arena).msg;
316
- const upb_msgdef *m = upb_fielddef_msgsubdef(f);
331
+ } else if (upb_FieldDef_IsSubMessage(f)) {
332
+ if (!upb_Message_Has(self->msg, f)) return Qnil;
333
+ upb_Message* submsg = upb_Message_Mutable(msg, f, arena).msg;
334
+ const upb_MessageDef* m = upb_FieldDef_MessageSubDef(f);
317
335
  return Message_GetRubyWrapper(submsg, m, self->arena);
318
336
  } else {
319
- upb_msgval msgval = upb_msg_get(self->msg, f);
337
+ upb_MessageValue msgval = upb_Message_Get(self->msg, f);
320
338
  return Convert_UpbToRuby(msgval, TypeInfo_get(f), self->arena);
321
339
  }
322
340
  }
323
341
 
324
- static VALUE Message_field_accessor(VALUE _self, const upb_fielddef* f,
342
+ static VALUE Message_field_accessor(VALUE _self, const upb_FieldDef* f,
325
343
  int accessor_type, int argc, VALUE* argv) {
326
- upb_arena *arena = Arena_get(Message_GetArena(_self));
344
+ upb_Arena* arena = Arena_get(Message_GetArena(_self));
327
345
 
328
346
  switch (accessor_type) {
329
347
  case METHOD_SETTER:
330
348
  Message_setfield(Message_GetMutable(_self, NULL), f, argv[1], arena);
331
349
  return Qnil;
332
350
  case METHOD_CLEAR:
333
- upb_msg_clearfield(Message_GetMutable(_self, NULL), f);
351
+ upb_Message_ClearField(Message_GetMutable(_self, NULL), f);
334
352
  return Qnil;
335
353
  case METHOD_PRESENCE:
336
- if (!upb_fielddef_haspresence(f)) {
354
+ if (!upb_FieldDef_HasPresence(f)) {
337
355
  rb_raise(rb_eRuntimeError, "Field does not have presence.");
338
356
  }
339
- return upb_msg_has(Message_Get(_self, NULL), f);
357
+ return upb_Message_Has(Message_Get(_self, NULL), f);
340
358
  case METHOD_WRAPPER_GETTER: {
341
359
  Message* self = ruby_to_Message(_self);
342
- if (upb_msg_has(self->msg, f)) {
343
- PBRUBY_ASSERT(upb_fielddef_issubmsg(f) && !upb_fielddef_isseq(f));
344
- upb_msgval wrapper = upb_msg_get(self->msg, f);
345
- const upb_msgdef *wrapper_m = upb_fielddef_msgsubdef(f);
346
- const upb_fielddef *value_f = upb_msgdef_itof(wrapper_m, 1);
347
- upb_msgval value = upb_msg_get(wrapper.msg_val, value_f);
360
+ if (upb_Message_Has(self->msg, f)) {
361
+ PBRUBY_ASSERT(upb_FieldDef_IsSubMessage(f) &&
362
+ !upb_FieldDef_IsRepeated(f));
363
+ upb_MessageValue wrapper = upb_Message_Get(self->msg, f);
364
+ const upb_MessageDef* wrapper_m = upb_FieldDef_MessageSubDef(f);
365
+ const upb_FieldDef* value_f =
366
+ upb_MessageDef_FindFieldByNumber(wrapper_m, 1);
367
+ upb_MessageValue value = upb_Message_Get(wrapper.msg_val, value_f);
348
368
  return Convert_UpbToRuby(value, TypeInfo_get(value_f), self->arena);
349
369
  } else {
350
370
  return Qnil;
351
371
  }
352
372
  }
353
373
  case METHOD_WRAPPER_SETTER: {
354
- upb_msg *msg = Message_GetMutable(_self, NULL);
374
+ upb_Message* msg = Message_GetMutable(_self, NULL);
355
375
  if (argv[1] == Qnil) {
356
- upb_msg_clearfield(msg, f);
376
+ upb_Message_ClearField(msg, f);
357
377
  } else {
358
- const upb_fielddef *val_f = upb_msgdef_itof(upb_fielddef_msgsubdef(f), 1);
359
- upb_msgval msgval = Convert_RubyToUpb(argv[1], upb_fielddef_name(f),
360
- TypeInfo_get(val_f), arena);
361
- upb_msg *wrapper = upb_msg_mutable(msg, f, arena).msg;
362
- upb_msg_set(wrapper, val_f, msgval, arena);
378
+ const upb_FieldDef* val_f =
379
+ upb_MessageDef_FindFieldByNumber(upb_FieldDef_MessageSubDef(f), 1);
380
+ upb_MessageValue msgval = Convert_RubyToUpb(
381
+ argv[1], upb_FieldDef_Name(f), TypeInfo_get(val_f), arena);
382
+ upb_Message* wrapper = upb_Message_Mutable(msg, f, arena).msg;
383
+ upb_Message_Set(wrapper, val_f, msgval, arena);
363
384
  }
364
385
  return Qnil;
365
386
  }
366
387
  case METHOD_ENUM_GETTER: {
367
- upb_msgval msgval = upb_msg_get(Message_Get(_self, NULL), f);
388
+ upb_MessageValue msgval = upb_Message_Get(Message_Get(_self, NULL), f);
368
389
 
369
- if (upb_fielddef_label(f) == UPB_LABEL_REPEATED) {
390
+ if (upb_FieldDef_Label(f) == kUpb_Label_Repeated) {
370
391
  // Map repeated fields to a new type with ints
371
392
  VALUE arr = rb_ary_new();
372
- size_t i, n = upb_array_size(msgval.array_val);
393
+ size_t i, n = upb_Array_Size(msgval.array_val);
373
394
  for (i = 0; i < n; i++) {
374
- upb_msgval elem = upb_array_get(msgval.array_val, i);
395
+ upb_MessageValue elem = upb_Array_Get(msgval.array_val, i);
375
396
  rb_ary_push(arr, INT2NUM(elem.int32_val));
376
397
  }
377
398
  return arr;
@@ -416,8 +437,8 @@ static VALUE Message_field_accessor(VALUE _self, const upb_fielddef* f,
416
437
  */
417
438
  static VALUE Message_method_missing(int argc, VALUE* argv, VALUE _self) {
418
439
  Message* self = ruby_to_Message(_self);
419
- const upb_oneofdef* o;
420
- const upb_fielddef* f;
440
+ const upb_OneofDef* o;
441
+ const upb_FieldDef* f;
421
442
  int accessor_type;
422
443
 
423
444
  if (argc < 1) {
@@ -454,8 +475,8 @@ static VALUE Message_method_missing(int argc, VALUE* argv, VALUE _self) {
454
475
 
455
476
  static VALUE Message_respond_to_missing(int argc, VALUE* argv, VALUE _self) {
456
477
  Message* self = ruby_to_Message(_self);
457
- const upb_oneofdef* o;
458
- const upb_fielddef* f;
478
+ const upb_OneofDef* o;
479
+ const upb_FieldDef* f;
459
480
  int accessor_type;
460
481
 
461
482
  if (argc < 1) {
@@ -473,53 +494,54 @@ static VALUE Message_respond_to_missing(int argc, VALUE* argv, VALUE _self) {
473
494
  }
474
495
  }
475
496
 
476
- void Message_InitFromValue(upb_msg* msg, const upb_msgdef* m, VALUE val,
477
- upb_arena* arena);
497
+ void Message_InitFromValue(upb_Message* msg, const upb_MessageDef* m, VALUE val,
498
+ upb_Arena* arena);
478
499
 
479
500
  typedef struct {
480
- upb_map *map;
501
+ upb_Map* map;
481
502
  TypeInfo key_type;
482
503
  TypeInfo val_type;
483
- upb_arena *arena;
504
+ upb_Arena* arena;
484
505
  } MapInit;
485
506
 
486
507
  static int Map_initialize_kwarg(VALUE key, VALUE val, VALUE _self) {
487
- MapInit *map_init = (MapInit*)_self;
488
- upb_msgval k, v;
508
+ MapInit* map_init = (MapInit*)_self;
509
+ upb_MessageValue k, v;
489
510
  k = Convert_RubyToUpb(key, "", map_init->key_type, NULL);
490
511
 
491
- if (map_init->val_type.type == UPB_TYPE_MESSAGE && TYPE(val) == T_HASH) {
492
- upb_msg *msg = upb_msg_new(map_init->val_type.def.msgdef, map_init->arena);
512
+ if (map_init->val_type.type == kUpb_CType_Message && TYPE(val) == T_HASH) {
513
+ upb_Message* msg =
514
+ upb_Message_New(map_init->val_type.def.msgdef, map_init->arena);
493
515
  Message_InitFromValue(msg, map_init->val_type.def.msgdef, val,
494
516
  map_init->arena);
495
517
  v.msg_val = msg;
496
518
  } else {
497
519
  v = Convert_RubyToUpb(val, "", map_init->val_type, map_init->arena);
498
520
  }
499
- upb_map_set(map_init->map, k, v, map_init->arena);
521
+ upb_Map_Set(map_init->map, k, v, map_init->arena);
500
522
  return ST_CONTINUE;
501
523
  }
502
524
 
503
- static void Map_InitFromValue(upb_map* map, const upb_fielddef* f, VALUE val,
504
- upb_arena* arena) {
505
- const upb_msgdef* entry_m = upb_fielddef_msgsubdef(f);
506
- const upb_fielddef* key_f = upb_msgdef_itof(entry_m, 1);
507
- const upb_fielddef* val_f = upb_msgdef_itof(entry_m, 2);
525
+ static void Map_InitFromValue(upb_Map* map, const upb_FieldDef* f, VALUE val,
526
+ upb_Arena* arena) {
527
+ const upb_MessageDef* entry_m = upb_FieldDef_MessageSubDef(f);
528
+ const upb_FieldDef* key_f = upb_MessageDef_FindFieldByNumber(entry_m, 1);
529
+ const upb_FieldDef* val_f = upb_MessageDef_FindFieldByNumber(entry_m, 2);
508
530
  if (TYPE(val) != T_HASH) {
509
531
  rb_raise(rb_eArgError,
510
532
  "Expected Hash object as initializer value for map field '%s' "
511
533
  "(given %s).",
512
- upb_fielddef_name(f), rb_class2name(CLASS_OF(val)));
534
+ upb_FieldDef_Name(f), rb_class2name(CLASS_OF(val)));
513
535
  }
514
536
  MapInit map_init = {map, TypeInfo_get(key_f), TypeInfo_get(val_f), arena};
515
537
  rb_hash_foreach(val, Map_initialize_kwarg, (VALUE)&map_init);
516
538
  }
517
539
 
518
- static upb_msgval MessageValue_FromValue(VALUE val, TypeInfo info,
519
- upb_arena* arena) {
520
- if (info.type == UPB_TYPE_MESSAGE) {
521
- upb_msgval msgval;
522
- upb_msg* msg = upb_msg_new(info.def.msgdef, arena);
540
+ static upb_MessageValue MessageValue_FromValue(VALUE val, TypeInfo info,
541
+ upb_Arena* arena) {
542
+ if (info.type == kUpb_CType_Message) {
543
+ upb_MessageValue msgval;
544
+ upb_Message* msg = upb_Message_New(info.def.msgdef, arena);
523
545
  Message_InitFromValue(msg, info.def.msgdef, val, arena);
524
546
  msgval.msg_val = msg;
525
547
  return msgval;
@@ -528,61 +550,62 @@ static upb_msgval MessageValue_FromValue(VALUE val, TypeInfo info,
528
550
  }
529
551
  }
530
552
 
531
- static void RepeatedField_InitFromValue(upb_array* arr, const upb_fielddef* f,
532
- VALUE val, upb_arena* arena) {
553
+ static void RepeatedField_InitFromValue(upb_Array* arr, const upb_FieldDef* f,
554
+ VALUE val, upb_Arena* arena) {
533
555
  TypeInfo type_info = TypeInfo_get(f);
534
556
 
535
557
  if (TYPE(val) != T_ARRAY) {
536
558
  rb_raise(rb_eArgError,
537
- "Expected array as initializer value for repeated field '%s' (given %s).",
538
- upb_fielddef_name(f), rb_class2name(CLASS_OF(val)));
559
+ "Expected array as initializer value for repeated field '%s' "
560
+ "(given %s).",
561
+ upb_FieldDef_Name(f), rb_class2name(CLASS_OF(val)));
539
562
  }
540
563
 
541
564
  for (int i = 0; i < RARRAY_LEN(val); i++) {
542
565
  VALUE entry = rb_ary_entry(val, i);
543
- upb_msgval msgval;
544
- if (upb_fielddef_issubmsg(f) && TYPE(entry) == T_HASH) {
566
+ upb_MessageValue msgval;
567
+ if (upb_FieldDef_IsSubMessage(f) && TYPE(entry) == T_HASH) {
545
568
  msgval = MessageValue_FromValue(entry, type_info, arena);
546
569
  } else {
547
- msgval = Convert_RubyToUpb(entry, upb_fielddef_name(f), type_info, arena);
570
+ msgval = Convert_RubyToUpb(entry, upb_FieldDef_Name(f), type_info, arena);
548
571
  }
549
- upb_array_append(arr, msgval, arena);
572
+ upb_Array_Append(arr, msgval, arena);
550
573
  }
551
574
  }
552
575
 
553
- static void Message_InitFieldFromValue(upb_msg* msg, const upb_fielddef* f,
554
- VALUE val, upb_arena* arena) {
576
+ static void Message_InitFieldFromValue(upb_Message* msg, const upb_FieldDef* f,
577
+ VALUE val, upb_Arena* arena) {
555
578
  if (TYPE(val) == T_NIL) return;
556
579
 
557
- if (upb_fielddef_ismap(f)) {
558
- upb_map *map = upb_msg_mutable(msg, f, arena).map;
580
+ if (upb_FieldDef_IsMap(f)) {
581
+ upb_Map* map = upb_Message_Mutable(msg, f, arena).map;
559
582
  Map_InitFromValue(map, f, val, arena);
560
- } else if (upb_fielddef_label(f) == UPB_LABEL_REPEATED) {
561
- upb_array *arr = upb_msg_mutable(msg, f, arena).array;
583
+ } else if (upb_FieldDef_Label(f) == kUpb_Label_Repeated) {
584
+ upb_Array* arr = upb_Message_Mutable(msg, f, arena).array;
562
585
  RepeatedField_InitFromValue(arr, f, val, arena);
563
- } else if (upb_fielddef_issubmsg(f)) {
586
+ } else if (upb_FieldDef_IsSubMessage(f)) {
564
587
  if (TYPE(val) == T_HASH) {
565
- upb_msg *submsg = upb_msg_mutable(msg, f, arena).msg;
566
- Message_InitFromValue(submsg, upb_fielddef_msgsubdef(f), val, arena);
588
+ upb_Message* submsg = upb_Message_Mutable(msg, f, arena).msg;
589
+ Message_InitFromValue(submsg, upb_FieldDef_MessageSubDef(f), val, arena);
567
590
  } else {
568
591
  Message_setfield(msg, f, val, arena);
569
592
  }
570
593
  } else {
571
- upb_msgval msgval =
572
- Convert_RubyToUpb(val, upb_fielddef_name(f), TypeInfo_get(f), arena);
573
- upb_msg_set(msg, f, msgval, arena);
594
+ upb_MessageValue msgval =
595
+ Convert_RubyToUpb(val, upb_FieldDef_Name(f), TypeInfo_get(f), arena);
596
+ upb_Message_Set(msg, f, msgval, arena);
574
597
  }
575
598
  }
576
599
 
577
600
  typedef struct {
578
- upb_msg *msg;
579
- const upb_msgdef *msgdef;
580
- upb_arena *arena;
601
+ upb_Message* msg;
602
+ const upb_MessageDef* msgdef;
603
+ upb_Arena* arena;
581
604
  } MsgInit;
582
605
 
583
606
  static int Message_initialize_kwarg(VALUE key, VALUE val, VALUE _self) {
584
- MsgInit *msg_init = (MsgInit*)_self;
585
- const char *name;
607
+ MsgInit* msg_init = (MsgInit*)_self;
608
+ const char* name;
586
609
 
587
610
  if (TYPE(key) == T_STRING) {
588
611
  name = RSTRING_PTR(key);
@@ -590,10 +613,12 @@ static int Message_initialize_kwarg(VALUE key, VALUE val, VALUE _self) {
590
613
  name = RSTRING_PTR(rb_id2str(SYM2ID(key)));
591
614
  } else {
592
615
  rb_raise(rb_eArgError,
593
- "Expected string or symbols as hash keys when initializing proto from hash.");
616
+ "Expected string or symbols as hash keys when initializing proto "
617
+ "from hash.");
594
618
  }
595
619
 
596
- const upb_fielddef* f = upb_msgdef_ntofz(msg_init->msgdef, name);
620
+ const upb_FieldDef* f =
621
+ upb_MessageDef_FindFieldByName(msg_init->msgdef, name);
597
622
 
598
623
  if (f == NULL) {
599
624
  rb_raise(rb_eArgError,
@@ -604,8 +629,8 @@ static int Message_initialize_kwarg(VALUE key, VALUE val, VALUE _self) {
604
629
  return ST_CONTINUE;
605
630
  }
606
631
 
607
- void Message_InitFromValue(upb_msg* msg, const upb_msgdef* m, VALUE val,
608
- upb_arena* arena) {
632
+ void Message_InitFromValue(upb_Message* msg, const upb_MessageDef* m, VALUE val,
633
+ upb_Arena* arena) {
609
634
  MsgInit msg_init = {msg, m, arena};
610
635
  if (TYPE(val) == T_HASH) {
611
636
  rb_hash_foreach(val, Message_initialize_kwarg, (VALUE)&msg_init);
@@ -630,8 +655,8 @@ void Message_InitFromValue(upb_msg* msg, const upb_msgdef* m, VALUE val,
630
655
  static VALUE Message_initialize(int argc, VALUE* argv, VALUE _self) {
631
656
  Message* self = ruby_to_Message(_self);
632
657
  VALUE arena_rb = Arena_new();
633
- upb_arena *arena = Arena_get(arena_rb);
634
- upb_msg *msg = upb_msg_new(self->msgdef, arena);
658
+ upb_Arena* arena = Arena_get(arena_rb);
659
+ upb_Message* msg = upb_Message_New(self->msgdef, arena);
635
660
 
636
661
  Message_InitPtr(_self, msg, arena_rb);
637
662
 
@@ -641,7 +666,7 @@ static VALUE Message_initialize(int argc, VALUE* argv, VALUE _self) {
641
666
  if (argc != 1) {
642
667
  rb_raise(rb_eArgError, "Expected 0 or 1 arguments.");
643
668
  }
644
- Message_InitFromValue((upb_msg*)self->msg, self->msgdef, argv[0], arena);
669
+ Message_InitFromValue((upb_Message*)self->msg, self->msgdef, argv[0], arena);
645
670
  return Qnil;
646
671
  }
647
672
 
@@ -655,34 +680,35 @@ static VALUE Message_dup(VALUE _self) {
655
680
  Message* self = ruby_to_Message(_self);
656
681
  VALUE new_msg = rb_class_new_instance(0, NULL, CLASS_OF(_self));
657
682
  Message* new_msg_self = ruby_to_Message(new_msg);
658
- size_t size = upb_msgdef_layout(self->msgdef)->size;
683
+ size_t size = upb_MessageDef_MiniTable(self->msgdef)->size;
659
684
 
660
685
  // TODO(copy unknown fields?)
661
686
  // TODO(use official upb msg copy function)
662
- memcpy((upb_msg*)new_msg_self->msg, self->msg, size);
663
- upb_arena_fuse(Arena_get(new_msg_self->arena), Arena_get(self->arena));
687
+ memcpy((upb_Message*)new_msg_self->msg, self->msg, size);
688
+ Arena_fuse(self->arena, Arena_get(new_msg_self->arena));
664
689
  return new_msg;
665
690
  }
666
691
 
667
692
  // Support function for Message_eq, and also used by other #eq functions.
668
- bool Message_Equal(const upb_msg *m1, const upb_msg *m2, const upb_msgdef *m) {
693
+ bool Message_Equal(const upb_Message* m1, const upb_Message* m2,
694
+ const upb_MessageDef* m) {
669
695
  if (m1 == m2) return true;
670
696
 
671
697
  size_t size1, size2;
672
- int encode_opts = UPB_ENCODE_SKIPUNKNOWN | UPB_ENCODE_DETERMINISTIC;
673
- upb_arena *arena_tmp = upb_arena_new();
674
- const upb_msglayout *layout = upb_msgdef_layout(m);
698
+ int encode_opts = kUpb_Encode_SkipUnknown | kUpb_Encode_Deterministic;
699
+ upb_Arena* arena_tmp = upb_Arena_New();
700
+ const upb_MiniTable* layout = upb_MessageDef_MiniTable(m);
675
701
 
676
702
  // Compare deterministically serialized payloads with no unknown fields.
677
- char *data1 = upb_encode_ex(m1, layout, encode_opts, arena_tmp, &size1);
678
- char *data2 = upb_encode_ex(m2, layout, encode_opts, arena_tmp, &size2);
703
+ char* data1 = upb_Encode(m1, layout, encode_opts, arena_tmp, &size1);
704
+ char* data2 = upb_Encode(m2, layout, encode_opts, arena_tmp, &size2);
679
705
 
680
706
  if (data1 && data2) {
681
707
  bool ret = (size1 == size2) && (memcmp(data1, data2, size1) == 0);
682
- upb_arena_free(arena_tmp);
708
+ upb_Arena_Free(arena_tmp);
683
709
  return ret;
684
710
  } else {
685
- upb_arena_free(arena_tmp);
711
+ upb_Arena_Free(arena_tmp);
686
712
  rb_raise(cParseError, "Error comparing messages");
687
713
  }
688
714
  }
@@ -706,22 +732,23 @@ static VALUE Message_eq(VALUE _self, VALUE _other) {
706
732
  return Message_Equal(self->msg, other->msg, self->msgdef) ? Qtrue : Qfalse;
707
733
  }
708
734
 
709
- uint64_t Message_Hash(const upb_msg* msg, const upb_msgdef* m, uint64_t seed) {
710
- upb_arena *arena = upb_arena_new();
711
- const char *data;
735
+ uint64_t Message_Hash(const upb_Message* msg, const upb_MessageDef* m,
736
+ uint64_t seed) {
737
+ upb_Arena* arena = upb_Arena_New();
738
+ const char* data;
712
739
  size_t size;
713
740
 
714
741
  // Hash a deterministically serialized payloads with no unknown fields.
715
- data = upb_encode_ex(msg, upb_msgdef_layout(m),
716
- UPB_ENCODE_SKIPUNKNOWN | UPB_ENCODE_DETERMINISTIC, arena,
717
- &size);
742
+ data = upb_Encode(msg, upb_MessageDef_MiniTable(m),
743
+ kUpb_Encode_SkipUnknown | kUpb_Encode_Deterministic, arena,
744
+ &size);
718
745
 
719
746
  if (data) {
720
- uint64_t ret = wyhash(data, size, seed, _wyp);
721
- upb_arena_free(arena);
747
+ uint64_t ret = _upb_Hash(data, size, seed);
748
+ upb_Arena_Free(arena);
722
749
  return ret;
723
750
  } else {
724
- upb_arena_free(arena);
751
+ upb_Arena_Free(arena);
725
752
  rb_raise(cParseError, "Error calculating hash");
726
753
  }
727
754
  }
@@ -734,7 +761,10 @@ uint64_t Message_Hash(const upb_msg* msg, const upb_msgdef* m, uint64_t seed) {
734
761
  */
735
762
  static VALUE Message_hash(VALUE _self) {
736
763
  Message* self = ruby_to_Message(_self);
737
- return INT2FIX(Message_Hash(self->msg, self->msgdef, 0));
764
+ uint64_t hash_value = Message_Hash(self->msg, self->msgdef, 0);
765
+ // RUBY_FIXNUM_MAX should be one less than a power of 2.
766
+ assert((RUBY_FIXNUM_MAX & (RUBY_FIXNUM_MAX + 1)) == 0);
767
+ return INT2FIX(hash_value & RUBY_FIXNUM_MAX);
738
768
  }
739
769
 
740
770
  /*
@@ -757,13 +787,13 @@ static VALUE Message_inspect(VALUE _self) {
757
787
 
758
788
  // Support functions for Message_to_h //////////////////////////////////////////
759
789
 
760
- static VALUE RepeatedField_CreateArray(const upb_array* arr,
790
+ static VALUE RepeatedField_CreateArray(const upb_Array* arr,
761
791
  TypeInfo type_info) {
762
- int size = arr ? upb_array_size(arr) : 0;
792
+ int size = arr ? upb_Array_Size(arr) : 0;
763
793
  VALUE ary = rb_ary_new2(size);
764
794
 
765
795
  for (int i = 0; i < size; i++) {
766
- upb_msgval msgval = upb_array_get(arr, i);
796
+ upb_MessageValue msgval = upb_Array_Get(arr, i);
767
797
  VALUE val = Scalar_CreateHash(msgval, type_info);
768
798
  rb_ary_push(ary, val);
769
799
  }
@@ -771,46 +801,55 @@ static VALUE RepeatedField_CreateArray(const upb_array* arr,
771
801
  return ary;
772
802
  }
773
803
 
774
- static VALUE Message_CreateHash(const upb_msg *msg, const upb_msgdef *m) {
804
+ static VALUE Message_CreateHash(const upb_Message* msg,
805
+ const upb_MessageDef* m) {
775
806
  if (!msg) return Qnil;
776
807
 
777
808
  VALUE hash = rb_hash_new();
778
- int n = upb_msgdef_fieldcount(m);
809
+ int n = upb_MessageDef_FieldCount(m);
779
810
  bool is_proto2;
780
811
 
781
812
  // We currently have a few behaviors that are specific to proto2.
782
813
  // This is unfortunate, we should key behaviors off field attributes (like
783
814
  // whether a field has presence), not proto2 vs. proto3. We should see if we
784
815
  // can change this without breaking users.
785
- is_proto2 = upb_msgdef_syntax(m) == UPB_SYNTAX_PROTO2;
816
+ is_proto2 = upb_MessageDef_Syntax(m) == kUpb_Syntax_Proto2;
786
817
 
787
818
  for (int i = 0; i < n; i++) {
788
- const upb_fielddef* field = upb_msgdef_field(m, i);
819
+ const upb_FieldDef* field = upb_MessageDef_Field(m, i);
789
820
  TypeInfo type_info = TypeInfo_get(field);
790
- upb_msgval msgval;
821
+ upb_MessageValue msgval;
791
822
  VALUE msg_value;
792
823
  VALUE msg_key;
793
824
 
825
+ if (!is_proto2 && upb_FieldDef_IsSubMessage(field) &&
826
+ !upb_FieldDef_IsRepeated(field) && !upb_Message_Has(msg, field)) {
827
+ // TODO: Legacy behavior, remove when we fix the is_proto2 differences.
828
+ msg_key = ID2SYM(rb_intern(upb_FieldDef_Name(field)));
829
+ rb_hash_aset(hash, msg_key, Qnil);
830
+ continue;
831
+ }
832
+
794
833
  // Do not include fields that are not present (oneof or optional fields).
795
- if (is_proto2 && upb_fielddef_haspresence(field) &&
796
- !upb_msg_has(msg, field)) {
834
+ if (is_proto2 && upb_FieldDef_HasPresence(field) &&
835
+ !upb_Message_Has(msg, field)) {
797
836
  continue;
798
837
  }
799
838
 
800
- msg_key = ID2SYM(rb_intern(upb_fielddef_name(field)));
801
- msgval = upb_msg_get(msg, field);
839
+ msg_key = ID2SYM(rb_intern(upb_FieldDef_Name(field)));
840
+ msgval = upb_Message_Get(msg, field);
802
841
 
803
842
  // Proto2 omits empty map/repeated filds also.
804
843
 
805
- if (upb_fielddef_ismap(field)) {
806
- const upb_msgdef *entry_m = upb_fielddef_msgsubdef(field);
807
- const upb_fielddef *key_f = upb_msgdef_itof(entry_m, 1);
808
- const upb_fielddef *val_f = upb_msgdef_itof(entry_m, 2);
809
- upb_fieldtype_t key_type = upb_fielddef_type(key_f);
844
+ if (upb_FieldDef_IsMap(field)) {
845
+ const upb_MessageDef* entry_m = upb_FieldDef_MessageSubDef(field);
846
+ const upb_FieldDef* key_f = upb_MessageDef_FindFieldByNumber(entry_m, 1);
847
+ const upb_FieldDef* val_f = upb_MessageDef_FindFieldByNumber(entry_m, 2);
848
+ upb_CType key_type = upb_FieldDef_CType(key_f);
810
849
  msg_value = Map_CreateHash(msgval.map_val, key_type, TypeInfo_get(val_f));
811
- } else if (upb_fielddef_isseq(field)) {
850
+ } else if (upb_FieldDef_IsRepeated(field)) {
812
851
  if (is_proto2 &&
813
- (!msgval.array_val || upb_array_size(msgval.array_val) == 0)) {
852
+ (!msgval.array_val || upb_Array_Size(msgval.array_val) == 0)) {
814
853
  continue;
815
854
  }
816
855
  msg_value = RepeatedField_CreateArray(msgval.array_val, type_info);
@@ -824,8 +863,8 @@ static VALUE Message_CreateHash(const upb_msg *msg, const upb_msgdef *m) {
824
863
  return hash;
825
864
  }
826
865
 
827
- VALUE Scalar_CreateHash(upb_msgval msgval, TypeInfo type_info) {
828
- if (type_info.type == UPB_TYPE_MESSAGE) {
866
+ VALUE Scalar_CreateHash(upb_MessageValue msgval, TypeInfo type_info) {
867
+ if (type_info.type == kUpb_CType_Message) {
829
868
  return Message_CreateHash(msgval.msg_val, type_info.def.msgdef);
830
869
  } else {
831
870
  return Convert_UpbToRuby(msgval, type_info, Qnil);
@@ -868,10 +907,10 @@ static VALUE Message_freeze(VALUE _self) {
868
907
  */
869
908
  static VALUE Message_index(VALUE _self, VALUE field_name) {
870
909
  Message* self = ruby_to_Message(_self);
871
- const upb_fielddef* field;
910
+ const upb_FieldDef* field;
872
911
 
873
912
  Check_Type(field_name, T_STRING);
874
- field = upb_msgdef_ntofz(self->msgdef, RSTRING_PTR(field_name));
913
+ field = upb_MessageDef_FindFieldByName(self->msgdef, RSTRING_PTR(field_name));
875
914
 
876
915
  if (field == NULL) {
877
916
  return Qnil;
@@ -889,32 +928,54 @@ static VALUE Message_index(VALUE _self, VALUE field_name) {
889
928
  */
890
929
  static VALUE Message_index_set(VALUE _self, VALUE field_name, VALUE value) {
891
930
  Message* self = ruby_to_Message(_self);
892
- const upb_fielddef* f;
893
- upb_msgval val;
894
- upb_arena *arena = Arena_get(self->arena);
931
+ const upb_FieldDef* f;
932
+ upb_MessageValue val;
933
+ upb_Arena* arena = Arena_get(self->arena);
895
934
 
896
935
  Check_Type(field_name, T_STRING);
897
- f = upb_msgdef_ntofz(self->msgdef, RSTRING_PTR(field_name));
936
+ f = upb_MessageDef_FindFieldByName(self->msgdef, RSTRING_PTR(field_name));
898
937
 
899
938
  if (f == NULL) {
900
939
  rb_raise(rb_eArgError, "Unknown field: %s", RSTRING_PTR(field_name));
901
940
  }
902
941
 
903
- val = Convert_RubyToUpb(value, upb_fielddef_name(f), TypeInfo_get(f), arena);
904
- upb_msg_set(Message_GetMutable(_self, NULL), f, val, arena);
942
+ val = Convert_RubyToUpb(value, upb_FieldDef_Name(f), TypeInfo_get(f), arena);
943
+ upb_Message_Set(Message_GetMutable(_self, NULL), f, val, arena);
905
944
 
906
945
  return Qnil;
907
946
  }
908
947
 
909
948
  /*
910
949
  * call-seq:
911
- * MessageClass.decode(data) => message
950
+ * MessageClass.decode(data, options) => message
912
951
  *
913
952
  * Decodes the given data (as a string containing bytes in protocol buffers wire
914
953
  * format) under the interpretration given by this message class's definition
915
954
  * and returns a message object with the corresponding field values.
955
+ * @param options [Hash] options for the decoder
956
+ * recursion_limit: set to maximum decoding depth for message (default is 64)
916
957
  */
917
- static VALUE Message_decode(VALUE klass, VALUE data) {
958
+ static VALUE Message_decode(int argc, VALUE* argv, VALUE klass) {
959
+ VALUE data = argv[0];
960
+ int options = 0;
961
+
962
+ if (argc < 1 || argc > 2) {
963
+ rb_raise(rb_eArgError, "Expected 1 or 2 arguments.");
964
+ }
965
+
966
+ if (argc == 2) {
967
+ VALUE hash_args = argv[1];
968
+ if (TYPE(hash_args) != T_HASH) {
969
+ rb_raise(rb_eArgError, "Expected hash arguments.");
970
+ }
971
+
972
+ VALUE depth = rb_hash_lookup(hash_args, ID2SYM(rb_intern("recursion_limit")));
973
+
974
+ if (depth != Qnil && TYPE(depth) == T_FIXNUM) {
975
+ options |= UPB_DECODE_MAXDEPTH(FIX2INT(depth));
976
+ }
977
+ }
978
+
918
979
  if (TYPE(data) != T_STRING) {
919
980
  rb_raise(rb_eArgError, "Expected string for binary protobuf data.");
920
981
  }
@@ -922,9 +983,11 @@ static VALUE Message_decode(VALUE klass, VALUE data) {
922
983
  VALUE msg_rb = initialize_rb_class_with_no_args(klass);
923
984
  Message* msg = ruby_to_Message(msg_rb);
924
985
 
925
- if (!upb_decode(RSTRING_PTR(data), RSTRING_LEN(data), (upb_msg*)msg->msg,
926
- upb_msgdef_layout(msg->msgdef),
927
- Arena_get(msg->arena))) {
986
+ upb_DecodeStatus status = upb_Decode(
987
+ RSTRING_PTR(data), RSTRING_LEN(data), (upb_Message*)msg->msg,
988
+ upb_MessageDef_MiniTable(msg->msgdef), NULL, options, Arena_get(msg->arena));
989
+
990
+ if (status != kUpb_DecodeStatus_Ok) {
928
991
  rb_raise(cParseError, "Error occurred during parsing");
929
992
  }
930
993
 
@@ -946,10 +1009,10 @@ static VALUE Message_decode(VALUE klass, VALUE data) {
946
1009
  static VALUE Message_decode_json(int argc, VALUE* argv, VALUE klass) {
947
1010
  VALUE data = argv[0];
948
1011
  int options = 0;
949
- upb_status status;
1012
+ upb_Status status;
950
1013
 
951
1014
  // TODO(haberman): use this message's pool instead.
952
- const upb_symtab *symtab = DescriptorPool_GetSymtab(generated_pool);
1015
+ const upb_DefPool* symtab = DescriptorPool_GetSymtab(generated_pool);
953
1016
 
954
1017
  if (argc < 1 || argc > 2) {
955
1018
  rb_raise(rb_eArgError, "Expected 1 or 2 arguments.");
@@ -961,8 +1024,9 @@ static VALUE Message_decode_json(int argc, VALUE* argv, VALUE klass) {
961
1024
  rb_raise(rb_eArgError, "Expected hash arguments.");
962
1025
  }
963
1026
 
964
- if (RTEST(rb_hash_lookup2( hash_args, ID2SYM(rb_intern("ignore_unknown_fields")), Qfalse))) {
965
- options |= UPB_JSONDEC_IGNOREUNKNOWN;
1027
+ if (RTEST(rb_hash_lookup2(
1028
+ hash_args, ID2SYM(rb_intern("ignore_unknown_fields")), Qfalse))) {
1029
+ options |= upb_JsonDecode_IgnoreUnknown;
966
1030
  }
967
1031
  }
968
1032
 
@@ -978,16 +1042,16 @@ static VALUE Message_decode_json(int argc, VALUE* argv, VALUE klass) {
978
1042
  Message* msg = ruby_to_Message(msg_rb);
979
1043
 
980
1044
  // We don't allow users to decode a wrapper type directly.
981
- if (upb_msgdef_iswrapper(msg->msgdef)) {
1045
+ if (IsWrapper(msg->msgdef)) {
982
1046
  rb_raise(rb_eRuntimeError, "Cannot parse a wrapper directly.");
983
1047
  }
984
1048
 
985
- upb_status_clear(&status);
986
- if (!upb_json_decode(RSTRING_PTR(data), RSTRING_LEN(data), (upb_msg*)msg->msg,
987
- msg->msgdef, symtab, options,
988
- Arena_get(msg->arena), &status)) {
1049
+ upb_Status_Clear(&status);
1050
+ if (!upb_JsonDecode(RSTRING_PTR(data), RSTRING_LEN(data),
1051
+ (upb_Message*)msg->msg, msg->msgdef, symtab, options,
1052
+ Arena_get(msg->arena), &status)) {
989
1053
  rb_raise(cParseError, "Error occurred during parsing: %s",
990
- upb_status_errmsg(&status));
1054
+ upb_Status_ErrorMessage(&status));
991
1055
  }
992
1056
 
993
1057
  return msg_rb;
@@ -995,31 +1059,51 @@ static VALUE Message_decode_json(int argc, VALUE* argv, VALUE klass) {
995
1059
 
996
1060
  /*
997
1061
  * call-seq:
998
- * MessageClass.encode(msg) => bytes
1062
+ * MessageClass.encode(msg, options) => bytes
999
1063
  *
1000
1064
  * Encodes the given message object to its serialized form in protocol buffers
1001
1065
  * wire format.
1066
+ * @param options [Hash] options for the encoder
1067
+ * recursion_limit: set to maximum encoding depth for message (default is 64)
1002
1068
  */
1003
- static VALUE Message_encode(VALUE klass, VALUE msg_rb) {
1004
- Message* msg = ruby_to_Message(msg_rb);
1005
- upb_arena *arena = upb_arena_new();
1006
- const char *data;
1069
+ static VALUE Message_encode(int argc, VALUE* argv, VALUE klass) {
1070
+ Message* msg = ruby_to_Message(argv[0]);
1071
+ int options = 0;
1072
+ const char* data;
1007
1073
  size_t size;
1008
1074
 
1009
- if (CLASS_OF(msg_rb) != klass) {
1075
+ if (CLASS_OF(argv[0]) != klass) {
1010
1076
  rb_raise(rb_eArgError, "Message of wrong type.");
1011
1077
  }
1012
1078
 
1013
- data = upb_encode(msg->msg, upb_msgdef_layout(msg->msgdef), arena,
1014
- &size);
1079
+ if (argc < 1 || argc > 2) {
1080
+ rb_raise(rb_eArgError, "Expected 1 or 2 arguments.");
1081
+ }
1082
+
1083
+ if (argc == 2) {
1084
+ VALUE hash_args = argv[1];
1085
+ if (TYPE(hash_args) != T_HASH) {
1086
+ rb_raise(rb_eArgError, "Expected hash arguments.");
1087
+ }
1088
+ VALUE depth = rb_hash_lookup(hash_args, ID2SYM(rb_intern("recursion_limit")));
1089
+
1090
+ if (depth != Qnil && TYPE(depth) == T_FIXNUM) {
1091
+ options |= UPB_DECODE_MAXDEPTH(FIX2INT(depth));
1092
+ }
1093
+ }
1094
+
1095
+ upb_Arena *arena = upb_Arena_New();
1096
+
1097
+ data = upb_Encode(msg->msg, upb_MessageDef_MiniTable(msg->msgdef),
1098
+ options, arena, &size);
1015
1099
 
1016
1100
  if (data) {
1017
1101
  VALUE ret = rb_str_new(data, size);
1018
1102
  rb_enc_associate(ret, rb_ascii8bit_encoding());
1019
- upb_arena_free(arena);
1103
+ upb_Arena_Free(arena);
1020
1104
  return ret;
1021
1105
  } else {
1022
- upb_arena_free(arena);
1106
+ upb_Arena_Free(arena);
1023
1107
  rb_raise(rb_eRuntimeError, "Exceeded maximum depth (possibly cycle)");
1024
1108
  }
1025
1109
  }
@@ -1030,18 +1114,19 @@ static VALUE Message_encode(VALUE klass, VALUE msg_rb) {
1030
1114
  *
1031
1115
  * Encodes the given message object into its serialized JSON representation.
1032
1116
  * @param options [Hash] options for the decoder
1033
- * preserve_proto_fieldnames: set true to use original fieldnames (default is to camelCase)
1034
- * emit_defaults: set true to emit 0/false values (default is to omit them)
1117
+ * preserve_proto_fieldnames: set true to use original fieldnames (default is
1118
+ * to camelCase) emit_defaults: set true to emit 0/false values (default is to
1119
+ * omit them)
1035
1120
  */
1036
1121
  static VALUE Message_encode_json(int argc, VALUE* argv, VALUE klass) {
1037
1122
  Message* msg = ruby_to_Message(argv[0]);
1038
1123
  int options = 0;
1039
1124
  char buf[1024];
1040
1125
  size_t size;
1041
- upb_status status;
1126
+ upb_Status status;
1042
1127
 
1043
1128
  // TODO(haberman): use this message's pool instead.
1044
- const upb_symtab *symtab = DescriptorPool_GetSymtab(generated_pool);
1129
+ const upb_DefPool* symtab = DescriptorPool_GetSymtab(generated_pool);
1045
1130
 
1046
1131
  if (argc < 1 || argc > 2) {
1047
1132
  rb_raise(rb_eArgError, "Expected 1 or 2 arguments.");
@@ -1050,35 +1135,39 @@ static VALUE Message_encode_json(int argc, VALUE* argv, VALUE klass) {
1050
1135
  if (argc == 2) {
1051
1136
  VALUE hash_args = argv[1];
1052
1137
  if (TYPE(hash_args) != T_HASH) {
1053
- rb_raise(rb_eArgError, "Expected hash arguments.");
1138
+ if (RTEST(rb_funcall(hash_args, rb_intern("respond_to?"), 1, rb_str_new2("to_h")))) {
1139
+ hash_args = rb_funcall(hash_args, rb_intern("to_h"), 0);
1140
+ } else {
1141
+ rb_raise(rb_eArgError, "Expected hash arguments.");
1142
+ }
1054
1143
  }
1055
1144
 
1056
1145
  if (RTEST(rb_hash_lookup2(hash_args,
1057
1146
  ID2SYM(rb_intern("preserve_proto_fieldnames")),
1058
1147
  Qfalse))) {
1059
- options |= UPB_JSONENC_PROTONAMES;
1148
+ options |= upb_JsonEncode_UseProtoNames;
1060
1149
  }
1061
1150
 
1062
1151
  if (RTEST(rb_hash_lookup2(hash_args, ID2SYM(rb_intern("emit_defaults")),
1063
1152
  Qfalse))) {
1064
- options |= UPB_JSONENC_EMITDEFAULTS;
1153
+ options |= upb_JsonEncode_EmitDefaults;
1065
1154
  }
1066
1155
  }
1067
1156
 
1068
- upb_status_clear(&status);
1069
- size = upb_json_encode(msg->msg, msg->msgdef, symtab, options, buf,
1070
- sizeof(buf), &status);
1157
+ upb_Status_Clear(&status);
1158
+ size = upb_JsonEncode(msg->msg, msg->msgdef, symtab, options, buf,
1159
+ sizeof(buf), &status);
1071
1160
 
1072
- if (!upb_ok(&status)) {
1161
+ if (!upb_Status_IsOk(&status)) {
1073
1162
  rb_raise(cParseError, "Error occurred during encoding: %s",
1074
- upb_status_errmsg(&status));
1163
+ upb_Status_ErrorMessage(&status));
1075
1164
  }
1076
1165
 
1077
1166
  VALUE ret;
1078
1167
  if (size >= sizeof(buf)) {
1079
1168
  char* buf2 = malloc(size + 1);
1080
- upb_json_encode(msg->msg, msg->msgdef, symtab, options, buf2, size + 1,
1081
- &status);
1169
+ upb_JsonEncode(msg->msg, msg->msgdef, symtab, options, buf2, size + 1,
1170
+ &status);
1082
1171
  ret = rb_str_new(buf2, size);
1083
1172
  free(buf2);
1084
1173
  } else {
@@ -1101,10 +1190,10 @@ static VALUE Message_descriptor(VALUE klass) {
1101
1190
  }
1102
1191
 
1103
1192
  VALUE build_class_from_descriptor(VALUE descriptor) {
1104
- const char *name;
1193
+ const char* name;
1105
1194
  VALUE klass;
1106
1195
 
1107
- name = upb_msgdef_fullname(Descriptor_GetMsgDef(descriptor));
1196
+ name = upb_MessageDef_FullName(Descriptor_GetMsgDef(descriptor));
1108
1197
  if (name == NULL) {
1109
1198
  rb_raise(rb_eRuntimeError, "Descriptor does not have assigned name.");
1110
1199
  }
@@ -1112,8 +1201,7 @@ VALUE build_class_from_descriptor(VALUE descriptor) {
1112
1201
  klass = rb_define_class_id(
1113
1202
  // Docs say this parameter is ignored. User will assign return value to
1114
1203
  // their own toplevel constant class name.
1115
- rb_intern("Message"),
1116
- rb_cObject);
1204
+ rb_intern("Message"), rb_cObject);
1117
1205
  rb_ivar_set(klass, descriptor_instancevar_interned, descriptor);
1118
1206
  rb_define_alloc_func(klass, Message_alloc);
1119
1207
  rb_require("google/protobuf/message_exts");
@@ -1121,10 +1209,9 @@ VALUE build_class_from_descriptor(VALUE descriptor) {
1121
1209
  rb_extend_object(
1122
1210
  klass, rb_eval_string("::Google::Protobuf::MessageExts::ClassMethods"));
1123
1211
 
1124
- rb_define_method(klass, "method_missing",
1125
- Message_method_missing, -1);
1126
- rb_define_method(klass, "respond_to_missing?",
1127
- Message_respond_to_missing, -1);
1212
+ rb_define_method(klass, "method_missing", Message_method_missing, -1);
1213
+ rb_define_method(klass, "respond_to_missing?", Message_respond_to_missing,
1214
+ -1);
1128
1215
  rb_define_method(klass, "initialize", Message_initialize, -1);
1129
1216
  rb_define_method(klass, "dup", Message_dup, 0);
1130
1217
  // Also define #clone so that we don't inherit Object#clone.
@@ -1138,8 +1225,8 @@ VALUE build_class_from_descriptor(VALUE descriptor) {
1138
1225
  rb_define_method(klass, "to_s", Message_inspect, 0);
1139
1226
  rb_define_method(klass, "[]", Message_index, 1);
1140
1227
  rb_define_method(klass, "[]=", Message_index_set, 2);
1141
- rb_define_singleton_method(klass, "decode", Message_decode, 1);
1142
- rb_define_singleton_method(klass, "encode", Message_encode, 1);
1228
+ rb_define_singleton_method(klass, "decode", Message_decode, -1);
1229
+ rb_define_singleton_method(klass, "encode", Message_encode, -1);
1143
1230
  rb_define_singleton_method(klass, "decode_json", Message_decode_json, -1);
1144
1231
  rb_define_singleton_method(klass, "encode_json", Message_encode_json, -1);
1145
1232
  rb_define_singleton_method(klass, "descriptor", Message_descriptor, 0);
@@ -1157,13 +1244,12 @@ VALUE build_class_from_descriptor(VALUE descriptor) {
1157
1244
  static VALUE enum_lookup(VALUE self, VALUE number) {
1158
1245
  int32_t num = NUM2INT(number);
1159
1246
  VALUE desc = rb_ivar_get(self, descriptor_instancevar_interned);
1160
- const upb_enumdef *e = EnumDescriptor_GetEnumDef(desc);
1161
-
1162
- const char* name = upb_enumdef_iton(e, num);
1163
- if (name == NULL) {
1164
- return Qnil;
1247
+ const upb_EnumDef* e = EnumDescriptor_GetEnumDef(desc);
1248
+ const upb_EnumValueDef* ev = upb_EnumDef_FindValueByNumber(e, num);
1249
+ if (ev) {
1250
+ return ID2SYM(rb_intern(upb_EnumValueDef_Name(ev)));
1165
1251
  } else {
1166
- return ID2SYM(rb_intern(name));
1252
+ return Qnil;
1167
1253
  }
1168
1254
  }
1169
1255
 
@@ -1177,14 +1263,12 @@ static VALUE enum_lookup(VALUE self, VALUE number) {
1177
1263
  static VALUE enum_resolve(VALUE self, VALUE sym) {
1178
1264
  const char* name = rb_id2name(SYM2ID(sym));
1179
1265
  VALUE desc = rb_ivar_get(self, descriptor_instancevar_interned);
1180
- const upb_enumdef *e = EnumDescriptor_GetEnumDef(desc);
1181
-
1182
- int32_t num = 0;
1183
- bool found = upb_enumdef_ntoiz(e, name, &num);
1184
- if (!found) {
1185
- return Qnil;
1266
+ const upb_EnumDef* e = EnumDescriptor_GetEnumDef(desc);
1267
+ const upb_EnumValueDef* ev = upb_EnumDef_FindValueByName(e, name);
1268
+ if (ev) {
1269
+ return INT2NUM(upb_EnumValueDef_Number(ev));
1186
1270
  } else {
1187
- return INT2NUM(num);
1271
+ return Qnil;
1188
1272
  }
1189
1273
  }
1190
1274
 
@@ -1200,21 +1284,28 @@ static VALUE enum_descriptor(VALUE self) {
1200
1284
  }
1201
1285
 
1202
1286
  VALUE build_module_from_enumdesc(VALUE _enumdesc) {
1203
- const upb_enumdef *e = EnumDescriptor_GetEnumDef(_enumdesc);
1204
- VALUE mod = rb_define_module_id(rb_intern(upb_enumdef_fullname(e)));
1205
-
1206
- upb_enum_iter it;
1207
- for (upb_enum_begin(&it, e);
1208
- !upb_enum_done(&it);
1209
- upb_enum_next(&it)) {
1210
- const char* name = upb_enum_iter_name(&it);
1211
- int32_t value = upb_enum_iter_number(&it);
1287
+ const upb_EnumDef* e = EnumDescriptor_GetEnumDef(_enumdesc);
1288
+ VALUE mod = rb_define_module_id(rb_intern(upb_EnumDef_FullName(e)));
1289
+
1290
+ int n = upb_EnumDef_ValueCount(e);
1291
+ for (int i = 0; i < n; i++) {
1292
+ const upb_EnumValueDef* ev = upb_EnumDef_Value(e, i);
1293
+ upb_Arena* arena = upb_Arena_New();
1294
+ const char* src_name = upb_EnumValueDef_Name(ev);
1295
+ char* name = upb_strdup2(src_name, strlen(src_name), arena);
1296
+ int32_t value = upb_EnumValueDef_Number(ev);
1212
1297
  if (name[0] < 'A' || name[0] > 'Z') {
1213
- rb_warn("Enum value '%s' does not start with an uppercase letter "
1214
- "as is required for Ruby constants.",
1215
- name);
1298
+ if (name[0] >= 'a' && name[0] <= 'z') {
1299
+ name[0] -= 32; // auto capitalize
1300
+ } else {
1301
+ rb_warn(
1302
+ "Enum value '%s' does not start with an uppercase letter "
1303
+ "as is required for Ruby constants.",
1304
+ name);
1305
+ }
1216
1306
  }
1217
1307
  rb_define_const(mod, name, INT2NUM(value));
1308
+ upb_Arena_Free(arena);
1218
1309
  }
1219
1310
 
1220
1311
  rb_define_singleton_method(mod, "lookup", enum_lookup, 1);
@@ -1226,84 +1317,84 @@ VALUE build_module_from_enumdesc(VALUE _enumdesc) {
1226
1317
  }
1227
1318
 
1228
1319
  // Internal only; used by Google::Protobuf.deep_copy.
1229
- upb_msg* Message_deep_copy(const upb_msg* msg, const upb_msgdef* m,
1230
- upb_arena *arena) {
1320
+ upb_Message* Message_deep_copy(const upb_Message* msg, const upb_MessageDef* m,
1321
+ upb_Arena* arena) {
1231
1322
  // Serialize and parse.
1232
- upb_arena *tmp_arena = upb_arena_new();
1233
- const upb_msglayout *layout = upb_msgdef_layout(m);
1323
+ upb_Arena* tmp_arena = upb_Arena_New();
1324
+ const upb_MiniTable* layout = upb_MessageDef_MiniTable(m);
1234
1325
  size_t size;
1235
1326
 
1236
- char* data = upb_encode_ex(msg, layout, 0, tmp_arena, &size);
1237
- upb_msg* new_msg = upb_msg_new(m, arena);
1327
+ char* data = upb_Encode(msg, layout, 0, tmp_arena, &size);
1328
+ upb_Message* new_msg = upb_Message_New(m, arena);
1238
1329
 
1239
- if (!data || !upb_decode(data, size, new_msg, layout, arena)) {
1240
- upb_arena_free(tmp_arena);
1330
+ if (!data || upb_Decode(data, size, new_msg, layout, NULL, 0, arena) !=
1331
+ kUpb_DecodeStatus_Ok) {
1332
+ upb_Arena_Free(tmp_arena);
1241
1333
  rb_raise(cParseError, "Error occurred copying proto");
1242
1334
  }
1243
1335
 
1244
- upb_arena_free(tmp_arena);
1336
+ upb_Arena_Free(tmp_arena);
1245
1337
  return new_msg;
1246
1338
  }
1247
1339
 
1248
- const upb_msg* Message_GetUpbMessage(VALUE value, const upb_msgdef* m,
1249
- const char* name, upb_arena* arena) {
1340
+ const upb_Message* Message_GetUpbMessage(VALUE value, const upb_MessageDef* m,
1341
+ const char* name, upb_Arena* arena) {
1250
1342
  if (value == Qnil) {
1251
1343
  rb_raise(cTypeError, "nil message not allowed here.");
1252
1344
  }
1253
1345
 
1254
1346
  VALUE klass = CLASS_OF(value);
1255
1347
  VALUE desc_rb = rb_ivar_get(klass, descriptor_instancevar_interned);
1256
- const upb_msgdef* val_m =
1348
+ const upb_MessageDef* val_m =
1257
1349
  desc_rb == Qnil ? NULL : Descriptor_GetMsgDef(desc_rb);
1258
1350
 
1259
1351
  if (val_m != m) {
1260
1352
  // Check for possible implicit conversions
1261
1353
  // TODO: hash conversion?
1262
1354
 
1263
- switch (upb_msgdef_wellknowntype(m)) {
1264
- case UPB_WELLKNOWN_TIMESTAMP: {
1355
+ switch (upb_MessageDef_WellKnownType(m)) {
1356
+ case kUpb_WellKnown_Timestamp: {
1265
1357
  // Time -> Google::Protobuf::Timestamp
1266
- upb_msg *msg = upb_msg_new(m, arena);
1267
- upb_msgval sec, nsec;
1358
+ upb_Message* msg = upb_Message_New(m, arena);
1359
+ upb_MessageValue sec, nsec;
1268
1360
  struct timespec time;
1269
- const upb_fielddef *sec_f = upb_msgdef_itof(m, 1);
1270
- const upb_fielddef *nsec_f = upb_msgdef_itof(m, 2);
1361
+ const upb_FieldDef* sec_f = upb_MessageDef_FindFieldByNumber(m, 1);
1362
+ const upb_FieldDef* nsec_f = upb_MessageDef_FindFieldByNumber(m, 2);
1271
1363
 
1272
1364
  if (!rb_obj_is_kind_of(value, rb_cTime)) goto badtype;
1273
1365
 
1274
1366
  time = rb_time_timespec(value);
1275
1367
  sec.int64_val = time.tv_sec;
1276
1368
  nsec.int32_val = time.tv_nsec;
1277
- upb_msg_set(msg, sec_f, sec, arena);
1278
- upb_msg_set(msg, nsec_f, nsec, arena);
1369
+ upb_Message_Set(msg, sec_f, sec, arena);
1370
+ upb_Message_Set(msg, nsec_f, nsec, arena);
1279
1371
  return msg;
1280
1372
  }
1281
- case UPB_WELLKNOWN_DURATION: {
1373
+ case kUpb_WellKnown_Duration: {
1282
1374
  // Numeric -> Google::Protobuf::Duration
1283
- upb_msg *msg = upb_msg_new(m, arena);
1284
- upb_msgval sec, nsec;
1285
- const upb_fielddef *sec_f = upb_msgdef_itof(m, 1);
1286
- const upb_fielddef *nsec_f = upb_msgdef_itof(m, 2);
1375
+ upb_Message* msg = upb_Message_New(m, arena);
1376
+ upb_MessageValue sec, nsec;
1377
+ const upb_FieldDef* sec_f = upb_MessageDef_FindFieldByNumber(m, 1);
1378
+ const upb_FieldDef* nsec_f = upb_MessageDef_FindFieldByNumber(m, 2);
1287
1379
 
1288
1380
  if (!rb_obj_is_kind_of(value, rb_cNumeric)) goto badtype;
1289
1381
 
1290
1382
  sec.int64_val = NUM2LL(value);
1291
1383
  nsec.int32_val = round((NUM2DBL(value) - NUM2LL(value)) * 1000000000);
1292
- upb_msg_set(msg, sec_f, sec, arena);
1293
- upb_msg_set(msg, nsec_f, nsec, arena);
1384
+ upb_Message_Set(msg, sec_f, sec, arena);
1385
+ upb_Message_Set(msg, nsec_f, nsec, arena);
1294
1386
  return msg;
1295
1387
  }
1296
1388
  default:
1297
1389
  badtype:
1298
1390
  rb_raise(cTypeError,
1299
1391
  "Invalid type %s to assign to submessage field '%s'.",
1300
- rb_class2name(CLASS_OF(value)), name);
1392
+ rb_class2name(CLASS_OF(value)), name);
1301
1393
  }
1302
-
1303
1394
  }
1304
1395
 
1305
1396
  Message* self = ruby_to_Message(value);
1306
- upb_arena_fuse(arena, Arena_get(self->arena));
1397
+ Arena_fuse(self->arena, arena);
1307
1398
 
1308
1399
  return self->msg;
1309
1400
  }