google-maps 2.2.0 → 3.0.0

data/spec/google_maps/route_spec.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require File.expand_path('../spec_helper', __dir__)
+
+describe Google::Maps::Route do
+  describe 'dutch' do
+    before(:each) do
+      stub_response('amsterdam-deventer-nl.json')
+      @route = Google::Maps::Route.new('Science Park, Amsterdam', 'Deventer', :nl)
+    end
+
+    it 'should be able to calculate a route' do
+      expect(@route.distance.text).to eq('104 km')
+      expect(@route.duration.text).to eq('1 uur 12 min.')
+      expect(@route.distance.value).to eq(103_712)
+      expect(@route.duration.value).to eq(4337)
+    end
+
+    it 'should be able to present the text in Dutch' do
+      expect(@route.options[:language]).to eq(:nl)
+      expect(@route.end_address).to eq('Deventer, Nederland')
+    end
+
+    it 'should be able to return the address for the origin' do
+      expect(@route.start_address).to eq('Science Park, 1098 Amsterdam, Nederland')
+    end
+
+    it 'should be able to return the address for the destination' do
+      expect(@route.end_address).to eq('Deventer, Nederland')
+    end
+
+    it 'should be able to return the latiude and longitude for the origin' do
+      expect(@route.start_location.lat).to eq(52.35445000000001)
+      expect(@route.start_location.lng).to eq(4.95420)
+      expect(@route.origin_latlong).to eq('52.35445000000001,4.9542')
+    end
+
+    it 'should be able to return the latiude and longitude for the destination' do
+      expect(@route.end_location.lat).to eq(52.25441000000001)
+      expect(@route.end_location.lng).to eq(6.160470)
+      expect(@route.destination_latlong).to eq('52.25441000000001,6.16047')
+    end
+  end
+
+  describe 'english' do
+    it 'should be able to present the text in English' do
+      stub_response('amsterdam-deventer-en.json')
+      route = Google::Maps::Route.new('Science Park, Amsterdam', 'Deventer', :en)
+      expect(route.options[:language]).to eq(:en)
+      expect(route.end_address).to eq('Deventer, The Netherlands')
+    end
+  end
+end

data/spec/google_maps_spec.rb

@@ -0,0 +1,174 @@
+# frozen_string_literal: true
+
+require File.expand_path('spec_helper', __dir__)
+
+describe Google::Maps do
+  describe 'Directions' do
+    before(:each) do
+      stub_response('amsterdam-deventer-en.json')
+    end
+
+    it 'should be able to calculate a route' do
+      route = Google::Maps.route('Science Park, Amsterdam', 'Deventer')
+      expect(route.class).to eq(Google::Maps::Route)
+      expect(route.distance.text).to eq('104 km')
+      expect(route.duration.text).to eq('1 hour 12 mins')
+      expect(route.distance.value).to eq(103_712)
+      expect(route.duration.value).to eq(4337)
+    end
+
+    it 'should be able to calculate the distance' do
+      expect(Google::Maps.distance('Science Park, Amsterdam', 'Deventer')).to eq('104 km')
+    end
+
+    it 'should be able to calculate the duration' do
+      expect(Google::Maps.duration('Science Park, Amsterdam', 'Deventer')).to eq('1 hour 12 mins')
+    end
+  end
+
+  describe 'Places' do
+    before(:each) do
+      stub_response('deventer-en.json')
+    end
+
+    it 'should find a list of places for a keyword' do
+      place = Google::Maps.places('Deventer').first
+      expect(place.class).to eq(Google::Maps::Place)
+      expect(place.text).to eq('Deventer, The Netherlands')
+      expect(place.html).to eq('<strong>Deventer</strong>, The Netherlands')
+    end
+  end
+
+  describe 'Geocoder' do
+    it 'should lookup a latlong for an address' do
+      stub_response('geocoder/science-park-400-amsterdam-en.json')
+
+      location = Google::Maps.geocode('Science Park 400, Amsterdam').first
+      expect(location.class).to eq(Google::Maps::Location)
+      expect(location.address).to eq('Science Park Amsterdam 400, University of Amsterdam, 1098 XH Amsterdam, The Netherlands')
+      expect(location.latitude).to eq(52.3564490)
+      expect(location.longitude).to eq(4.95568890)
+
+      expect(location.lat_lng).to eq([52.3564490, 4.95568890])
+    end
+
+    it 'should handle multiple location for an address' do
+      stub_response('geocoder/amsterdam-en.json')
+
+      locations = Google::Maps.geocode('Amsterdam')
+      expect(locations).to have(2).items
+      location = locations.last
+      expect(location.address).to eq('Amsterdam, NY, USA')
+      expect(location.latitude).to eq(42.93868560)
+      expect(location.longitude).to eq(-74.18818580)
+    end
+
+    it 'should accept languages other than en' do
+      stub_response('geocoder/science-park-400-amsterdam-nl.json')
+
+      location = Google::Maps.geocode('Science Park 400, Amsterdam', :nl).first
+      expect(location.address).to eq('Science Park 400, Amsterdam, 1098 XH Amsterdam, Nederland')
+    end
+
+    it 'should return an empty array when an address could not be geocoded' do
+      stub_response('zero-results.json')
+
+      expect(Google::Maps.geocode('Amsterdam')).to eq([])
+    end
+  end
+
+  describe '.end_point=' do
+    it 'should set the end_point' do
+      Google::Maps.end_point = 'http://maps.google.com/'
+      expect(Google::Maps.end_point).to eq('http://maps.google.com/')
+    end
+  end
+
+  describe '.options' do
+    it 'should return a hash with the current settings' do
+      Google::Maps.end_point = 'test end point'
+      Google::Maps.options == { end_point: 'test end point' }
+    end
+  end
+
+  describe '.configure' do
+    it 'has constants for the authentication methods' do
+      expect(Google::Maps::Configuration::API_KEY).to eq 'api_key'
+      expect(Google::Maps::Configuration::DIGITAL_SIGNATURE).to eq 'digital_signature'
+    end
+
+    context 'api key configuration' do
+      it 'is be possible to set configuration with an api key' do
+        Google::Maps.configure do |config|
+          config.authentication_mode = Google::Maps::Configuration::API_KEY
+          config.api_key = 'xxxxxxxxxxx'
+        end
+
+        expect(Google::Maps.authentication_mode).to eq(Google::Maps::Configuration::API_KEY)
+        expect(Google::Maps.api_key).to eq('xxxxxxxxxxx')
+      end
+
+      it 'fails when no api key is provided' do
+        expect do
+          Google::Maps.configure do |config|
+            config.authentication_mode = Google::Maps::Configuration::API_KEY
+          end
+        end.to raise_error(Google::Maps::InvalidConfigurationError)
+      end
+    end
+
+    context 'digital signature configuration' do
+      it 'is be possible to set configuration with an api key' do
+        Google::Maps.configure do |config|
+          config.authentication_mode = Google::Maps::Configuration::DIGITAL_SIGNATURE
+          config.client_id = 'xxxxxxxxxxx'
+          config.client_secret = 'xxxxxxxxxxx'
+        end
+
+        expect(Google::Maps.authentication_mode).to eq(Google::Maps::Configuration::DIGITAL_SIGNATURE)
+        expect(Google::Maps.client_id).to eq('xxxxxxxxxxx')
+        expect(Google::Maps.client_secret).to eq('xxxxxxxxxxx')
+      end
+
+      it 'fails when no client id is provided' do
+        expect do
+          Google::Maps.configure do |config|
+            config.authentication_mode = Google::Maps::Configuration::DIGITAL_SIGNATURE
+            config.client_secret = 'xxxxxxxxxxx'
+          end
+        end.to raise_error(Google::Maps::InvalidConfigurationError)
+      end
+
+      it 'fails when no client secret is provided' do
+        expect do
+          Google::Maps.configure do |config|
+            config.authentication_mode = Google::Maps::Configuration::DIGITAL_SIGNATURE
+            config.client_id = 'xxxxxxxxxxx'
+          end
+        end.to raise_error(Google::Maps::InvalidConfigurationError)
+      end
+    end
+
+    context 'with invalid authentication mode' do
+      it 'raises an invalid configuration exception' do
+        expect do
+          Google::Maps.configure do |config|
+            config.authentication_mode = 'hack'
+            config.client_secret = 'xxxxxxxxxxx'
+          end
+        end.to raise_error(Google::Maps::InvalidConfigurationError)
+      end
+    end
+
+    Google::Maps::Configuration::VALID_OPTIONS_KEYS.reject { |x| x == :authentication_mode }.each do |key|
+      it "should set the #{key}" do
+        Google::Maps.configure do |config|
+          config.authentication_mode = Google::Maps::Configuration::API_KEY
+          config.api_key = 'xxxxxxxxxxx'
+          config.send("#{key}=", key)
+          expect(Google::Maps.send(key)).to eq(key)
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'coveralls'
 Coveralls.wear!
 
@@ -7,16 +9,13 @@ require 'rspec/collection_matchers'
 require 'simplecov'
 
 SimpleCov.start do
-  add_group 'GoogleMaps', 'lib/google-maps'
+  add_group 'GoogleMaps', 'lib/google_maps'
   add_group 'Specs', 'spec'
   add_filter __FILE__
 end
 
 RSpec.configure do |config|
   config.mock_with :mocha
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.filter_run :focus => true
-  config.run_all_when_everything_filtered = true
 
   config.before(:each) do
     # catch all unmocked requests
@@ -36,7 +35,7 @@ def stub_response(fixture, url = nil)
   fixture_path = File.expand_path("../fixtures/#{fixture}", __FILE__)
   expectation = HTTPClient.any_instance.expects(:get_content)
   expectation.with(url) if url
-  expectation.returns(File.open(fixture_path, "rb").read)
+  expectation.returns(File.open(fixture_path, 'rb').read)
 end
 
-load File.expand_path('../../lib/google-maps.rb', __FILE__)
+load File.expand_path('../lib/google_maps.rb', __dir__)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-maps
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Daniel van Hoesel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-04 00:00:00.000000000 Z
+date: 2018-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -25,47 +25,61 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: 1.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: 1.7.0
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 12.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 12.3.2
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.8.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.8.0
 - !ruby/object:Gem::Dependency
   name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
@@ -81,103 +95,127 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.61.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.61.1
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.9'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.9'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.11
 - !ruby/object:Gem::Dependency
-  name: json
+  name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.5
+        version: 3.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.5
+        version: 3.6.0
 - !ruby/object:Gem::Dependency
-  name: hashie
+  name: httpclient
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.5
+        version: '2.7'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.5
+        version: '2.7'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.7.1
 - !ruby/object:Gem::Dependency
-  name: httpclient
+  name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: '2.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: '2.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: ruby-hmac
   requirement: !ruby/object:Gem::Requirement
@@ -194,26 +232,28 @@ dependencies:
         version: 0.4.0
 description: This is a ruby wrapper for the Google Maps api
 email:
-- daniel@danielvanhoesel.nl
+- info@zilverline.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
-- LICENSE.mkd
-- README.mkd
+- LICENSE.md
+- README.md
 - Rakefile
 - google-maps.gemspec
-- lib/google-maps.rb
-- lib/google-maps/api.rb
-- lib/google-maps/configuration.rb
-- lib/google-maps/location.rb
-- lib/google-maps/logger.rb
-- lib/google-maps/place.rb
-- lib/google-maps/route.rb
-- lib/google-maps/version.rb
+- lib/google_maps.rb
+- lib/google_maps/api.rb
+- lib/google_maps/configuration.rb
+- lib/google_maps/location.rb
+- lib/google_maps/logger.rb
+- lib/google_maps/place.rb
+- lib/google_maps/result.rb
+- lib/google_maps/route.rb
+- lib/google_maps/version.rb
 - spec/fixtures/amsterdam-deventer-en.json
 - spec/fixtures/amsterdam-deventer-nl.json
 - spec/fixtures/den-haag-nl.json
@@ -225,15 +265,16 @@ files:
 - spec/fixtures/over_query_limit.json
 - spec/fixtures/place_details.json
 - spec/fixtures/zero-results.json
-- spec/google-maps/api_spec.rb
-- spec/google-maps/logger_spec.rb
-- spec/google-maps/place_details_spec.rb
-- spec/google-maps/place_spec.rb
-- spec/google-maps/route_spec.rb
-- spec/google-maps_spec.rb
+- spec/google_maps/api_spec.rb
+- spec/google_maps/logger_spec.rb
+- spec/google_maps/place_details_spec.rb
+- spec/google_maps/place_spec.rb
+- spec/google_maps/route_spec.rb
+- spec/google_maps_spec.rb
 - spec/spec_helper.rb
 homepage: http://zilverline.com/
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -251,7 +292,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: google-maps
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper for the Google Maps API
@@ -267,11 +308,10 @@ test_files:
 - spec/fixtures/over_query_limit.json
 - spec/fixtures/place_details.json
 - spec/fixtures/zero-results.json
-- spec/google-maps/api_spec.rb
-- spec/google-maps/logger_spec.rb
-- spec/google-maps/place_details_spec.rb
-- spec/google-maps/place_spec.rb
-- spec/google-maps/route_spec.rb
-- spec/google-maps_spec.rb
+- spec/google_maps/api_spec.rb
+- spec/google_maps/logger_spec.rb
+- spec/google_maps/place_details_spec.rb
+- spec/google_maps/place_spec.rb
+- spec/google_maps/route_spec.rb
+- spec/google_maps_spec.rb
 - spec/spec_helper.rb
-has_rdoc: