google-gax 0.8.10 → 0.8.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76440a4d7dd2108f85483471d10f1a6423f859d5
-  data.tar.gz: abf6c468b2e6a3d4000da9471507739df2396c34
+  metadata.gz: 9b97f693e0972f255cf0b0ddbbf27a63370afc04
+  data.tar.gz: 852fb0aeeeb4312fae5951bcf4a034466dcb38ee
 SHA512:
-  metadata.gz: 4318c6095b0eb2fde132101060f19d8484c9522c9fdeb39feb569a227cdbcff07577708af72f6aebe49e8b21f503e9292751a975355af085c852c2223edd6ad9
-  data.tar.gz: dce53acdbc2064e0fd85b127a01621cf8aa0db94d2952abef5da22eaba60a68828aec8e951846ee3e9d89aae9331d0a52244d13d136bef35e3445a6ed13973fb
+  metadata.gz: 5552ba83b4e65d7889df1fdec4cf3f59d07b96161c5064f7c2344f0eb8299daea86cfddd55e35a1ca01b16dba846d46c34cfe933d15974a0353624862dafc9ca
+  data.tar.gz: 1970759850a9d2ccd7f9655a688b3bf8bbb973442e9ce542dc6b53e21f412c68b3fa0cfe6d20d85f26f06de3e1f552af4ffcd64b659e21235c7f1ca3781a7ad7

data/lib/google/gax/errors.rb

@@ -29,16 +29,21 @@
 
 require 'English'
 
+require 'google/gax/grpc'
+
 module Google
   module Gax
     # Common base class for exceptions raised by GAX.
     class GaxError < StandardError
+      attr_reader :details
+
       # @param msg [String] describes the error that occurred.
       def initialize(msg)
         msg = "GaxError #{msg}"
         msg += ", caused by #{$ERROR_INFO}" if $ERROR_INFO
         super(msg)
         @cause = $ERROR_INFO
+        @details = Google::Gax::Grpc.deserialize_error_status_details(@cause)
       end
 
       # cause is a new method introduced in 2.1.0, bring this

data/lib/google/gax/grpc.rb

@@ -28,8 +28,12 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 require 'grpc'
+require 'grpc/google_rpc_status_utils'
 require 'googleauth'
 require 'google/gax/errors'
+require 'google/protobuf/well_known_types'
+# Required in order to deserialize common error detail proto types
+require 'google/rpc/error_details_pb'
 
 module Google
   module Gax
@@ -43,6 +47,35 @@ module Google
 
       API_ERRORS = [GRPC::BadStatus, GRPC::Cancelled].freeze
 
+      def deserialize_error_status_details(error)
+        return unless error.is_a? GRPC::BadStatus
+        # If error status is malformed, swallow the gRPC error that gets raised.
+        begin
+          details =
+            GRPC::GoogleRpcStatusUtils.extract_google_rpc_status(
+              error.to_status
+            ).details
+        rescue
+          return 'Could not parse error details due to a malformed server '\
+                 'response trailer.'
+        end
+        return if details.nil?
+        details =
+          GRPC::GoogleRpcStatusUtils.extract_google_rpc_status(
+            error.to_status
+          ).details
+        details.map do |any|
+          # If the type of the proto wrapped by the Any instance is not
+          # available, do not deserialize.
+          candidate_class_name = class_case(any.type_name.split('.')).join('::')
+          begin
+            any.unpack(Object.const_get(candidate_class_name))
+          rescue NameError
+            any
+          end
+        end
+      end
+
       # rubocop:disable Metrics/ParameterLists
 
       # Creates a gRPC client stub.
@@ -97,7 +130,7 @@ module Google
         end
       end
 
-      module_function :create_stub
+      module_function :create_stub, :deserialize_error_status_details
 
       def self.verify_params(channel, chan_creds, updater_proc)
         if (channel && chan_creds) ||
@@ -109,7 +142,15 @@ module Google
         end
       end
 
-      private_class_method :verify_params
+      # Capitalize all modules except the message class, which is already
+      # correctly cased
+      def self.class_case(modules)
+        message = modules.pop
+        modules = modules.map(&:capitalize)
+        modules << message
+      end
+
+      private_class_method :verify_params, :class_case
     end
   end
 end

data/lib/google/gax/util.rb

@@ -42,12 +42,21 @@ module Google
     # messages using hashes but does not allow for nested hashes to instantiate
     # nested submessages.
     #
-    # @param hash [Hash] The hash to be converted into a proto message.
+    # @param hash [Hash || Class] The hash to be converted into a proto message.
+    #   If an instance of the proto message class is given, it is returned
+    #   unchanged.
     # @param message_class [Class] The corresponding protobuf message class of
     #   the given hash.
     #
     # @return [Object] An instance of the given message class.
     def to_proto(hash, message_class)
+      return hash if hash.is_a? message_class
+
+      # Sanity check: input must be a Hash
+      unless hash.is_a? Hash
+        raise ArgumentError,
+              "Value #{hash} must be a Hash or a #{message_class.name}"
+      end
       hash = coerce_submessages(hash, message_class)
       message_class.new(hash)
     end

data/lib/google/gax/version.rb

@@ -29,6 +29,6 @@
 
 module Google
   module Gax
-    VERSION = '0.8.10'.freeze
+    VERSION = '0.8.12'.freeze
   end
 end

data/spec/google/gax/util_spec.rb

@@ -28,6 +28,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 require 'google/gax'
+require 'google/protobuf/any_pb'
 require 'spec/fixtures/fixture_pb'
 
 describe Google::Gax do
@@ -118,5 +119,20 @@ describe Google::Gax do
         Google::Gax.to_proto(user_hash, Google::Protobuf::User)
       end.to raise_error(ArgumentError)
     end
+
+    it 'handles proto messages' do
+      user_message = Google::Protobuf::User.new(
+        name: USER_NAME, type: USER_TYPE
+      )
+      user = Google::Gax.to_proto(user_message, Google::Protobuf::User)
+      expect(user).to eq user_message
+    end
+
+    it 'fails if proto message has unexpected type' do
+      user_message = Google::Protobuf::Any
+      expect do
+        Google::Gax.to_proto(user_message, Google::Protobuf::User)
+      end.to raise_error(ArgumentError)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-gax
 version: !ruby/object:Gem::Version
-  version: 0.8.10
+  version: 0.8.12
 platform: ruby
 authors:
 - Google API Authors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-27 00:00:00.000000000 Z
+date: 2017-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: googleauth
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.6.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.6.6
 - !ruby/object:Gem::Dependency
   name: googleapis-common-protos
   requirement: !ruby/object:Gem::Requirement