google-cloud-storage_transfer-v1 1.1.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45fb795177f75aea586fe5474b2713cf69181f1a9d6b57adcc81ccfa0d0d1bc6
-  data.tar.gz: 0006f1f7379c7838d899cc4244fa46e064ad80f0a3ba68c8a8ba56627b3a8d20
+  metadata.gz: f9b1e8785565756ae5630147d48ca8a51f005ed7dc115035cf0d2abd23f2c9f4
+  data.tar.gz: 10cfdb8cfb060e65f114fe0b86eb5f8cd99bec848e97d9d9c6ff018e3a55ba85
 SHA512:
-  metadata.gz: 73bce4f27811ced6fceed6a01089b1314a834a4e58f4e4f268e6fdfd9a325798199d023efd3bb4c94169d1dfe509f8a3a7797cb3fa3a90d9e6e2cc36d0d9ba65
-  data.tar.gz: ceb6b9b73f48b48a310eaddb5c6191d79e1d492dbdc301eb598560025842b8d42fb1ce0d1f86a77a4e9aa950f2e47e7ff7d0dc43681b71baca78db8577d37f83
+  metadata.gz: 80e8c3ea772be504f23a104de7b194d99a920225eb90b68e233b95874b65c616c1f300f75374225ad90ddd94a68beabc8206693fb2c832c42f425c03808f28af
+  data.tar.gz: a46a8838a2c88e28e2cb48dffa01a330700449a593b66f870f5adccb43c243c292aa996aac9fedaa00f79069053ba4d155881b7b17c48cad366ddec9076a0cf3

data/README.md

@@ -43,33 +43,43 @@ for class and method documentation.
 See also the [Product Documentation](https://cloud.google.com/storage-transfer-service/)
 for general usage information.
 
-## Enabling Logging
-
-To enable logging for this library, set the logger for the underlying [gRPC](https://github.com/grpc/grpc/tree/master/src/ruby) library.
-The logger that you set may be a Ruby stdlib [`Logger`](https://ruby-doc.org/current/stdlibs/logger/Logger.html) as shown below,
-or a [`Google::Cloud::Logging::Logger`](https://cloud.google.com/ruby/docs/reference/google-cloud-logging/latest)
-that will write logs to [Cloud Logging](https://cloud.google.com/logging/). See [grpc/logconfig.rb](https://github.com/grpc/grpc/blob/master/src/ruby/lib/grpc/logconfig.rb)
-and the gRPC [spec_helper.rb](https://github.com/grpc/grpc/blob/master/src/ruby/spec/spec_helper.rb) for additional information.
-
-Configuring a Ruby stdlib logger:
+## Debug Logging
+
+This library comes with opt-in Debug Logging that can help you troubleshoot
+your application's integration with the API. When logging is activated, key
+events such as requests and responses, along with data payloads and metadata
+such as headers and client configuration, are logged to the standard error
+stream.
+
+**WARNING:** Client Library Debug Logging includes your data payloads in
+plaintext, which could include sensitive data such as PII for yourself or your
+customers, private keys, or other security data that could be compromising if
+leaked. Always practice good data hygiene with your application logs, and follow
+the principle of least access. Google also recommends that Client Library Debug
+Logging be enabled only temporarily during active debugging, and not used
+permanently in production.
+
+To enable logging, set the environment variable `GOOGLE_SDK_RUBY_LOGGING_GEMS`
+to the value `all`. Alternatively, you can set the value to a comma-delimited
+list of client library gem names. This will select the default logging behavior,
+which writes logs to the standard error stream. On a local workstation, this may
+result in logs appearing on the console. When running on a Google Cloud hosting
+service such as [Google Cloud Run](https://cloud.google.com/run), this generally
+results in logs appearing alongside your application logs in the
+[Google Cloud Logging](https://cloud.google.com/logging/) service.
+
+You can customize logging by modifying the `logger` configuration when
+constructing a client object. For example:
 
 ```ruby
+require "google/cloud/storage_transfer/v1"
 require "logger"
 
-module MyLogger
-  LOGGER = Logger.new $stderr, level: Logger::WARN
-  def logger
-    LOGGER
-  end
-end
-
-# Define a gRPC module-level logger method before grpc/logconfig.rb loads.
-module GRPC
-  extend MyLogger
+client = ::Google::Cloud::StorageTransfer::V1::StorageTransferService::Client.new do |config|
+  config.logger = Logger.new "my-app.log"
 end
 ```
 
-
 ## Google Cloud Samples
 
 To browse ready to use code samples check [Google Cloud Samples](https://cloud.google.com/docs/samples).

data/lib/google/cloud/storage_transfer/v1/storage_transfer_service/client.rb

@@ -173,8 +173,19 @@ module Google
                 universe_domain: @config.universe_domain,
                 channel_args: @config.channel_args,
                 interceptors: @config.interceptors,
-                channel_pool_config: @config.channel_pool
+                channel_pool_config: @config.channel_pool,
+                logger: @config.logger
               )
+
+              @storage_transfer_service_stub.stub_logger&.info do |entry|
+                entry.set_system_name
+                entry.set_service
+                entry.message = "Created client for #{entry.service}"
+                entry.set_credentials_fields credentials
+                entry.set "customEndpoint", @config.endpoint if @config.endpoint
+                entry.set "defaultTimeout", @config.timeout if @config.timeout
+                entry.set "quotaProject", @quota_project_id if @quota_project_id
+              end
             end
 
             ##
@@ -184,6 +195,15 @@ module Google
             #
             attr_reader :operations_client
 
+            ##
+            # The logger used for request/response debug logging.
+            #
+            # @return [Logger]
+            #
+            def logger
+              @storage_transfer_service_stub.logger
+            end
+
             # Service calls
 
             ##
@@ -274,7 +294,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :get_google_service_account, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -352,7 +371,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :create_transfer_job, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -473,7 +491,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :update_transfer_job, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -562,7 +579,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :get_transfer_job, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -588,17 +604,32 @@ module Google
             #
             #   @param filter [::String]
             #     Required. A list of query parameters specified as JSON text in the form of:
-            #     `{"projectId":"my_project_id",
-            #      "jobNames":["jobid1","jobid2",...],
-            #      "jobStatuses":["status1","status2",...]}`
-            #
-            #     Since `jobNames` and `jobStatuses` support multiple values, their values
-            #     must be specified with array notation. `projectId` is required.
-            #     `jobNames` and `jobStatuses` are optional.  The valid values for
-            #     `jobStatuses` are case-insensitive:
-            #     {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::ENABLED ENABLED},
-            #     {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DISABLED DISABLED}, and
-            #     {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DELETED DELETED}.
+            #
+            #     ```
+            #     {
+            #       "projectId":"my_project_id",
+            #       "jobNames":["jobid1","jobid2",...],
+            #       "jobStatuses":["status1","status2",...],
+            #       "dataBackend":"QUERY_REPLICATION_CONFIGS",
+            #       "sourceBucket":"source-bucket-name",
+            #       "sinkBucket":"sink-bucket-name",
+            #     }
+            #     ```
+            #
+            #     The JSON formatting in the example is for display only; provide the
+            #     query parameters without spaces or line breaks.
+            #
+            #     * `projectId` is required.
+            #     * Since `jobNames` and `jobStatuses` support multiple values, their values
+            #       must be specified with array notation. `jobNames` and `jobStatuses` are
+            #       optional. Valid values are case-insensitive:
+            #         * {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::ENABLED ENABLED}
+            #         * {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DISABLED DISABLED}
+            #         * {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DELETED DELETED}
+            #     * Specify `"dataBackend":"QUERY_REPLICATION_CONFIGS"` to return a list of
+            #       cross-bucket replication jobs.
+            #     * Limit the results to jobs from a particular bucket with `sourceBucket`
+            #       and/or to a particular bucket with `sinkBucket`.
             #   @param page_size [::Integer]
             #     The list page size. The max allowed value is 256.
             #   @param page_token [::String]
@@ -660,7 +691,7 @@ module Google
               @storage_transfer_service_stub.call_rpc :list_transfer_jobs, request, options: options do |response, operation|
                 response = ::Gapic::PagedEnumerable.new @storage_transfer_service_stub, :list_transfer_jobs, request, response, operation, options
                 yield response, operation if block_given?
-                return response
+                throw :response, response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -746,7 +777,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :pause_transfer_operation, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -832,7 +862,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :resume_transfer_operation, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -932,7 +961,7 @@ module Google
               @storage_transfer_service_stub.call_rpc :run_transfer_job, request, options: options do |response, operation|
                 response = ::Gapic::Operation.new response, @operations_client, options: options
                 yield response, operation if block_given?
-                return response
+                throw :response, response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -1022,7 +1051,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :delete_transfer_job, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -1125,7 +1153,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :create_agent_pool, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -1229,7 +1256,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :update_agent_pool, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -1315,7 +1341,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :get_agent_pool, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -1419,7 +1444,7 @@ module Google
               @storage_transfer_service_stub.call_rpc :list_agent_pools, request, options: options do |response, operation|
                 response = ::Gapic::PagedEnumerable.new @storage_transfer_service_stub, :list_agent_pools, request, response, operation, options
                 yield response, operation if block_given?
-                return response
+                throw :response, response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -1505,7 +1530,6 @@ module Google
 
               @storage_transfer_service_stub.call_rpc :delete_agent_pool, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -1594,6 +1618,11 @@ module Google
             #   default endpoint URL. The default value of nil uses the environment
             #   universe (usually the default "googleapis.com" universe).
             #   @return [::String,nil]
+            # @!attribute [rw] logger
+            #   A custom logger to use for request/response debug logging, or the value
+            #   `:default` (the default) to construct a default logger, or `nil` to
+            #   explicitly disable logging.
+            #   @return [::Logger,:default,nil]
             #
             class Configuration
               extend ::Gapic::Config
@@ -1618,6 +1647,7 @@ module Google
               config_attr :retry_policy,  nil, ::Hash, ::Proc, nil
               config_attr :quota_project, nil, ::String, nil
               config_attr :universe_domain, nil, ::String, nil
+              config_attr :logger, :default, ::Logger, nil, :default
 
               # @private
               def initialize parent_config = nil

data/lib/google/cloud/storage_transfer/v1/storage_transfer_service/operations.rb

@@ -124,14 +124,6 @@ module Google
             # Lists operations that match the specified filter in the request. If the
             # server doesn't support this method, it returns `UNIMPLEMENTED`.
             #
-            # NOTE: the `name` binding allows API services to override the binding
-            # to use different resource name schemes, such as `users/*/operations`. To
-            # override the binding, API services can add a binding such as
-            # `"/v1/{name=users/*}/operations"` to their service configuration.
-            # For backwards compatibility, the default name includes the operations
-            # collection id, however overriding users must ensure the name binding
-            # is the parent resource, without the operations collection id.
-            #
             # @overload list_operations(request, options = nil)
             #   Pass arguments to `list_operations` via a request object, either of type
             #   {::Google::Longrunning::ListOperationsRequest} or an equivalent Hash.
@@ -221,7 +213,7 @@ module Google
                 wrap_lro_operation = ->(op_response) { ::Gapic::Operation.new op_response, @operations_client }
                 response = ::Gapic::PagedEnumerable.new @operations_stub, :list_operations, request, response, operation, options, format_resource: wrap_lro_operation
                 yield response, operation if block_given?
-                return response
+                throw :response, response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -317,7 +309,7 @@ module Google
               @operations_stub.call_rpc :get_operation, request, options: options do |response, operation|
                 response = ::Gapic::Operation.new response, @operations_client, options: options
                 yield response, operation if block_given?
-                return response
+                throw :response, response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -406,7 +398,6 @@ module Google
 
               @operations_stub.call_rpc :delete_operation, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -421,8 +412,9 @@ module Google
             # other methods to check whether the cancellation succeeded or whether the
             # operation completed despite cancellation. On successful cancellation,
             # the operation is not deleted; instead, it becomes an operation with
-            # an {::Google::Longrunning::Operation#error Operation.error} value with a {::Google::Rpc::Status#code google.rpc.Status.code} of 1,
-            # corresponding to `Code.CANCELLED`.
+            # an {::Google::Longrunning::Operation#error Operation.error} value with a
+            # {::Google::Rpc::Status#code google.rpc.Status.code} of `1`, corresponding to
+            # `Code.CANCELLED`.
             #
             # @overload cancel_operation(request, options = nil)
             #   Pass arguments to `cancel_operation` via a request object, either of type
@@ -501,7 +493,6 @@ module Google
 
               @operations_stub.call_rpc :cancel_operation, request, options: options do |response, operation|
                 yield response, operation if block_given?
-                return response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -599,7 +590,7 @@ module Google
               @operations_stub.call_rpc :wait_operation, request, options: options do |response, operation|
                 response = ::Gapic::Operation.new response, @operations_client, options: options
                 yield response, operation if block_given?
-                return response
+                throw :response, response
               end
             rescue ::GRPC::BadStatus => e
               raise ::Google::Cloud::Error.from_error(e)
@@ -688,6 +679,11 @@ module Google
             #   default endpoint URL. The default value of nil uses the environment
             #   universe (usually the default "googleapis.com" universe).
             #   @return [::String,nil]
+            # @!attribute [rw] logger
+            #   A custom logger to use for request/response debug logging, or the value
+            #   `:default` (the default) to construct a default logger, or `nil` to
+            #   explicitly disable logging.
+            #   @return [::Logger,:default,nil]
             #
             class Configuration
               extend ::Gapic::Config
@@ -712,6 +708,7 @@ module Google
               config_attr :retry_policy,  nil, ::Hash, ::Proc, nil
               config_attr :quota_project, nil, ::String, nil
               config_attr :universe_domain, nil, ::String, nil
+              config_attr :logger, :default, ::Logger, nil, :default
 
               # @private
               def initialize parent_config = nil

data/lib/google/cloud/storage_transfer/v1/storage_transfer_service/rest/client.rb

@@ -166,8 +166,19 @@ module Google
                   endpoint: @config.endpoint,
                   endpoint_template: DEFAULT_ENDPOINT_TEMPLATE,
                   universe_domain: @config.universe_domain,
-                  credentials: credentials
+                  credentials: credentials,
+                  logger: @config.logger
                 )
+
+                @storage_transfer_service_stub.logger(stub: true)&.info do |entry|
+                  entry.set_system_name
+                  entry.set_service
+                  entry.message = "Created client for #{entry.service}"
+                  entry.set_credentials_fields credentials
+                  entry.set "customEndpoint", @config.endpoint if @config.endpoint
+                  entry.set "defaultTimeout", @config.timeout if @config.timeout
+                  entry.set "quotaProject", @quota_project_id if @quota_project_id
+                end
               end
 
               ##
@@ -177,6 +188,15 @@ module Google
               #
               attr_reader :operations_client
 
+              ##
+              # The logger used for request/response debug logging.
+              #
+              # @return [Logger]
+              #
+              def logger
+                @storage_transfer_service_stub.logger
+              end
+
               # Service calls
 
               ##
@@ -260,7 +280,6 @@ module Google
 
                 @storage_transfer_service_stub.get_google_service_account request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -339,7 +358,6 @@ module Google
 
                 @storage_transfer_service_stub.create_transfer_job request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -453,7 +471,6 @@ module Google
 
                 @storage_transfer_service_stub.update_transfer_job request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -535,7 +552,6 @@ module Google
 
                 @storage_transfer_service_stub.get_transfer_job request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -561,17 +577,32 @@ module Google
               #
               #   @param filter [::String]
               #     Required. A list of query parameters specified as JSON text in the form of:
-              #     `{"projectId":"my_project_id",
-              #      "jobNames":["jobid1","jobid2",...],
-              #      "jobStatuses":["status1","status2",...]}`
-              #
-              #     Since `jobNames` and `jobStatuses` support multiple values, their values
-              #     must be specified with array notation. `projectId` is required.
-              #     `jobNames` and `jobStatuses` are optional.  The valid values for
-              #     `jobStatuses` are case-insensitive:
-              #     {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::ENABLED ENABLED},
-              #     {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DISABLED DISABLED}, and
-              #     {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DELETED DELETED}.
+              #
+              #     ```
+              #     {
+              #       "projectId":"my_project_id",
+              #       "jobNames":["jobid1","jobid2",...],
+              #       "jobStatuses":["status1","status2",...],
+              #       "dataBackend":"QUERY_REPLICATION_CONFIGS",
+              #       "sourceBucket":"source-bucket-name",
+              #       "sinkBucket":"sink-bucket-name",
+              #     }
+              #     ```
+              #
+              #     The JSON formatting in the example is for display only; provide the
+              #     query parameters without spaces or line breaks.
+              #
+              #     * `projectId` is required.
+              #     * Since `jobNames` and `jobStatuses` support multiple values, their values
+              #       must be specified with array notation. `jobNames` and `jobStatuses` are
+              #       optional. Valid values are case-insensitive:
+              #         * {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::ENABLED ENABLED}
+              #         * {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DISABLED DISABLED}
+              #         * {::Google::Cloud::StorageTransfer::V1::TransferJob::Status::DELETED DELETED}
+              #     * Specify `"dataBackend":"QUERY_REPLICATION_CONFIGS"` to return a list of
+              #       cross-bucket replication jobs.
+              #     * Limit the results to jobs from a particular bucket with `sourceBucket`
+              #       and/or to a particular bucket with `sinkBucket`.
               #   @param page_size [::Integer]
               #     The list page size. The max allowed value is 256.
               #   @param page_token [::String]
@@ -634,7 +665,7 @@ module Google
                 @storage_transfer_service_stub.list_transfer_jobs request, options do |result, operation|
                   result = ::Gapic::Rest::PagedEnumerable.new @storage_transfer_service_stub, :list_transfer_jobs, "transfer_jobs", request, result, options
                   yield result, operation if block_given?
-                  return result
+                  throw :response, result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -713,7 +744,6 @@ module Google
 
                 @storage_transfer_service_stub.pause_transfer_operation request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -792,7 +822,6 @@ module Google
 
                 @storage_transfer_service_stub.resume_transfer_operation request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -885,7 +914,7 @@ module Google
                 @storage_transfer_service_stub.run_transfer_job request, options do |result, operation|
                   result = ::Gapic::Operation.new result, @operations_client, options: options
                   yield result, operation if block_given?
-                  return result
+                  throw :response, result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -968,7 +997,6 @@ module Google
 
                 @storage_transfer_service_stub.delete_transfer_job request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -1064,7 +1092,6 @@ module Google
 
                 @storage_transfer_service_stub.create_agent_pool request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -1161,7 +1188,6 @@ module Google
 
                 @storage_transfer_service_stub.update_agent_pool request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -1240,7 +1266,6 @@ module Google
 
                 @storage_transfer_service_stub.get_agent_pool request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -1337,7 +1362,7 @@ module Google
                 @storage_transfer_service_stub.list_agent_pools request, options do |result, operation|
                   result = ::Gapic::Rest::PagedEnumerable.new @storage_transfer_service_stub, :list_agent_pools, "agent_pools", request, result, options
                   yield result, operation if block_given?
-                  return result
+                  throw :response, result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -1416,7 +1441,6 @@ module Google
 
                 @storage_transfer_service_stub.delete_agent_pool request, options do |result, operation|
                   yield result, operation if block_given?
-                  return result
                 end
               rescue ::Gapic::Rest::Error => e
                 raise ::Google::Cloud::Error.from_error(e)
@@ -1496,6 +1520,11 @@ module Google
               #   default endpoint URL. The default value of nil uses the environment
               #   universe (usually the default "googleapis.com" universe).
               #   @return [::String,nil]
+              # @!attribute [rw] logger
+              #   A custom logger to use for request/response debug logging, or the value
+              #   `:default` (the default) to construct a default logger, or `nil` to
+              #   explicitly disable logging.
+              #   @return [::Logger,:default,nil]
               #
               class Configuration
                 extend ::Gapic::Config
@@ -1517,6 +1546,7 @@ module Google
                 config_attr :retry_policy,  nil, ::Hash, ::Proc, nil
                 config_attr :quota_project, nil, ::String, nil
                 config_attr :universe_domain, nil, ::String, nil
+                config_attr :logger, :default, ::Logger, nil, :default
 
                 # @private
                 def initialize parent_config = nil