google-cloud-spanner 1.12.0 → 1.12.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 77c43b9e9a22d239c163e14d195be8047d33e504b5ce51c355c81756d35671b3
-  data.tar.gz: 2bccb6e48fec612be8c5b5238940d1279e172cca04909add370e4a2369a328fa
+  metadata.gz: bb9356b25e44c40dc9130499d1a5d0f186d4637819ca7ad27d02d7c2456c6c88
+  data.tar.gz: 5cfa6241edcbb3530654584587a309843f04bb6d08aeab6d31ba6273c5c95b7e
 SHA512:
-  metadata.gz: c93a67b2af771dda520193926b31e411c4c16b4ecb7cb77ec28282cec5eabeb44f20381b6e2701b2f6696835888a3c7a73920ab26bcb072285f3f377c8aa854c
-  data.tar.gz: a21857fc35d438151589eab2ca73cc7284968eadd33ddf9a3052ba5864466f366ac4a911a0da44bd3da802f872bd98c8751780c5ae1d691f6ed4294d6491af43
+  metadata.gz: 44a9560fcc37b55aed30d4a36c8a9eb7f379dc84abf79f838b11ba95f8e3225139ae255558d80f68430fd95845497f491a8ccc28c019cbe43fd0a85fb3daec56
+  data.tar.gz: 2de6ab1fc1f7d5b26a79ca5a8f1835d4ce0ba732e188e9c0342897826027c1f59a88b9263cc026d76b245ba59d6b0ad2755542bba49fff32bca73eb7363871ab

data/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Release History
 
+### 1.12.2 / 2019-12-19
+
+#### Bug Fixes
+
+* Rename endpoint_urls to endpoint_uris
+* Revert #commit mutations to positional in lower-level API
+* Revert breaking change to test_iam_permissions in lower-level API
+
+#### Performance Improvements
+
+* Add Instance#endpoint_urls and GetInstanceRequest#field_mask in lower-level API
+* Add service address and port for lower-level API clients
+
+### 1.12.1 / 2019-11-12
+
+#### Features
+
+* Add InstanceConfig#replicas (ReplicaInfo) to the lower-level API.
+
+#### Documentation
+
+* Update lower-level API documentation.
+
+#### Bug Fixes
+
+* Update minimum runtime dependencies.
+
 ### 1.12.0 / 2019-10-29
 
 This release requires Ruby 2.4 or later.

data/lib/google/cloud/spanner/admin/database/v1/database_admin_client.rb

@@ -175,6 +175,8 @@ module Google
                   scopes: scopes,
                   client_config: client_config,
                   timeout: timeout,
+                  service_address: service_address,
+                  service_port: service_port,
                   lib_name: lib_name,
                   lib_version: lib_version,
                   metadata: metadata,
@@ -497,7 +499,7 @@ module Google
               # @param database [String]
               #   Required. The database to update.
               # @param statements [Array<String>]
-              #   DDL statements to be applied to the database.
+              #   Required. DDL statements to be applied to the database.
               # @param operation_id [String]
               #   If empty, the new update request is assigned an
               #   automatically-generated operation ID. Otherwise, `operation_id`
@@ -645,11 +647,11 @@ module Google
                 @get_database_ddl.call(req, options, &block)
               end
 
-              # Sets the access control policy on a database resource. Replaces any
-              # existing policy.
+              # Sets the access control policy on a database resource.
+              # Replaces any existing policy.
               #
-              # Authorization requires `spanner.databases.setIamPolicy` permission on
-              # {Google::Iam::V1::SetIamPolicyRequest#resource resource}.
+              # Authorization requires `spanner.databases.setIamPolicy`
+              # permission on {Google::Iam::V1::SetIamPolicyRequest#resource resource}.
               #
               # @param resource [String]
               #   REQUIRED: The resource for which the policy is being specified.
@@ -692,8 +694,9 @@ module Google
                 @set_iam_policy.call(req, options, &block)
               end
 
-              # Gets the access control policy for a database resource. Returns an empty
-              # policy if a database exists but does not have a policy set.
+              # Gets the access control policy for a database resource.
+              # Returns an empty policy if a database exists but does
+              # not have a policy set.
               #
               # Authorization requires `spanner.databases.getIamPolicy` permission on
               # {Google::Iam::V1::GetIamPolicyRequest#resource resource}.
@@ -736,10 +739,10 @@ module Google
 
               # Returns permissions that the caller has on the specified database resource.
               #
-              # Attempting this RPC on a non-existent Cloud Spanner database will result in
-              # a NOT_FOUND error if the user has `spanner.databases.list` permission on
-              # the containing Cloud Spanner instance. Otherwise returns an empty set of
-              # permissions.
+              # Attempting this RPC on a non-existent Cloud Spanner database will
+              # result in a NOT_FOUND error if the user has
+              # `spanner.databases.list` permission on the containing Cloud
+              # Spanner instance. Otherwise returns an empty set of permissions.
               #
               # @param resource [String]
               #   REQUIRED: The resource for which the policy detail is being requested.

data/lib/google/cloud/spanner/admin/database/v1/doc/google/iam/v1/policy.rb

@@ -82,12 +82,13 @@ module Google
       #
       #     Operations affecting conditional bindings must specify version 3. This can
       #     be either setting a conditional policy, modifying a conditional binding,
-      #     or removing a conditional binding from the stored conditional policy.
+      #     or removing a binding (conditional or unconditional) from the stored
+      #     conditional policy.
       #     Operations on non-conditional policies may specify any valid value or
       #     leave the field unset.
       #
-      #     If no etag is provided in the call to `setIamPolicy`, any version
-      #     compliance checks on the incoming and/or stored policy is skipped.
+      #     If no etag is provided in the call to `setIamPolicy`, version compliance
+      #     checks against the stored policy is skipped.
       # @!attribute [rw] bindings
       #   @return [Array<Google::Iam::V1::Binding>]
       #     Associates a list of `members` to a `role`. Optionally may specify a
@@ -105,8 +106,8 @@ module Google
       #
       #     If no `etag` is provided in the call to `setIamPolicy`, then the existing
       #     policy is overwritten. Due to blind-set semantics of an etag-less policy,
-      #     'setIamPolicy' will not fail even if either of incoming or stored policy
-      #     does not meet the version requirements.
+      #     'setIamPolicy' will not fail even if the incoming policy version does not
+      #     meet the requirements for modifying the stored policy.
       class Policy; end
 
       # Associates `members` with a `role`.

data/lib/google/cloud/spanner/admin/database/v1/doc/google/spanner/admin/database/v1/spanner_database_admin.rb

@@ -131,7 +131,7 @@ module Google
           #     Required. The database to update.
           # @!attribute [rw] statements
           #   @return [Array<String>]
-          #     DDL statements to be applied to the database.
+          #     Required. DDL statements to be applied to the database.
           # @!attribute [rw] operation_id
           #   @return [String]
           #     If empty, the new update request is assigned an

data/lib/google/cloud/spanner/admin/instance/v1/doc/google/iam/v1/policy.rb

@@ -82,12 +82,13 @@ module Google
       #
       #     Operations affecting conditional bindings must specify version 3. This can
       #     be either setting a conditional policy, modifying a conditional binding,
-      #     or removing a conditional binding from the stored conditional policy.
+      #     or removing a binding (conditional or unconditional) from the stored
+      #     conditional policy.
       #     Operations on non-conditional policies may specify any valid value or
       #     leave the field unset.
       #
-      #     If no etag is provided in the call to `setIamPolicy`, any version
-      #     compliance checks on the incoming and/or stored policy is skipped.
+      #     If no etag is provided in the call to `setIamPolicy`, version compliance
+      #     checks against the stored policy is skipped.
       # @!attribute [rw] bindings
       #   @return [Array<Google::Iam::V1::Binding>]
       #     Associates a list of `members` to a `role`. Optionally may specify a
@@ -105,8 +106,8 @@ module Google
       #
       #     If no `etag` is provided in the call to `setIamPolicy`, then the existing
       #     policy is overwritten. Due to blind-set semantics of an etag-less policy,
-      #     'setIamPolicy' will not fail even if either of incoming or stored policy
-      #     does not meet the version requirements.
+      #     'setIamPolicy' will not fail even if the incoming policy version does not
+      #     meet the requirements for modifying the stored policy.
       class Policy; end
 
       # Associates `members` with a `role`.

data/lib/google/cloud/spanner/admin/instance/v1/doc/google/spanner/admin/instance/v1/spanner_instance_admin.rb

@@ -18,6 +18,54 @@ module Google
     module Admin
       module Instance
         module V1
+          # @!attribute [rw] location
+          #   @return [String]
+          #     The location of the serving resources, e.g. "us-central1".
+          # @!attribute [rw] type
+          #   @return [Google::Spanner::Admin::Instance::V1::ReplicaInfo::ReplicaType]
+          #     The type of replica.
+          # @!attribute [rw] default_leader_location
+          #   @return [true, false]
+          #     If true, this location is designated as the default leader location where
+          #     leader replicas are placed. See the [region types
+          #     documentation](https://cloud.google.com/spanner/docs/instances#region_types)
+          #     for more details.
+          class ReplicaInfo
+            # Indicates the type of replica.  See the [replica types
+            # documentation](https://cloud.google.com/spanner/docs/replication#replica_types)
+            # for more details.
+            module ReplicaType
+              # Not specified.
+              TYPE_UNSPECIFIED = 0
+
+              # Read-write replicas support both reads and writes. These replicas:
+              #
+              # * Maintain a full copy of your data.
+              # * Serve reads.
+              # * Can vote whether to commit a write.
+              # * Participate in leadership election.
+              # * Are eligible to become a leader.
+              READ_WRITE = 1
+
+              # Read-only replicas only support reads (not writes). Read-only replicas:
+              #
+              # * Maintain a full copy of your data.
+              # * Serve reads.
+              # * Do not participate in voting to commit writes.
+              # * Are not eligible to become a leader.
+              READ_ONLY = 2
+
+              # Witness replicas don't support reads but do participate in voting to
+              # commit writes. Witness replicas:
+              #
+              # * Do not maintain a full copy of data.
+              # * Do not serve reads.
+              # * Vote whether to commit writes.
+              # * Participate in leader election but are not eligible to become leader.
+              WITNESS = 3
+            end
+          end
+
           # A possible configuration for a Cloud Spanner instance. Configurations
           # define the geographic placement of nodes and their replication.
           # @!attribute [rw] name
@@ -28,6 +76,10 @@ module Google
           # @!attribute [rw] display_name
           #   @return [String]
           #     The name of this instance configuration as it appears in UIs.
+          # @!attribute [rw] replicas
+          #   @return [Array<Google::Spanner::Admin::Instance::V1::ReplicaInfo>]
+          #     The geographic placement of nodes in this instance configuration and their
+          #     replication properties.
           class InstanceConfig; end
 
           # An isolated set of Cloud Spanner resources on which databases can be hosted.
@@ -36,7 +88,7 @@ module Google
           #     Required. A unique identifier for the instance, which cannot be changed
           #     after the instance is created. Values are of the form
           #     `projects/<project>/instances/[a-z][-a-z0-9]*[a-z0-9]`. The final
-          #     segment of the name must be between 6 and 30 characters in length.
+          #     segment of the name must be between 2 and 64 characters in length.
           # @!attribute [rw] config
           #   @return [String]
           #     Required. The name of the instance's configuration. Values are of the form
@@ -58,10 +110,10 @@ module Google
           # @!attribute [rw] state
           #   @return [Google::Spanner::Admin::Instance::V1::Instance::State]
           #     Output only. The current instance state. For
-          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::CreateInstance CreateInstance},
-          #     the state must be either omitted or set to `CREATING`. For
-          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::UpdateInstance UpdateInstance},
-          #     the state must be either omitted or set to `READY`.
+          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::CreateInstance CreateInstance}, the state must be
+          #     either omitted or set to `CREATING`. For
+          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::UpdateInstance UpdateInstance}, the state must be
+          #     either omitted or set to `READY`.
           # @!attribute [rw] labels
           #   @return [Hash{String => String}]
           #     Cloud Labels are a flexible and lightweight mechanism for organizing cloud
@@ -85,6 +137,16 @@ module Google
           #     specific characters being disallowed.  For example, representing labels
           #     as the string:  name + "_" + value  would prove problematic if we were to
           #     allow "_" in a future release.
+          # @!attribute [rw] endpoint_uris
+          #   @return [Array<String>]
+          #     Output only. The endpoint URIs based on the instance config.
+          #     For example, instances located in a specific cloud region (or multi region)
+          #     such as nam3, would have a nam3 specific endpoint URI.
+          #     This URI is to be used implictly by SDK clients, with fallback to default
+          #     URI. These endpoints are intended to optimize the network routing between
+          #     the client and the instance's serving resources.
+          #     If multiple endpoints are present, client may establish connections using
+          #     any of the given URIs.
           class Instance
             # Indicates the current state of the instance.
             module State
@@ -102,8 +164,7 @@ module Google
             end
           end
 
-          # The request for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstanceConfigs ListInstanceConfigs}.
+          # The request for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstanceConfigs ListInstanceConfigs}.
           # @!attribute [rw] parent
           #   @return [String]
           #     Required. The name of the project for which a list of supported instance
@@ -117,20 +178,18 @@ module Google
           #   @return [String]
           #     If non-empty, `page_token` should contain a
           #     {Google::Spanner::Admin::Instance::V1::ListInstanceConfigsResponse#next_page_token next_page_token}
-          #     from a previous
-          #     {Google::Spanner::Admin::Instance::V1::ListInstanceConfigsResponse ListInstanceConfigsResponse}.
+          #     from a previous {Google::Spanner::Admin::Instance::V1::ListInstanceConfigsResponse ListInstanceConfigsResponse}.
           class ListInstanceConfigsRequest; end
 
-          # The response for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstanceConfigs ListInstanceConfigs}.
+          # The response for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstanceConfigs ListInstanceConfigs}.
           # @!attribute [rw] instance_configs
           #   @return [Array<Google::Spanner::Admin::Instance::V1::InstanceConfig>]
           #     The list of requested instance configurations.
           # @!attribute [rw] next_page_token
           #   @return [String]
           #     `next_page_token` can be sent in a subsequent
-          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstanceConfigs ListInstanceConfigs}
-          #     call to fetch more of the matching instance configurations.
+          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstanceConfigs ListInstanceConfigs} call to
+          #     fetch more of the matching instance configurations.
           class ListInstanceConfigsResponse; end
 
           # The request for
@@ -141,16 +200,19 @@ module Google
           #     the form `projects/<project>/instanceConfigs/<config>`.
           class GetInstanceConfigRequest; end
 
-          # The request for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::GetInstance GetInstance}.
+          # The request for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::GetInstance GetInstance}.
           # @!attribute [rw] name
           #   @return [String]
           #     Required. The name of the requested instance. Values are of the form
           #     `projects/<project>/instances/<instance>`.
+          # @!attribute [rw] field_mask
+          #   @return [Google::Protobuf::FieldMask]
+          #     If field_mask is present, specifies the subset of [][google.spanner.admin.instance.v1.Instance] fields that
+          #     should be returned.
+          #     If absent, all [][google.spanner.admin.instance.v1.Instance] fields are returned.
           class GetInstanceRequest; end
 
-          # The request for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::CreateInstance CreateInstance}.
+          # The request for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::CreateInstance CreateInstance}.
           # @!attribute [rw] parent
           #   @return [String]
           #     Required. The name of the project in which to create the instance. Values
@@ -158,7 +220,7 @@ module Google
           # @!attribute [rw] instance_id
           #   @return [String]
           #     Required. The ID of the instance to create.  Valid identifiers are of the
-          #     form `[a-z][-a-z0-9]*[a-z0-9]` and must be between 6 and 30 characters in
+          #     form `[a-z][-a-z0-9]*[a-z0-9]` and must be between 2 and 64 characters in
           #     length.
           # @!attribute [rw] instance
           #   @return [Google::Spanner::Admin::Instance::V1::Instance]
@@ -166,8 +228,7 @@ module Google
           #     specified must be `<parent>/instances/<instance_id>`.
           class CreateInstanceRequest; end
 
-          # The request for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstances ListInstances}.
+          # The request for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstances ListInstances}.
           # @!attribute [rw] parent
           #   @return [String]
           #     Required. The name of the project for which a list of instances is
@@ -179,9 +240,8 @@ module Google
           # @!attribute [rw] page_token
           #   @return [String]
           #     If non-empty, `page_token` should contain a
-          #     {Google::Spanner::Admin::Instance::V1::ListInstancesResponse#next_page_token next_page_token}
-          #     from a previous
-          #     {Google::Spanner::Admin::Instance::V1::ListInstancesResponse ListInstancesResponse}.
+          #     {Google::Spanner::Admin::Instance::V1::ListInstancesResponse#next_page_token next_page_token} from a
+          #     previous {Google::Spanner::Admin::Instance::V1::ListInstancesResponse ListInstancesResponse}.
           # @!attribute [rw] filter
           #   @return [String]
           #     An expression for filtering the results of the request. Filter rules are
@@ -205,38 +265,31 @@ module Google
           #         containing "dev".
           class ListInstancesRequest; end
 
-          # The response for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstances ListInstances}.
+          # The response for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstances ListInstances}.
           # @!attribute [rw] instances
           #   @return [Array<Google::Spanner::Admin::Instance::V1::Instance>]
           #     The list of requested instances.
           # @!attribute [rw] next_page_token
           #   @return [String]
           #     `next_page_token` can be sent in a subsequent
-          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstances ListInstances}
-          #     call to fetch more of the matching instances.
+          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::ListInstances ListInstances} call to fetch more
+          #     of the matching instances.
           class ListInstancesResponse; end
 
-          # The request for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::UpdateInstance UpdateInstance}.
+          # The request for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::UpdateInstance UpdateInstance}.
           # @!attribute [rw] instance
           #   @return [Google::Spanner::Admin::Instance::V1::Instance]
           #     Required. The instance to update, which must always include the instance
-          #     name.  Otherwise, only fields mentioned in
-          #     [][google.spanner.admin.instance.v1.UpdateInstanceRequest.field_mask] need
-          #     be included.
+          #     name.  Otherwise, only fields mentioned in [][google.spanner.admin.instance.v1.UpdateInstanceRequest.field_mask] need be included.
           # @!attribute [rw] field_mask
           #   @return [Google::Protobuf::FieldMask]
-          #     Required. A mask specifying which fields in
-          #     [][google.spanner.admin.instance.v1.UpdateInstanceRequest.instance] should
-          #     be updated. The field mask must always be specified; this prevents any
-          #     future fields in
-          #     [][google.spanner.admin.instance.v1.Instance] from being erased
-          #     accidentally by clients that do not know about them.
+          #     Required. A mask specifying which fields in [][google.spanner.admin.instance.v1.UpdateInstanceRequest.instance] should be updated.
+          #     The field mask must always be specified; this prevents any future fields in
+          #     [][google.spanner.admin.instance.v1.Instance] from being erased accidentally by clients that do not know
+          #     about them.
           class UpdateInstanceRequest; end
 
-          # The request for
-          # {Google::Spanner::Admin::Instance::V1::InstanceAdmin::DeleteInstance DeleteInstance}.
+          # The request for {Google::Spanner::Admin::Instance::V1::InstanceAdmin::DeleteInstance DeleteInstance}.
           # @!attribute [rw] name
           #   @return [String]
           #     Required. The name of the instance to be deleted. Values are of the form
@@ -251,8 +304,8 @@ module Google
           # @!attribute [rw] start_time
           #   @return [Google::Protobuf::Timestamp]
           #     The time at which the
-          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::CreateInstance CreateInstance}
-          #     request was received.
+          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::CreateInstance CreateInstance} request was
+          #     received.
           # @!attribute [rw] cancel_time
           #   @return [Google::Protobuf::Timestamp]
           #     The time at which this operation was cancelled. If set, this operation is
@@ -270,8 +323,7 @@ module Google
           #     The desired end state of the update.
           # @!attribute [rw] start_time
           #   @return [Google::Protobuf::Timestamp]
-          #     The time at which
-          #     {Google::Spanner::Admin::Instance::V1::InstanceAdmin::UpdateInstance UpdateInstance}
+          #     The time at which {Google::Spanner::Admin::Instance::V1::InstanceAdmin::UpdateInstance UpdateInstance}
           #     request was received.
           # @!attribute [rw] cancel_time
           #   @return [Google::Protobuf::Timestamp]

data/lib/google/cloud/spanner/admin/instance/v1/instance_admin_client.rb

@@ -208,6 +208,8 @@ module Google
                   scopes: scopes,
                   client_config: client_config,
                   timeout: timeout,
+                  service_address: service_address,
+                  service_port: service_port,
                   lib_name: lib_name,
                   lib_version: lib_version,
                   metadata: metadata,
@@ -523,6 +525,12 @@ module Google
               # @param name [String]
               #   Required. The name of the requested instance. Values are of the form
               #   `projects/<project>/instances/<instance>`.
+              # @param field_mask [Google::Protobuf::FieldMask | Hash]
+              #   If field_mask is present, specifies the subset of [][google.spanner.admin.instance.v1.Instance] fields that
+              #   should be returned.
+              #   If absent, all [][google.spanner.admin.instance.v1.Instance] fields are returned.
+              #   A hash of the same form as `Google::Protobuf::FieldMask`
+              #   can also be provided.
               # @param options [Google::Gax::CallOptions]
               #   Overrides the default settings for this call, e.g, timeout,
               #   retries, etc.
@@ -540,10 +548,12 @@ module Google
 
               def get_instance \
                   name,
+                  field_mask: nil,
                   options: nil,
                   &block
                 req = {
-                  name: name
+                  name: name,
+                  field_mask: field_mask
                 }.delete_if { |_, v| v.nil? }
                 req = Google::Gax::to_proto(req, Google::Spanner::Admin::Instance::V1::GetInstanceRequest)
                 @get_instance.call(req, options, &block)
@@ -589,7 +599,7 @@ module Google
               #   are of the form `projects/<project>`.
               # @param instance_id [String]
               #   Required. The ID of the instance to create.  Valid identifiers are of the
-              #   form `[a-z][-a-z0-9]*[a-z0-9]` and must be between 6 and 30 characters in
+              #   form `[a-z][-a-z0-9]*[a-z0-9]` and must be between 2 and 64 characters in
               #   length.
               # @param instance [Google::Spanner::Admin::Instance::V1::Instance | Hash]
               #   Required. The instance to create.  The name may be omitted, but if
@@ -676,9 +686,9 @@ module Google
               # Until completion of the returned operation:
               #
               # * Cancelling the operation sets its metadata's
-              #   {Google::Spanner::Admin::Instance::V1::UpdateInstanceMetadata#cancel_time cancel_time},
-              #   and begins restoring resources to their pre-request values. The
-              #   operation is guaranteed to succeed at undoing all resource changes,
+              #   {Google::Spanner::Admin::Instance::V1::UpdateInstanceMetadata#cancel_time cancel_time}, and begins
+              #   restoring resources to their pre-request values. The operation
+              #   is guaranteed to succeed at undoing all resource changes,
               #   after which point it terminates with a `CANCELLED` status.
               #   * All other attempts to modify the instance are rejected.
               #   * Reading the instance via the API continues to give the pre-request
@@ -705,18 +715,14 @@ module Google
               #
               # @param instance [Google::Spanner::Admin::Instance::V1::Instance | Hash]
               #   Required. The instance to update, which must always include the instance
-              #   name.  Otherwise, only fields mentioned in
-              #   [][google.spanner.admin.instance.v1.UpdateInstanceRequest.field_mask] need
-              #   be included.
+              #   name.  Otherwise, only fields mentioned in [][google.spanner.admin.instance.v1.UpdateInstanceRequest.field_mask] need be included.
               #   A hash of the same form as `Google::Spanner::Admin::Instance::V1::Instance`
               #   can also be provided.
               # @param field_mask [Google::Protobuf::FieldMask | Hash]
-              #   Required. A mask specifying which fields in
-              #   [][google.spanner.admin.instance.v1.UpdateInstanceRequest.instance] should
-              #   be updated. The field mask must always be specified; this prevents any
-              #   future fields in
-              #   [][google.spanner.admin.instance.v1.Instance] from being erased
-              #   accidentally by clients that do not know about them.
+              #   Required. A mask specifying which fields in [][google.spanner.admin.instance.v1.UpdateInstanceRequest.instance] should be updated.
+              #   The field mask must always be specified; this prevents any future fields in
+              #   [][google.spanner.admin.instance.v1.Instance] from being erased accidentally by clients that do not know
+              #   about them.
               #   A hash of the same form as `Google::Protobuf::FieldMask`
               #   can also be provided.
               # @param options [Google::Gax::CallOptions]