google-cloud-spanner-admin-instance-v1 1.3.0 → 1.5.0

data/lib/google/cloud/spanner/admin/instance/v1/instance_admin/operations.rb

@@ -126,14 +126,6 @@ module Google
                 # Lists operations that match the specified filter in the request. If the
                 # server doesn't support this method, it returns `UNIMPLEMENTED`.
                 #
-                # NOTE: the `name` binding allows API services to override the binding
-                # to use different resource name schemes, such as `users/*/operations`. To
-                # override the binding, API services can add a binding such as
-                # `"/v1/{name=users/*}/operations"` to their service configuration.
-                # For backwards compatibility, the default name includes the operations
-                # collection id, however overriding users must ensure the name binding
-                # is the parent resource, without the operations collection id.
-                #
                 # @overload list_operations(request, options = nil)
                 #   Pass arguments to `list_operations` via a request object, either of type
                 #   {::Google::Longrunning::ListOperationsRequest} or an equivalent Hash.
@@ -223,7 +215,7 @@ module Google
                     wrap_lro_operation = ->(op_response) { ::Gapic::Operation.new op_response, @operations_client }
                     response = ::Gapic::PagedEnumerable.new @operations_stub, :list_operations, request, response, operation, options, format_resource: wrap_lro_operation
                     yield response, operation if block_given?
-                    return response
+                    throw :response, response
                   end
                 rescue ::GRPC::BadStatus => e
                   raise ::Google::Cloud::Error.from_error(e)
@@ -319,7 +311,7 @@ module Google
                   @operations_stub.call_rpc :get_operation, request, options: options do |response, operation|
                     response = ::Gapic::Operation.new response, @operations_client, options: options
                     yield response, operation if block_given?
-                    return response
+                    throw :response, response
                   end
                 rescue ::GRPC::BadStatus => e
                   raise ::Google::Cloud::Error.from_error(e)
@@ -408,7 +400,6 @@ module Google
 
                   @operations_stub.call_rpc :delete_operation, request, options: options do |response, operation|
                     yield response, operation if block_given?
-                    return response
                   end
                 rescue ::GRPC::BadStatus => e
                   raise ::Google::Cloud::Error.from_error(e)
@@ -423,8 +414,9 @@ module Google
                 # other methods to check whether the cancellation succeeded or whether the
                 # operation completed despite cancellation. On successful cancellation,
                 # the operation is not deleted; instead, it becomes an operation with
-                # an {::Google::Longrunning::Operation#error Operation.error} value with a {::Google::Rpc::Status#code google.rpc.Status.code} of 1,
-                # corresponding to `Code.CANCELLED`.
+                # an {::Google::Longrunning::Operation#error Operation.error} value with a
+                # {::Google::Rpc::Status#code google.rpc.Status.code} of `1`, corresponding to
+                # `Code.CANCELLED`.
                 #
                 # @overload cancel_operation(request, options = nil)
                 #   Pass arguments to `cancel_operation` via a request object, either of type
@@ -503,7 +495,6 @@ module Google
 
                   @operations_stub.call_rpc :cancel_operation, request, options: options do |response, operation|
                     yield response, operation if block_given?
-                    return response
                   end
                 rescue ::GRPC::BadStatus => e
                   raise ::Google::Cloud::Error.from_error(e)
@@ -601,7 +592,7 @@ module Google
                   @operations_stub.call_rpc :wait_operation, request, options: options do |response, operation|
                     response = ::Gapic::Operation.new response, @operations_client, options: options
                     yield response, operation if block_given?
-                    return response
+                    throw :response, response
                   end
                 rescue ::GRPC::BadStatus => e
                   raise ::Google::Cloud::Error.from_error(e)
@@ -690,6 +681,11 @@ module Google
                 #   default endpoint URL. The default value of nil uses the environment
                 #   universe (usually the default "googleapis.com" universe).
                 #   @return [::String,nil]
+                # @!attribute [rw] logger
+                #   A custom logger to use for request/response debug logging, or the value
+                #   `:default` (the default) to construct a default logger, or `nil` to
+                #   explicitly disable logging.
+                #   @return [::Logger,:default,nil]
                 #
                 class Configuration
                   extend ::Gapic::Config
@@ -714,6 +710,7 @@ module Google
                   config_attr :retry_policy,  nil, ::Hash, ::Proc, nil
                   config_attr :quota_project, nil, ::String, nil
                   config_attr :universe_domain, nil, ::String, nil
+                  config_attr :logger, :default, ::Logger, nil, :default
 
                   # @private
                   def initialize parent_config = nil

data/lib/google/cloud/spanner/admin/instance/v1/instance_admin/rest/client.rb

@@ -217,8 +217,19 @@ module Google
                       endpoint: @config.endpoint,
                       endpoint_template: DEFAULT_ENDPOINT_TEMPLATE,
                       universe_domain: @config.universe_domain,
-                      credentials: credentials
+                      credentials: credentials,
+                      logger: @config.logger
                     )
+
+                    @instance_admin_stub.logger(stub: true)&.info do |entry|
+                      entry.set_system_name
+                      entry.set_service
+                      entry.message = "Created client for #{entry.service}"
+                      entry.set_credentials_fields credentials
+                      entry.set "customEndpoint", @config.endpoint if @config.endpoint
+                      entry.set "defaultTimeout", @config.timeout if @config.timeout
+                      entry.set "quotaProject", @quota_project_id if @quota_project_id
+                    end
                   end
 
                   ##
@@ -228,11 +239,23 @@ module Google
                   #
                   attr_reader :operations_client
 
+                  ##
+                  # The logger used for request/response debug logging.
+                  #
+                  # @return [Logger]
+                  #
+                  def logger
+                    @instance_admin_stub.logger
+                  end
+
                   # Service calls
 
                   ##
                   # Lists the supported instance configurations for a given project.
                   #
+                  # Returns both Google-managed configurations and user-managed
+                  # configurations.
+                  #
                   # @overload list_instance_configs(request, options = nil)
                   #   Pass arguments to `list_instance_configs` via a request object, either of type
                   #   {::Google::Cloud::Spanner::Admin::Instance::V1::ListInstanceConfigsRequest} or an equivalent Hash.
@@ -318,7 +341,7 @@ module Google
                     @instance_admin_stub.list_instance_configs request, options do |result, operation|
                       result = ::Gapic::Rest::PagedEnumerable.new @instance_admin_stub, :list_instance_configs, "instance_configs", request, result, options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -398,7 +421,6 @@ module Google
 
                     @instance_admin_stub.get_instance_config request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -406,7 +428,7 @@ module Google
 
                   ##
                   # Creates an instance configuration and begins preparing it to be used. The
-                  # returned {::Google::Longrunning::Operation long-running operation}
+                  # returned long-running operation
                   # can be used to track the progress of preparing the new
                   # instance configuration. The instance configuration name is assigned by the
                   # caller. If the named instance configuration already exists,
@@ -433,13 +455,13 @@ module Google
                   #   {::Google::Cloud::Spanner::Admin::Instance::V1::InstanceConfig#reconciling reconciling}
                   #   field becomes false. Its state becomes `READY`.
                   #
-                  # The returned {::Google::Longrunning::Operation long-running operation} will
+                  # The returned long-running operation will
                   # have a name of the format
                   # `<instance_config_name>/operations/<operation_id>` and can be used to track
                   # creation of the instance configuration. The
-                  # {::Google::Longrunning::Operation#metadata metadata} field type is
+                  # metadata field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::CreateInstanceConfigMetadata CreateInstanceConfigMetadata}.
-                  # The {::Google::Longrunning::Operation#response response} field type is
+                  # The response field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::InstanceConfig InstanceConfig}, if
                   # successful.
                   #
@@ -471,10 +493,10 @@ module Google
                   #     characters in length. The `custom-` prefix is required to avoid name
                   #     conflicts with Google-managed configurations.
                   #   @param instance_config [::Google::Cloud::Spanner::Admin::Instance::V1::InstanceConfig, ::Hash]
-                  #     Required. The InstanceConfig proto of the configuration to create.
-                  #     instance_config.name must be
+                  #     Required. The `InstanceConfig` proto of the configuration to create.
+                  #     `instance_config.name` must be
                   #     `<parent>/instanceConfigs/<instance_config_id>`.
-                  #     instance_config.base_config must be a Google managed configuration name,
+                  #     `instance_config.base_config` must be a Google-managed configuration name,
                   #     e.g. <parent>/instanceConfigs/us-east1, <parent>/instanceConfigs/nam3.
                   #   @param validate_only [::Boolean]
                   #     An option to validate, but not actually execute, a request,
@@ -540,7 +562,7 @@ module Google
                     @instance_admin_stub.create_instance_config request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -548,7 +570,7 @@ module Google
 
                   ##
                   # Updates an instance configuration. The returned
-                  # {::Google::Longrunning::Operation long-running operation} can be used to track
+                  # long-running operation can be used to track
                   # the progress of updating the instance. If the named instance configuration
                   # does not exist, returns `NOT_FOUND`.
                   #
@@ -579,13 +601,13 @@ module Google
                   #   {::Google::Cloud::Spanner::Admin::Instance::V1::InstanceConfig#reconciling reconciling}
                   #   field becomes false.
                   #
-                  # The returned {::Google::Longrunning::Operation long-running operation} will
+                  # The returned long-running operation will
                   # have a name of the format
                   # `<instance_config_name>/operations/<operation_id>` and can be used to track
                   # the instance configuration modification.  The
-                  # {::Google::Longrunning::Operation#metadata metadata} field type is
+                  # metadata field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::UpdateInstanceConfigMetadata UpdateInstanceConfigMetadata}.
-                  # The {::Google::Longrunning::Operation#response response} field type is
+                  # The response field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::InstanceConfig InstanceConfig}, if
                   # successful.
                   #
@@ -686,7 +708,7 @@ module Google
                     @instance_admin_stub.update_instance_config request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -785,19 +807,18 @@ module Google
 
                     @instance_admin_stub.delete_instance_config request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
                   end
 
                   ##
-                  # Lists the user-managed instance configuration [long-running
-                  # operations][google.longrunning.Operation] in the given project. An instance
+                  # Lists the user-managed instance configuration long-running
+                  # operations in the given project. An instance
                   # configuration operation has a name of the form
                   # `projects/<project>/instanceConfigs/<instance_config>/operations/<operation>`.
                   # The long-running operation
-                  # {::Google::Longrunning::Operation#metadata metadata} field type
+                  # metadata field type
                   # `metadata.type_url` describes the type of the metadata. Operations returned
                   # include those that have completed/failed/canceled within the last 7 days,
                   # and pending operations. Operations returned are ordered by
@@ -831,8 +852,7 @@ module Google
                   #     must be one of: `<`, `>`, `<=`, `>=`, `!=`, `=`, or `:`.
                   #     Colon `:` is the contains operator. Filter rules are not case sensitive.
                   #
-                  #     The following fields in the {::Google::Longrunning::Operation Operation}
-                  #     are eligible for filtering:
+                  #     The following fields in the Operation are eligible for filtering:
                   #
                   #       * `name` - The name of the long-running operation
                   #       * `done` - False if the operation is in progress, else true.
@@ -933,7 +953,7 @@ module Google
                     @instance_admin_stub.list_instance_config_operations request, options do |result, operation|
                       result = ::Gapic::Rest::PagedEnumerable.new @instance_admin_stub, :list_instance_config_operations, "operations", request, result, options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1052,7 +1072,6 @@ module Google
 
                     @instance_admin_stub.list_instances request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1078,7 +1097,9 @@ module Google
                   #
                   #   @param parent [::String]
                   #     Required. The instance whose instance partitions should be listed. Values
-                  #     are of the form `projects/<project>/instances/<instance>`.
+                  #     are of the form `projects/<project>/instances/<instance>`. Use `{instance}
+                  #     = '-'` to list instance partitions for all Instances in a project, e.g.,
+                  #     `projects/myproject/instances/-`.
                   #   @param page_size [::Integer]
                   #     Number of instance partitions to be returned in the response. If 0 or less,
                   #     defaults to the server's maximum allowed page size.
@@ -1151,7 +1172,6 @@ module Google
 
                     @instance_admin_stub.list_instance_partitions request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1236,7 +1256,6 @@ module Google
 
                     @instance_admin_stub.get_instance request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1244,7 +1263,7 @@ module Google
 
                   ##
                   # Creates an instance and begins preparing it to begin serving. The
-                  # returned {::Google::Longrunning::Operation long-running operation}
+                  # returned long-running operation
                   # can be used to track the progress of preparing the new
                   # instance. The instance name is assigned by the caller. If the
                   # named instance already exists, `CreateInstance` returns
@@ -1270,12 +1289,12 @@ module Google
                   #   * The instance's allocated resource levels are readable via the API.
                   #   * The instance's state becomes `READY`.
                   #
-                  # The returned {::Google::Longrunning::Operation long-running operation} will
+                  # The returned long-running operation will
                   # have a name of the format `<instance_name>/operations/<operation_id>` and
                   # can be used to track creation of the instance.  The
-                  # {::Google::Longrunning::Operation#metadata metadata} field type is
+                  # metadata field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::CreateInstanceMetadata CreateInstanceMetadata}.
-                  # The {::Google::Longrunning::Operation#response response} field type is
+                  # The response field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::Instance Instance}, if successful.
                   #
                   # @overload create_instance(request, options = nil)
@@ -1364,7 +1383,7 @@ module Google
                     @instance_admin_stub.create_instance request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1372,8 +1391,7 @@ module Google
 
                   ##
                   # Updates an instance, and begins allocating or releasing resources
-                  # as requested. The returned [long-running
-                  # operation][google.longrunning.Operation] can be used to track the
+                  # as requested. The returned long-running operation can be used to track the
                   # progress of updating the instance. If the named instance does not
                   # exist, returns `NOT_FOUND`.
                   #
@@ -1401,12 +1419,12 @@ module Google
                   #     tables.
                   #   * The instance's new resource levels are readable via the API.
                   #
-                  # The returned {::Google::Longrunning::Operation long-running operation} will
+                  # The returned long-running operation will
                   # have a name of the format `<instance_name>/operations/<operation_id>` and
                   # can be used to track the instance modification.  The
-                  # {::Google::Longrunning::Operation#metadata metadata} field type is
+                  # metadata field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::UpdateInstanceMetadata UpdateInstanceMetadata}.
-                  # The {::Google::Longrunning::Operation#response response} field type is
+                  # The response field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::Instance Instance}, if successful.
                   #
                   # Authorization requires `spanner.instances.update` permission on
@@ -1499,7 +1517,7 @@ module Google
                     @instance_admin_stub.update_instance request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1589,7 +1607,6 @@ module Google
 
                     @instance_admin_stub.delete_instance request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1684,7 +1701,6 @@ module Google
 
                     @instance_admin_stub.set_iam_policy request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1771,7 +1787,6 @@ module Google
 
                     @instance_admin_stub.get_iam_policy request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1861,7 +1876,6 @@ module Google
 
                     @instance_admin_stub.test_iam_permissions request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1942,7 +1956,6 @@ module Google
 
                     @instance_admin_stub.get_instance_partition request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -1950,7 +1963,7 @@ module Google
 
                   ##
                   # Creates an instance partition and begins preparing it to be used. The
-                  # returned {::Google::Longrunning::Operation long-running operation}
+                  # returned long-running operation
                   # can be used to track the progress of preparing the new instance partition.
                   # The instance partition name is assigned by the caller. If the named
                   # instance partition already exists, `CreateInstancePartition` returns
@@ -1977,13 +1990,13 @@ module Google
                   #     API.
                   #   * The instance partition's state becomes `READY`.
                   #
-                  # The returned {::Google::Longrunning::Operation long-running operation} will
+                  # The returned long-running operation will
                   # have a name of the format
                   # `<instance_partition_name>/operations/<operation_id>` and can be used to
                   # track creation of the instance partition.  The
-                  # {::Google::Longrunning::Operation#metadata metadata} field type is
+                  # metadata field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::CreateInstancePartitionMetadata CreateInstancePartitionMetadata}.
-                  # The {::Google::Longrunning::Operation#response response} field type is
+                  # The response field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::InstancePartition InstancePartition}, if
                   # successful.
                   #
@@ -2075,7 +2088,7 @@ module Google
                     @instance_admin_stub.create_instance_partition request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -2167,7 +2180,6 @@ module Google
 
                     @instance_admin_stub.delete_instance_partition request, options do |result, operation|
                       yield result, operation if block_given?
-                      return result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -2175,8 +2187,7 @@ module Google
 
                   ##
                   # Updates an instance partition, and begins allocating or releasing resources
-                  # as requested. The returned [long-running
-                  # operation][google.longrunning.Operation] can be used to track the
+                  # as requested. The returned long-running operation can be used to track the
                   # progress of updating the instance partition. If the named instance
                   # partition does not exist, returns `NOT_FOUND`.
                   #
@@ -2205,13 +2216,13 @@ module Google
                   #     partition's tables.
                   #   * The instance partition's new resource levels are readable via the API.
                   #
-                  # The returned {::Google::Longrunning::Operation long-running operation} will
+                  # The returned long-running operation will
                   # have a name of the format
                   # `<instance_partition_name>/operations/<operation_id>` and can be used to
                   # track the instance partition modification. The
-                  # {::Google::Longrunning::Operation#metadata metadata} field type is
+                  # metadata field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::UpdateInstancePartitionMetadata UpdateInstancePartitionMetadata}.
-                  # The {::Google::Longrunning::Operation#response response} field type is
+                  # The response field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::InstancePartition InstancePartition}, if
                   # successful.
                   #
@@ -2307,19 +2318,18 @@ module Google
                     @instance_admin_stub.update_instance_partition request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
                   end
 
                   ##
-                  # Lists instance partition [long-running
-                  # operations][google.longrunning.Operation] in the given instance.
+                  # Lists instance partition long-running operations in the given instance.
                   # An instance partition operation has a name of the form
                   # `projects/<project>/instances/<instance>/instancePartitions/<instance_partition>/operations/<operation>`.
                   # The long-running operation
-                  # {::Google::Longrunning::Operation#metadata metadata} field type
+                  # metadata field type
                   # `metadata.type_url` describes the type of the metadata. Operations returned
                   # include those that have completed/failed/canceled within the last 7 days,
                   # and pending operations. Operations returned are ordered by
@@ -2357,8 +2367,7 @@ module Google
                   #     must be one of: `<`, `>`, `<=`, `>=`, `!=`, `=`, or `:`.
                   #     Colon `:` is the contains operator. Filter rules are not case sensitive.
                   #
-                  #     The following fields in the {::Google::Longrunning::Operation Operation}
-                  #     are eligible for filtering:
+                  #     The following fields in the Operation are eligible for filtering:
                   #
                   #       * `name` - The name of the long-running operation
                   #       * `done` - False if the operation is in progress, else true.
@@ -2405,7 +2414,8 @@ module Google
                   #     Optional. Deadline used while retrieving metadata for instance partition
                   #     operations. Instance partitions whose operation metadata cannot be
                   #     retrieved within this deadline will be added to
-                  #     [unreachable][ListInstancePartitionOperationsResponse.unreachable] in
+                  #     {::Google::Cloud::Spanner::Admin::Instance::V1::ListInstancePartitionOperationsResponse#unreachable_instance_partitions unreachable_instance_partitions}
+                  #     in
                   #     {::Google::Cloud::Spanner::Admin::Instance::V1::ListInstancePartitionOperationsResponse ListInstancePartitionOperationsResponse}.
                   # @yield [result, operation] Access the result along with the TransportOperation object
                   # @yieldparam result [::Gapic::Operation]
@@ -2465,7 +2475,7 @@ module Google
                     @instance_admin_stub.list_instance_partition_operations request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -2473,7 +2483,7 @@ module Google
 
                   ##
                   # Moves an instance to the target instance configuration. You can use the
-                  # returned {::Google::Longrunning::Operation long-running operation} to track
+                  # returned long-running operation to track
                   # the progress of moving the instance.
                   #
                   # `MoveInstance` returns `FAILED_PRECONDITION` if the instance meets any of
@@ -2504,13 +2514,13 @@ module Google
                   #     transaction abort rate. However, moving an instance doesn't cause any
                   #     downtime.
                   #
-                  # The returned {::Google::Longrunning::Operation long-running operation} has
+                  # The returned long-running operation has
                   # a name of the format
                   # `<instance_name>/operations/<operation_id>` and can be used to track
                   # the move instance operation. The
-                  # {::Google::Longrunning::Operation#metadata metadata} field type is
+                  # metadata field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::MoveInstanceMetadata MoveInstanceMetadata}.
-                  # The {::Google::Longrunning::Operation#response response} field type is
+                  # The response field type is
                   # {::Google::Cloud::Spanner::Admin::Instance::V1::Instance Instance},
                   # if successful.
                   # Cancelling the operation sets its metadata's
@@ -2616,7 +2626,7 @@ module Google
                     @instance_admin_stub.move_instance request, options do |result, operation|
                       result = ::Gapic::Operation.new result, @operations_client, options: options
                       yield result, operation if block_given?
-                      return result
+                      throw :response, result
                     end
                   rescue ::Gapic::Rest::Error => e
                     raise ::Google::Cloud::Error.from_error(e)
@@ -2696,6 +2706,11 @@ module Google
                   #   default endpoint URL. The default value of nil uses the environment
                   #   universe (usually the default "googleapis.com" universe).
                   #   @return [::String,nil]
+                  # @!attribute [rw] logger
+                  #   A custom logger to use for request/response debug logging, or the value
+                  #   `:default` (the default) to construct a default logger, or `nil` to
+                  #   explicitly disable logging.
+                  #   @return [::Logger,:default,nil]
                   #
                   class Configuration
                     extend ::Gapic::Config
@@ -2717,6 +2732,7 @@ module Google
                     config_attr :retry_policy,  nil, ::Hash, ::Proc, nil
                     config_attr :quota_project, nil, ::String, nil
                     config_attr :universe_domain, nil, ::String, nil
+                    config_attr :logger, :default, ::Logger, nil, :default
 
                     # @private
                     def initialize parent_config = nil