google-cloud-pubsub 2.12.0 → 2.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19d022ba204052f7d871418daa55ed9b47f9e6786abe0c2bc996eba6e31f393e
-  data.tar.gz: 5440bfb2fa042c83d0e9ea22a3bd974c517c9d7c771b291ddbe953b7f622100f
+  metadata.gz: 06c05b51b56c92420e68bd4decf6cbcf91f2027c572cb89302bcae505e6a3f5b
+  data.tar.gz: b2072f171d8fcf1e3d7506ef86c278b5d7d60faa4dbbb0092b16fe759e1d4245
 SHA512:
-  metadata.gz: 0a487ba4783cb96c663b7ff96311b6514ec851aca7d0985b391574ff1161b19f8aaed391fdc3571f68103c43ab3244adc6d79e9f2a13b3a99fab792139b4da56
-  data.tar.gz: 683a30d9cd5db86e950323205007ac1e83796b386929bb41d4ed5978c1e984debdd0f7f08a273f1ff6fed4c0fcbaef4e9b5cfcfcec11c37e0ab48078ba64e50a
+  metadata.gz: 65446317085d8522281bbfbf84f923f6a6efa98342afd4ac4900995436ad57b91d11ce77498fda558d3f37de9fb540ac99bfd38d825bbc54267e2b0490c5c1ca
+  data.tar.gz: 5a421f55fd6f75449162b1c7fbba30e78bd99409a6af3e62861e9cf95e5de2699fdd76ae23dbd4806123086fa1f25077590313ddc36adeea9d9d993e34c01293

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Release History
 
+### 2.13.0 (2022-10-18)
+
+#### Features
+
+* Added support for bigquery subscription ([#19221](https://github.com/googleapis/google-cloud-ruby/issues/19221)) 
+
+### 2.12.1 (2022-08-21)
+
+#### Bug Fixes
+
+* update non EOS ack to return Success always ([#19023](https://github.com/googleapis/google-cloud-ruby/issues/19023)) 
+
 ### 2.12.0 (2022-08-09)
 
 #### Features

data/lib/google/cloud/pubsub/received_message.rb

@@ -204,7 +204,12 @@ module Google
         #
         def acknowledge! &block
           ensure_subscription!
-          subscription.acknowledge ack_id, &block
+          if subscription.respond_to?(:exactly_once_delivery_enabled) && subscription.exactly_once_delivery_enabled
+            subscription.acknowledge ack_id, &block
+          else
+            subscription.acknowledge ack_id
+            yield AcknowledgeResult.new(AcknowledgeResult::SUCCESS) if block_given?
+          end
         end
         alias ack! acknowledge!
 
@@ -265,7 +270,12 @@ module Google
         #
         def modify_ack_deadline! new_deadline, &block
           ensure_subscription!
-          subscription.modify_ack_deadline new_deadline, ack_id, &block
+          if subscription.respond_to?(:exactly_once_delivery_enabled) && subscription.exactly_once_delivery_enabled
+            subscription.modify_ack_deadline new_deadline, ack_id, &block
+          else
+            subscription.modify_ack_deadline new_deadline, ack_id
+            yield AcknowledgeResult.new(AcknowledgeResult::SUCCESS) if block_given?
+          end
         end
 
         ##

data/lib/google/cloud/pubsub/subscriber/timed_unary_buffer.rb

@@ -35,11 +35,11 @@ module Google
 
           PERMANENT_FAILURE = "PERMANENT_FAILURE".freeze
           # Google::Cloud::Unavailable error is already retried at gapic level
-          RETRIABLE_ERRORS = [Google::Cloud::CanceledError,
-                              Google::Cloud::DeadlineExceededError,
-                              Google::Cloud::InternalError,
-                              Google::Cloud::ResourceExhaustedError,
-                              Google::Cloud::InvalidArgumentError].freeze
+          EXACTLY_ONCE_DELIVERY_POSSIBLE_RETRIABLE_ERRORS = [Google::Cloud::CanceledError,
+                                                             Google::Cloud::DeadlineExceededError,
+                                                             Google::Cloud::InternalError,
+                                                             Google::Cloud::ResourceExhaustedError,
+                                                             Google::Cloud::InvalidArgumentError].freeze
           MAX_RETRY_DURATION = 600 # 600s since the server allows ack/modacks for 10 mins max
           MAX_TRIES = 15
           BASE_INTERVAL = 1
@@ -128,7 +128,7 @@ module Google
                 begin
                   @subscriber.service.acknowledge ack_req.subscription, *ack_req.ack_ids
                   handle_callback AcknowledgeResult.new(AcknowledgeResult::SUCCESS), ack_req.ack_ids
-                rescue *RETRIABLE_ERRORS => e
+                rescue *EXACTLY_ONCE_DELIVERY_POSSIBLE_RETRIABLE_ERRORS => e
                   handle_failure e, ack_req.ack_ids if @subscriber.exactly_once_delivery_enabled
                 rescue StandardError => e
                   handle_callback construct_result(e), ack_req.ack_ids
@@ -146,7 +146,7 @@ module Google
                   handle_callback AcknowledgeResult.new(AcknowledgeResult::SUCCESS),
                                   mod_ack_req.ack_ids,
                                   modack: true
-                rescue *RETRIABLE_ERRORS => e
+                rescue *EXACTLY_ONCE_DELIVERY_POSSIBLE_RETRIABLE_ERRORS => e
                   if @subscriber.exactly_once_delivery_enabled
                     handle_failure e, mod_ack_req.ack_ids, mod_ack_req.ack_deadline_seconds
                   end
@@ -276,7 +276,7 @@ module Google
                                   max_interval: MAX_INTERVAL,
                                   multiplier: MULTIPLIER,
                                   max_elapsed_time: MAX_RETRY_DURATION,
-                                  on: RETRIABLE_ERRORS do
+                                  on: EXACTLY_ONCE_DELIVERY_POSSIBLE_RETRIABLE_ERRORS do
                 return if ack_ids.nil?
                 begin
                   yield ack_ids

data/lib/google/cloud/pubsub/subscription.rb

@@ -303,6 +303,56 @@ module Google
           config.freeze
         end
 
+        ##
+        # Inspect the Subscription's bigquery configuration settings. The
+        # configuration can be changed by modifying the values in the method's
+        # block.
+        #
+        # @yield [bigquery_config] a block for modifying the bigquery configuration
+        # @yieldparam [Google::Cloud::PubSub::V1::BigQueryConfig] bigquery_config
+        #
+        # @return [Google::Cloud::PubSub::V1::BigQueryConfig]
+        #
+        # @example
+        #   require "google/cloud/pubsub"
+        #
+        #   pubsub = Google::Cloud::PubSub.new
+        #
+        #   sub = pubsub.subscription "my-topic-sub"
+        #   sub.bigquery_config.table #=> "my-project:dataset-id.table-id"
+        #   sub.bigquery_config.use_topic_schema #=> true
+        #   sub.bigquery_config.write_metadata #=> false
+        #
+        # @example Update the bigquery configuration by passing a block:
+        #   require "google/cloud/pubsub"
+        #
+        #   pubsub = Google::Cloud::PubSub.new
+        #   sub = pubsub.subscription "my-subscription"
+        #
+        #   sub.bigquery_config do |bc|
+        #     bc.write_metadata = true
+        #     bc.use_topic_schema = false
+        #   end
+        #
+        def bigquery_config
+          ensure_service!
+
+          config = reference? ? Google::Cloud::PubSub::V1::BigQueryConfig.new : @grpc.bigquery_config
+
+          if block_given?
+            old_config = config.dup
+            yield config
+            new_config = config
+
+            if old_config != new_config # has the object been changed?
+              update_grpc = Google::Cloud::PubSub::V1::Subscription.new name: name, bigquery_config: new_config
+              @grpc = service.update_subscription update_grpc, :bigquery_config
+            end
+          end
+
+          config.freeze
+        end
+
         ##
         # A hash of user-provided labels associated with this subscription.
         # Labels can be used to organize and group subscriptions.See [Creating

data/lib/google/cloud/pubsub/version.rb

@@ -16,7 +16,7 @@
 module Google
   module Cloud
     module PubSub
-      VERSION = "2.12.0".freeze
+      VERSION = "2.13.0".freeze
     end
 
     Pubsub = PubSub unless const_defined? :Pubsub

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-cloud-pubsub
 version: !ruby/object:Gem::Version
-  version: 2.12.0
+  version: 2.13.0
 platform: ruby
 authors:
 - Mike Moore
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-09 00:00:00.000000000 Z
+date: 2022-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby