google-cloud-logging 1.10.4 → 1.10.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c44ea43caa6da57f944c25da29cb76c70b99805fbf517f36273e290f39e51a1
-  data.tar.gz: 9d4b2142b4713362151659a8af7b959be1950fe895254500a300052655e7c228
+  metadata.gz: bd1f41e64309828c0a4ade40f6f37f34f5c880d5bc076cef18c3d864aba75e1d
+  data.tar.gz: 58f97d26011dbd5438f3644291096c37cf39fef9ab0394498148153d1a45ac50
 SHA512:
-  metadata.gz: 6544f6f25befee91e60d009685797fab479c77d2d679584b35965bea7a44c536efe77a9bb8b68340719937371030129f018eb5fdff34221bff58752ceb98e240
-  data.tar.gz: c1219e8155a148df9874c5ddb6b0b03b9365b358f3bf3e855beebc9da6acc5307679a8c4c4c387350e8a9169b3a45eb67d0731e297c0c120033831018ff74fec
+  metadata.gz: f702d5baed7f22f965e294e4e81ec582aa04b0df72ffb9231d02a41791656acc486e8b0093b9c60c3f5119ceb195cf74208a5fdfa13373758f2d7a20e9326057
+  data.tar.gz: cf3d386de873038b9db370e66b85078dc4ed15961e5ba4410f7ac5dc192131db84ced61a9312d215b2e4039587433507c0758b8f913d5101d6ad1ec781d3baaa

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+### 1.10.5 / 2020-05-05
+
+#### Bug Fixes
+
+* Prevent error when calling stop! on unused AsyncWriter
+
 ### 1.10.4 / 2020-04-20
 
 #### Documentation

data/lib/google/cloud/logging/async_writer.rb

@@ -155,7 +155,7 @@ module Google
               max_threads: @threads, max_queue: @max_queue
             @thread ||= Thread.new { run_background }
 
-            publish_batch! if @batch.ready?
+            publish_batch! if @batch&.ready?
 
             @cond.broadcast
           end
@@ -222,6 +222,10 @@ module Google
         # writer. To stop the writer, first call {#stop} and then call {#wait!}
         # to block until the writer is stopped.
         #
+        # @param [Number, nil] timeout The maximum number of seconds to wait for
+        #   shutdown to complete. Will wait forever when the value is `nil`. The
+        #   default value is `nil`.
+        #
         # @return [AsyncWriter] returns self so calls can be chained.
         def wait! timeout = nil
           synchronize do
@@ -237,18 +241,22 @@ module Google
         ##
         # Stop this asynchronous writer and block until it has been stopped.
         #
-        # @param [Number] timeout Timeout in seconds.
+        # @param [Number, nil] timeout The maximum number of seconds to wait for
+        #   shutdown to complete. Will wait forever when the value is `nil`. The
+        #   default value is `nil`.
         # @param [Boolean] force If set to true, and the writer hasn't stopped
-        #     within the given timeout, kill it forcibly by terminating the
-        #     thread. This should be used with extreme caution, as it can
-        #     leave RPCs unfinished. Default is false.
+        #   within the given timeout, kill it forcibly by terminating the
+        #   thread. This should be used with extreme caution, as it can
+        #   leave RPCs unfinished. Default is false.
         #
-        # @return [Symbol] Returns `:stopped` if the AsyncWriter was already
-        #     stopped at the time of invocation, `:waited` if it stopped
-        #     during the timeout period, `:timeout` if it is still running
-        #     after the timeout, or `:forced` if it was forcibly killed.
+        # @return [Symbol] Returns `:new` if {#write_entries} has never been
+        #   called on the AsyncWriter, `:stopped` if it was already stopped
+        #   at the time of invocation, `:waited` if it stopped during the
+        #   timeout period, `:timeout` if it is still running after the
+        #   timeout, or `:forced` if it was forcibly killed.
         #
         def stop! timeout = nil, force: nil
+          return :new unless @thread_pool
           return :stopped if stopped?
 
           stop

data/lib/google/cloud/logging/version.rb

@@ -16,7 +16,7 @@
 module Google
   module Cloud
     module Logging
-      VERSION = "1.10.4".freeze
+      VERSION = "1.10.5".freeze
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-cloud-logging
 version: !ruby/object:Gem::Version
-  version: 1.10.4
+  version: 1.10.5
 platform: ruby
 authors:
 - Mike Moore
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-20 00:00:00.000000000 Z
+date: 2020-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-cloud-core
@@ -127,14 +127,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.10'
+        version: '5.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.10'
+        version: '5.14'
 - !ruby/object:Gem::Dependency
   name: minitest-autotest
   requirement: !ruby/object:Gem::Requirement