google-cloud-error_reporting 0.32.0 → 0.32.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96a8b2ba7e135e4e92d2214792fa1e984be8e651f9b807369e8b4b6ba85288cf
-  data.tar.gz: c5a07ee5288fe0914460c57b21b25c7c21505d6569a03da05752ac14389c8556
+  metadata.gz: c9979f9f2835f10dddb6e0176470af18c3365f327c08b738986327efffab2408
+  data.tar.gz: 68c69be359657054041e9c8a81948c16750245a9ecc211679f610eab74931004
 SHA512:
-  metadata.gz: ea52d976179d1cf59e0f7b5a601cf0c5a760ec2596ddf966a18ac678913dfca9a5ec16e83fe0a5998c6bb14ef5d1d4a8e6d9b8cec5f5db2a70a7d3ded4b2ab49
-  data.tar.gz: 91ab3a7c056f6bf1157e4d495bd8e985601571bf131e274627ad94d2fd2a2818a44633bc43b5a5ca1e66ed0eeaa42383353019d0200bed443d8310d6036f3916
+  metadata.gz: ae9b9ea77ab3cf2119c798d82cdf3060903fa2bff1797d112c33e1e3dadda94143e580cfa644aca7ee44e707633300df58d38daa72386320799120d90f196967
+  data.tar.gz: a89bb5a4d117fc776db3f55d12b0f127bd8742ad4b82414a8f4ff1c6dd269dfcd7dff2494fbea8b9a70f2f2ca127cea2b66d1a3230a7d637c6160d2676b38881

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+### 0.32.1 / 2019-10-10
+
+#### Bug Fixes
+
+* The ErrorReporting middleware reuses the existing default reporter instead of creating new ones every time
+
 ### 0.32.0 / 2019-08-23
 
 #### Features

data/lib/google/cloud/error_reporting.rb

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 
+require "monitor"
 require "google-cloud-error_reporting"
 require "google/cloud/error_reporting/async_error_reporter"
 require "google/cloud/error_reporting/project"
@@ -35,7 +36,8 @@ module Google
       ##
       # @private The default Google::Cloud::ErrorReporting::Project client used
       # for the Google::Cloud::ErrorReporting.report API.
-      @@default_client = nil
+      @default_reporter = nil
+      @default_reporter_mutex = Monitor.new
 
       ##
       # Creates a new object for connecting to the Stackdriver Error Reporting
@@ -224,7 +226,7 @@ module Google
 
         yield error_event if block_given?
 
-        default_client.report error_event
+        default_reporter.report error_event
       end
 
       ##
@@ -253,22 +255,32 @@ module Google
       private_class_method :resolve_project_id
 
       ##
-      # @private Create a private client to
-      def self.default_client
-        unless @@default_client
-          project_id = Project.default_project_id
-          credentials = default_credentials
-
-          @@default_client = AsyncErrorReporter.new(
-            new(project_id: project_id, credentials: credentials)
-          )
+      # Returns the global default reporter used by middleware and the
+      # {Google::Cloud::ErrorReporting.report} convenience method.
+      #
+      # If the default reporter is already defined, returns it. Otherwise, if
+      # a block is given, it is called and the result is set as the default
+      # reporter. Otherwise, if no block is given, a reporter is constructed
+      # from the default project and credentials.
+      #
+      # @return [#report]
+      #
+      def self.default_reporter &block
+        @default_reporter_mutex.synchronize do
+          @default_reporter ||=
+            if block
+              block.call
+            else
+              project_id = Project.default_project_id
+              credentials = default_credentials
+              AsyncErrorReporter.new(
+                new(project_id: project_id, credentials: credentials)
+              )
+            end
         end
-
-        @@default_client
+        @default_reporter
       end
 
-      private_class_method :default_client
-
       ##
       # @private Default credentials.
       def self.default_credentials scope: nil

data/lib/google/cloud/error_reporting/middleware.rb

@@ -54,14 +54,12 @@ module Google
 
           @error_reporting =
             error_reporting ||
-            ErrorReporting::AsyncErrorReporter.new(
-              ErrorReporting.new(project: configuration.project_id,
-                                 credentials: configuration.credentials)
-            )
-
-          # Set module default client to reuse the same client. Update module
-          # configuration parameters.
-          ErrorReporting.class_variable_set :@@default_client, @error_reporting
+            ErrorReporting.default_reporter do
+              ErrorReporting::AsyncErrorReporter.new(
+                ErrorReporting.new(project: configuration.project_id,
+                                   credentials: configuration.credentials)
+              )
+            end
         end
 
         ##

data/lib/google/cloud/error_reporting/v1beta1/doc/google/protobuf/timestamp.rb

@@ -88,11 +88,13 @@ module Google
     # 01:30 UTC on January 15, 2017.
     #
     # In JavaScript, one can convert a Date object to this format using the
-    # standard [toISOString()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString)
+    # standard
+    # [toISOString()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString)
     # method. In Python, a standard `datetime.datetime` object can be converted
-    # to this format using [`strftime`](https://docs.python.org/2/library/time.html#time.strftime)
-    # with the time format spec '%Y-%m-%dT%H:%M:%S.%fZ'. Likewise, in Java, one
-    # can use the Joda Time's [`ISODateTimeFormat.dateTime()`](
+    # to this format using
+    # [`strftime`](https://docs.python.org/2/library/time.html#time.strftime) with
+    # the time format spec '%Y-%m-%dT%H:%M:%S.%fZ'. Likewise, in Java, one can use
+    # the Joda Time's [`ISODateTimeFormat.dateTime()`](
     # http://www.joda.org/joda-time/apidocs/org/joda/time/format/ISODateTimeFormat.html#dateTime%2D%2D
     # ) to obtain a formatter capable of generating timestamps in this format.
     # @!attribute [rw] seconds

data/lib/google/cloud/error_reporting/version.rb

@@ -16,7 +16,7 @@
 module Google
   module Cloud
     module ErrorReporting
-      VERSION = "0.32.0".freeze
+      VERSION = "0.32.1".freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-cloud-error_reporting
 version: !ruby/object:Gem::Version
-  version: 0.32.0
+  version: 0.32.1
 platform: ruby
 authors:
 - Google Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-23 00:00:00.000000000 Z
+date: 2019-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-cloud-core