google-cloud-env 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 743c1259c72af3a3cd7872d88adfa2d4ba8d4850733dfba06403ad9014e510fb
-  data.tar.gz: f1d426cd09a3591e4e60e95c0d47ada831ec498bdfc04ab709a90c6333cae560
+  metadata.gz: 5ac62dcc3131def7be6bf69813f79c3d23b6d6ce5199d0250ffad596cf3b7fcb
+  data.tar.gz: d9eadf5f767d8225022ed9551ea3a5a2ee37e8ad5b68da9eea7c94f416333f4f
 SHA512:
-  metadata.gz: f851d76b537d777a94973491da78ab454dbcbe23f1809ce981d86a654a28af8e1b22c7f2595ea3d4a5c64d0648d263790a61fa36e56a63eb70f83ff9a0862922
-  data.tar.gz: 6b2160f8ab772f8af3bdbc8ee613cbc33e92310d99ac36dbf9a8962a8c75f5db6a6a7145c1560e2aa73e51d5e07acb04d3aa4638d222d2814de5288b043686b5
+  metadata.gz: def8ccefb5d889744cb562a85cc78a9d3b718f80f2d48eab409c6fcdbcbe2dfe9adae14393f06aab3b6a6db83b6fc6d631902d11c1a932e2a77ee2f93a5ca82f
+  data.tar.gz: 5faabdeb543a4237dd19a69a9963237e4b843f93aeeaa1f002cc08bd0269ba005da6a89baee20989076330b97de9551a41a50e658febd173847166fc29013bcb

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Release History
 
+### 2.0.1 (2023-12-01)
+
+#### Bug Fixes
+
+* Bad response status or flavor headers no longer signal positive metadata existence ([#61](https://github.com/googleapis/ruby-cloud-env/issues/61)) 
+* Increase token expiry buffer to three and a half minutes ([#59](https://github.com/googleapis/ruby-cloud-env/issues/59)) 
+
 ### 2.0.0 (2023-11-14)
 
 This is a major overhaul of the mechanisms underlying this gem, to improve reliability and provide better mocking interfaces. Environment interrogation calls are unchanged, but the mocking override parameters from 1.x have been removed in favor of the new interfaces, hence the semver-major version bump.

data/lib/google/cloud/env/compute_metadata.rb

@@ -124,6 +124,14 @@ module Google
           # @return [Hash{String=>String}]
           #
           attr_reader :headers
+
+          ##
+          # Returns true if the metadata-flavor is correct for Google Cloud
+          # @return [boolean]
+          #
+          def google_flavor?
+            headers["Metadata-Flavor"] == "Google"
+          end
         end
 
         ##
@@ -233,20 +241,10 @@ module Google
                        compute_smbios: nil
           @variables = variables || Variables.new
           @compute_smbios = compute_smbios || ComputeSMBIOS.new
-          self.host = nil
-          @connection = Faraday.new url: host
-          self.open_timeout = DEFAULT_OPEN_TIMEOUT
-          self.request_timeout = DEFAULT_REQUEST_TIMEOUT
-          self.retry_count = DEFAULT_RETRY_COUNT
-          self.retry_timeout = DEFAULT_RETRY_TIMEOUT
-          self.retry_interval = DEFAULT_RETRY_INTERVAL
-          self.warmup_time = DEFAULT_WARMUP_TIME
-          @cache = create_cache
           # This mutex protects the overrides and existence settings.
           # Those values won't change within a synchronize block.
           @mutex = Thread::Mutex.new
-          reset_existence!
-          @overrides = nil
+          reset!
         end
 
         ##
@@ -443,7 +441,7 @@ module Google
                                      request_timeout: request_timeout,
                                      retry_count: retry_count,
                                      retry_timeout: retry_timeout
-          return nil unless response.status == 200 && response.headers["Metadata-Flavor"] == "Google"
+          return nil unless response.status == 200 && response.google_flavor?
           response.body
         end
 
@@ -618,6 +616,26 @@ module Google
         #
         attr_reader :compute_smbios
 
+        ##
+        # @private
+        # Reset the cache, overrides, and all settings to default, for testing.
+        #
+        def reset!
+          @mutex.synchronize do
+            self.host = nil
+            @connection = Faraday.new url: host
+            self.open_timeout = DEFAULT_OPEN_TIMEOUT
+            self.request_timeout = DEFAULT_REQUEST_TIMEOUT
+            self.retry_count = DEFAULT_RETRY_COUNT
+            self.retry_timeout = DEFAULT_RETRY_TIMEOUT
+            self.retry_interval = DEFAULT_RETRY_INTERVAL
+            self.warmup_time = DEFAULT_WARMUP_TIME
+            @cache = create_cache
+            @overrides = nil
+          end
+          reset_existence!
+        end
+
         ##
         # @private
         # Clear the existence cache, for testing.
@@ -627,6 +645,7 @@ module Google
             @existence = nil
             @startup_time = Process.clock_gettime Process::CLOCK_MONOTONIC
           end
+          self
         end
 
         private
@@ -645,6 +664,29 @@ module Google
           Timeout::Error
         ].freeze
 
+        ##
+        # @private
+        #
+        # A buffer in seconds for token expiry. Our cache for the token will
+        # expire approximately this many seconds before the declared expiry
+        # time of the token itself.
+        #
+        # We want this value to be positive so that we provide some buffer to
+        # offset any clock skew and Metadata Server latency that might affect
+        # our calculation of the expiry time, but more importantly so that a
+        # client has approximately this amount of time to use a token we give
+        # them before it expires.
+        #
+        # We don't want this to be much higher, however, to keep the load down
+        # on the Metadata Server. We've been advised by the compute/serverless
+        # engineering teams to set this value less than 4 minutes because the
+        # Metadata Server can refresh the token as late as 4 minutes before the
+        # actual expiry of the previous token. If our cache expires and we
+        # request a new token, we actually want to receive a new token rather
+        # than the previous old token. See internal issue b/311414224.
+        #
+        TOKEN_EXPIRY_BUFFER = 210
+
         ##
         # @private
         #
@@ -708,8 +750,12 @@ module Google
             req.options.timeout = request_timeout if request_timeout
             req.options.open_timeout = open_timeout if open_timeout
           end
-          post_update_existence true
           response = Response.new http_response.status, http_response.body, http_response.headers
+          if path.nil?
+            post_update_existence(response.status == 200 && response.google_flavor?)
+          elsif response.google_flavor?
+            post_update_existence true
+          end
           lifetime = determine_data_lifetime path, response.body.strip
           LazyValue.expiring_value lifetime, response
         rescue *TRANSIENT_EXCEPTIONS
@@ -754,8 +800,7 @@ module Google
         def access_token_lifetime data
           json = JSON.parse data rescue nil
           return 0 unless json&.key? "expires_in"
-          # Buffer of 10 seconds to account for MDS latency
-          lifetime = json["expires_in"].to_i - 10
+          lifetime = json["expires_in"].to_i - TOKEN_EXPIRY_BUFFER
           lifetime = 0 if lifetime.negative?
           lifetime
         end
@@ -769,8 +814,7 @@ module Google
           base64 = Base64.decode64 Regexp.last_match[1]
           json = JSON.parse base64 rescue nil
           return 0 unless json&.key? "exp"
-          # Buffer of 10 seconds in case of clock skew
-          lifetime = json["exp"].to_i - Time.now.to_i - 10
+          lifetime = json["exp"].to_i - Time.now.to_i - TOKEN_EXPIRY_BUFFER
           lifetime = 0 if lifetime.negative?
           lifetime
         end

data/lib/google/cloud/env/version.rb

@@ -20,7 +20,7 @@ module Google
       # Library version
       # @return [String]
       #
-      VERSION = "2.0.0".freeze
+      VERSION = "2.0.1".freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-cloud-env
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Daniel Azuma
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-15 00:00:00.000000000 Z
+date: 2023-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -59,10 +59,10 @@ homepage: https://github.com/googleapis/ruby-cloud-env
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://rubydoc.info/gems/google-cloud-env/2.0.0/CHANGELOG.md
+  changelog_uri: https://rubydoc.info/gems/google-cloud-env/2.0.1/CHANGELOG.md
   source_code_uri: https://github.com/googleapis/ruby-cloud-env
   bug_tracker_uri: https://github.com/googleapis/ruby-cloud-env/issues
-  documentation_uri: https://rubydoc.info/gems/google-cloud-env/2.0.0
+  documentation_uri: https://rubydoc.info/gems/google-cloud-env/2.0.1
 post_install_message: 
 rdoc_options: []
 require_paths: