google-cloud-datastore 1.7.1 → 1.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d609665c2857145f66bc2c74a6cd06c444ee70c919ddb191a6204c4fdb91b5b
-  data.tar.gz: '018f3738beaaa8227b901766c27d348a6bdb0333d6eb06aba620104b01923a10'
+  metadata.gz: a29b6748c619ac4ab18f6fdeb209b5abdbdab08ec6bd76fd31b751bb79a1d147
+  data.tar.gz: 3b77201abcdaead06a37eb19c39fdd2ba8e480eff2b191a05fd76547a8c0a93e
 SHA512:
-  metadata.gz: 33c5af902ce9b556881a4788e0c64cb3e47175bb0a3442bd3e15014e6402cbfe7cbd5440fd377d91540a42e7ebe40dc47070a2bdd2fc1ab61bbe4973486c6d44
-  data.tar.gz: ceb2fbb93d0a65c6325d7eb1964bd06b5a69905a57cddc953d724218400fbc8933fcfa54e12d50ff5b4bebfc1e7dfe948d8016685add15c359a5f6a419d7fafa
+  metadata.gz: b9f41907d8ac7577068d992acb6c3cbffcc03a9167ac98c3ff5e1d10da677aebc5f7f3a73a70c3437775ade84eee2b2b519621dba8bce0ededc3ad648feab533
+  data.tar.gz: 8f973fce895ea84f1f6547a53a24c57ee3b9893d481ab9fdb6d9751ba43ee31b50f4f1b18204bc01bbd82bc8bdedcfa1831354ecf80a1f11068b125caf06e03e

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+### 1.7.2 / 2019-12-12
+
+#### Bug Fixes
+
+* Update some positional params to keyword args in the lower-level API to match the backend service.
+
 ### 1.7.1 / 2019-11-06
 
 #### Bug Fixes

data/lib/google/cloud/datastore/service.rb

@@ -107,12 +107,11 @@ module Google
           end
 
           execute do
-            service.run_query project,
-                              partition_id,
-                              read_options: read_options,
-                              query: query,
-                              gql_query: gql_query,
-                              options: default_options
+            service.run_query project, partition_id: partition_id,
+                                       read_options: read_options,
+                                       query: query,
+                                       gql_query: gql_query,
+                                       options: default_options
           end
         end
 
@@ -144,8 +143,10 @@ module Google
         def commit mutations, transaction: nil
           mode =  transaction.nil? ? :NON_TRANSACTIONAL : :TRANSACTIONAL
           execute do
-            service.commit project, mode, mutations, transaction: transaction,
-                                                     options: default_options
+            service.commit project, mode: mode,
+                                    mutations: mutations,
+                                    transaction: transaction,
+                                    options: default_options
           end
         end
 

data/lib/google/cloud/datastore/v1/datastore_client.rb

@@ -236,9 +236,9 @@ module Google
           # Looks up entities by key.
           #
           # @param project_id [String]
-          #   The ID of the project against which to make the request.
+          #   Required. The ID of the project against which to make the request.
           # @param keys [Array<Google::Datastore::V1::Key | Hash>]
-          #   Keys of entities to look up.
+          #   Required. Keys of entities to look up.
           #   A hash of the same form as `Google::Datastore::V1::Key`
           #   can also be provided.
           # @param read_options [Google::Datastore::V1::ReadOptions | Hash]
@@ -283,7 +283,7 @@ module Google
           # Queries for entities.
           #
           # @param project_id [String]
-          #   The ID of the project against which to make the request.
+          #   Required. The ID of the project against which to make the request.
           # @param partition_id [Google::Datastore::V1::PartitionId | Hash]
           #   Entities are partitioned into subsets, identified by a partition ID.
           #   Queries are scoped to a single partition.
@@ -318,14 +318,11 @@ module Google
           #
           #   # TODO: Initialize `project_id`:
           #   project_id = ''
-          #
-          #   # TODO: Initialize `partition_id`:
-          #   partition_id = {}
-          #   response = datastore_client.run_query(project_id, partition_id)
+          #   response = datastore_client.run_query(project_id)
 
           def run_query \
               project_id,
-              partition_id,
+              partition_id: nil,
               read_options: nil,
               query: nil,
               gql_query: nil,
@@ -345,7 +342,7 @@ module Google
           # Begins a new transaction.
           #
           # @param project_id [String]
-          #   The ID of the project against which to make the request.
+          #   Required. The ID of the project against which to make the request.
           # @param transaction_options [Google::Datastore::V1::TransactionOptions | Hash]
           #   Options for a new transaction.
           #   A hash of the same form as `Google::Datastore::V1::TransactionOptions`
@@ -384,9 +381,13 @@ module Google
           # entities.
           #
           # @param project_id [String]
-          #   The ID of the project against which to make the request.
+          #   Required. The ID of the project against which to make the request.
           # @param mode [Google::Datastore::V1::CommitRequest::Mode]
           #   The type of commit to perform. Defaults to `TRANSACTIONAL`.
+          # @param transaction [String]
+          #   The identifier of the transaction associated with the commit. A
+          #   transaction identifier is returned by a call to
+          #   {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
           # @param mutations [Array<Google::Datastore::V1::Mutation | Hash>]
           #   The mutations to perform.
           #
@@ -403,10 +404,6 @@ module Google
           #   entity.
           #   A hash of the same form as `Google::Datastore::V1::Mutation`
           #   can also be provided.
-          # @param transaction [String]
-          #   The identifier of the transaction associated with the commit. A
-          #   transaction identifier is returned by a call to
-          #   {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
           # @param options [Google::Gax::CallOptions]
           #   Overrides the default settings for this call, e.g, timeout,
           #   retries, etc.
@@ -422,26 +419,20 @@ module Google
           #
           #   # TODO: Initialize `project_id`:
           #   project_id = ''
-          #
-          #   # TODO: Initialize `mode`:
-          #   mode = :MODE_UNSPECIFIED
-          #
-          #   # TODO: Initialize `mutations`:
-          #   mutations = []
-          #   response = datastore_client.commit(project_id, mode, mutations)
+          #   response = datastore_client.commit(project_id)
 
           def commit \
               project_id,
-              mode,
-              mutations,
+              mode: nil,
               transaction: nil,
+              mutations: nil,
               options: nil,
               &block
             req = {
               project_id: project_id,
               mode: mode,
-              mutations: mutations,
-              transaction: transaction
+              transaction: transaction,
+              mutations: mutations
             }.delete_if { |_, v| v.nil? }
             req = Google::Gax::to_proto(req, Google::Datastore::V1::CommitRequest)
             @commit.call(req, options, &block)
@@ -450,9 +441,9 @@ module Google
           # Rolls back a transaction.
           #
           # @param project_id [String]
-          #   The ID of the project against which to make the request.
+          #   Required. The ID of the project against which to make the request.
           # @param transaction [String]
-          #   The transaction identifier, returned by a call to
+          #   Required. The transaction identifier, returned by a call to
           #   {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
           # @param options [Google::Gax::CallOptions]
           #   Overrides the default settings for this call, e.g, timeout,
@@ -491,9 +482,9 @@ module Google
           # before it is inserted.
           #
           # @param project_id [String]
-          #   The ID of the project against which to make the request.
+          #   Required. The ID of the project against which to make the request.
           # @param keys [Array<Google::Datastore::V1::Key | Hash>]
-          #   A list of keys with incomplete key paths for which to allocate IDs.
+          #   Required. A list of keys with incomplete key paths for which to allocate IDs.
           #   No key may be reserved/read-only.
           #   A hash of the same form as `Google::Datastore::V1::Key`
           #   can also be provided.
@@ -534,9 +525,9 @@ module Google
           # Datastore.
           #
           # @param project_id [String]
-          #   The ID of the project against which to make the request.
+          #   Required. The ID of the project against which to make the request.
           # @param keys [Array<Google::Datastore::V1::Key | Hash>]
-          #   A list of keys with complete key paths whose numeric IDs should not be
+          #   Required. A list of keys with complete key paths whose numeric IDs should not be
           #   auto-allocated.
           #   A hash of the same form as `Google::Datastore::V1::Key`
           #   can also be provided.

data/lib/google/cloud/datastore/v1/datastore_client_config.json

@@ -13,21 +13,21 @@
           "initial_retry_delay_millis": 100,
           "retry_delay_multiplier": 1.3,
           "max_retry_delay_millis": 60000,
-          "initial_rpc_timeout_millis": 60000,
+          "initial_rpc_timeout_millis": 20000,
           "rpc_timeout_multiplier": 1.0,
-          "max_rpc_timeout_millis": 60000,
+          "max_rpc_timeout_millis": 20000,
           "total_timeout_millis": 600000
         }
       },
       "methods": {
         "Lookup": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "RunQuery": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "BeginTransaction": {
@@ -52,7 +52,7 @@
         },
         "ReserveIds": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         }
       }

data/lib/google/cloud/datastore/v1/doc/google/datastore/v1/datastore.rb

@@ -19,13 +19,13 @@ module Google
       # The request for {Google::Datastore::V1::Datastore::Lookup Datastore::Lookup}.
       # @!attribute [rw] project_id
       #   @return [String]
-      #     The ID of the project against which to make the request.
+      #     Required. The ID of the project against which to make the request.
       # @!attribute [rw] read_options
       #   @return [Google::Datastore::V1::ReadOptions]
       #     The options for this lookup request.
       # @!attribute [rw] keys
       #   @return [Array<Google::Datastore::V1::Key>]
-      #     Keys of entities to look up.
+      #     Required. Keys of entities to look up.
       class LookupRequest; end
 
       # The response for {Google::Datastore::V1::Datastore::Lookup Datastore::Lookup}.
@@ -49,7 +49,7 @@ module Google
       # The request for {Google::Datastore::V1::Datastore::RunQuery Datastore::RunQuery}.
       # @!attribute [rw] project_id
       #   @return [String]
-      #     The ID of the project against which to make the request.
+      #     Required. The ID of the project against which to make the request.
       # @!attribute [rw] partition_id
       #   @return [Google::Datastore::V1::PartitionId]
       #     Entities are partitioned into subsets, identified by a partition ID.
@@ -67,8 +67,7 @@ module Google
       #     The GQL query to run.
       class RunQueryRequest; end
 
-      # The response for
-      # {Google::Datastore::V1::Datastore::RunQuery Datastore::RunQuery}.
+      # The response for {Google::Datastore::V1::Datastore::RunQuery Datastore::RunQuery}.
       # @!attribute [rw] batch
       #   @return [Google::Datastore::V1::QueryResultBatch]
       #     A batch of query results (always present).
@@ -77,18 +76,16 @@ module Google
       #     The parsed form of the `GqlQuery` from the request, if it was set.
       class RunQueryResponse; end
 
-      # The request for
-      # {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
+      # The request for {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
       # @!attribute [rw] project_id
       #   @return [String]
-      #     The ID of the project against which to make the request.
+      #     Required. The ID of the project against which to make the request.
       # @!attribute [rw] transaction_options
       #   @return [Google::Datastore::V1::TransactionOptions]
       #     Options for a new transaction.
       class BeginTransactionRequest; end
 
-      # The response for
-      # {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
+      # The response for {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
       # @!attribute [rw] transaction
       #   @return [String]
       #     The transaction identifier (always present).
@@ -97,22 +94,21 @@ module Google
       # The request for {Google::Datastore::V1::Datastore::Rollback Datastore::Rollback}.
       # @!attribute [rw] project_id
       #   @return [String]
-      #     The ID of the project against which to make the request.
+      #     Required. The ID of the project against which to make the request.
       # @!attribute [rw] transaction
       #   @return [String]
-      #     The transaction identifier, returned by a call to
+      #     Required. The transaction identifier, returned by a call to
       #     {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}.
       class RollbackRequest; end
 
-      # The response for
-      # {Google::Datastore::V1::Datastore::Rollback Datastore::Rollback}. (an empty
-      # message).
+      # The response for {Google::Datastore::V1::Datastore::Rollback Datastore::Rollback}.
+      # (an empty message).
       class RollbackResponse; end
 
       # The request for {Google::Datastore::V1::Datastore::Commit Datastore::Commit}.
       # @!attribute [rw] project_id
       #   @return [String]
-      #     The ID of the project against which to make the request.
+      #     Required. The ID of the project against which to make the request.
       # @!attribute [rw] mode
       #   @return [Google::Datastore::V1::CommitRequest::Mode]
       #     The type of commit to perform. Defaults to `TRANSACTIONAL`.
@@ -163,41 +159,37 @@ module Google
       #     updated.
       class CommitResponse; end
 
-      # The request for
-      # {Google::Datastore::V1::Datastore::AllocateIds Datastore::AllocateIds}.
+      # The request for {Google::Datastore::V1::Datastore::AllocateIds Datastore::AllocateIds}.
       # @!attribute [rw] project_id
       #   @return [String]
-      #     The ID of the project against which to make the request.
+      #     Required. The ID of the project against which to make the request.
       # @!attribute [rw] keys
       #   @return [Array<Google::Datastore::V1::Key>]
-      #     A list of keys with incomplete key paths for which to allocate IDs.
+      #     Required. A list of keys with incomplete key paths for which to allocate IDs.
       #     No key may be reserved/read-only.
       class AllocateIdsRequest; end
 
-      # The response for
-      # {Google::Datastore::V1::Datastore::AllocateIds Datastore::AllocateIds}.
+      # The response for {Google::Datastore::V1::Datastore::AllocateIds Datastore::AllocateIds}.
       # @!attribute [rw] keys
       #   @return [Array<Google::Datastore::V1::Key>]
       #     The keys specified in the request (in the same order), each with
       #     its key path completed with a newly allocated ID.
       class AllocateIdsResponse; end
 
-      # The request for
-      # {Google::Datastore::V1::Datastore::ReserveIds Datastore::ReserveIds}.
+      # The request for {Google::Datastore::V1::Datastore::ReserveIds Datastore::ReserveIds}.
       # @!attribute [rw] project_id
       #   @return [String]
-      #     The ID of the project against which to make the request.
+      #     Required. The ID of the project against which to make the request.
       # @!attribute [rw] database_id
       #   @return [String]
       #     If not empty, the ID of the database against which to make the request.
       # @!attribute [rw] keys
       #   @return [Array<Google::Datastore::V1::Key>]
-      #     A list of keys with complete key paths whose numeric IDs should not be
+      #     Required. A list of keys with complete key paths whose numeric IDs should not be
       #     auto-allocated.
       class ReserveIdsRequest; end
 
-      # The response for
-      # {Google::Datastore::V1::Datastore::ReserveIds Datastore::ReserveIds}.
+      # The response for {Google::Datastore::V1::Datastore::ReserveIds Datastore::ReserveIds}.
       class ReserveIdsResponse; end
 
       # A mutation to apply to an entity.
@@ -268,10 +260,8 @@ module Google
       # Options for beginning a new transaction.
       #
       # Transactions can be created explicitly with calls to
-      # {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction}
-      # or implicitly by setting
-      # {Google::Datastore::V1::ReadOptions#new_transaction ReadOptions#new_transaction}
-      # in read requests.
+      # {Google::Datastore::V1::Datastore::BeginTransaction Datastore::BeginTransaction} or implicitly by setting
+      # {Google::Datastore::V1::ReadOptions#new_transaction ReadOptions#new_transaction} in read requests.
       # @!attribute [rw] read_write
       #   @return [Google::Datastore::V1::TransactionOptions::ReadWrite]
       #     The transaction should allow both reads and writes.

data/lib/google/cloud/datastore/v1/doc/google/datastore/v1/entity.rb

@@ -100,8 +100,8 @@ module Google
       # @!attribute [rw] values
       #   @return [Array<Google::Datastore::V1::Value>]
       #     Values in the array.
-      #     The order of this array may not be preserved if it contains a mix of
-      #     indexed and unindexed values.
+      #     The order of values in an array is preserved as long as all values have
+      #     identical settings for 'exclude_from_indexes'.
       class ArrayValue; end
 
       # A message that can hold any of the supported value types and associated
@@ -129,8 +129,8 @@ module Google
       # @!attribute [rw] string_value
       #   @return [String]
       #     A UTF-8 encoded string value.
-      #     When `exclude_from_indexes` is false (it is indexed) , may have at most
-      #     1500 bytes. Otherwise, may be set to at least 1,000,000 bytes.
+      #     When `exclude_from_indexes` is false (it is indexed) , may have at most 1500 bytes.
+      #     Otherwise, may be set to at least 1,000,000 bytes.
       # @!attribute [rw] blob_value
       #   @return [String]
       #     A blob value.

data/lib/google/cloud/datastore/v1/doc/google/datastore/v1/query.rb

@@ -25,12 +25,12 @@ module Google
       #     The version of the entity, a strictly positive number that monotonically
       #     increases with changes to the entity.
       #
-      #     This field is set for
-      #     {Google::Datastore::V1::EntityResult::ResultType::FULL `FULL`} entity results.
+      #     This field is set for {Google::Datastore::V1::EntityResult::ResultType::FULL `FULL`} entity
+      #     results.
       #
-      #     For {Google::Datastore::V1::LookupResponse#missing missing} entities in
-      #     `LookupResponse`, this is the version of the snapshot that was used to look
-      #     up the entity, and it is always set except for eventually consistent reads.
+      #     For {Google::Datastore::V1::LookupResponse#missing missing} entities in `LookupResponse`, this
+      #     is the version of the snapshot that was used to look up the entity, and it
+      #     is always set except for eventually consistent reads.
       # @!attribute [rw] cursor
       #   @return [String]
       #     A cursor that points to the position after the result entity.

data/lib/google/cloud/datastore/version.rb

@@ -16,7 +16,7 @@
 module Google
   module Cloud
     module Datastore
-      VERSION = "1.7.1".freeze
+      VERSION = "1.7.2".freeze
     end
   end
 end

data/lib/google/datastore/v1/datastore_pb.rb

@@ -5,6 +5,8 @@
 require 'google/protobuf'
 
 require 'google/api/annotations_pb'
+require 'google/api/client_pb'
+require 'google/api/field_behavior_pb'
 require 'google/datastore/v1/entity_pb'
 require 'google/datastore/v1/query_pb'
 Google::Protobuf::DescriptorPool.generated_pool.build do

data/lib/google/datastore/v1/datastore_services_pb.rb

@@ -1,7 +1,7 @@
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # Source: google/datastore/v1/datastore.proto for package 'google.datastore.v1'
 # Original file comments:
-# Copyright 2018 Google Inc.
+# Copyright 2019 Google LLC.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-cloud-datastore
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.7.2
 platform: ruby
 authors:
 - Mike Moore
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-07 00:00:00.000000000 Z
+date: 2019-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-cloud-core