google-cloud-bigtable 0.6.2 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 204a51cfb08c7ea7a45b1700011de87612270cc16024521f93abde0de4d3315d
-  data.tar.gz: ee65018c352bd6aeab7958e2a7c35833ed4285c839106c8d638e6066db71b00c
+  metadata.gz: 833d4009bf7801aeea418cc20c01957beb3aa7717eae7660aef91c4afc1b09c5
+  data.tar.gz: 95a806973acd438380803a215e1fdfb3d06846b66363ee541419ebe7f54cb507
 SHA512:
-  metadata.gz: da6d13d7f2bbcd4952f4e98859c765da3ee47ab236ba4656148dc928e55de2ccb2f7d8231d15f23dbe84e9118e2712d48ce95c6e07a6b75f3344dcb9177d560f
-  data.tar.gz: af744f8795db5b57843bd101bbaa9d541c71d272339b97d56600606d4810bc0aaef04e28530a26ee2f5a933cc9d7e5dfa3fb0b214d71d1453f466a9d64572564
+  metadata.gz: 7f8ba6fe01b55f0eae24961447f829ca02bb8f709ee11b75d8ec985314f673d714ebc4f71528a74da3c34911777da9cd95895c667cc74334b55fb8b786689db6
+  data.tar.gz: 131d9b4c4f58215ce1808eb721b4f8a01086df6a6b207503629d86a2200ceb8b871894b5d93d0246a69e72b87d9c2a665baf4ee02e5d278f263daef72a473c4d

data/CHANGELOG.md

@@ -1,5 +1,41 @@
 # Release History
 
+### 0.7.0 / 2019-10-22
+
+#### Features
+
+* Update Table#column_families to yield ColumnFamilyMap for updates.
+  * ColumnFamilyMap now manages ColumnFamily lifecycle.
+* Add MutationOperations::Response.
+* Add Bigtable::Status.
+* Add Bigtable::RoutingPolicy.
+* Update Ruby dependency to minimum of 2.4.
+
+#### BREAKING CHANGES
+
+* Remove ColumnFamily lifecycle methods (create, save, delete, and related class methods).
+  * Replaced by Table#column_families yield block.
+* Move Google::Cloud::Bigtable::Table::ColumnFamilyMap to Google::Cloud::Bigtable::ColumnFamilyMap.
+  * This should only affect introspection, since the constructor was previously undocumented.
+* Remove Project#modify_column_families.
+  * Replaced by Table#column_families yield block.
+* Remove Table#column_family.
+  * Replaced by ColumnFamilyMap lifecycle methods.
+* Remove Table#modify_column_families.
+  * Replaced by Table#column_families yield block.
+* Update GcRule#union and #intersection to not return lower-level API types.
+* Update all return types and parameters associated with AppProfile routing policy to not use lower-level API types.
+  * The new types have exactly the same API as the old types, so this change should only affect type introspection.
+* Update return types of Chain and Interleave row filters to not use lower-level API types.
+* Change return type of MutationOperations#mutate_rows from lower-level API types to wrapper types.
+* Remove private MutationEntry#mutations from documentation.
+* Update GcRule#max_age to microsecond precision.
+
+#### Documentation
+
+* Update sample code.
+* Update documentation.
+
 ### 0.6.2 / 2019-10-01
 
 #### Documentation

data/CONTRIBUTING.md

@@ -24,7 +24,7 @@ be able to accept your pull requests.
 In order to use the google-cloud-bigtable console and run the project's tests,
 there is a small amount of setup:
 
-1. Install Ruby. google-cloud-bigtable requires Ruby 2.3+. You may choose to
+1. Install Ruby. google-cloud-bigtable requires Ruby 2.4+. You may choose to
    manage your Ruby and gem installations with [RVM](https://rvm.io/),
    [rbenv](https://github.com/rbenv/rbenv), or
    [chruby](https://github.com/postmodern/chruby).

data/lib/google-cloud-bigtable.rb

@@ -26,6 +26,7 @@ require "google/cloud/config"
 
 module Google
   module Cloud
+    ##
     # Creates a new object for connecting to the Cloud Bigtable service.
     #
     # For more information on connecting to Google Cloud Platform, see the
@@ -39,7 +40,8 @@ module Google
     #   updater_proc is supplied.
     # @param timeout [Integer]
     #   The default timeout, in seconds, for calls made through this client.
-    # @param credentials [Google::Auth::Credentials, String, Hash, GRPC::Core::Channel, GRPC::Core::ChannelCredentials, Proc]
+    # @param credentials [Google::Auth::Credentials, String, Hash, GRPC::Core::Channel,
+    #   GRPC::Core::ChannelCredentials, Proc]
     #   Provides the means for authenticating requests made by the client. This parameter can
     #   be one of the following types.
     #   `Google::Auth::Credentials` uses the properties of its represented keyfile for
@@ -61,23 +63,23 @@ module Google
     # @return [Google::Cloud::Bigtable::Project]
     #
     # @example
-    #   require "google/cloud"
+    #   require "google/cloud/bigtable"
     #
     #   gcloud  = Google::Cloud.new
     #
     #   bigtable = gcloud.bigtable
     #
-
     def bigtable scope: nil, timeout: nil, credentials: nil, client_config: nil
       Google::Cloud.bigtable(
-        project_id: @project,
-        credentials: (credentials || @keyfile),
-        scope: scope,
-        timeout: (timeout || @timeout),
+        project_id:    @project,
+        credentials:   (credentials || @keyfile),
+        scope:         scope,
+        timeout:       (timeout || @timeout),
         client_config: client_config
       )
     end
 
+    ##
     # Creates a Cloud Bigtable client instance for data, table admin and instance admin
     # operations.
     #
@@ -85,7 +87,8 @@ module Google
     #   Project identifier for the Bigtable service you
     #   are connecting to. If not present, the default project for the
     #   credentials is used.
-    # @param credentials [Google::Auth::Credentials, String, Hash, GRPC::Core::Channel, GRPC::Core::ChannelCredentials, Proc]
+    # @param credentials [Google::Auth::Credentials, String, Hash, GRPC::Core::Channel,
+    #   GRPC::Core::ChannelCredentials, Proc]
     #   The means for authenticating requests made by the client. This parameter can
     #   be one of the following types.
     #   `Google::Auth::Credentials` uses the properties of its represented keyfile for
@@ -116,22 +119,17 @@ module Google
     # @return [Google::Cloud::Bigtable::Project]
     #
     # @example
-    #   require "google/cloud"
+    #   require "google/cloud/bigtable"
     #
     #   bigtable = Google::Cloud.bigtable
-
-    def self.bigtable \
-        project_id: nil,
-        credentials: nil,
-        scope: nil,
-        timeout: nil,
-        client_config: nil
+    #
+    def self.bigtable project_id: nil, credentials: nil, scope: nil, timeout: nil, client_config: nil
       require "google/cloud/bigtable"
       Google::Cloud::Bigtable.new(
-        project_id: project_id,
-        credentials: credentials,
-        scope: scope,
-        timeout: timeout,
+        project_id:    project_id,
+        credentials:   credentials,
+        scope:         scope,
+        timeout:       timeout,
         client_config: client_config
       )
     end
@@ -156,7 +154,7 @@ Google::Cloud.configure.add_config! :bigtable do |config|
   config.add_field! :project_id, default_project, match: String, allow_nil: true
   config.add_alias! :project, :project_id
   config.add_field! :credentials, default_creds,
-                    match: [
+                    match:     [
                       String,
                       Hash,
                       Google::Auth::Credentials,

data/lib/google/cloud/bigtable.rb

@@ -21,18 +21,21 @@ require "google/cloud/bigtable/project"
 
 module Google
   module Cloud
+    ##
     # Cloud Bigtable
     #
     # See {file:OVERVIEW.md Bigtable Overview}.
     #
     module Bigtable
+      ##
       # Service for managing Cloud Bigtable instances and tables and for reading from and
       # writing to Bigtable tables.
       #
       # @param project_id [String]
       #   Project identifier for the Bigtable service you are connecting to.
       #   If not present, the default project for the credentials is used.
-      # @param credentials [Google::Auth::Credentials, String, Hash, GRPC::Core::Channel, GRPC::Core::ChannelCredentials, Proc]
+      # @param credentials [Google::Auth::Credentials, String, Hash, GRPC::Core::Channel,
+      #   GRPC::Core::ChannelCredentials, Proc]
       #   Provides the means for authenticating requests made by the client. This parameter can
       #   be one of the following types:
       #   `Google::Auth::Credentials` uses the properties of its represented keyfile for
@@ -70,14 +73,8 @@ module Google
       #
       #   client = Google::Cloud::Bigtable.new
       #
-      def self.new \
-          project_id: nil,
-          credentials: nil,
-          emulator_host: nil,
-          scope: nil,
-          client_config: nil,
-          endpoint: nil,
-          timeout: nil
+      def self.new project_id: nil, credentials: nil, emulator_host: nil, scope: nil, client_config: nil, endpoint: nil,
+                   timeout: nil
         project_id    ||= default_project_id
         scope         ||= configure.scope
         timeout       ||= configure.timeout
@@ -98,9 +95,10 @@ module Google
           project_id, credentials,
           host: endpoint, timeout: timeout, client_config: client_config
         )
-        Bigtable::Project.new(service)
+        Bigtable::Project.new service
       end
 
+      ##
       # Configure the Google Cloud Bigtable library.
       #
       # The following Bigtable configuration parameters are supported:
@@ -151,10 +149,8 @@ module Google
       #
       def self.resolve_credentials given_credentials, scope
         credentials = given_credentials || default_credentials(scope: scope)
-        unless credentials.is_a? Google::Auth::Credentials
-          credentials = Bigtable::Credentials.new credentials, scope: scope
-        end
-        credentials
+        return credentials if credentials.is_a? Google::Auth::Credentials
+        Bigtable::Credentials.new credentials, scope: scope
       end
 
       # @private
@@ -162,9 +158,7 @@ module Google
       #
       def self.resolve_project_id given_project_id, credentials
         project_id = given_project_id || default_project_id
-        if credentials.respond_to? :project_id
-          project_id ||= credentials.project_id
-        end
+        project_id ||= credentials.project_id if credentials.respond_to? :project_id
         project_id.to_s # Always cast to a string
       end
 

data/lib/google/cloud/bigtable/app_profile.rb

@@ -17,10 +17,12 @@
 
 require "google/cloud/bigtable/app_profile/list"
 require "google/cloud/bigtable/app_profile/job"
+require "google/cloud/bigtable/routing_policy"
 
 module Google
   module Cloud
     module Bigtable
+      ##
       # # AppProfile
       #
       # A configuration object describing how Cloud Bigtable should treat traffic
@@ -33,7 +35,7 @@ module Google
       #
       #   instance = bigtable.instance("my-instance")
       #
-      #   app_profile = bigtable.app_profile("my-instance", "my-app-profile")
+      #   app_profile = instance.app_profile("my-app-profile")
       #
       #   # Update
       #   app_profile.description = "User data instance app profile"
@@ -58,86 +60,113 @@ module Google
           @changed_fields = {}
         end
 
+        ##
         # The unique identifier for the project.
         #
         # @return [String]
+        #
         def project_id
           @grpc.name.split("/")[1]
         end
 
+        ##
         # The unique identifier for the instance.
         #
         # @return [String]
+        #
         def instance_id
           @grpc.name.split("/")[3]
         end
 
+        ##
         # The unique identifier for the app profile.
         #
         # @return [String]
+        #
         def name
           @grpc.name.split("/")[5]
         end
 
+        ##
         # The full path for the instance resource. Values are of the form
         # `projects/<project_id>/instances/<instance_id>`.
         #
         # @return [String]
+        #
         def path
           @grpc.name
         end
 
+        ##
         # Etag for optimistic concurrency control.
         #
         # @return [String]
+        #
         def etag
           @grpc.etag
         end
 
+        ##
         # Description of the AppProfile.
         #
         # @return [String]
+        #
         def description
           @grpc.description
         end
 
+        ##
         # Set description of the AppProfile.
         #
         # @param text [String] Description text
+        #
         def description= text
           @grpc.description = text
           @changed_fields["description"] = "description"
         end
 
-        # Get value of multi-cluster routing policy.
+        ##
+        # Gets the multi-cluster routing policy, if present.
+        #
+        # @return [Google::Cloud::Bigtable::MultiClusterRoutingUseAny, nil]
         #
-        # @return [Google::Bigtable::Admin::V2::AppProfile::MultiClusterRoutingUseAny]
         def multi_cluster_routing
-          @grpc.multi_cluster_routing_use_any
+          return nil unless @grpc.multi_cluster_routing_use_any
+
+          Google::Cloud::Bigtable::MultiClusterRoutingUseAny.new
         end
 
-        # Get value of single cluster routing policy.
+        ##
+        # Gets the single cluster routing policy, if present.
+        #
+        # @return [Google::Cloud::Bigtable::SingleClusterRouting, nil]
         #
-        # @return [Google::Bigtable::Admin::V2::AppProfile::SingleClusterRouting]
         def single_cluster_routing
-          @grpc.single_cluster_routing
+          return nil unless @grpc.single_cluster_routing
+
+          Google::Cloud::Bigtable::SingleClusterRouting.new(
+            @grpc.single_cluster_routing.cluster_id,
+            @grpc.single_cluster_routing.allow_transactional_writes
+          )
         end
 
-        # Set routing policy.
+        ##
+        # Sets the routing policy for the app profile.
         #
-        # @param policy [Google::Bigtable::Admin::V2::AppProfile::SingleClusterRouting | Google::Bigtable::Admin::V2::AppProfile::MultiClusterRoutingUseAny]
-        #   The routing policy for all read/write requests that use this app profile.
-        #   A value must be explicitly set.
+        # @param policy [Google::Cloud::Bigtable::RoutingPolicy]
+        #   The routing policy for all read/write requests that use this app profile. A value must be explicitly set.
         #
         #   Routing Policies:
-        #   * `multi_cluster_routing` - Read/write requests may be routed to any
-        #     cluster in the instance and will fail over to another cluster in the event
-        #     of transient errors or delays. Choosing this option sacrifices
-        #     read-your-writes consistency to improve availability.
-        #   * `single_cluster_routing` - Unconditionally routes all read/write requests
-        #     to a specific cluster. This option preserves read-your-writes consistency
-        #     but does not improve availability.
-        #     The value contains `cluster_id` and optional field `allow_transactional_writes`.
+        #   * {Google::Cloud::Bigtable::MultiClusterRoutingUseAny} - Read/write
+        #     requests may be routed to any cluster in the instance and will
+        #     fail over to another cluster in the event of transient errors or
+        #     delays. Choosing this option sacrifices read-your-writes
+        #     consistency to improve availability.
+        #   * {Google::Cloud::Bigtable::SingleClusterRouting} - Unconditionally
+        #     routes all read/write requests to a specific cluster. This option
+        #     preserves read-your-writes consistency but does not improve
+        #     availability. Value contains `cluster_id` and optional field
+        #     `allow_transactional_writes`.
         #
         # @example Set multi cluster routing policy
         #   require "google/cloud/bigtable"
@@ -157,30 +186,61 @@ module Google
         #   app_profile = instance.app_profile("my-app-profile")
         #
         #   routing_policy = Google::Cloud::Bigtable::AppProfile.single_cluster_routing(
-        #     "my-instance-cluster-1"
+        #     "my-instance-cluster-1",
         #     allow_transactional_writes: true
         #   )
         #   app_profile.routing_policy = routing_policy
         #
         def routing_policy= policy
-          if policy.is_a?(Google::Bigtable::Admin::V2::AppProfile:: \
-              SingleClusterRouting)
-            @grpc.single_cluster_routing = policy
+          routing_policy_grpc = policy.to_grpc
+          if routing_policy_grpc.is_a? Google::Bigtable::Admin::V2::AppProfile::SingleClusterRouting
+            @grpc.single_cluster_routing = routing_policy_grpc
             @changed_fields["routing_policy"] = "single_cluster_routing"
           else
-            @grpc.multi_cluster_routing_use_any = policy
+            @grpc.multi_cluster_routing_use_any = routing_policy_grpc
             @changed_fields["routing_policy"] = "multi_cluster_routing_use_any"
           end
         end
 
-        # Get routing policy.
+        ##
+        # Gets the routing policy for all read/write requests that use the app
+        # profile.
+        #
+        # Routing Policies:
+        # * {Google::Cloud::Bigtable::MultiClusterRoutingUseAny} - Read/write
+        #   requests may be routed to any cluster in the instance and will
+        #   fail over to another cluster in the event of transient errors or
+        #   delays. Choosing this option sacrifices read-your-writes
+        #   consistency to improve availability.
+        # * {Google::Cloud::Bigtable::SingleClusterRouting} - Unconditionally
+        #   routes all read/write requests to a specific cluster. This option
+        #   preserves read-your-writes consistency but does not improve
+        #   availability. Value contains `cluster_id` and optional field
+        #   `allow_transactional_writes`.
+        #
+        # @return [Google::Cloud::Bigtable::RoutingPolicy]
         #
-        # @return [Google::Bigtable::Admin::V2::AppProfile::SingleClusterRouting, Google::Bigtable::Admin::V2::AppProfile::MultiClusterRoutingUseAny]
+        # @example
+        #   require "google/cloud/bigtable"
+        #
+        #   bigtable = Google::Cloud::Bigtable.new
+        #
+        #   instance = bigtable.instance("my-instance")
+        #
+        #   routing_policy = Google::Cloud::Bigtable::AppProfile.multi_cluster_routing
+        #
+        #   app_profile = instance.create_app_profile(
+        #     "my-app-profile",
+        #     routing_policy,
+        #     description: "App profile for user data instance"
+        #   )
+        #   puts app_profile.routing_policy
         #
         def routing_policy
-          @grpc.single_cluster_routing || @grpc.multi_cluster_routing_use_any
+          single_cluster_routing || multi_cluster_routing
         end
 
+        ##
         # Delete app profile.
         #
         # @param ignore_warnings [Boolean]
@@ -194,7 +254,8 @@ module Google
         #   bigtable = Google::Cloud::Bigtable.new
         #
         #   instance = bigtable.instance("my-instance")
-        #   app_profile = bigtable.instance("my-app-profile")
+        #
+        #   app_profile = instance.app_profile("my-app-profile")
         #
         #   app_profile.delete(ignore_warnings: true) # Ignore warnings.
         #
@@ -203,14 +264,11 @@ module Google
         #
         def delete ignore_warnings: false
           ensure_service!
-          service.delete_app_profile(
-            instance_id,
-            name,
-            ignore_warnings: ignore_warnings
-          )
+          service.delete_app_profile instance_id, name, ignore_warnings: ignore_warnings
           true
         end
 
+        ##
         # Update app profile.
         #
         # @param ignore_warnings [Boolean]
@@ -223,7 +281,9 @@ module Google
         #
         #   bigtable = Google::Cloud::Bigtable.new
         #
-        #   app_profile = bigtable.app_profile("my-app-profile")
+        #   instance = bigtable.instance("my-instance")
+        #
+        #   app_profile = instance.app_profile("my-app-profile")
         #
         #   app_profile.description = "User data instance app profile"
         #   app_profile.routing_policy = \
@@ -238,17 +298,13 @@ module Google
         #     app_profile = job.app_profile
         #   end
         #
-        #   # OR - Update with ignoring warnings.
-        #   job = app_profile.save(ignore_warnings: true)
-        #   job.wait_until_done!
-        #
         # @example Update with single cluster routing
         #   require "google/cloud/bigtable"
         #
         #   bigtable = Google::Cloud::Bigtable.new
         #
         #   instance = bigtable.instance("my-instance")
-        #   app_profile = bigtable.instance("my-app-profile")
+        #   app_profile = instance.app_profile("my-app-profile")
         #
         #   app_profile.description = "User data instance app profile"
         #   routing_policy = Google::Cloud::Bigtable::AppProfile.single_cluster_routing(
@@ -261,10 +317,6 @@ module Google
         #
         #   job.done? #=> false
         #   job.reload!
-        #   job.done? #=> false
-        #
-        #   # Reload job until completion.
-        #   job.wait_until_done!
         #   job.done? #=> true
         #
         #   if job.error?
@@ -273,52 +325,62 @@ module Google
         #     app_profile = job.app_profile
         #     puts app_profile.name
         #   end
-
+        #
         def save ignore_warnings: false
           ensure_service!
-          update_mask = Google::Protobuf::FieldMask.new(
-            paths: @changed_fields.values
-          )
-          grpc = service.update_app_profile(
-            @grpc,
-            update_mask,
-            ignore_warnings: ignore_warnings
-          )
+          update_mask = Google::Protobuf::FieldMask.new paths: @changed_fields.values
+          grpc = service.update_app_profile @grpc, update_mask, ignore_warnings: ignore_warnings
           @changed_fields.clear
-          AppProfile::Job.from_grpc(grpc, service)
+          AppProfile::Job.from_grpc grpc, service
         end
         alias update save
 
+        ##
         # Reload app profile information.
         #
         # @return [Google::Cloud::Bigtable::AppProfile]
-
+        #
         def reload!
-          @grpc = service.get_app_profile(instance_id, name)
+          @grpc = service.get_app_profile instance_id, name
           self
         end
 
-        # Create instance of multi cluster routing policy.
+        ##
+        # Creates an instance of the multi cluster routing policy.
+        #
+        # Read/write requests may be routed to any cluster in the instance and
+        # will fail over to another cluster in the event of transient errors or
+        # delays. Choosing this option sacrifices read-your-writes consistency
+        # to improve availability.
         #
-        # Read/write requests may be routed to any cluster in the instance and will
-        # fail over to another cluster in the event of transient errors or delays.
-        # Choosing this option sacrifices read-your-writes consistency to improve
-        # availability.
-        # @return [Google::Bigtable::Admin::V2::AppProfile::MultiClusterRoutingUseAny]
+        # @return [Google::Cloud::Bigtable::MultiClusterRoutingUseAny]
+        #
+        # @example
+        #   require "google/cloud/bigtable"
         #
-        # @example Create instance of multi cluster routing
+        #   bigtable = Google::Cloud::Bigtable.new
         #
-        #   Google::Cloud::Bigtable::AppProfile.multi_cluster_routing
+        #   instance = bigtable.instance("my-instance")
+        #
+        #   routing_policy = Google::Cloud::Bigtable::AppProfile.multi_cluster_routing
+        #
+        #   app_profile = instance.create_app_profile(
+        #     "my-app-profile",
+        #     routing_policy,
+        #     description: "App profile for user data instance"
+        #   )
+        #   puts app_profile.routing_policy
         #
         def self.multi_cluster_routing
-          Google::Bigtable::Admin::V2::AppProfile::MultiClusterRoutingUseAny.new
+          Google::Cloud::Bigtable::MultiClusterRoutingUseAny.new
         end
 
-        # Create instance of single cluster routing.
+        ##
+        # Creates an instance of the single cluster routing policy.
         #
         # Unconditionally routes all read/write requests to a specific cluster.
-        # This option preserves read-your-writes consistency but does not improve
-        # availability.
+        # This option preserves read-your-writes consistency but does not
+        # improve availability.
         #
         # @param cluster_id [String]
         #   The cluster to which read/write requests should be routed.
@@ -327,25 +389,29 @@ module Google
         #   allowed by this app profile. It is unsafe to send these requests to
         #   the same table/row/column in multiple clusters.
         #   Default value is false.
-        # @return [Google::Bigtable::Admin::V2::AppProfile::SingleClusterRouting]
+        # @return [Google::Cloud::Bigtable::SingleClusterRouting]
         #
-        # @example Create instance of single cluster routing
+        # @example
+        #   require "google/cloud/bigtable"
         #
-        #   Google::Cloud::Bigtable::AppProfile.single_cluster_routing("my-cluster")
+        #   bigtable = Google::Cloud::Bigtable.new
         #
-        #   # With allowed transactional writes
-        #   Google::Cloud::Bigtable::AppProfile.single_cluster_routing(
-        #     "my-cluster",
+        #   instance = bigtable.instance("my-instance")
+        #
+        #   routing_policy = Google::Cloud::Bigtable::AppProfile.single_cluster_routing(
+        #     "my-instance-cluster-1",
         #     allow_transactional_writes: true
         #   )
-
-        def self.single_cluster_routing \
-            cluster_id,
-            allow_transactional_writes: false
-          Google::Bigtable::Admin::V2::AppProfile::SingleClusterRouting.new(
-            cluster_id: cluster_id,
-            allow_transactional_writes: allow_transactional_writes
-          )
+        #
+        #   app_profile = instance.create_app_profile(
+        #     "my-app-profile",
+        #     routing_policy,
+        #     description: "App profile for user data instance"
+        #   )
+        #   puts app_profile.routing_policy
+        #
+        def self.single_cluster_routing cluster_id, allow_transactional_writes: false
+          Google::Cloud::Bigtable::SingleClusterRouting.new cluster_id, allow_transactional_writes
         end
 
         # @private
@@ -356,7 +422,7 @@ module Google
         # @param service [Google::Cloud::Bigtable::Service]
         # @return [Google::Cloud::Bigtable::Table]
         def self.from_grpc grpc, service
-          new(grpc, service)
+          new grpc, service
         end
 
         protected