google-cloud-bigquery 1.26.0 → 1.29.0

data/lib/google/cloud/bigquery/job/list.rb

@@ -72,8 +72,8 @@ module Google
             return nil unless next?
             ensure_service!
             next_kwargs = @kwargs.merge token: token
-            next_gapi = @service.list_jobs next_kwargs
-            self.class.from_gapi next_gapi, @service, next_kwargs
+            next_gapi = @service.list_jobs(**next_kwargs)
+            self.class.from_gapi next_gapi, @service, **next_kwargs
           end
 
           ##
@@ -121,12 +121,12 @@ module Google
           #     puts job.state
           #   end
           #
-          def all request_limit: nil
+          def all request_limit: nil, &block
             request_limit = request_limit.to_i if request_limit
             return enum_for :all, request_limit: request_limit unless block_given?
             results = self
             loop do
-              results.each { |r| yield r }
+              results.each(&block)
               if request_limit
                 request_limit -= 1
                 break if request_limit.negative?

data/lib/google/cloud/bigquery/load_job.rb

@@ -606,6 +606,7 @@ module Google
           ##
           # @private Create an Updater object.
           def initialize gapi
+            super()
             @updates = []
             @gapi = gapi
             @schema = nil

data/lib/google/cloud/bigquery/model/list.rb

@@ -124,12 +124,12 @@ module Google
           #     puts model.model_id
           #   end
           #
-          def all request_limit: nil
+          def all request_limit: nil, &block
             request_limit = request_limit.to_i if request_limit
             return enum_for :all, request_limit: request_limit unless block_given?
             results = self
             loop do
-              results.each { |r| yield r }
+              results.each(&block)
               if request_limit
                 request_limit -= 1
                 break if request_limit.negative?

data/lib/google/cloud/bigquery/policy.rb

@@ -96,7 +96,8 @@ module Google
       #   end
       #
       class Policy
-        attr_reader :etag, :bindings
+        attr_reader :etag
+        attr_reader :bindings
 
         # @private
         def initialize etag, bindings

data/lib/google/cloud/bigquery/project.rb

@@ -56,7 +56,8 @@ module Google
         # @private The Service object.
         attr_accessor :service
 
-        attr_reader :name, :numeric_id
+        attr_reader :name
+        attr_reader :numeric_id
 
         ##
         # Creates a new Service instance.
@@ -981,8 +982,7 @@ module Google
         # @param [String] description A user-friendly description of the
         #   dataset.
         # @param [Integer] expiration The default lifetime of all tables in the
-        #   dataset, in milliseconds. The minimum value is 3600000 milliseconds
-        #   (one hour).
+        #   dataset, in milliseconds. The minimum value is `3_600_000` (one hour).
         # @param [String] location The geographic location where the dataset
         #   should reside. Possible values include `EU` and `US`. The default
         #   value is `US`.

data/lib/google/cloud/bigquery/project/list.rb

@@ -121,12 +121,12 @@ module Google
           #     puts project.name
           #   end
           #
-          def all request_limit: nil
+          def all request_limit: nil, &block
             request_limit = request_limit.to_i if request_limit
             return enum_for :all, request_limit: request_limit unless block_given?
             results = self
             loop do
-              results.each { |r| yield r }
+              results.each(&block)
               if request_limit
                 request_limit -= 1
                 break if request_limit.negative?

data/lib/google/cloud/bigquery/query_job.rb

@@ -692,8 +692,11 @@ module Google
           end
           ensure_schema!
 
-          options = { token: token, max: max, start: start }
-          data_hash = service.list_tabledata destination_table_dataset_id, destination_table_table_id, options
+          data_hash = service.list_tabledata destination_table_dataset_id,
+                                             destination_table_table_id,
+                                             token: token,
+                                             max: max,
+                                             start: start
           Data.from_gapi_json data_hash, destination_table_gapi, @gapi, service
         end
         alias query_results data
@@ -704,12 +707,11 @@ module Google
           ##
           # @private Create an Updater object.
           def initialize service, gapi
+            super()
             @service = service
             @gapi = gapi
           end
 
-          # rubocop:disable all
-
           ##
           # @private Create an Updater from an options hash.
           #
@@ -748,8 +750,6 @@ module Google
             updater
           end
 
-          # rubocop:enable all
-
           ##
           # Sets the geographic location where the job should run. Required
           # except for US and EU.
@@ -935,13 +935,13 @@ module Google
             raise ArgumentError, "types must use the same format as params" if types.class != params.class
 
             case params
-            when Array then
+            when Array
               @gapi.configuration.query.use_legacy_sql = false
               @gapi.configuration.query.parameter_mode = "POSITIONAL"
               @gapi.configuration.query.query_parameters = params.zip(types).map do |param, type|
                 Convert.to_query_param param, type
               end
-            when Hash then
+            when Hash
               @gapi.configuration.query.use_legacy_sql = false
               @gapi.configuration.query.parameter_mode = "NAMED"
               @gapi.configuration.query.query_parameters = params.map do |name, param|
@@ -1592,9 +1592,20 @@ module Google
         #   end
         #
         class Stage
-          attr_reader :compute_ratio_avg, :compute_ratio_max, :id, :name, :read_ratio_avg, :read_ratio_max,
-                      :records_read, :records_written, :status, :steps, :wait_ratio_avg, :wait_ratio_max,
-                      :write_ratio_avg, :write_ratio_max
+          attr_reader :compute_ratio_avg
+          attr_reader :compute_ratio_max
+          attr_reader :id
+          attr_reader :name
+          attr_reader :read_ratio_avg
+          attr_reader :read_ratio_max
+          attr_reader :records_read
+          attr_reader :records_written
+          attr_reader :status
+          attr_reader :steps
+          attr_reader :wait_ratio_avg
+          attr_reader :wait_ratio_max
+          attr_reader :write_ratio_avg
+          attr_reader :write_ratio_max
 
           ##
           # @private Creates a new Stage instance.
@@ -1657,7 +1668,8 @@ module Google
         #   end
         #
         class Step
-          attr_reader :kind, :substeps
+          attr_reader :kind
+          attr_reader :substeps
 
           ##
           # @private Creates a new Stage instance.

data/lib/google/cloud/bigquery/routine.rb

@@ -603,6 +603,93 @@ module Google
           update_gapi!
         end
 
+        ###
+        # The JavaScript UDF determinism level. Optional.
+        #
+        # * `DETERMINISTIC` - Deterministic indicates that two calls with the same input to a UDF yield the same output.
+        #   If all JavaScript UDFs are `DETERMINISTIC`, the query result is potentially cachable.
+        # * `NOT_DETERMINISTIC` - Not deterministic indicates that the output of the UDF is not guaranteed to yield the
+        #   same output each time for a given set of inputs. If any JavaScript UDF is `NOT_DETERMINISTIC`, the query
+        #   result is not cacheable.
+        #
+        # Even if a JavaScript UDF is deterministic, many other factors can prevent usage of cached query results.
+        # Example factors include but not limited to: DDL/DML, non-deterministic SQL function calls, update of
+        # referenced tables/views/UDFs or imported JavaScript libraries. SQL UDFs cannot have determinism specified.
+        # Their determinism is automatically determined.
+        #
+        # @return [String, nil] The routine determinism level in upper case, or `nil` if not set or the object is a
+        #   reference (see {#reference?}).
+        #
+        # @example
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #   dataset = bigquery.dataset "my_dataset"
+        #   routine = dataset.routine "my_routine"
+        #
+        #   routine.determinism_level #=> "NOT_DETERMINISTIC"
+        #
+        # @!group Attributes
+        #
+        def determinism_level
+          return nil if reference?
+          ensure_full_data!
+          @gapi.determinism_level
+        end
+
+        ##
+        # Updates the JavaScript UDF determinism level. Optional.
+        #
+        # * `DETERMINISTIC` - Deterministic indicates that two calls with the same input to a UDF yield the same output.
+        #   If all JavaScript UDFs are `DETERMINISTIC`, the query result is potentially cachable.
+        # * `NOT_DETERMINISTIC` - Not deterministic indicates that the output of the UDF is not guaranteed to yield the
+        #   same output each time for a given set of inputs. If any JavaScript UDF is `NOT_DETERMINISTIC`, the query
+        #   result is not cacheable.
+        #
+        # @param [String, nil] new_determinism_level The new routine determinism level in upper case.
+        #
+        # @example
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #   dataset = bigquery.dataset "my_dataset"
+        #   routine = dataset.routine "my_routine"
+        #
+        #   routine.determinism_level #=> "NOT_DETERMINISTIC"
+        #   routine.determinism_level = "DETERMINISTIC"
+        #
+        # @!group Attributes
+        #
+        def determinism_level= new_determinism_level
+          ensure_full_data!
+          @gapi.determinism_level = new_determinism_level
+          update_gapi!
+        end
+
+        ##
+        # Checks if the value of {#determinism_level} is `DETERMINISTIC`. The default is `false`.
+        #
+        # @return [Boolean] `true` when `DETERMINISTIC` and the object is not a reference (see {#reference?}), `false`
+        #   otherwise.
+        #
+        # @!group Attributes
+        #
+        def determinism_level_deterministic?
+          @gapi.determinism_level == "DETERMINISTIC"
+        end
+
+        ##
+        # Checks if the value of {#determinism_level} is `NOT_DETERMINISTIC`. The default is `false`.
+        #
+        # @return [Boolean] `true` when `NOT_DETERMINISTIC` and the object is not a reference (see {#reference?}),
+        #   `false` otherwise.
+        #
+        # @!group Attributes
+        #
+        def determinism_level_not_deterministic?
+          @gapi.determinism_level == "NOT_DETERMINISTIC"
+        end
+
         ##
         # Updates the routine with changes made in the given block in a single update request. The following attributes
         # may be set: {Updater#routine_type=}, {Updater#language=}, {Updater#arguments=}, {Updater#return_type=},
@@ -919,6 +1006,7 @@ module Google
           ##
           # @private Create an Updater object.
           def initialize gapi
+            super()
             @original_gapi = gapi
             @gapi = gapi.dup
           end
@@ -999,7 +1087,9 @@ module Google
           #   routine = dataset.routine "my_routine"
           #
           #   routine.return_type.type_kind #=> "INT64"
-          #   routine.return_type = "STRING"
+          #   routine.update do |r|
+          #     r.return_type = "STRING"
+          #   end
           #
           def return_type= new_return_type
             @gapi.return_type = StandardSql::DataType.gapi_from_string_or_data_type new_return_type
@@ -1019,9 +1109,11 @@ module Google
           #   dataset = bigquery.dataset "my_dataset"
           #   routine = dataset.routine "my_routine"
           #
-          #   routine.imported_libraries = [
-          #     "gs://cloud-samples-data/bigquery/udfs/max-value.js"
-          #   ]
+          #   routine.update do |r|
+          #     r.imported_libraries = [
+          #       "gs://cloud-samples-data/bigquery/udfs/max-value.js"
+          #     ]
+          #   end
           #
           def imported_libraries= new_imported_libraries
             @gapi.imported_libraries = new_imported_libraries
@@ -1069,12 +1161,43 @@ module Google
           #   routine = dataset.routine "my_routine"
           #
           #   routine.description #=> "My routine description"
-          #   routine.description = "My updated routine description"
+          #   routine.update do |r|
+          #     r.description = "My updated routine description"
+          #   end
           #
           def description= new_description
             @gapi.description = new_description
           end
 
+          ##
+          # Updates the JavaScript UDF determinism level. Optional.
+          #
+          # * `DETERMINISTIC` - Deterministic indicates that two calls with the same input to a UDF yield the same
+          #   output. If all JavaScript UDFs are `DETERMINISTIC`, the query result is potentially cachable.
+          # * `NOT_DETERMINISTIC` - Not deterministic indicates that the output of the UDF is not guaranteed to yield
+          #   the same output each time for a given set of inputs. If any JavaScript UDF is `NOT_DETERMINISTIC`, the
+          #   query result is not cacheable.
+          #
+          # @param [String, nil] new_determinism_level The new routine determinism level in upper case.
+          #
+          # @example
+          #   require "google/cloud/bigquery"
+          #
+          #   bigquery = Google::Cloud::Bigquery.new
+          #   dataset = bigquery.dataset "my_dataset"
+          #   routine = dataset.routine "my_routine"
+          #
+          #   routine.determinism_level #=> "NOT_DETERMINISTIC"
+          #   routine.update do |r|
+          #     r.determinism_level = "DETERMINISTIC"
+          #   end
+          #
+          # @!group Attributes
+          #
+          def determinism_level= new_determinism_level
+            @gapi.determinism_level = new_determinism_level
+          end
+
           def update
             raise "not implemented in #{self.class}"
           end
@@ -1088,15 +1211,11 @@ module Google
           end
           alias refresh! reload!
 
-          # rubocop:disable Style/CaseEquality
-
           # @private
           def updates?
             !(@gapi === @original_gapi)
           end
 
-          # rubocop:enable Style/CaseEquality
-
           # @private
           def to_gapi
             @gapi

data/lib/google/cloud/bigquery/routine/list.rb

@@ -124,12 +124,12 @@ module Google
           #     puts routine.routine_id
           #   end
           #
-          def all request_limit: nil
+          def all request_limit: nil, &block
             request_limit = request_limit.to_i if request_limit
             return enum_for :all, request_limit: request_limit unless block_given?
             results = self
             loop do
-              results.each { |r| yield r }
+              results.each(&block)
               if request_limit
                 request_limit -= 1
                 break if request_limit.negative?

data/lib/google/cloud/bigquery/service.rb

@@ -483,7 +483,7 @@ module Google
             table_id:   m["tbl"]
           }.delete_if { |_, v| v.nil? }
           str_table_ref_hash = default_ref.to_h.merge str_table_ref_hash
-          ref = Google::Apis::BigqueryV2::TableReference.new str_table_ref_hash
+          ref = Google::Apis::BigqueryV2::TableReference.new(**str_table_ref_hash)
           validate_table_ref ref
           ref
         end
@@ -554,9 +554,9 @@ module Google
           nil
         end
 
-        def execute backoff: nil
+        def execute backoff: nil, &block
           if backoff
-            Backoff.new(retries: retries).execute { yield }
+            Backoff.new(retries: retries).execute(&block)
           else
             yield
           end
@@ -590,22 +590,20 @@ module Google
           def execute
             current_retries = 0
             loop do
-              begin
-                return yield
-              rescue Google::Apis::Error => e
-                raise e unless retry? e.body, current_retries
-
-                @backoff.call current_retries
-                current_retries += 1
-              end
+              return yield
+            rescue Google::Apis::Error => e
+              raise e unless retry? e.body, current_retries
+
+              @backoff.call current_retries
+              current_retries += 1
             end
           end
 
           protected
 
           def retry? result, current_retries #:nodoc:
-            if current_retries < @retries
-              return true if retry_error_reason? result
+            if current_retries < @retries && retry_error_reason?(result)
+              return true
             end
             false
           end

data/lib/google/cloud/bigquery/standard_sql.rb

@@ -401,11 +401,12 @@ module Google
           # @private New Google::Apis::BigqueryV2::StandardSqlDataType from a String or StandardSql::DataType object.
           def self.gapi_from_string_or_data_type data_type
             return if data_type.nil?
-            if data_type.is_a? StandardSql::DataType
+            case data_type
+            when StandardSql::DataType
               data_type.to_gapi
-            elsif data_type.is_a? Hash
+            when Hash
               data_type
-            elsif data_type.is_a?(String) || data_type.is_a?(Symbol)
+            when String, Symbol
               Google::Apis::BigqueryV2::StandardSqlDataType.new type_kind: data_type.to_s.upcase
             else
               raise ArgumentError, "Unable to convert #{data_type} to Google::Apis::BigqueryV2::StandardSqlDataType"