google-cloud-bigquery 1.16.0 → 1.17.0

data/lib/google/cloud/bigquery/extract_job.rb

@@ -57,9 +57,7 @@ module Google
         def source
           table = @gapi.configuration.extract.source_table
           return nil unless table
-          retrieve_table table.project_id,
-                         table.dataset_id,
-                         table.table_id
+          retrieve_table table.project_id, table.dataset_id, table.table_id
         end
 
         ##
@@ -291,8 +289,7 @@ module Google
           # @!group Attributes
           #
           def format= new_format
-            @gapi.configuration.extract.update! \
-              destination_format: Convert.source_format(new_format)
+            @gapi.configuration.extract.update! destination_format: Convert.source_format(new_format)
           end
 
           ##

data/lib/google/cloud/bigquery/insert_response.rb

@@ -99,9 +99,7 @@ module Google
         #   data.
         #
         def error_rows
-          Array(@gapi.insert_errors).map do |ie|
-            @rows[ie.index]
-          end
+          Array(@gapi.insert_errors).map { |ie| @rows[ie.index] }
         end
 
         ##

data/lib/google/cloud/bigquery/job.rb

@@ -440,15 +440,11 @@ module Google
         end
 
         def status_code_for_reason reason
-          codes = { "accessDenied" => 403, "backendError" => 500,
-                    "billingNotEnabled" => 403,
-                    "billingTierLimitExceeded" => 400, "blocked" => 403,
-                    "duplicate" => 409, "internalError" => 500,
-                    "invalid" => 400, "invalidQuery" => 400, "notFound" => 404,
-                    "notImplemented" => 501, "quotaExceeded" => 403,
-                    "rateLimitExceeded" => 403, "resourceInUse" => 400,
-                    "resourcesExceeded" => 400, "responseTooLarge" => 403,
-                    "tableUnavailable" => 400 }
+          codes = { "accessDenied" => 403, "backendError" => 500, "billingNotEnabled" => 403,
+                    "billingTierLimitExceeded" => 400, "blocked" => 403, "duplicate" => 409, "internalError" => 500,
+                    "invalid" => 400, "invalidQuery" => 400, "notFound" => 404, "notImplemented" => 501,
+                    "quotaExceeded" => 403, "rateLimitExceeded" => 403, "resourceInUse" => 400,
+                    "resourcesExceeded" => 400, "responseTooLarge" => 403, "tableUnavailable" => 400 }
           codes[reason] || 0
         end
       end

data/lib/google/cloud/bigquery/job/list.rb

@@ -123,15 +123,13 @@ module Google
           #
           def all request_limit: nil
             request_limit = request_limit.to_i if request_limit
-            unless block_given?
-              return enum_for :all, request_limit: request_limit
-            end
+            return enum_for :all, request_limit: request_limit unless block_given?
             results = self
             loop do
               results.each { |r| yield r }
               if request_limit
                 request_limit -= 1
-                break if request_limit < 0
+                break if request_limit.negative?
               end
               break unless results.next?
               results = results.next
@@ -142,9 +140,7 @@ module Google
           # @private New Job::List from a Google API Client
           # Google::Apis::BigqueryV2::JobList object.
           def self.from_gapi gapi_list, service, options = {}
-            jobs = List.new(Array(gapi_list.jobs).map do |gapi_object|
-              Job.from_gapi gapi_object, service
-            end)
+            jobs = List.new(Array(gapi_list.jobs).map { |gapi_object| Job.from_gapi gapi_object, service })
             jobs.instance_variable_set :@token,    gapi_list.next_page_token
             jobs.instance_variable_set :@etag,     gapi_list.etag
             jobs.instance_variable_set :@service,  service

data/lib/google/cloud/bigquery/load_job.rb

@@ -67,9 +67,7 @@ module Google
         def destination
           table = @gapi.configuration.load.destination_table
           return nil unless table
-          retrieve_table table.project_id,
-                         table.dataset_id,
-                         table.table_id
+          retrieve_table table.project_id, table.dataset_id, table.table_id
         end
 
         ##
@@ -402,9 +400,10 @@ module Google
         # @!group Attributes
         #
         def time_partitioning_expiration
-          @gapi.configuration.load.time_partitioning.expiration_ms / 1_000 if
-              time_partitioning? &&
-              !@gapi.configuration.load.time_partitioning.expiration_ms.nil?
+          return nil unless time_partitioning?
+          return nil if @gapi.configuration.load.time_partitioning.expiration_ms.nil?
+
+          @gapi.configuration.load.time_partitioning.expiration_ms / 1_000
         end
 
         ###
@@ -934,8 +933,7 @@ module Google
           # @!group Attributes
           #
           def format= new_format
-            @gapi.configuration.load.update! \
-              source_format: Convert.source_format(new_format)
+            @gapi.configuration.load.update! source_format: Convert.source_format(new_format)
           end
 
           ##
@@ -955,8 +953,7 @@ module Google
           # @!group Attributes
           #
           def create= new_create
-            @gapi.configuration.load.update! \
-              create_disposition: Convert.create_disposition(new_create)
+            @gapi.configuration.load.update! create_disposition: Convert.create_disposition(new_create)
           end
 
           ##
@@ -977,8 +974,7 @@ module Google
           # @!group Attributes
           #
           def write= new_write
-            @gapi.configuration.load.update! \
-              write_disposition: Convert.write_disposition(new_write)
+            @gapi.configuration.load.update! write_disposition: Convert.write_disposition(new_write)
           end
 
           ##
@@ -999,8 +995,7 @@ module Google
             if new_fields.nil?
               @gapi.configuration.load.update! projection_fields: nil
             else
-              @gapi.configuration.load.update! \
-                projection_fields: Array(new_fields)
+              @gapi.configuration.load.update! projection_fields: Array(new_fields)
             end
           end
 
@@ -1199,8 +1194,7 @@ module Google
             if new_options.nil?
               @gapi.configuration.load.update! schema_update_options: nil
             else
-              @gapi.configuration.load.update! \
-                schema_update_options: Array(new_options)
+              @gapi.configuration.load.update! schema_update_options: Array(new_options)
             end
           end
 
@@ -1238,9 +1232,7 @@ module Google
           #
           # @!group Attributes
           def encryption= val
-            @gapi.configuration.load.update!(
-              destination_encryption_configuration: val.to_gapi
-            )
+            @gapi.configuration.load.update! destination_encryption_configuration: val.to_gapi
           end
 
           ##
@@ -1288,8 +1280,7 @@ module Google
           # @!group Attributes
           #
           def time_partitioning_type= type
-            @gapi.configuration.load.time_partitioning ||= \
-              Google::Apis::BigqueryV2::TimePartitioning.new
+            @gapi.configuration.load.time_partitioning ||= Google::Apis::BigqueryV2::TimePartitioning.new
             @gapi.configuration.load.time_partitioning.update! type: type
           end
 
@@ -1332,8 +1323,7 @@ module Google
           # @!group Attributes
           #
           def time_partitioning_field= field
-            @gapi.configuration.load.time_partitioning ||= \
-              Google::Apis::BigqueryV2::TimePartitioning.new
+            @gapi.configuration.load.time_partitioning ||= Google::Apis::BigqueryV2::TimePartitioning.new
             @gapi.configuration.load.time_partitioning.update! field: field
           end
 
@@ -1366,10 +1356,8 @@ module Google
           # @!group Attributes
           #
           def time_partitioning_expiration= expiration
-            @gapi.configuration.load.time_partitioning ||= \
-              Google::Apis::BigqueryV2::TimePartitioning.new
-            @gapi.configuration.load.time_partitioning.update! \
-              expiration_ms: expiration * 1000
+            @gapi.configuration.load.time_partitioning ||= Google::Apis::BigqueryV2::TimePartitioning.new
+            @gapi.configuration.load.time_partitioning.update! expiration_ms: expiration * 1000
           end
 
           ##
@@ -1384,10 +1372,8 @@ module Google
           # @!group Attributes
           #
           def time_partitioning_require_filter= val
-            @gapi.configuration.load.time_partitioning ||= \
-              Google::Apis::BigqueryV2::TimePartitioning.new
-            @gapi.configuration.load.time_partitioning.update! \
-              require_partition_filter: val
+            @gapi.configuration.load.time_partitioning ||= Google::Apis::BigqueryV2::TimePartitioning.new
+            @gapi.configuration.load.time_partitioning.update! require_partition_filter: val
           end
 
           ##
@@ -1436,8 +1422,7 @@ module Google
           # @!group Attributes
           #
           def clustering_fields= fields
-            @gapi.configuration.load.clustering ||= \
-              Google::Apis::BigqueryV2::Clustering.new
+            @gapi.configuration.load.clustering ||= Google::Apis::BigqueryV2::Clustering.new
             @gapi.configuration.load.clustering.fields = fields
           end
 

data/lib/google/cloud/bigquery/model.rb

@@ -397,10 +397,7 @@ module Google
           # We have to create a gapic object from the hash because that is what
           # EncryptionConfiguration is expecing.
           json_cmek = @gapi_json[:encryptionConfiguration].to_json
-          gapi_cmek = \
-            Google::Apis::BigqueryV2::EncryptionConfiguration.from_json(
-              json_cmek
-            )
+          gapi_cmek = Google::Apis::BigqueryV2::EncryptionConfiguration.from_json json_cmek
           EncryptionConfiguration.from_gapi(gapi_cmek).freeze
         end
 

data/lib/google/cloud/bigquery/model/list.rb

@@ -126,15 +126,13 @@ module Google
           #
           def all request_limit: nil
             request_limit = request_limit.to_i if request_limit
-            unless block_given?
-              return enum_for :all, request_limit: request_limit
-            end
+            return enum_for :all, request_limit: request_limit unless block_given?
             results = self
             loop do
               results.each { |r| yield r }
               if request_limit
                 request_limit -= 1
-                break if request_limit < 0
+                break if request_limit.negative?
               end
               break unless results.next?
               results = results.next
@@ -144,9 +142,7 @@ module Google
           ##
           # @private New Model::List from a response object.
           def self.from_gapi gapi_list, service, dataset_id = nil, max = nil
-            models = List.new(Array(gapi_list[:models]).map do |gapi_json|
-              Model.from_gapi_json gapi_json, service
-            end)
+            models = List.new(Array(gapi_list[:models]).map { |gapi_json| Model.from_gapi_json gapi_json, service })
             models.instance_variable_set :@token,      gapi_list[:nextPageToken]
             models.instance_variable_set :@service,    service
             models.instance_variable_set :@dataset_id, dataset_id

data/lib/google/cloud/bigquery/project.rb

@@ -91,8 +91,7 @@ module Google
         # @return [String] The service account email address.
         #
         def service_account_email
-          @service_account_email ||= \
-            service.project_service_account.email
+          @service_account_email ||= service.project_service_account.email
         end
 
         ##
@@ -182,11 +181,9 @@ module Google
         #
         # @!group Data
         #
-        def copy_job source_table, destination_table, create: nil, write: nil,
-                     job_id: nil, prefix: nil, labels: nil
+        def copy_job source_table, destination_table, create: nil, write: nil, job_id: nil, prefix: nil, labels: nil
           ensure_service!
-          options = { create: create, write: write, labels: labels,
-                      job_id: job_id, prefix: prefix }
+          options = { create: create, write: write, labels: labels, job_id: job_id, prefix: prefix }
 
           updater = CopyJob::Updater.from_options(
             service,
@@ -261,13 +258,8 @@ module Google
         #
         # @!group Data
         #
-        def copy source_table, destination_table, create: nil, write: nil,
-                 &block
-          job = copy_job source_table,
-                         destination_table,
-                         create: create,
-                         write:  write,
-                         &block
+        def copy source_table, destination_table, create: nil, write: nil, &block
+          job = copy_job source_table, destination_table, create: create, write: write, &block
           job.wait_until_done!
           ensure_job_succeeded! job
           true
@@ -538,23 +530,16 @@ module Google
         #     end
         #   end
         #
-        def query_job query, params: nil, external: nil,
-                      priority: "INTERACTIVE", cache: true, table: nil,
-                      create: nil, write: nil, dryrun: nil, dataset: nil,
-                      project: nil, standard_sql: nil, legacy_sql: nil,
-                      large_results: nil, flatten: nil,
-                      maximum_billing_tier: nil, maximum_bytes_billed: nil,
+        def query_job query, params: nil, external: nil, priority: "INTERACTIVE", cache: true, table: nil, create: nil,
+                      write: nil, dryrun: nil, dataset: nil, project: nil, standard_sql: nil, legacy_sql: nil,
+                      large_results: nil, flatten: nil, maximum_billing_tier: nil, maximum_bytes_billed: nil,
                       job_id: nil, prefix: nil, labels: nil, udfs: nil
           ensure_service!
-          options = { priority: priority, cache: cache, table: table,
-                      create: create, write: write, dryrun: dryrun,
-                      large_results: large_results, flatten: flatten,
-                      dataset: dataset, project: (project || self.project),
-                      legacy_sql: legacy_sql, standard_sql: standard_sql,
-                      maximum_billing_tier: maximum_billing_tier,
-                      maximum_bytes_billed: maximum_bytes_billed,
-                      external: external, job_id: job_id, prefix: prefix,
-                      labels: labels, udfs: udfs, params: params }
+          options = { priority: priority, cache: cache, table: table, create: create, write: write, dryrun: dryrun,
+                      large_results: large_results, flatten: flatten, dataset: dataset,
+                      project: (project || self.project), legacy_sql: legacy_sql, standard_sql: standard_sql,
+                      maximum_billing_tier: maximum_billing_tier, maximum_bytes_billed: maximum_bytes_billed,
+                      external: external, job_id: job_id, prefix: prefix, labels: labels, udfs: udfs, params: params }
 
           updater = QueryJob::Updater.from_options service, query, options
 
@@ -759,13 +744,10 @@ module Google
         #     puts row[:name]
         #   end
         #
-        def query query, params: nil, external: nil, max: nil, cache: true,
-                  dataset: nil, project: nil, standard_sql: nil,
-                  legacy_sql: nil, &block
-          job = query_job query, params: params, external: external,
-                                 cache: cache, dataset: dataset,
-                                 project: project, standard_sql: standard_sql,
-                                 legacy_sql: legacy_sql, &block
+        def query query, params: nil, external: nil, max: nil, cache: true, dataset: nil, project: nil,
+                  standard_sql: nil, legacy_sql: nil, &block
+          job = query_job query, params: params, external: external, cache: cache, dataset: dataset, project: project,
+                                 standard_sql: standard_sql, legacy_sql: legacy_sql, &block
           job.wait_until_done!
 
           if job.failed?
@@ -861,9 +843,7 @@ module Google
         #
         def dataset dataset_id, skip_lookup: nil
           ensure_service!
-          if skip_lookup
-            return Dataset.new_reference project, dataset_id, service
-          end
+          return Dataset.new_reference project, dataset_id, service if skip_lookup
           gapi = service.get_dataset dataset_id
           Dataset.from_gapi gapi, service
         rescue Google::Cloud::NotFoundError
@@ -1092,10 +1072,8 @@ module Google
         def jobs all: nil, token: nil, max: nil, filter: nil,
                  min_created_at: nil, max_created_at: nil
           ensure_service!
-          options = {
-            all: all, token: token, max: max, filter: filter,
-            min_created_at: min_created_at, max_created_at: max_created_at
-          }
+          options = { all: all, token: token, max: max, filter: filter, min_created_at: min_created_at,
+                      max_created_at: max_created_at }
           gapi = service.list_jobs options
           Job::List.from_gapi gapi, service, options
         end
@@ -1386,17 +1364,14 @@ module Google
         #
         # @!group Data
         #
-        def extract_job table, extract_url, format: nil, compression: nil,
-                        delimiter: nil, header: nil, job_id: nil, prefix: nil,
-                        labels: nil
+        def extract_job table, extract_url, format: nil, compression: nil, delimiter: nil, header: nil, job_id: nil,
+                        prefix: nil, labels: nil
           ensure_service!
-          options = { format: format, compression: compression,
-                      delimiter: delimiter, header: header, job_id: job_id,
+          options = { format: format, compression: compression, delimiter: delimiter, header: header, job_id: job_id,
                       prefix: prefix, labels: labels }
 
           table_ref = Service.get_table_ref table, default_ref: project_ref
-          updater = ExtractJob::Updater.from_options service, table_ref,
-                                                     extract_url, options
+          updater = ExtractJob::Updater.from_options service, table_ref, extract_url, options
 
           yield updater if block_given?
 
@@ -1460,10 +1435,8 @@ module Google
         #
         # @!group Data
         #
-        def extract table, extract_url, format: nil, compression: nil,
-                    delimiter: nil, header: nil, &block
-          job = extract_job table,
-                            extract_url,
+        def extract table, extract_url, format: nil, compression: nil, delimiter: nil, header: nil, &block
+          job = extract_job table, extract_url,
                             format:      format,
                             compression: compression,
                             delimiter:   delimiter,
@@ -1487,9 +1460,7 @@ module Google
 
             # TODO: remove `Integer` and set normally after migrating to Gax or
             # to google-api-client 0.10 (See google/google-api-ruby-client#439)
-            if gapi.numeric_id
-              p.instance_variable_set :@numeric_id, Integer(gapi.numeric_id)
-            end
+            p.instance_variable_set :@numeric_id, Integer(gapi.numeric_id) if gapi.numeric_id
           end
         end
 

data/lib/google/cloud/bigquery/project/list.rb

@@ -124,15 +124,13 @@ module Google
           #
           def all request_limit: nil
             request_limit = request_limit.to_i if request_limit
-            unless block_given?
-              return enum_for :all, request_limit: request_limit
-            end
+            return enum_for :all, request_limit: request_limit unless block_given?
             results = self
             loop do
               results.each { |r| yield r }
               if request_limit
                 request_limit -= 1
-                break if request_limit < 0
+                break if request_limit.negative?
               end
               break unless results.next?
               results = results.next
@@ -142,9 +140,7 @@ module Google
           ##
           # @private New Project::List from a response object.
           def self.from_gapi gapi_list, service, max = nil
-            projects = List.new(Array(gapi_list.projects).map do |gapi_object|
-              Project.from_gapi gapi_object, service
-            end)
+            projects = List.new(Array(gapi_list.projects).map { |gapi_object| Project.from_gapi gapi_object, service })
             projects.instance_variable_set :@token,   gapi_list.next_page_token
             projects.instance_variable_set :@etag,    gapi_list.etag
             projects.instance_variable_set :@service, service