google-apis-core 0.9.3 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e29025436ed278972d36fc429f233b081edc5d40fa68921b71ae65758ece231
-  data.tar.gz: 2a41e0145da41d66e0455f58b4ba0213ea4468b7d9ed94d4fcdcfba1bc8895f2
+  metadata.gz: 0c4ade0959657cd3bff8601534b1f50e10335061306f94f19a1a5f0d31243378
+  data.tar.gz: 97c094fd9c168d9e1bad64607dd4acc9ab3c9e748018b7173246bd76a52505dc
 SHA512:
-  metadata.gz: '0540862757c8e96b73c1378544d3aac273f446f16ef430e3c5a9c36859ead4a1542502e896603ec9b5a92f119c3c2b11b2fc1e376fd0e838d93787d8d71d73f4'
-  data.tar.gz: c6ffa51666f75b6de32ab113e36eb9774a0c77d8050e9b6f8d18ca6a9acbd5b3f1c84413339b8d58dfe8b7eefd8bf8b758b3d1fdb238e015c8a5ae41c8ebd701
+  metadata.gz: 38718b83507b48984c0808da6c550092a7d4988574595b8eb769f3303352b1b51af520e323179836289f3c5524f780ea393df25c26f15555d636786788255336
+  data.tar.gz: 967b026074f0a0d016621f78649e41b3d47c04fd7f2da8a14564897d21bfe9cc25aa207fe6612a00a97c044d31a9505018140ca4cf94bd4fc45d1709d0e0d38d

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+### 0.9.4 (2023-01-07)
+
+#### Bug Fixes
+
+* Recursively redact unsafe payloads from logs ([#13189](https://github.com/googleapis/google-api-ruby-client/issues/13189)) 
+
 ### 0.9.3 (2023-01-04)
 
 #### Bug Fixes

data/lib/google/apis/core/http_command.rb

@@ -264,7 +264,7 @@ module Google
         # @return [Object] result if no block given
         # @yield [result, nil] if block given
         def success(result, &block)
-          logger.debug { sprintf('Success - %s', safe_object_representation(result)) }
+          logger.debug { sprintf('Success - %s', safe_pretty_representation(result)) }
           block.call(result, nil) if block_given?
           result
         end
@@ -317,7 +317,7 @@ module Google
                                        header: request_header,
                                        follow_redirect: true)
             logger.debug { @http_res.status }
-            logger.debug { safe_response_representation @http_res }
+            logger.debug { safe_single_line_representation @http_res }
             response = process_response(@http_res.status.to_i, @http_res.header, @http_res.body)
             success(response)
           rescue => e
@@ -351,21 +351,37 @@ module Google
           "Google::Apis::SecretmanagerV1beta1::SecretPayload"
         ]
 
-        def safe_object_representation obj
-          name = obj.class.name
-          if UNSAFE_CLASS_NAMES.include? name
-            "#<#{name} (fields redacted)>"
-          else
-            PP.pp(obj, "")
+        module RedactingPPMethods
+          def pp_object obj
+            return super unless UNSAFE_CLASS_NAMES.include? obj.class.name
+            object_address_group obj do
+              text "(fields redacted)"
+            end
           end
         end
 
-        def safe_response_representation http_res
-          if respond_to?(:response_class) && response_class.is_a?(Class) &&
-             UNSAFE_CLASS_NAMES.include?(response_class.name)
-            return "#<#{http_res.class.name} (fields redacted)>"
-          end
-          http_res.inspect
+        class RedactingPP < PP
+          include RedactingPPMethods
+        end
+
+        class RedactingSingleLine < PP::SingleLine
+          include RedactingPPMethods
+        end
+
+        def safe_pretty_representation obj
+          out = ""
+          printer = RedactingPP.new out, 79
+          printer.guard_inspect_key { printer.pp obj }
+          printer.flush
+          out << "\n"
+        end
+
+        def safe_single_line_representation obj
+          out = ""
+          printer = RedactingSingleLine.new out
+          printer.guard_inspect_key { printer.pp obj }
+          printer.flush
+          out
         end
 
         def opencensus_begin_span

data/lib/google/apis/core/version.rb

@@ -16,7 +16,7 @@ module Google
   module Apis
     module Core
       # Core version
-      VERSION = "0.9.3".freeze
+      VERSION = "0.9.4".freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-apis-core
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
 platform: ruby
 authors:
 - Google LLC
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-04 00:00:00.000000000 Z
+date: 2023-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: representable
@@ -186,7 +186,7 @@ licenses:
 metadata:
   bug_tracker_uri: https://github.com/googleapis/google-api-ruby-client/issues
   changelog_uri: https://github.com/googleapis/google-api-ruby-client/tree/main/google-apis-core/CHANGELOG.md
-  documentation_uri: https://googleapis.dev/ruby/google-apis-core/v0.9.3
+  documentation_uri: https://googleapis.dev/ruby/google-apis-core/v0.9.4
   source_code_uri: https://github.com/googleapis/google-api-ruby-client/tree/main/google-apis-core
 post_install_message: 
 rdoc_options: []
@@ -203,7 +203,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.14
+rubygems_version: 3.4.2
 signing_key: 
 specification_version: 4
 summary: Common utility and base classes for legacy Google REST clients