google-ads-googleads 2.2.1 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc8e4f351fdb74766a4707c673e7128ce176d6ccd71ea7502f1239f9c9f541ae
-  data.tar.gz: a9d1a0e8b06282165ac3e164085f79b22fa3ab07ba71d645c4359cd113f48435
+  metadata.gz: 6414dafc809b2e584848d7c95481177a28145d053b231a8df0350d130a3bd0b0
+  data.tar.gz: 0cd532287d4dd3c7c1d89becddcbdb5941515406fcb62eeccad32a479d44a0f4
 SHA512:
-  metadata.gz: 7aea8684a68e7caee59fb24a5a4d89b36317759422c157f93ba41f51fddd31b2ec2d400b5f2d02ad9f16acf8ff5ca529012cf70e7a326254d3ca7131cb347007
-  data.tar.gz: 85a689bd378f7cc2d7943952dd205175137e579b39832c121e09e640c645a6d48a57299d78e2cbe3a1118ae615979048ac715b143d109b2c3e529a4f4afef301
+  metadata.gz: 37fa253c3b4bcb815b292bf700eb5a5c2ab5ef326e0ab48431a931b47fc432efc24763a44d78256a7a472bd6d580ea34692564eb9f94f8d5a938240746259bf9
+  data.tar.gz: 30b84e57df5d640c481eb76a65aab43ac23d0a11016d5c5bd8bacd17aa17a44eba45ff337e4c410940368a541ee233f10e49f495f0c846698ef6be92f5854140

data/ChangeLog

@@ -1,3 +1,6 @@
+2.3.0:
+  - Add autoboxing fields that set value wrappers from primitives
+
 2.2.1:
   - Fix support for long running operations.
 

data/lib/google/ads/google_ads/autoboxing_fields.rb

@@ -0,0 +1,102 @@
+require 'google/protobuf/message_exts'
+require 'google/protobuf/wrappers_pb'
+module Google
+  module Ads
+    module GoogleAds
+      module AutoboxingFields
+        MAPPINGS = {
+          Google::Protobuf::Int32Value => lambda { |x| Integer(x) },
+          Google::Protobuf::Int64Value => lambda { |x| Integer(x) },
+          Google::Protobuf::StringValue => lambda { |x| String(x) },
+          Google::Protobuf::BoolValue => lambda { |x|
+            case x
+            when TrueClass, true, "true", "TRUE", "True", "1", 1
+              true
+            when FalseClass, false, "false", "FALSE", "False", "0", 0
+              false
+            else
+              raise ArgumentError.new("Value #{x} is not boolish")
+            end
+          },
+          Google::Protobuf::DoubleValue => lambda { |x| Float(x) },
+          Google::Protobuf::BytesValue => lambda { |x| x.force_encoding("ASCII-8BIT") },
+        }
+
+        def self.patch_class(klass)
+          return if klass.instance_variable_get(:@_patched_for_autoboxing_fields)
+          klass.instance_variable_set(:@_patched_for_autoboxing_fields, true)
+
+          klass.instance_eval do
+            fields = []
+            descriptor.each do |field|
+              if field.type == :message && AutoboxingFields.is_value_field?(field.subtype.msgclass)
+                fields << field
+                AutoboxingFields.patch_field_for_autoboxing(field, self)
+              end
+            end
+
+            AutoboxingFields.patch_constructor_for_autoboxing(fields, self)
+          end
+        end
+
+        def self.is_value_field?(class_name)
+          MAPPINGS.keys.include?(class_name)
+        end
+
+        def self.patch_constructor_for_autoboxing(fields, klass_to_patch)
+          orig_initialize = klass_to_patch.instance_method(:initialize)
+          klass_to_patch.instance_eval do
+            define_method(:initialize) do |**kwargs|
+              new_kwargs = Hash[kwargs.map { |name, value|
+                field = fields.select { |x| x.name == name.to_s }.first
+                actual_value = if field
+                                 if field.subtype.msgclass === value
+                                   value
+                                 else
+                                   field.subtype.msgclass.new(value: MAPPINGS.fetch(field.subtype.msgclass).call(value))
+                                 end
+                               else
+                                 value
+                               end
+                [name, actual_value]
+              }]
+              orig_initialize.bind(self).call(**new_kwargs)
+            end
+          end
+        end
+
+        def self.patch_field_for_autoboxing(field, klass_to_patch)
+          name = field.name
+          field_klass = field.subtype.msgclass
+          mapping = MAPPINGS.fetch(field_klass)
+
+          klass_to_patch.instance_eval do
+            define_method("#{name}=".to_sym) do |value|
+              if value.nil?
+                send(:method_missing, :"#{name}=", value)
+              elsif field_klass === value
+                send(:method_missing, :"#{name}=", value)
+              else
+                send(:method_missing, :"#{name}=", field_klass.new(value: mapping.call(value)))
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end
+
+module Google::Protobuf
+  module MessageExts
+    module ClassMethods
+      def new(*args, &blk)
+        if self.name.start_with?("Google::Ads::GoogleAds")
+          Google::Ads::GoogleAds::AutoboxingFields.patch_class(self)
+        end
+
+        super
+      end
+    end
+  end
+end

data/lib/google/ads/google_ads/google_ads_client.rb

@@ -38,6 +38,10 @@ module Google
   end
 end
 
+# this require needs to always come first to patch protobufs to have "autoboxing
+# fields"
+require 'google/ads/google_ads/autoboxing_fields'
+
 require 'googleauth'
 
 require 'google/ads/google_ads/patches'

data/lib/google/ads/google_ads/version.rb

@@ -19,7 +19,7 @@
 module Google
   module Ads
     module GoogleAds
-      CLIENT_LIB_VERSION = '2.2.1'.freeze
+      CLIENT_LIB_VERSION = '2.3.0'.freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-googleads
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.3.0
 platform: ruby
 authors:
 - Google Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-28 00:00:00.000000000 Z
+date: 2019-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-gax
@@ -85,6 +85,7 @@ files:
 - google_ads_config.rb
 - lib/google/ads/google_ads.rb
 - lib/google/ads/google_ads/api_versions.rb
+- lib/google/ads/google_ads/autoboxing_fields.rb
 - lib/google/ads/google_ads/config.rb
 - lib/google/ads/google_ads/errors.rb
 - lib/google/ads/google_ads/factories.rb