google-ads-googleads 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4cf7ec45c64d8e3b15c113cedc904e46d667d301740608146d0985537f6e3e44
-  data.tar.gz: 0a33073c1cf8401df2388172f6026d4c0cbe3a4f8f8e81b5da710ac57766dc01
+  metadata.gz: d909d1d6d9386d5ce00534af05b6ce762f3f981a4242aa501f3a884ed8f82695
+  data.tar.gz: 88cef4570b6123d494d04d13ac64c42abc540e87fbf1426186982480c29f8109
 SHA512:
-  metadata.gz: 0d36f3d385b11ce0efa43e7c4008af8569f4b3f1133d8c151eb1cf472958c50489c3dbd43c8180935588a21ef47413fea5135785187b84297a3ab27b28f2d012
-  data.tar.gz: 7c42c6b2bc5edb4f5b795ffe5b5316d0e5a539a6ceaa5dd1a913b5c7f1c54a61c4bc5f0873ea3ac8c215ebe8599699a54df712dd962a94fc3b9c6e50725bc945
+  metadata.gz: f13b5d6f77f0bb1a9aa061365e9459507a3990301e7d25b5cce1b3ff945b4335c2bbc1f53465aa821b7281e08bac00f987d61d451d120500baf0cfe8f8f92246
+  data.tar.gz: 73d88a624bfdb3ec1dad7772057c8ac9418cea5459e0ed13786f7bee964f3c94823145fe39931f7350e952eb128b2e7a42cfb014bfad66c58f6f3420888e56d6

data/ChangeLog

@@ -1,3 +1,7 @@
+1.1.1:
+  - Add `ExtensionFeedItem` as an operation look up
+  - Fixes various broken resource types
+
 1.1.0:
   - Adding support for Google Ads API v1_1.
   - Refactored proto and path lookup utils to be accessible before client

data/README.md

@@ -49,23 +49,23 @@ See and run the [Authentication example][] to generate your refresh token.
 Once this is generated, you can provide it to the library in a few different
 ways.
 
-The simplest is to copy the [adwords_config.rb][] to your home directory and
+The simplest is to copy the [google_ads_config.rb][] to your home directory and
 simply modify it to include the client ID, client secret, and refresh token.
 The library will automatically read it from the home directory if instantiated
 with no arguments:
 
-    adwords = Google::Ads::GoogleAds::GoogleAdsClient.new
+    client = Google::Ads::GoogleAds::GoogleAdsClient.new
 
 Alternatively, if you prefer to keep the file elsewhere, you can instantiate the
 library by passing the path to where you keep this file:
 
-    adwords = Google::Ads::GoogleAds::GoogleAdsClient.new('path/to/file.rb')
+    client = Google::Ads::GoogleAds::GoogleAdsClient.new('path/to/file.rb')
 
 If you prefer not to store this information in a file at all, and would rather
 pass the information programmatically at runtime, you can accomplish that this
 way:
 
-    adwords = Google::Ads::GoogleAds::GoogleAdsClient.new do |config|
+    client = Google::Ads::GoogleAds::GoogleAdsClient.new do |config|
       config.client_id = 'INSERT_CLIENT_ID_HERE'
       config.client_secret = 'INSERT_CLIENT_SECRET_HERE'
       config.refresh_token = 'INSERT_REFRESH_TOKEN_HERE'
@@ -73,11 +73,11 @@ way:
     end
 
 You can also modify these properties after instantiation by using the
-`configure` method on the `AdwordsClient`, using the same structure as above.
+`configure` method on the `GoogleAdsClient`, using the same structure as above.
 
 [Authorization guide]: https://developers.google.com/google-ads/api/docs/oauth/overview
 [Authentication example]: https://github.com/googleads/google-ads-ruby/blob/master/examples/authentication/authenticate_in_standalone_application.rb
-[adwords_config.rb]: https://github.com/googleads/google-ads-ruby/blob/master/google_ads_config.rb
+[google_ads_config.rb]: https://github.com/googleads/google-ads-ruby/blob/master/google_ads_config.rb
 
 ## Usage
 
@@ -87,8 +87,8 @@ To include the gem in your code:
 
 To fetch a specific service, for example CampaignService:
 
-    adwords = Google::Ads::GoogleAds::GoogleAdsClient.new
-    campaign_service = adwords.service(:Campaign)
+    client = Google::Ads::GoogleAds::GoogleAdsClient.new
+    campaign_service = client.service(:Campaign)
 
 See the provided [examples][] for more detailed demonstrations of how to use the
 library.
@@ -116,3 +116,4 @@ Author:
 Maintainer:
 
  - Michael Cloonan
+ - Sam Phippen

data/Rakefile

@@ -5,3 +5,36 @@ require 'rake/testtask'
 Rake::TestTask.new do |t|
   t.test_files = FileList['test/**/test_*.rb']
 end
+
+def apply_patches
+  clean = system(<<~EOD)
+  bash -c 'if [ -z "$(git status --porcelain)" ]; then exit 0; else exit 1; fi'
+  EOD
+
+  raise "Working directory is not clean" unless clean
+
+  patches = Dir["patches/*.patch"]
+  patches.each do |patch|
+    puts "PATCH #{patch}"
+    res = system("git apply #{patch}")
+    if res
+      `git add -u`
+      `git commit -m 'Applying #{patch} for v#{Google::Ads::GoogleAds::CLIENT_LIB_VERSION} release'`
+    else
+      puts "FAIL #{patch}: may not be a big deal because already applied or no longer needed"
+    end
+  end
+end
+
+task :validate_protos do
+  res = system("./scripts/validate_protos.rb")
+  if !res
+    raise "Couldn't load all protos"
+  end
+end
+
+task :apply_patches do |t|
+  apply_patches
+end
+
+task :build => [:apply_patches, :validate_protos]

data/lib/google/ads/google_ads/logging_interceptor.rb

@@ -44,7 +44,7 @@ module Google
             @logger.debug(build_request_message(metadata, request))
             @logger.debug(build_success_response_message(response))
             if response.respond_to?(:partial_failure_error) && response.partial_failure_error
-              @logger.warn(build_partial_failure_message(response))
+              @logger.debug(build_partial_failure_message(response))
             end
             response
           rescue Exception

data/lib/google/ads/google_ads/utils/v1/proto_lookup_util.rb

@@ -678,6 +678,7 @@ module Google
               Customer: ['customer_service_pb', 'CustomerOperation'],
               ConversionAction: ['conversion_action_service_pb', 'ConversionActionOperation'],
               DismissRecommendation: ['recommendation_service_pb', 'DismissRecommendationRequest::DismissRecommendationOperation'],
+              ExtensionFeedItem: ['extension_feed_item_service_pb', 'ExtensionFeedItemOperation'],
               ExtensionFeedItemOperation: ['extension_feed_item_service_pb', 'ExtensionFeedItemOperation'],
               FeedItem: ['feed_item_service_pb', 'FeedItemOperation'],
               FeedItemTarget: ['feed_item_target_service_pb', 'FeedItemTargetOperation'],

data/lib/google/ads/google_ads/v1/resources/detail_placement_view_pb.rb

@@ -17,6 +17,6 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
   end
 end
 
-module Google::Ads::GoogleAds::V1::Services
+module Google::Ads::GoogleAds::V1::Resources
   DetailPlacementView = Google::Protobuf::DescriptorPool.generated_pool.lookup("google.ads.googleads.v1.resources.DetailPlacementView").msgclass
 end

data/lib/google/ads/google_ads/v1/resources/group_placement_view_pb.rb

@@ -16,6 +16,6 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
   end
 end
 
-module Google::Ads::GoogleAds::V1::Services
+module Google::Ads::GoogleAds::V1::Resources
   GroupPlacementView = Google::Protobuf::DescriptorPool.generated_pool.lookup("google.ads.googleads.v1.resources.GroupPlacementView").msgclass
 end

data/lib/google/ads/google_ads/v1/resources/product_bidding_category_constant_pb.rb

@@ -20,6 +20,6 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
   end
 end
 
-module Google::Ads::GoogleAds::V1::Enums
+module Google::Ads::GoogleAds::V1::Resources
   ProductBiddingCategoryConstant = Google::Protobuf::DescriptorPool.generated_pool.lookup("google.ads.googleads.v1.resources.ProductBiddingCategoryConstant").msgclass
 end

data/lib/google/ads/google_ads/version.rb

@@ -19,7 +19,7 @@
 module Google
   module Ads
     module GoogleAds
-      CLIENT_LIB_VERSION = '1.1.0'.freeze
+      CLIENT_LIB_VERSION = '1.1.1'.freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-googleads
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Google Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-28 00:00:00.000000000 Z
+date: 2019-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-gax