google-ads-common 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6dea057cca6ae39b6511699238e37f2f68a49c0
-  data.tar.gz: 2e48d936448f87385b04a70ffe9bf0d122f8d38d
+  metadata.gz: '067293eb179d644ad5b96f6a03efed2ae0a9feda'
+  data.tar.gz: a5315b11005916c7ebc3ecfc00ed75d3db325b97
 SHA512:
-  metadata.gz: a64cf5a9debeaf2bd41dad73dacfd5356fcdd52d585954b66b539d617934dbbf79d43d522c479d718b7bf2b414afb202497538c64e80ced339319259a7007b47
-  data.tar.gz: ff6f3b0736385234e34bb8548dfe74bd865632e6ab26d9b93bb14c7a98b0af452e82120a8aeea20ca1c4f8374a7d95a0bab1466aec6e10f9d97a8167b8fd8b31
+  metadata.gz: 2d7af7a96d81234c804467b962d17818bf076d1f22305e10df2e68339bb358924464b65385dbae5bd912e740f1f7c638d30d8dfdfa698accbe8215094becc80c
+  data.tar.gz: 24f0e5d3a6f77aeca775c2c88ef30fa65935561903d525ccefb039b880347fb3bed36f529d5bb07e0a93d5d8555f8f265a3b22062e41100f6b8f6d8bf25f8abe

data/ChangeLog

@@ -1,3 +1,7 @@
+1.0.2:
+  - Added enumeration values to SOAP service registry objects (pull
+    request #153).
+
 1.0.1:
   - Fixed issue #139. Library now gives a more appropriate warning when it
     can't get an access token.

data/lib/ads_common/api_config.rb

@@ -109,7 +109,6 @@ module AdsCommon
     #
     def endpoint(version, service)
       base = get_wsdl_base(version)
-      # TODO(dklimkin): Unflatten subdir constants. Cross-API refactor 0.9.0.
       if !subdir_config().nil?
         base = base.to_s + subdir_config()[[version, service]].to_s
       end
@@ -127,7 +126,6 @@ module AdsCommon
     #
     def subdir(version, service)
       return nil if subdir_config().nil?
-      # TODO(dklimkin): Unflatten subdir constants. Cross-API refactor 0.9.0.
       subdir_config()[[version, service]]
     end
 

data/lib/ads_common/build/savon_registry.rb

@@ -145,6 +145,9 @@ module AdsCommon
             'sequence | complexContent/extension/sequence') do |seq_node|
           type[:fields] += get_element_fields(seq_node)
         end
+
+        extract_enumerations(type_element, type)
+
         REXML::XPath.each(type_element, 'choice') do |seq_node|
           type[:choices] ||= []
           type[:choices] += get_element_fields(seq_node)
@@ -152,6 +155,22 @@ module AdsCommon
         return type
       end
 
+      # Extracts all possible enumerations for a type and adds them as an
+      # `enumerations` key on the type.
+      def extract_enumerations(type_element, type)
+        REXML::XPath.each(type_element,
+            "restriction[@base='xsd:string']") do |enum_node|
+          type.delete(:fields)
+          type[:type] = enum_node.attribute('base').to_s.gsub(/^.+:/, '')
+        end
+        REXML::XPath.each(type_element,
+            "restriction[@base='xsd:string']/enumeration") do |enum_node|
+          type[:enumerations] ||= []
+          type[:enumerations] << enum_node.attribute('value').to_s
+        end
+        return type
+      end
+
       # Extracts input parameters of given method as an array.
       def extract_input_parameters(op_node, doc)
         op_name = get_element_name(op_node)

data/lib/ads_common/version.rb

@@ -19,6 +19,6 @@
 
 module AdsCommon
   module ApiConfig
-    CLIENT_LIB_VERSION = '1.0.1'
+    CLIENT_LIB_VERSION = '1.0.2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-common
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Sergio Gomes
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-15 00:00:00.000000000 Z
+date: 2018-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-ads-savon
@@ -196,7 +196,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: google-ads-common
-rubygems_version: 2.6.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Common code for Google Ads APIs